From nobody Tue Nov 18 16:52:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611305830; cv=none; d=zohomail.com; s=zohoarc; b=TF/J8DmmKGbgt92FNvpo4+rk0XtoFmLUA2hNtFeFZ+WNXeJByaxYv4EKOCG2mpwm/3sOig/tafol5b31j7MG4AkRYoSpspM/BMP/ohbRdaHCi2jva0Ze4vulef2w3a6XbiUTNhcfRLrU49ueLN6kF94WQFKhscoifaVONk45Q5s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611305830; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6woqXCQPBXF+2AZzqpiLMk3R+C2bqTLs3O/t0lpF0I8=; b=jNWXeWKKZZktNfhRZwbfPR7hkZ3jkTLBPq35UN2GqCMC0cvNhGf4tnlOJWINSPB2qG+Cnzz+TfI3fnJw53qUCuf2IuJjxfACnwwhZPdlzLJc4g8cXiT60lGPLJuj/wISaHZqg5OyganUBlb9DadmhCyVWcQSYbO7R/4wNTDSreE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161130583005096.70580848712507; Fri, 22 Jan 2021 00:57:10 -0800 (PST) Received: from localhost ([::1]:56674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2sFe-0004Ik-Hp for importer@patchew.org; Fri, 22 Jan 2021 03:57:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2sEE-0003n4-NI for qemu-devel@nongnu.org; Fri, 22 Jan 2021 03:55:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:24359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2sEA-0006cr-Mb for qemu-devel@nongnu.org; Fri, 22 Jan 2021 03:55:37 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-0YhfRKZyMVClnL9Vp6DMnQ-1; Fri, 22 Jan 2021 03:55:31 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5F95192D795 for ; Fri, 22 Jan 2021 08:55:30 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 81EE86B540; Fri, 22 Jan 2021 08:55:27 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5F0FF18000AB; Fri, 22 Jan 2021 09:55:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611305733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6woqXCQPBXF+2AZzqpiLMk3R+C2bqTLs3O/t0lpF0I8=; b=KzKAafr32rGmE5gqJ5jWabGntiQBGghbfWjp13074rbL2iiemPP4hI6gYuOImDTstr8XxD gj1UH6CEn5UQcUh1upF97WA/YDc4+oBYewNWW/v96JkWznRRZs011obF5opD97b6LjUzGJ 0k1gtBTOeKic3Ua+U/DdweBZqbEawlA= X-MC-Unique: 0YhfRKZyMVClnL9Vp6DMnQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH] vnc: drop vnc_colordepth() call. Date: Fri, 22 Jan 2021 09:55:25 +0100 Message-Id: <20210122085525.3827724-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laszlo Ersek , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" With gtk-vnc (which supports VNC_FEATURE_WMVI) this results in sending a VNC_ENCODING_WMVi message to the client. Which in turn seems to make gtk-vnc respond with another non-incremental update request. Hello endless loop ... Drop the call. Fixes: 9e1632ad07ca ("vnc: move initialization to framebuffer_update_reques= t") Reported-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index d429bfee5a65..0a3e2f4aa98c 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2041,7 +2041,6 @@ static void framebuffer_update_request(VncState *vs, = int incremental, } else { vs->update =3D VNC_STATE_UPDATE_FORCE; vnc_set_area_dirty(vs->dirty, vs->vd, x, y, w, h); - vnc_colordepth(vs); vnc_desktop_resize(vs); vnc_led_state_change(vs); vnc_cursor_define(vs); --=20 2.29.2