From nobody Tue Nov 18 15:24:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611155980; cv=none; d=zohomail.com; s=zohoarc; b=TaWCxwLoG7lPnE29PcjcXGG2pYp2U2vxnpJlZtER7YlMx+XilRtxDOo6Pa4y1HmKCanacoBhfYe9yaqfOT+2Mh1tayg4jgzghvME60FICIDWeDva6FkfiW/2h0lppnLvB3gNp90DlJhAATEz3vaNsSBJNhLHTnqqmSGo5yHHn/I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611155980; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Y7WrzwPEJea74ZJswOnFr7VkphOOOJIX5g6UJTnwvsY=; b=XptZ1A4uYlAloEaSNNzzP86DigVdcaJCkt5fIqyE6s9aEw8Tj3t3H2A7U0hemOCu2QJI7gk3expx+CoNYNA6jePrMVw/lL+xDKWmzaRsivKms2Wsho88Xp7o3D0xITElH9KKZriRpiQJi5rXj+kJvE5VyNveB07h3PD28bmxYbo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 161115598092969.94304896640938; Wed, 20 Jan 2021 07:19:40 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-uboJccmvOLWoINaHviuu-g-1; Wed, 20 Jan 2021 10:19:36 -0500 Received: by mail-ed1-f69.google.com with SMTP id w4so7466317edu.0 for ; Wed, 20 Jan 2021 07:19:35 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id l16sm1280410edw.10.2021.01.20.07.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 07:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611155979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y7WrzwPEJea74ZJswOnFr7VkphOOOJIX5g6UJTnwvsY=; b=WGZfLDfkhMCv+Dos3gPy2YDAoPKyJTH2FLdejnY99cV7nb4KMUYiGYXVmMt2MWO6sE6+TP L33Y2MkYc/blz2O9Gl0pDJ0rcl9IVEqKr0zN8MFSFKSI7+7kSKaAZJ5zrAbWVgV60wavLJ UYW30cvHfIuZNN3+Tc5Cjvk1C0hiNlE= X-MC-Unique: uboJccmvOLWoINaHviuu-g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7WrzwPEJea74ZJswOnFr7VkphOOOJIX5g6UJTnwvsY=; b=tup5mHvigKOr1fXXBPWf06y56c+xes2msVwsykKRlYemkI/tF2lxXmrPVzBt9KvU7A Y5koQgmqgzOSVusjm4BI1oqmlUAMr3e1YaAM6xctciOJKjfPvAQtMFA24kYUMMViGcfk BQT6zSHQ7YXPpV0NBgCtMZv3WNPRxIBLQ0E+Uft9DRPC2w+FuGN5DsQ+y7UqESwv5D// CBWlNCe6i33/2RRqSx9tBjNxbAYmjy2oENx2c/Pv381IMk/sfnu8Kx7QZAv0X3RCz1qY 8SFqBSk7X1PsexT+3DyCZOl8Hp8clLk6A8IeQKilhLHloZb89ajn3Hx1zJpr7nIAX/37 2kTQ== X-Gm-Message-State: AOAM531MHvLME+5RSOtlJNK6KKO+pUoESXrjIj9MN83ySuGJ4rhpSFLb usg7ccuj3DAvlSOgywm+nVJWFsr7bRF3iTIlJEoNCoNS85PstcmmYqqg9EgEvXdFuQr3ogekR0s rQFjeI44n668mag== X-Received: by 2002:aa7:c84c:: with SMTP id g12mr7537215edt.193.1611155974533; Wed, 20 Jan 2021 07:19:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7vxx1anSoTYlOdWJkYboxe5XklrzPZ+yEnvfLevuhsGehW1NIAM0B2GRngRJE/A1ziRDJbw== X-Received: by 2002:aa7:c84c:: with SMTP id g12mr7537209edt.193.1611155974418; Wed, 20 Jan 2021 07:19:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] configure: Emit warning when accelerator requested but not needed Date: Wed, 20 Jan 2021 16:19:16 +0100 Message-Id: <20210120151916.1167448-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210120151916.1167448-1-philmd@redhat.com> References: <20210120151916.1167448-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) In some configurations it might be pointless to check and compile accelerator code. Do not deselect the accelerator, but emit a warning. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/configure b/configure index a5159157a49..09e1cd8bfe6 100755 --- a/configure +++ b/configure @@ -5514,6 +5514,27 @@ if test $git_update =3D 'yes' ; then (cd "${source_path}" && GIT=3D"$git" "./scripts/git-submodule.sh" upda= te "$git_submodules") fi =20 +if [ "$softmmu" =3D "no" ]; then + if [ "$tcg" =3D "enabled" ]; then + echo "WARN: TCG accelerator selected but no target requires it" + fi + if [ "$kvm" =3D "enabled" ]; then + echo "WARN: KVM accelerator selected but no target requires it" + fi + if [ "$xen" =3D "enabled" ]; then + echo "WARN: Xen accelerator selected but no target requires it" + fi + if [ "$hax" =3D "enabled" ]; then + echo "WARN: HAX accelerator selected but no target requires it" + fi + if [ "$hvf" =3D "enabled" ]; then + echo "WARN: HVF accelerator selected but no target requires it" + fi + if [ "$whpx" =3D "enabled" ]; then + echo "WARN: WHPX accelerator selected but no target requires it" + fi +fi + config_host_mak=3D"config-host.mak" =20 echo "# Automatically generated by configure - do not modify" > $config_ho= st_mak --=20 2.26.2