From nobody Tue Nov 18 14:13:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=126.com ARC-Seal: i=1; a=rsa-sha256; t=1611154057; cv=none; d=zohomail.com; s=zohoarc; b=OCHDn3i5urUnL8vVeNBq9sllHh1Buhdvco91/WS12hY0gHwn8pFs4SDpbpceUn8m9WZquK82KSATREmLS4wx4EXUp5vKqZoDcLYLPdG85H0DDhLgj3RFY3TDNUsdwYLe20PhL72nICbgWiSjW5e2/mAyWUCNKn27GQxjgDSuPOA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611154057; h=Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=HgFQroAYTO0ekSyc7y6cIY3yz9vhIpwmkfwFa3ZVz5A=; b=mAt6Ov4gy04qPaYr+Qr44FK6LlLdpkGCmi9rD7mu4hDVRpg/gIkzekje4dZghl2MBwuZzxLLpntTdkdeFOpXFaiTFsN1BkWAace63rfKazSL5L+NPm2EgRt9W6mFKRQlpVBNOtRcBsdZ/LfqFXBimODGqav/563o5oH9BeYIz4I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161115405768547.531736894111646; Wed, 20 Jan 2021 06:47:37 -0800 (PST) Received: from localhost ([::1]:59190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Elk-0000Wp-IY for importer@patchew.org; Wed, 20 Jan 2021 09:47:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l24W9-0006Jj-3G for qemu-devel@nongnu.org; Tue, 19 Jan 2021 22:50:50 -0500 Received: from mail-m963.mail.126.com ([123.126.96.3]:54814) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l24W3-0004dj-1n for qemu-devel@nongnu.org; Tue, 19 Jan 2021 22:50:48 -0500 Received: from localhost.localdomain (unknown [111.205.198.3]) by smtp8 (Coremail) with SMTP id NORpCgAnTh6FqAdgEJ85Cg--.57862S3; Wed, 20 Jan 2021 11:50:30 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id; bh=HgFQroAYTO0ekSyc7y 6cIY3yz9vhIpwmkfwFa3ZVz5A=; b=m1t22rcxELd4WTwC4BjXjnbo1vHxk0ob5s pK8QhXVYfyauu3h+dgOvCHEWQ2A/5bm4bMBPGFFy1TQIkcP0LmASX8MwkUMAi99g +WG08Qw0QAIgecp5KRRCdampwm+11dhvWovC/xRV6bRqOGsD54+kD0V/x+9w81+a nhYCBz+MA= From: Bobo Du To: qemu-devel@nongnu.org Subject: [PATCH] vhost-user-blk.c:fix the qemu-kvm crash in the vhost-user-blk env. Date: Wed, 20 Jan 2021 11:50:27 +0800 Message-Id: <20210120035027.51037-1-dubo163@126.com> X-Mailer: git-send-email 2.17.0 X-CM-TRANSID: NORpCgAnTh6FqAdgEJ85Cg--.57862S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7Kr43CF47ur43WF13JF15twb_yoW8XrWUpF 1UZr1fKrykGF18C3yDA3WkKF1xAayrAF4UG397Ca4Yy3yUZw4Ivr1q9a90kr48ZFZayF48 JFWUtrW8CF15GaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zR0oGQUUUUU= X-Originating-IP: [111.205.198.3] X-CM-SenderInfo: 5gxe0iiwt6ij2wof0z/1tbiegYgMFpEBT0W6wAAs3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=123.126.96.3; envelope-from=dubo163@126.com; helo=mail-m963.mail.126.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 20 Jan 2021 09:45:01 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bobo Du Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @126.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In our spdk env, when we restart spdk vhost process, all the spdk vhost dev will be reconnected,if the vhost_user_blk_device_realize failed in the reconnect code goto label with the qemu_chr_fe_wait_connected, the vhost_user_cleanup will set user->chr be NULL,but the fe handler vhost_user_blk_event is still work on the env. If the vhost slave(eg:spdk) has not been done,we will see the qemu-kvm crash after reopen the vhost-user-blk dev: gdb debug info from qemu-kvm-2.10: [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". Core was generated by `/usr/libexec/qemu-kvm -name guest=3Ddb1ae942ac9c5486= bf93c7baac5fcce6,debug-thread'. Program terminated with signal 11, Segmentation fault. #0 qemu_chr_fe_set_msgfds (be=3D0x0, fds=3D0x0, num=3D0) at chardev/char-f= e.c:144 144 Chardev *s =3D be->chr; So,we must reset the fe handler after the goto label virtio_err. Signed-off-by: Bobo Du Reviewed-by: Raphael Norwitz --- hw/block/vhost-user-blk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index da4fbf9084..c90687ab82 100644 --- a/hw/block/vhost-user-blk.c +++ b/hw/block/vhost-user-blk.c @@ -507,6 +507,8 @@ virtio_err: } g_free(s->virtqs); virtio_cleanup(vdev); + qemu_chr_fe_set_handlers(&s->chardev, NULL, NULL, NULL, + NULL, NULL, NULL, false); vhost_user_cleanup(&s->vhost_user); } =20 --=20 2.17.0