From nobody Tue Nov 18 15:28:30 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1611065615; cv=none; d=zohomail.com; s=zohoarc; b=kdY8Vbp/hKp0xvTHo0YWG7sD7Nu2dlw1CrLlBAnXnFZNnFsgGumjUN/NmB/ydq0PIJ2SlJ6d+XdthJFtx0x+RqlSbt1XB2smcK1EhVkqnxtddw4PtbtZt+ZQ0N6BguuurH1/V5e+KcNmFYNfLVsf43kOCJtEbwmzeZ1HVLO26Dg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611065615; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RVx2IZTVsCD2+w7Ha7I9nGi/JJdqmChp6GbNEOlZTOc=; b=IlnCNyqafJrlgMB4f05Czq2y7ziXryJUpNKGnFqf22Lk04uyfF1BjBjprvCsgplqlsqGomgNq6wXHY+fj7KwZSI6eS/ihDwCVPyrTIGHc+Dz2g8FC3ZLzBw4haoypqMG1XCL4mKzXUOH1zLqoIQ2thL95x2ui2bBGW6BKG4O/DM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1611065615665735.386514874995; Tue, 19 Jan 2021 06:13:35 -0800 (PST) Received: from localhost ([::1]:47098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1rlG-0007Y2-9e for importer@patchew.org; Tue, 19 Jan 2021 09:13:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1rTZ-0002gC-2r; Tue, 19 Jan 2021 08:55:18 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1rTP-0005rr-MI; Tue, 19 Jan 2021 08:55:16 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E5FE05C0248; Tue, 19 Jan 2021 08:55:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 08:55:06 -0500 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id CB01C240057; Tue, 19 Jan 2021 08:55:05 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=RVx2IZTVsCD2+ w7Ha7I9nGi/JJdqmChp6GbNEOlZTOc=; b=3CnvDHsSE7HM0GD3Ag8/QI1AG+DAj omipaJeWIpbQOKH5zZqy3u7+cULZikP+ahMQb0z+/jYQ77ZdKw03KJCmNAaW/hjV OzT4GFjdcGNOxVA3uChueW++Y823jlKWMOA00+V98HWtcQE+Jfb/Y7GjfQNwQLRN JkOlpvoJFg0gkomwNqIEXxBnTD7M//sVi6n9+g1+rkGzgvew6kvcm+r88Bpn9ipW CFtYkobp/Akq+LQAQLMjHHNN4jY6UjcM/8XiQXUMJzk3KjOO4akVG0zmvgIWdA5v 6z940yGquAh9o78/TMKGkhvG7PMKDIaUQHruGpcaG5VDSQDlOuns6UOgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=RVx2IZTVsCD2+w7Ha7I9nGi/JJdqmChp6GbNEOlZTOc=; b=PpqmmMS2 zL6+B4rGhsqpHPXE/S7hKNTuQuhgrRnNgAAOkDGAlmVZMuyMs4tS2cpRRsJ8QGub AiWq6FtOJMylPQKkNufavSRChj7ZYZGaFB6SelPcmabR9rKe0zxCXYTzVOrMjwiD AtOFKTPHYZGOX+4ySIFjHrOhfdkQfv3XhsKd0dL3widt2k9vxtKIoL9VYlgM25l+ LR7sIfrQT9oTLQZpOT+3MXU1cGuxXp2QvmIoG6KzFUwyF5kcJiXdyWdiFixmo3Ju uxSRIs5kRFE3dlsVUBpeT4tuWHxUqylioJu4frFwA5fRhJzQbU2t9w9uQP9re8oY sZSlpYyMauc1vQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepmfhlrghushcu lfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrthhtvg hrnhepueelteegieeuhffgkeefgfevjeeigfetkeeitdfgtdeifefhtdfhfeeuffevgfek necukfhppeektddrudeijedrleekrdduledtnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org Subject: [PATCH 2/2] hw/block/nvme: refactor the logic for zone write checks Date: Tue, 19 Jan 2021 14:55:00 +0100 Message-Id: <20210119135500.265403-3-its@irrelevant.dk> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210119135500.265403-1-its@irrelevant.dk> References: <20210119135500.265403-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=66.111.4.28; envelope-from=its@irrelevant.dk; helo=out4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Dmitry Fomichev , Klaus Jensen , Max Reitz , Klaus Jensen , Keith Busch Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Refactor the zone write check logic such that the most "meaningful" error is returned first. That is, first, if the zone is not writable, return an appropriate status code for that. Then, make sure we are actually writing at the write pointer and finally check that we do not cross the zone write boundary. This aligns with the "priority" of status codes for zone read checks. Also add a couple of additional descriptive trace events and remove an always true assert. Cc: Dmitry Fomichev Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 47 +++++++++++++++++++------------------------ hw/block/trace-events | 5 +++++ 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index f05dea657b01..193a27259dda 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1106,56 +1106,51 @@ static inline NvmeZone *nvme_get_zone_by_slba(NvmeN= amespace *ns, uint64_t slba) =20 static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) { - uint16_t status; + uint64_t zslba =3D zone->d.zslba; =20 switch (nvme_get_zone_state(zone)) { case NVME_ZONE_STATE_EMPTY: case NVME_ZONE_STATE_IMPLICITLY_OPEN: case NVME_ZONE_STATE_EXPLICITLY_OPEN: case NVME_ZONE_STATE_CLOSED: - status =3D NVME_SUCCESS; - break; + return NVME_SUCCESS; case NVME_ZONE_STATE_FULL: - status =3D NVME_ZONE_FULL; - break; + trace_pci_nvme_err_zone_is_full(zslba); + return NVME_ZONE_FULL; case NVME_ZONE_STATE_OFFLINE: - status =3D NVME_ZONE_OFFLINE; - break; + trace_pci_nvme_err_zone_is_offline(zslba); + return NVME_ZONE_OFFLINE; case NVME_ZONE_STATE_READ_ONLY: - status =3D NVME_ZONE_READ_ONLY; - break; + trace_pci_nvme_err_zone_is_read_only(zslba); + return NVME_ZONE_READ_ONLY; default: assert(false); } - - return status; } =20 static uint16_t nvme_check_zone_write(NvmeCtrl *n, NvmeNamespace *ns, NvmeZone *zone, uint64_t slba, uint32_t nlb) { + uint64_t zcap =3D nvme_zone_wr_boundary(zone); uint16_t status; =20 - if (unlikely((slba + nlb) > nvme_zone_wr_boundary(zone))) { - status =3D NVME_ZONE_BOUNDARY_ERROR; - } else { - status =3D nvme_check_zone_state_for_write(zone); + status =3D nvme_check_zone_state_for_write(zone); + if (status) { + return status; } =20 - if (status !=3D NVME_SUCCESS) { - trace_pci_nvme_err_zone_write_not_ok(slba, nlb, status); - } else { - assert(nvme_wp_is_valid(zone)); - - if (unlikely(slba !=3D zone->w_ptr)) { - trace_pci_nvme_err_write_not_at_wp(slba, zone->d.zslba, - zone->w_ptr); - status =3D NVME_ZONE_INVALID_WRITE; - } + if (unlikely(slba !=3D zone->w_ptr)) { + trace_pci_nvme_err_write_not_at_wp(slba, zone->d.zslba, zone->w_pt= r); + return NVME_ZONE_INVALID_WRITE; } =20 - return status; + if (unlikely((slba + nlb) > zcap)) { + trace_pci_nvme_err_zone_boundary(slba, nlb, zcap); + return NVME_ZONE_BOUNDARY_ERROR; + } + + return NVME_SUCCESS; } =20 static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) diff --git a/hw/block/trace-events b/hw/block/trace-events index 78d76b0a71c1..c80b02b85ac9 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -127,6 +127,11 @@ pci_nvme_err_unaligned_zone_cmd(uint8_t action, uint64= _t slba, uint64_t zslba) " pci_nvme_err_invalid_zone_state_transition(uint8_t action, uint64_t slba, = uint8_t attrs) "action=3D0x%"PRIx8", slba=3D%"PRIu64", attrs=3D0x%"PRIx32"" pci_nvme_err_write_not_at_wp(uint64_t slba, uint64_t zone, uint64_t wp) "w= riting at slba=3D%"PRIu64", zone=3D%"PRIu64", but wp=3D%"PRIu64"" pci_nvme_err_append_not_at_start(uint64_t slba, uint64_t zone) "appending = at slba=3D%"PRIu64", but zone=3D%"PRIu64"" +pci_nvme_err_zone_is_full(uint64_t zslba) "zslba 0x%"PRIx64"" +pci_nvme_err_zone_is_read_only(uint64_t zslba) "zslba 0x%"PRIx64"" +pci_nvme_err_zone_is_offline(uint64_t zslba) "zslba 0x%"PRIx64"" +pci_nvme_err_zone_boundary(uint64_t slba, uint32_t nlb, uint64_t zcap) "lb= a 0x%"PRIx64" nlb %"PRIu32" zcap 0x%"PRIx64"" +pci_nvme_err_zone_invalid_write(uint64_t slba, uint64_t wp) "lba 0x%"PRIx6= 4" wp 0x%"PRIx64"" pci_nvme_err_zone_write_not_ok(uint64_t slba, uint32_t nlb, uint32_t statu= s) "slba=3D%"PRIu64", nlb=3D%"PRIu32", status=3D0x%"PRIx16"" pci_nvme_err_zone_read_not_ok(uint64_t slba, uint32_t nlb, uint32_t status= ) "slba=3D%"PRIu64", nlb=3D%"PRIu32", status=3D0x%"PRIx16"" pci_nvme_err_append_too_large(uint64_t slba, uint32_t nlb, uint8_t zasl) "= slba=3D%"PRIu64", nlb=3D%"PRIu32", zasl=3D%"PRIu8"" --=20 2.30.0