From nobody Tue Nov 18 15:24:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610968081; cv=none; d=zohomail.com; s=zohoarc; b=QMbr07dxShdpwMNSNKV9w43pTVhNYGUvyaxK0W42+ouTfDp5dkodXT1hMZeZMWcWBOggaue1NLTX+ZIr1WsvjF1ZP5B31ykFxMm3m4vtsiZDCCZHHySQwABfJdS7zpFBQK4wgZew04FxgD8swrgEErjhPUi2ZIGwQmEoTcwJK/k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610968081; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=k8E5OzmfpPhPTHqY35rlCclfuYnizBJAAP9m3Rw1KMk=; b=MBnhQDbrymZPIGZGFhWjV7eXmoeTwMC47IwQ+Uiaus3QH3e3vYQ814O9wSuaRaoyXyJwQKk0jsie4b4XMbJ6xkDdPEoyncKIexVCrJZeiOspSSCZjzrKWaDkxUI2AQj4Go6vcwGyWOTEqmyNW3jr4OAvT7towi2fCxR8EgSDaAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610968081489698.4618014522476; Mon, 18 Jan 2021 03:08:01 -0800 (PST) Received: from localhost ([::1]:50394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1SO8-0002Mr-6O for importer@patchew.org; Mon, 18 Jan 2021 06:08:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1SEP-00007g-IB for qemu-devel@nongnu.org; Mon, 18 Jan 2021 05:57:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20001) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l1SEL-0001Cr-0v for qemu-devel@nongnu.org; Mon, 18 Jan 2021 05:57:57 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-532-J38Fo12DMvmkTgtI2GVwWg-1; Mon, 18 Jan 2021 05:57:48 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C152180E461; Mon, 18 Jan 2021 10:57:47 +0000 (UTC) Received: from localhost (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0256A19725; Mon, 18 Jan 2021 10:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610967472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k8E5OzmfpPhPTHqY35rlCclfuYnizBJAAP9m3Rw1KMk=; b=Arnpd77At4nX0/jSrVQZfrdkglnVUThFOO0hRkridecOvPLLZVHGr/OATOlzS+eDQI+5WC u02wedJ781o7fN8vYYIZpUxIQG5FQizSUFFUjcqOMxdCyCv0A7Wr+BPwONE/vNtTifHMVc fYpDgspiSfwUnDaQMGlmza+YYdgEBK4= X-MC-Unique: J38Fo12DMvmkTgtI2GVwWg-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH v5 10/10] iotests/300: Clean up pylint and mypy complaints Date: Mon, 18 Jan 2021 11:57:20 +0100 Message-Id: <20210118105720.14824-11-mreitz@redhat.com> In-Reply-To: <20210118105720.14824-1-mreitz@redhat.com> References: <20210118105720.14824-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.189, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz , Willian Rampazzo Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" And consequentially drop it from 297's skip list. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Willian Rampazzo --- tests/qemu-iotests/297 | 2 +- tests/qemu-iotests/300 | 18 +++++++++++++++--- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297 index 234e1da2fb..eab3d660bb 100755 --- a/tests/qemu-iotests/297 +++ b/tests/qemu-iotests/297 @@ -33,7 +33,7 @@ SKIP_FILES =3D ( '218', '219', '222', '224', '228', '234', '235', '236', '237', '238', '240', '242', '245', '246', '248', '255', '256', '257', '258', '260', '262', '264', '266', '274', '277', '280', '281', '295', '296', '298', - '299', '300', '302', '303', '304', '307', + '299', '302', '303', '304', '307', 'nbd-fault-injector.py', 'qcow2.py', 'qcow2_format.py', 'qed.py' ) =20 diff --git a/tests/qemu-iotests/300 b/tests/qemu-iotests/300 index b864a21d5e..4115f90578 100755 --- a/tests/qemu-iotests/300 +++ b/tests/qemu-iotests/300 @@ -22,7 +22,11 @@ import os import random import re from typing import Dict, List, Optional, Union + import iotests + +# Import qemu after iotests.py has amended sys.path +# pylint: disable=3Dwrong-import-order import qemu =20 BlockBitmapMapping =3D List[Dict[str, Union[str, List[Dict[str, str]]]]] @@ -110,10 +114,14 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase): If @msg is None, check that there has not been any error. """ self.vm_b.shutdown() + + log =3D self.vm_b.get_log() + assert log is not None # Loaded after shutdown + if msg is None: - self.assertNotIn('qemu-system-', self.vm_b.get_log()) + self.assertNotIn('qemu-system-', log) else: - self.assertIn(msg, self.vm_b.get_log()) + self.assertIn(msg, log) =20 @staticmethod def mapping(node_name: str, node_alias: str, @@ -445,9 +453,13 @@ class TestBlockBitmapMappingErrors(TestDirtyBitmapMigr= ation): =20 # Check for the error in the source's log self.vm_a.shutdown() + + log =3D self.vm_a.get_log() + assert log is not None # Loaded after shutdown + self.assertIn(f"Cannot migrate bitmap '{name}' on node " f"'{self.src_node_name}': Name is longer than 255 by= tes", - self.vm_a.get_log()) + log) =20 # Expect abnormal shutdown of the destination VM because of # the failed migration --=20 2.29.2