From nobody Sat May 4 16:31:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1610940158; cv=none; d=zohomail.com; s=zohoarc; b=QNFkBWnVfVierDVBDI+HHRKx+TLL7P3SQTvDAQQ47qCiB+6GUsLt7ELcAQHA3srepLpTmNaUry9NyP5pYawSAtkoxLKr7+5TnlKYMciNHcexje4wW5lW+ohGbSL5bn4m1uy8gzy8z/Gxum7il8OGJnl/GW90edHXJfRt0/w4G10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610940158; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ApzxttbILK0zP5pmPcwJKINVHhvk+bo+9gALgKL2jOs=; b=Gt+6kAT10ACh5wb0hxxrJ2Q1No4Ywb8SwnfrWOOS2hjyqNs4j+NMw0xzDdj/lDES6MpGo64WRSSKP6+JStKJuhI6/a9XJiH6NIgyjx3wPRtmJfyl7lHstlkZ672QA5K3EUNIPB9L2TOFvvXqBpP++gi3e29mYhZinfGtdamzoOA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610940158627344.11319329742173; Sun, 17 Jan 2021 19:22:38 -0800 (PST) Received: from localhost ([::1]:36152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1L7l-0000Fp-6B for importer@patchew.org; Sun, 17 Jan 2021 22:22:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3d-0003uV-5i for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:21 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3Z-0006nx-Le for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:20 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DJxlY3PdYzl6Hv; Mon, 18 Jan 2021 11:16:41 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Jan 2021 11:17:56 +0800 From: zhouyang To: Subject: [PATCH v3 1/5] contrib: Don't use '#' flag of printf format Date: Mon, 18 Jan 2021 11:10:00 +0800 Message-ID: <20210118031004.1662363-2-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210118031004.1662363-1-zhouyang789@huawei.com> References: <20210118031004.1662363-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhouyang789@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, qemu-devel@nongnu.org, zhouyang789@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the misuse of '#' flag of printf format Signed-off-by: zhouyang --- contrib/plugins/hotblocks.c | 2 +- contrib/plugins/hotpages.c | 2 +- contrib/plugins/howvec.c | 2 +- contrib/plugins/lockstep.c | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c index 37435a3fc7..4b08340143 100644 --- a/contrib/plugins/hotblocks.c +++ b/contrib/plugins/hotblocks.c @@ -63,7 +63,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) =20 for (i =3D 0; i < limit && it->next; i++, it =3D it->next) { ExecCount *rec =3D (ExecCount *) it->data; - g_string_append_printf(report, "%#016"PRIx64", %d, %ld, %"PRId= 64"\n", + g_string_append_printf(report, "0x%016"PRIx64", %d, %ld, %"PRI= d64"\n", rec->start_addr, rec->trans_count, rec->insns, rec->exec_count); } diff --git a/contrib/plugins/hotpages.c b/contrib/plugins/hotpages.c index ecd6c18732..eacc678eac 100644 --- a/contrib/plugins/hotpages.c +++ b/contrib/plugins/hotpages.c @@ -88,7 +88,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) for (i =3D 0; i < limit && it->next; i++, it =3D it->next) { PageCounters *rec =3D (PageCounters *) it->data; g_string_append_printf(report, - "%#016"PRIx64", 0x%04x, %"PRId64 + "0x%016"PRIx64", 0x%04x, %"PRId64 ", 0x%04x, %"PRId64"\n", rec->page_address, rec->cpu_read, rec->reads, diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 3b9a6939f2..6e602aaccf 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -209,7 +209,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) i++, counts =3D g_list_next(counts)) { InsnExecCount *rec =3D (InsnExecCount *) counts->data; g_string_append_printf(report, - "Instr: %-24s\t(%ld hits)\t(op=3D%#08x/= %s)\n", + "Instr: %-24s\t(%ld hits)\t(op=3D0x%08x= /%s)\n", rec->insn, rec->count, rec->opcode, diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 5aad50869d..7fd35eb669 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -134,7 +134,7 @@ static void report_divergance(ExecState *us, ExecState = *them) =20 /* Output short log entry of going out of sync... */ if (verbose || divrec.distance =3D=3D 1 || diverged) { - g_string_printf(out, "@ %#016lx vs %#016lx (%d/%d since last)\n", + g_string_printf(out, "@ 0x%016lx vs 0x%016lx (%d/%d since last)\n", us->pc, them->pc, g_slist_length(divergence_log), divrec.distance); qemu_plugin_outs(out->str); @@ -144,7 +144,7 @@ static void report_divergance(ExecState *us, ExecState = *them) int i; GSList *entry; =20 - g_string_printf(out, "=CE=94 insn_count @ %#016lx (%ld) vs %#016lx= (%ld)\n", + g_string_printf(out, "=CE=94 insn_count @ 0x%016lx (%ld) vs 0x%016= lx (%ld)\n", us->pc, us->insn_count, them->pc, them->insn_count= ); =20 for (entry =3D log, i =3D 0; @@ -152,7 +152,7 @@ static void report_divergance(ExecState *us, ExecState = *them) entry =3D g_slist_next(entry), i++) { ExecInfo *prev =3D (ExecInfo *) entry->data; g_string_append_printf(out, - " previously @ %#016lx/%ld (%ld insns)= \n", + " previously @ 0x%016lx/%ld (%ld insns= )\n", prev->block->pc, prev->block->insns, prev->insn_count); } --=20 2.23.0 From nobody Sat May 4 16:31:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1610940067; cv=none; d=zohomail.com; s=zohoarc; b=fgvNiPuMTfRooF6j+Q8kaN8lQpOR3rArNfJtRz+OZEkIa66QhS2L5C7mvYA+jfP8LG3ydPju5zwmnRkT7r7w8mCSnSX1sLzGNPNiWJt+STcPCHd0uFQ041DzLmkQBkcLUPctB/JE3FckztX8+rdQkQ2crSnV/IDqBnpNvaIWkf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610940067; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S9U/WeQLgwHsKpCvpBBDu+ZJEyw6fNAxv52Q4J+SnEg=; b=d/fwiBxgtfzERvgDv4H0knrfq35RM8W+4higs5P01hfMDxa+6bR6/ZYbLkyzhHmoPCstDU/feJwCvqgMfDCCDK/Tm4n/BXHFoVzAVFUBkI+1r3v6zLlaiiDvu47W/eopdegZd0dB1xNGcik7KzWUgtx3RgkVByKZljK6kvAVL/0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610940067467264.5993475516716; Sun, 17 Jan 2021 19:21:07 -0800 (PST) Received: from localhost ([::1]:32832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1L6I-0007IF-G4 for importer@patchew.org; Sun, 17 Jan 2021 22:21:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3c-0003uL-LH for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:20 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3a-0006ns-GQ for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:20 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DJxlY3BKHzl6Hs; Mon, 18 Jan 2021 11:16:41 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Jan 2021 11:17:57 +0800 From: zhouyang To: Subject: [PATCH v3 2/5] contrib: Fix some code style problems, ERROR: "foo * bar" should be "foo *bar" Date: Mon, 18 Jan 2021 11:10:01 +0800 Message-ID: <20210118031004.1662363-3-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210118031004.1662363-1-zhouyang789@huawei.com> References: <20210118031004.1662363-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhouyang789@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, qemu-devel@nongnu.org, zhouyang789@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: zhouyang --- contrib/plugins/howvec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 6e602aaccf..2f892da17d 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -235,7 +235,7 @@ static void vcpu_insn_exec_before(unsigned int cpu_inde= x, void *udata) (*count)++; } =20 -static uint64_t * find_counter(struct qemu_plugin_insn *insn) +static uint64_t *find_counter(struct qemu_plugin_insn *insn) { int i; uint64_t *cnt =3D NULL; --=20 2.23.0 From nobody Sat May 4 16:31:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1610939956; cv=none; d=zohomail.com; s=zohoarc; b=AfwMwN4nfjLRhOaKirWqvfHVDwz068g6OXtXJ6UmRjVwCQcj6s+GSW43QsaLDAec7AmXQ46gs979vFOkpJap58L8gYT3N36Rz+FnvDchffIz8sj1Spjvfziln16s5C8ruAERM+w5vbInn9vxrHhLLYdtDcRVVGcSs8pmNVOW8Xk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610939956; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yfwRodM3SVvFLcgsYmQ4W0ghVCgariZfqKCl3iTjfzE=; b=lJGP0abDdiWKB27qHyYjTvzoTd9Hq8s2NeM7PH7Cyly07FQAd6rBOmSBWRD1kawakzMvUVmJ1iwXBneCXDoqPcGyxsB6E5EbbNIYSH2NQkndGk3crLLcSTPcU8XThtTPkFbMPCnCqNzz2Qr+fT5mQfGGBjFqIVmvcwklcPfJuEg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610939956125802.1871409068513; Sun, 17 Jan 2021 19:19:16 -0800 (PST) Received: from localhost ([::1]:55556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1L4V-00055f-2q for importer@patchew.org; Sun, 17 Jan 2021 22:19:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3c-0003u9-9e for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:20 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3a-0006nt-41 for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:20 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DJxlY2qxfzl6Hn; Mon, 18 Jan 2021 11:16:41 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Jan 2021 11:17:57 +0800 From: zhouyang To: Subject: [PATCH v3 3/5] contrib: Add spaces around operator Date: Mon, 18 Jan 2021 11:10:02 +0800 Message-ID: <20210118031004.1662363-4-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210118031004.1662363-1-zhouyang789@huawei.com> References: <20210118031004.1662363-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhouyang789@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, qemu-devel@nongnu.org, zhouyang789@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: spaces required around that '*' Signed-off-by: zhouyang --- contrib/ivshmem-server/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c index ee08c4ced0..224dbeb547 100644 --- a/contrib/ivshmem-server/main.c +++ b/contrib/ivshmem-server/main.c @@ -17,7 +17,7 @@ #define IVSHMEM_SERVER_DEFAULT_PID_FILE "/var/run/ivshmem-server.pid" #define IVSHMEM_SERVER_DEFAULT_UNIX_SOCK_PATH "/tmp/ivshmem_socket" #define IVSHMEM_SERVER_DEFAULT_SHM_PATH "ivshmem" -#define IVSHMEM_SERVER_DEFAULT_SHM_SIZE (4*1024*1024) +#define IVSHMEM_SERVER_DEFAULT_SHM_SIZE (4 * 1024 * 1024) #define IVSHMEM_SERVER_DEFAULT_N_VECTORS 1 =20 /* used to quit on signal SIGTERM */ --=20 2.23.0 From nobody Sat May 4 16:31:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1610939968; cv=none; d=zohomail.com; s=zohoarc; b=goM2ON7u1ebdMFGneQyb27DKERATWWkmB3aP+dkhSh1TbKDuLElar+vCIVcWVLXxHpzVOoykRNZj2i2xGKJbgbqixLbBH0yVe4j4XXsGswBer06OznY62MU1COiCLtnuMgcDaCi8Ov3h2CsP6j3XXlXwsEcASghpVYpXyg8mdpo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610939968; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OA6F4Mx+2bDFPtutFSvgUkIoKDw48xDLjIFjLos0Byk=; b=oB3DbLa7+QNBqxS9ILt3YJOVOcro9FGmoovij284f2OC4ZuO2fYotjwgFACcXgF8QulcNK+Pi3f2PEHVjnXj7nQlBYpNAaTLE+Y0pSPerLD/UXWGECwTB6CIdLg7264ORYsP7+arIHhGNc3wqJN0ze1U59Tz618dJ3M8LcsTUa0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610939968885263.1986273351414; Sun, 17 Jan 2021 19:19:28 -0800 (PST) Received: from localhost ([::1]:55844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1L4f-0005Ci-RB for importer@patchew.org; Sun, 17 Jan 2021 22:19:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3e-0003vm-Qu for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:22 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3c-0006ps-DR for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:22 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DJxlf0wF7zMLb8; Mon, 18 Jan 2021 11:16:46 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Jan 2021 11:17:58 +0800 From: zhouyang To: Subject: [PATCH v3 4/5] contrib: space required after that ',' Date: Mon, 18 Jan 2021 11:10:03 +0800 Message-ID: <20210118031004.1662363-5-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210118031004.1662363-1-zhouyang789@huawei.com> References: <20210118031004.1662363-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=zhouyang789@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, qemu-devel@nongnu.org, zhouyang789@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I am reading contrib related code and found some style problems while check the code using checkpatch.pl. This commit fixs the issue below: ERROR: space required after that ',' Signed-off-by: zhouyang --- contrib/plugins/howvec.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 2f892da17d..9d6fa33297 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -68,7 +68,7 @@ static InsnClassExecCount aarch64_insn_classes[] =3D { { "Reserved", "res", 0x1e000000, 0x00000000, COUNT_CLASS= }, /* Data Processing Immediate */ { " PCrel addr", "pcrel", 0x1f000000, 0x10000000, COUNT_CLASS= }, - { " Add/Sub (imm,tags)","asit", 0x1f800000, 0x11800000, COUNT_CLASS= }, + { " Add/Sub (imm,tags)", "asit", 0x1f800000, 0x11800000, COUNT_CLAS= S}, { " Add/Sub (imm)", "asi", 0x1f000000, 0x11000000, COUNT_CLASS= }, { " Logical (imm)", "logi", 0x1f800000, 0x12000000, COUNT_CLASS= }, { " Move Wide (imm)", "movwi", 0x1f800000, 0x12800000, COUNT_CLASS= }, @@ -91,17 +91,17 @@ static InsnClassExecCount aarch64_insn_classes[] =3D { { "Branches", "branch", 0x1c000000, 0x14000000, COUNT_CLASS= }, /* Loads and Stores */ { " AdvSimd ldstmult", "advlsm", 0xbfbf0000, 0x0c000000, COUNT_CLASS= }, - { " AdvSimd ldstmult++","advlsmp",0xbfb00000, 0x0c800000, COUNT_CLASS= }, + { " AdvSimd ldstmult++", "advlsmp", 0xbfb00000, 0x0c800000, COUNT_CLA= SS}, { " AdvSimd ldst", "advlss", 0xbf9f0000, 0x0d000000, COUNT_CLASS= }, - { " AdvSimd ldst++", "advlssp",0xbf800000, 0x0d800000, COUNT_CLASS= }, + { " AdvSimd ldst++", "advlssp", 0xbf800000, 0x0d800000, COUNT_CLAS= S}, { " ldst excl", "ldstx", 0x3f000000, 0x08000000, COUNT_CLASS= }, { " Prefetch", "prfm", 0xff000000, 0xd8000000, COUNT_CLASS= }, { " Load Reg (lit)", "ldlit", 0x1b000000, 0x18000000, COUNT_CLASS= }, - { " ldst noalloc pair", "ldstnap",0x3b800000, 0x28000000, COUNT_CLASS= }, + { " ldst noalloc pair", "ldstnap", 0x3b800000, 0x28000000, COUNT_CLAS= S}, { " ldst pair", "ldstp", 0x38000000, 0x28000000, COUNT_CLASS= }, { " ldst reg", "ldstr", 0x3b200000, 0x38000000, COUNT_CLASS= }, { " Atomic ldst", "atomic", 0x3b200c00, 0x38200000, COUNT_CLASS= }, - { " ldst reg (reg off)","ldstro", 0x3b200b00, 0x38200800, COUNT_CLASS= }, + { " ldst reg (reg off)", "ldstro", 0x3b200b00, 0x38200800, COUNT_CLAS= S}, { " ldst reg (pac)", "ldstpa", 0x3b200200, 0x38200800, COUNT_CLASS= }, { " ldst reg (imm)", "ldsti", 0x3b000000, 0x39000000, COUNT_CLASS= }, { "Loads & Stores", "ldst", 0x0a000000, 0x08000000, COUNT_CLASS= }, @@ -202,7 +202,7 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) =20 counts =3D g_hash_table_get_values(insns); if (counts && g_list_next(counts)) { - g_string_append_printf(report,"Individual Instructions:\n"); + g_string_append_printf(report, "Individual Instructions:\n"); counts =3D g_list_sort(counts, cmp_exec_count); =20 for (i =3D 0; i < limit && g_list_next(counts); --=20 2.23.0 From nobody Sat May 4 16:31:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1610940067; cv=none; d=zohomail.com; s=zohoarc; b=U5iJXTcJRgJWT5jkcJpxSbm8Xr8XPlrDLUr5Yh+TltJlI2kKreg13pGj5dP/n9CRaAK1cQDfKKtbwu+mNjFg6XXpOsCxwkwvE4LIjcNdjwp+g19Ejcu58SwDa8IHMHWN+veAdTEDs60srw4BlE4VvDDZfpxjTfeqdFyjKyfGxPM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610940067; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6fCh12kdodBm7K03w+8DVzQhhM81r7hXJJv75piL74E=; b=Mo+6Lglx2K8eI5Ea3gKwFrtnc1ktXORloeXG7FpgtIur4Z9RP35VyuCtaZbDd24XTXCNQ2sYVambTEAcQA8zJ0RJmKfTcXr4moxSiEJX8bPWu4m/Dkc1fVcXLt0enipuZ1dsw4hKdiWCcGf+Jf7/tnu61sMSfUVCPy/V89NkdC0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16109400674451000.2026457694436; Sun, 17 Jan 2021 19:21:07 -0800 (PST) Received: from localhost ([::1]:32812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1L6I-0007Hg-Fq for importer@patchew.org; Sun, 17 Jan 2021 22:21:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3f-0003wB-28 for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:23 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1L3d-0006pt-A8 for qemu-devel@nongnu.org; Sun, 17 Jan 2021 22:18:22 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DJxlf15hzzMLb7; Mon, 18 Jan 2021 11:16:46 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Jan 2021 11:17:58 +0800 From: zhouyang To: Subject: [PATCH v3 5/5] contrib: Open brace '{' following struct go on the same line Date: Mon, 18 Jan 2021 11:10:04 +0800 Message-ID: <20210118031004.1662363-6-zhouyang789@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210118031004.1662363-1-zhouyang789@huawei.com> References: <20210118031004.1662363-1-zhouyang789@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=zhouyang789@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, qemu-devel@nongnu.org, zhouyang789@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" I found some style problems whil check the code using checkpatch.pl. This commit fixs the issue below: ERROR: that open brace { should be on the previous line Signed-off-by: zhouyang --- contrib/plugins/howvec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/contrib/plugins/howvec.c b/contrib/plugins/howvec.c index 9d6fa33297..600f7facc1 100644 --- a/contrib/plugins/howvec.c +++ b/contrib/plugins/howvec.c @@ -145,8 +145,7 @@ typedef struct { int table_sz; } ClassSelector; =20 -static ClassSelector class_tables[] =3D -{ +static ClassSelector class_tables[] =3D { { "aarch64", aarch64_insn_classes, ARRAY_SIZE(aarch64_insn_classes) }, { "sparc", sparc32_insn_classes, ARRAY_SIZE(sparc32_insn_classes) }, { "sparc64", sparc64_insn_classes, ARRAY_SIZE(sparc64_insn_classes) }, --=20 2.23.0