From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911498; cv=none; d=zohomail.com; s=zohoarc; b=lBn3pgOjK/Y1Hz1Q9EfdnWsp0H57qqwOjjKkouxa4OjlByRbYNktwilT26ckJhV/LXxwFsNsYOQbl2XMaxK4I9x50cLXomQ8FzItIpiloF9y1VO1CAJhYubu/YjgTQ6dYL+7ZXxltCdG5Si/65q35qAlLn0W4m2iFX1A46PwBQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911498; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vafwmt7UGiwAARCHIG5psXHv2hnCIeQD5qlHTz8atP8=; b=RRdoawDkF8NJ3esS5QzxT8bV7H84myv1SBb99XxBoFo75eisNBAHjjo5DEi/7xp9Sunv+je/FfV+Frkp8tztaNESkbIfwN2OdnL8O09ePjeZwWdu5KUpmpTAWDfpuRD0+jCRIKHimYjZXG958EKhbWX99oGPLCauXifmjQKPSck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 161091149860068.33724716882182; Sun, 17 Jan 2021 11:24:58 -0800 (PST) Received: by mail-wm1-f45.google.com with SMTP id e15so5644999wme.0 for ; Sun, 17 Jan 2021 11:24:57 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id g10sm15146735wmq.3.2021.01.17.11.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vafwmt7UGiwAARCHIG5psXHv2hnCIeQD5qlHTz8atP8=; b=YIvRs5DEaJw/jyD9Lu9/F/RTIrW7XhEmbkbHFnNcCIGrl9cOlqxwEtSJW/8TwNIZ+l CoDzJMMuG0IrdayVH48zlOpVgL6LJmuhaaa3bXbPTZALbuE2KoZmPyy4o/60m8FRSdKc XO2GmJj/whS33/I3SxDL+TfPZSKym4rtP3R+/rTe9sh9lc6oRqWxaPLH4iCAIkPJxkXd 3PmT1aAer7RkKcEo8oHTy1CW11qLe6I3L/tW8W4tIrbliYm2AQMfAtrqCB3evdClCsNV EneNw0l+iPT/wH/qiuV/Bua9Fy9n9YNu1N7vAhzNTVFbmYlUQGE1tMu3cnTEluO/JRPX Wukg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vafwmt7UGiwAARCHIG5psXHv2hnCIeQD5qlHTz8atP8=; b=jMh2qiCuljbb+cBGW/Rebmgmt9J4qK06/9h6hlv51A8uBvmVF+AmYVclGXUqaySM8l W+jhJe3ZRw8fKCZkJMRRfCZ6zO+D/AS41/MbaYk2NYxD83Mv/x9FjmbFQ9jBcLyMdO4f UmcHivH8xlaT3dxwBpB7I4fjs5fBz2g8uePk7VDkCb/NGx8hhcZFRAK8iCqydnbyOoud kqFkHp15DiXghBDmenIw9hKgcOy44BdOAe35C+dgGcPPhMsoTh6/IZkr/NJhpGsrLlsN MFB4UPwa1b1gXDRj5v11VISFW/Dq89fXqNu2v5cEDa3aj2ODKzNgbnmVACbkMGeeREub NhVw== X-Gm-Message-State: AOAM531rHh0Bniak3bhT3qiyX6OdLYplQAf8QdoCPOXEx5q3t8X7Vrts 9Rk4CUHj6smIVvQdtGe0idU= X-Google-Smtp-Source: ABdhPJy2Z0EpzHJ5eAxkzhF93tt6soq0TpV11Q2+cAzt1rcQWY8ORK1vmFknf6ry9LKUxd1Hems5bg== X-Received: by 2002:a1c:4b14:: with SMTP id y20mr5519916wma.166.1610911495872; Sun, 17 Jan 2021 11:24:55 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 01/20] migration/vmstate: Restrict vmstate_dummy to user-mode Date: Sun, 17 Jan 2021 20:24:27 +0100 Message-Id: <20210117192446.23753-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) 'vmstate_dummy' is special and only used for user-mode. Rename it to something more specific. It was introduced restricted to user-mode in commit c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY") but this restriction was later removed in commit 6afc14e92ac ("migration: Fix warning caused by missing declaration of vmstate_dummy"). Avoid the missing declaration warning by adding a stub for the symbol, and restore the #ifdef'ry. Suggested-by: Daniel Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dr. David Alan Gilbert --- include/hw/core/cpu.h | 2 +- include/migration/vmstate.h | 4 +++- stubs/vmstate.c | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 140fa32a5e3..c79a58db9b9 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1132,7 +1132,7 @@ bool target_words_bigendian(void); #ifdef CONFIG_SOFTMMU extern const VMStateDescription vmstate_cpu_common; #else -#define vmstate_cpu_common vmstate_dummy +#define vmstate_cpu_common vmstate_user_mode_cpu_dummy #endif =20 #define VMSTATE_CPU() { = \ diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 075ee800960..dda65c9987d 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -194,7 +194,9 @@ struct VMStateDescription { const VMStateDescription **subsections; }; =20 -extern const VMStateDescription vmstate_dummy; +#if defined(CONFIG_USER_ONLY) +extern const VMStateDescription vmstate_user_mode_cpu_dummy; +#endif =20 extern const VMStateInfo vmstate_info_bool; =20 diff --git a/stubs/vmstate.c b/stubs/vmstate.c index cc4fe41dfc2..8da777a1fb4 100644 --- a/stubs/vmstate.c +++ b/stubs/vmstate.c @@ -1,7 +1,9 @@ #include "qemu/osdep.h" #include "migration/vmstate.h" =20 -const VMStateDescription vmstate_dummy =3D {}; +#if defined(CONFIG_USER_ONLY) +const VMStateDescription vmstate_user_mode_cpu_dummy =3D {}; +#endif =20 int vmstate_register_with_alias_id(VMStateIf *obj, uint32_t instance_id, --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) client-ip=209.85.128.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911503; cv=none; d=zohomail.com; s=zohoarc; b=i0lad0AC2SYziMW7130Q5iUm3ZT3bGKPaXqsLxuEx7ADc3RZCsSJAlwYbsoEEObyMNw13UoLcJq0lXVCZOWSrUY0BReIxgDIfN18PJvDEQEOC0zGh1owbD3wA5w/TXI165rXSPxnb9VOw4AjOAGT0bahsQpk7D3Y1IwRLLINw68= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911503; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rOquWOYfnZ1HWefCZ4bvuH3r0gldDGI6o719tcrABHg=; b=jJv2vBB693U3BGRG2wqftfM5GvCGA2wjvu6zGlYWDpc1OBnMjRETLsaD8Iynm5M8Mno7W1llillIW8QlwG6RerHq0c9sbu8LtTWz91Cz5n3UD5EnOMADCAvEcC6R4XnAOoc9FWPvDWqH3iMeXWUHI2kwn5x3SZGFstUGff4yev8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx.zohomail.com with SMTPS id 1610911503160567.4823596431215; Sun, 17 Jan 2021 11:25:03 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id r4so12027369wmh.5 for ; Sun, 17 Jan 2021 11:25:02 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id c7sm26812421wro.16.2021.01.17.11.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rOquWOYfnZ1HWefCZ4bvuH3r0gldDGI6o719tcrABHg=; b=EYnYeiQhZt4kdpurJRBjpjb/bcj/11MzVB6hWoOub2Sp7mN8xZudoHD1j7ZrWLtX8b RoZq9fdOkXGhavJbK4w2KZ1U4vmkeqpQcgbobilX16Ho2RzHV78cR5aDm4KihvLCNsGB 40Aq534HHEQK0hjW321NaI4/R0zR4TpTnpi7EZHcuTkRJvpZedDO0yHfqOYe5Kgpzis1 /8fU/glBDGWlwlF7gpsh+z2eman6W7+dn4l9ycIV1mNS78snMvDt7T61OWT7NTKyd+1I nwYp5hA29Iti93NhAi6Hd8T6fDmYU0KpiX0fI3r9UK909pE+LSLosLz/E7e380/rSPxd 1NQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rOquWOYfnZ1HWefCZ4bvuH3r0gldDGI6o719tcrABHg=; b=LNdw5c4SU+7+4+SbiadmVP30+22F9rHPPl6OoKX9JkyM3jvtgZDGBsWMB/KDtXs1Wq h1eFzLaQK9lPqwRFUSwhpMZpjiJMHCqvi41MBfdvGrR5fkd2ElW+u+zyVMMRpvwLIZHi /Y31iod0Pj02EgWvwGxa65mKn7zjW1nCmWf8NPEbRE3Ys4vhMx+iZc2H8aj+nSWAG/kv fNU26aHiWemdI+QFB39szgnZWXIJhSM1lkErPzBg0/wbVe7ET9e3aiFa79uDhIuh5hup /PTtgVoESGJusJJrzaFgpfyUlG5X7rYmesmcXuCoPIwBh5Ci+nzgL1wrRH0RsuoqiW8v yrRQ== X-Gm-Message-State: AOAM532UjmiF2Wo/PskW/u22E5vJN/CjuNnOJ+pJUKAYPBvMPlFiwqJO aqqN8tkLYi0ro8rYfSemwiw= X-Google-Smtp-Source: ABdhPJxBDmPKuKJLqL7gFLmi+ElRcs/UoRPsNdLu+sTc3B0ONi5NIEEYj38j6gv73oHIYgSH7GkpSg== X-Received: by 2002:a1c:99d1:: with SMTP id b200mr17629965wme.37.1610911501420; Sun, 17 Jan 2021 11:25:01 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 02/20] hw/core/qdev: Add vmstate_qdev_no_state_to_migrate Date: Sun, 17 Jan 2021 20:24:28 +0100 Message-Id: <20210117192446.23753-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Add vmstate_qdev_no_state_to_migrate, which is simply a pointer to vmstate_no_state_to_migrate. This way all qdev devices (including "hw/qdev-core.h") don't have to include "migration/vmstate.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Unresolved issues: https://www.mail-archive.com/qemu-devel@nongnu.org/msg721695.html Peter: > Does this definitely not put any data into the migration stream? > We don't want to change what's on the wire for machines that > use devices that start using this. (If it does by default, it > would be easy to make the migration code special case the > magic symbol to act like "no vmsd specified"). https://www.mail-archive.com/qemu-devel@nongnu.org/msg727634.html Dave: > I'd need to test it to be sure, but I think if we added a .needed > to vmstate_no_state_to_migrate with a function that always returned > false, then I think the stream would stay unchanged. --- include/hw/qdev-core.h | 2 ++ include/migration/vmstate.h | 1 + hw/core/qdev.c | 3 +++ migration/vmstate.c | 7 +++++++ stubs/vmstate.c | 7 +++++++ 5 files changed, 20 insertions(+) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index bafc311bfa1..d2c7a46e6a2 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -140,6 +140,8 @@ struct DeviceClass { const char *bus_type; }; =20 +extern const VMStateDescription *vmstate_qdev_no_state_to_migrate; + typedef struct NamedGPIOList NamedGPIOList; =20 struct NamedGPIOList { diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index dda65c9987d..50559598eac 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -197,6 +197,7 @@ struct VMStateDescription { #if defined(CONFIG_USER_ONLY) extern const VMStateDescription vmstate_user_mode_cpu_dummy; #endif +extern const VMStateDescription vmstate_no_state_to_migrate; =20 extern const VMStateInfo vmstate_info_bool; =20 diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..f0d0afd438d 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -44,6 +44,9 @@ static bool qdev_hot_added =3D false; bool qdev_hot_removed =3D false; =20 +const VMStateDescription *vmstate_qdev_no_state_to_migrate =3D + &vmstate_no_state_to_migrate; + const VMStateDescription *qdev_get_vmsd(DeviceState *dev) { DeviceClass *dc =3D DEVICE_GET_CLASS(dev); diff --git a/migration/vmstate.c b/migration/vmstate.c index 05f87cdddc5..2c373774dfa 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -20,6 +20,13 @@ #include "qemu/error-report.h" #include "trace.h" =20 +const VMStateDescription vmstate_no_state_to_migrate =3D { + .name =3D "empty-state", + .fields =3D (VMStateField[]) { + VMSTATE_END_OF_LIST() + } +}; + static int vmstate_subsection_save(QEMUFile *f, const VMStateDescription *= vmsd, void *opaque, JSONWriter *vmdesc); static int vmstate_subsection_load(QEMUFile *f, const VMStateDescription *= vmsd, diff --git a/stubs/vmstate.c b/stubs/vmstate.c index 8da777a1fb4..f561f9f39bd 100644 --- a/stubs/vmstate.c +++ b/stubs/vmstate.c @@ -5,6 +5,13 @@ const VMStateDescription vmstate_user_mode_cpu_dummy =3D {}; #endif =20 +const VMStateDescription vmstate_no_state_to_migrate =3D { + .name =3D "empty-state", + .fields =3D (VMStateField[]) { + VMSTATE_END_OF_LIST() + } +}; + int vmstate_register_with_alias_id(VMStateIf *obj, uint32_t instance_id, const VMStateDescription *vmsd, --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911508; cv=none; d=zohomail.com; s=zohoarc; b=F0OvB9SnafwLvQLkv3Ca/cRPOjIgKDRblJCkD2b8//5u+sOZr8qz6zwdBK+tLYaWtHtXuGWj9qq6Zkbnnv4nV6tWU9ZczhHMdIyu9Jqcu1U/srf7Jls8E7Y4FunJ8K44FvtguSasl7noeX29dDrMjVkit+7B4agkWoJqAJsmbl8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911508; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wgGk6yPxUB2DXYQxZxUZbUfoW7pWWFaws3b1nVoeQJI=; b=IZyBSM7YehPCyPovGqbJFCTAswP5oIdITq+p8IwdfrqUFTQaUuTST284/pdU4+AnfV4nFF/Lwde4y4EcA0MkixIy51TvhwEyjD+aij+IOkDOuhg5ipq1hKOagDmyrzPQo9Kb2SCkCXcZ9lssZxSJXuHNzqhQLbBqANpZAKRfab4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 1610911508584752.251554903232; Sun, 17 Jan 2021 11:25:08 -0800 (PST) Received: by mail-wm1-f43.google.com with SMTP id u14so7850203wmq.4 for ; Sun, 17 Jan 2021 11:25:08 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id g132sm7677099wmg.2.2021.01.17.11.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wgGk6yPxUB2DXYQxZxUZbUfoW7pWWFaws3b1nVoeQJI=; b=bqRm9TOuPkd2JJzuiyB3+fC/IaQmbzS4vjNWsXGFo8+5Mflus030NR2kBkBcyAY/TY dX3c8vZ7mTigiWmGz1TjoZtig2/ssKmjq325+fujlQL59FlqKNOSopcsHzOYrOaSepVf 4cAzYJILLGjz+GqgDA49atJK3MjD4tSF2eM5Ob1d0QiXVE0XTaHHwDfRTva9SAAddjDR 8on2onc7unLskg1eeRVvy6qMjk+UCmlJZRW1lMCmco3StadumZWmL6EidgQVa2Cci5Ng Yxlzv7LoOeScwOMTeFppoXhfkx+A8a+7/anoWV68P/Nc1kWtENblYlvDQGnX8OgnS2Rg qtgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wgGk6yPxUB2DXYQxZxUZbUfoW7pWWFaws3b1nVoeQJI=; b=BMGGZJQ/o7mHYWWoAkO4fCQaPzg28spWJjo3o6eq5a7hwdxVs+Xjv5F1eG0ipsgR73 ti9FrjMhD/kNaDQdfasx5+camzbUWCytw7woxzN0BTtgbWUQ9Z7PgC+tS3xO5zhxq21x hkXwQD+Saxt7SOw7Xm4e9VeMtAE9V3ukcP8ZdydhusyoWYnu+vUzVspzhSjjIWQDMCOQ sxtuHQdrBFQ0Egxs0p98kKVM6zG3NLtu0o7rxJ7VeBI8nHCi8LPeQ3K2Oj0Roj6/nnWc cZtEAyt6wHwGtoPP9rG+xQjdtA/AqTM7BIgEiOo6QaQ7shTAWWutD56p6b2FLa5XGJnd 7XPQ== X-Gm-Message-State: AOAM530w9zHD2O6ni/brIj/CoDTo0QlyH5JGvGF9Ukjo9Goi67RXyDDF 7dNpz0OA1RpYglCEVaxIdZ0= X-Google-Smtp-Source: ABdhPJwpd7o10gr0UWFsvUMmVK3jnwDM/gu8QrHjDx+1/Q3pAUJsv7+0OC7//09bWuFgQ+VEzCWJFQ== X-Received: by 2002:a1c:e255:: with SMTP id z82mr9888944wmg.60.1610911506845; Sun, 17 Jan 2021 11:25:06 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 03/20] hw/arm/armv7m: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:29 +0100 Message-Id: <20210117192446.23753-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The TYPE_BITBAND device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Reworded (Peter) --- hw/arm/armv7m.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 8224d4ade9f..41ac1b88ab4 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -347,6 +347,7 @@ static void bitband_class_init(ObjectClass *klass, void= *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D bitband_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, bitband_properties); } =20 --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911513; cv=none; d=zohomail.com; s=zohoarc; b=KhpmNeVuWGQaziDmTa7lYPyCBmmIOiMAnH4VIF85HmtVawWjEIhkhR3P/ah6kkrCzXvmA1vd2NBuJM87HBZxFIC0IHq7a7ayjUyvBIsJ0WYEkEN8Hmh7KHNP8V9deGtZ/YgaIe0seBHzvyn1C63sJmlaTNngv8BXBuowBUXakEY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911513; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AlGU2nsRUdTo0zfYKpVmo6pCOia5Vbf+z0yVnRjS/M8=; b=EyGfcFA6wJgmuncvnOkTG78XvgVoBHY3b/ycHi47MobNT78JyvuExQaRkDA7uFR0fvLLezztMUCXBlm4Jcrb9Z6HZk8o/VqREi8rpehXVZ6kMY48zMrqTbYiNLRolKGCS9sL5YqxlHtQMuIS02ynVdA3IkFd885U10e5pWkSekU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1610911513992442.7342713371514; Sun, 17 Jan 2021 11:25:13 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id d26so14433902wrb.12 for ; Sun, 17 Jan 2021 11:25:13 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id r2sm25630352wrn.83.2021.01.17.11.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AlGU2nsRUdTo0zfYKpVmo6pCOia5Vbf+z0yVnRjS/M8=; b=nqSVOhr4bDYAHt6sQopLvtMo2XRxmB7nW0+Z1zomvfYV2slp8usJZmsPVYy7XO/RCj n3gczAXJS8UT9Ac7MpiUJV6xB70/EK7cgaVOFSrgeppH/eXe9XFDFZvhUtSW3zY+r4wM DdZ0YD3KPsflQeXWaMffKZMYb/4TP8bUiw9sSDgYyqlF0GnTx4rjBhWT8xozR5MzpuCe sPOOLYtd//1aP1HFMxGHbHKO3YIVJDf+8skD0DFPAgw7kZNUCuymgrU9oaUo5mQgffo9 qpVd/5qR4Seyx+OUa/Kdkbfrd9qcgUsWjefN6zYTFz2EY0OxQOlVaCzkz1AwhtadLp53 wNmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=AlGU2nsRUdTo0zfYKpVmo6pCOia5Vbf+z0yVnRjS/M8=; b=F+DRPzkS3turz4mX+8LPBQ+D8RjRlv93r6Uqh/UMnbOgWhh+gCPGHvx/0qmgaW1u4x cGvNBXwymVekuAlRUN0JXfDEBr2Y1mb3q/wzQGAQzYl7tvpjs038K8hgqUjBrKW1PO57 Rfm+WMGpxMPrxCMN7GeK0cF+1hfCJN4Ww42chA0QKuo/Yl7P2qFpW0YKAGhm4HuM9Itj q/eBA2MpYGUe2Njz693uKsrq1/uQ35h0vPk0Av/fh6MXFa+2xCnoaJDKFQqQ/vmtogYV 3T8MDzYiyQ79aYr7xoUgdyC6jZtXzBn8a70TN4nmKQKJbHXlnv9Y1zgE0/y8Li0HEbQM 024Q== X-Gm-Message-State: AOAM532n0LXo1vjNBRWgvhGBoaaywxZUFL6n6YoPPHOUAmKnbg3aLkfD Ibud3nBxsm806R3rQ7nc1sM= X-Google-Smtp-Source: ABdhPJxYeHFxMVKx/TiAvFU8LTxUHEZIh5DFiDksj3H0CaaNJpfUMZd4E+qInreiVIbCr9q5WR/nLA== X-Received: by 2002:a05:6000:185:: with SMTP id p5mr22521077wrx.403.1610911512273; Sun, 17 Jan 2021 11:25:12 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 04/20] hw/arm/aspeed_soc: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:30 +0100 Message-Id: <20210117192446.23753-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: C=C3=A9dric Le Goater --- hw/arm/aspeed_soc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c index 7eefd54ac07..b503d32fef6 100644 --- a/hw/arm/aspeed_soc.c +++ b/hw/arm/aspeed_soc.c @@ -407,6 +407,7 @@ static void aspeed_soc_class_init(ObjectClass *oc, void= *data) dc->realize =3D aspeed_soc_realize; /* Reason: Uses serial_hds and nd_table in realize() directly */ dc->user_creatable =3D false; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, aspeed_soc_properties); } =20 --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911519; cv=none; d=zohomail.com; s=zohoarc; b=Lmpjn3qeHoukrrXMox35dsqhZFCY3X6neVZTERwXvYT0Sdd4y64SiZYjV4osOehuMzyuT2YWMy7LI8HR5vkJUc8Npwjies6o6WaQSWoA85zPMFSRbQXcsf/CVYvypPkQW/RqzqC7meEW4kZO0FdTITaV5lbku4Egub58NwS/HbA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911519; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qdebcebcEgAUy36pbkwOtCiC8gYa7FMBNTjw+ZgzJr8=; b=kuMCSYGnXQAor8q7gWJ8+b+4wZFGnyfgggWRiPLP1FO7ozwb7ZnptRDKKqUsqY2XxtaBjC39NEatHXcGQI6nXtuNXqKEixyPhORlqMf8rpSgNPyWIpOXLQuo2T7LU1OrDotjvrbwinYLrijWX6ytxJ48aL++bonMZbQ4VKEw8Vc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1610911519744168.48898058441716; Sun, 17 Jan 2021 11:25:19 -0800 (PST) Received: by mail-wr1-f50.google.com with SMTP id v15so10793911wrx.4 for ; Sun, 17 Jan 2021 11:25:19 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id b13sm23004714wrt.31.2021.01.17.11.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qdebcebcEgAUy36pbkwOtCiC8gYa7FMBNTjw+ZgzJr8=; b=okh6rYyT8WPB0Ldi5fnznckOXxu8R9A29W7mOana5evBSJUO9M+PZ+mXlLmf12WOoE 5jGrSGADlg8sUsn4uA0vkc74lAAqe/Qo4RqoQzjoh989ikJDMP2WHAYOBZgx6olSyBW0 rEIpmWGBSK/ojnfD51oSIXJeIMvHoJYWhSE7823T+P+txI7hi33ylobdsh10L1kGJDRj 7t/rEYZ2CHvxACFy9OUpIsfexlmg/zHHRh2ReiVK/aoODvSgQL+HVhKoAmcg2BfW66RZ yFkJCS2BTSzCngRyJ+m0NoAa4xWon5eo71UfslsmaPo81qwsbR6rGMRskT2guhxyRpbB c+tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=qdebcebcEgAUy36pbkwOtCiC8gYa7FMBNTjw+ZgzJr8=; b=k7240D7KEHDAx0svamTc/UKahWz2tNj9Lh/T1s8Tvhx2Pf0saop3MAy+Y3S3cIyPMq w8AXh+9mFExwsDz/GxAm5hKTQIR190G0rrlFK3lBQQiyRCWdiGu3eYJgzulk57BlHrB6 Nhn/x8y8dJad8DgDssoIG006dSHP9Qx4Qf83T45IF/PNNPM7UTcxAOXqS373dxAFElEB DscTkb2hyqJ0hR1IpLm0ApwnGlunGQAeA0i/j/j6IQ3PB5UF5eXduu1AxXQCDUZHvv6S +1W5a7MbTaXRxnuifjftRDlLpMonudtfFyXkBYTENUpPlNe2aH27VBzyT0bj6WoxW0JP O+AA== X-Gm-Message-State: AOAM533otDxg3iE5eC+YQd8HuJreL2rVvh6bp80PimgFnBoWKEj8xtzJ mslI13E/iT2B6Aa4kt1V/9M= X-Google-Smtp-Source: ABdhPJxbcsgYoEjcTophK/SL5VZkGui8pHNjy61kf97Brgh1NWMVJ2NHSLes7iCFjvWlfgu/zrgpfA== X-Received: by 2002:a05:6000:368:: with SMTP id f8mr22623971wrf.150.1610911518019; Sun, 17 Jan 2021 11:25:18 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 05/20] hw/arm/bcm283x: Mark devices with no migratable fields Date: Sun, 17 Jan 2021 20:24:31 +0100 Message-Id: <20210117192446.23753-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) These devices don't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/bcm2836.h | 5 +++-- hw/arm/bcm2835_peripherals.c | 1 + hw/arm/bcm2836.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h index 6f90cabfa3a..becb6cfd0a7 100644 --- a/include/hw/arm/bcm2836.h +++ b/include/hw/arm/bcm2836.h @@ -35,13 +35,14 @@ struct BCM283XState { DeviceState parent_obj; /*< public >*/ =20 - uint32_t enabled_cpus; - struct { ARMCPU core; } cpu[BCM283X_NCPUS]; BCM2836ControlState control; BCM2835PeripheralState peripherals; + + /* Properties */ + uint32_t enabled_cpus; }; =20 #endif /* BCM2836_H */ diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index dcff13433e5..8cf85f028fd 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -386,6 +386,7 @@ static void bcm2835_peripherals_class_init(ObjectClass = *oc, void *data) DeviceClass *dc =3D DEVICE_CLASS(oc); =20 dc->realize =3D bcm2835_peripherals_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; } =20 static const TypeInfo bcm2835_peripherals_type_info =3D { diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index de7ade2878e..d2de99147cc 100644 --- a/hw/arm/bcm2836.c +++ b/hw/arm/bcm2836.c @@ -176,6 +176,7 @@ static void bcm283x_class_init(ObjectClass *oc, void *d= ata) =20 /* Reason: Must be wired up in code (see raspi_init() function) */ dc->user_creatable =3D false; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; } =20 static void bcm2835_class_init(ObjectClass *oc, void *data) --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911524; cv=none; d=zohomail.com; s=zohoarc; b=dlVJCvH6E3aqWhPkp1cHszbavb0gdu+yUmXMIJsjZ+e6ECbn16ADCprh/V3IaIoLrO7RALnWWl2VGXW5OHydP99zXKpLAHwuVgyJTPgZXbcu1uCR2dLLlkQA3VCdOPWQIBlRZFH2Jj1gY/qZO7mZespSW/BhilQbtxf3od/QBlU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911524; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=B4YUxFFcqfLKGc47lrHSN4rEV4rWS7YudCY+3T61Wdo=; b=jJ4AQnEdtsjHpoPRT58PINSzUhMIDe94Wwg3CsACNP1tJ5ANzV7c/wOuWRjLPRXY21hQI9cBV+8+SwQDqMB3wPFFKpBhIT+uhtTpwXXNdMuXx15eEXKI8IR4Mlu5tw8gz2btArNRAE+u7E3N9u4v99H7ikykycGhPm1DiNUebTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1610911524935829.1275296273191; Sun, 17 Jan 2021 11:25:24 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id q18so14475632wrn.1 for ; Sun, 17 Jan 2021 11:25:24 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id c11sm22974584wmd.36.2021.01.17.11.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B4YUxFFcqfLKGc47lrHSN4rEV4rWS7YudCY+3T61Wdo=; b=Hw+879i6FA5pURTaL7CQP+GLpMvdsoTGDwnuQ+9kmBYGhIiHk1hqFo/fNuYG49S7Wl 2VviseMlvQfKy4hIX/zQDtdlIVAsWtfX+WMiImMd5c+/kdHvARiAQxuSb8t+GEJOV7QL Y5ZZzst3Q4Y1CXWklRHxqOOlpl3jwMDJ1hqORJP9N1QFTFnFc1Haq4r/FPLUOttFlGO1 0v0F7W3WXOL5BWGK5dKbCN3NbtqsMULQMiAhSmBAuJ1bA4Dr3UWI4Pdy+4c2o4/MZrhK QC5cbq9CHb1EvOgXzYwwizz0TGeOI11Uvv0kfmwo9V9odEnabftjxLlu6nRGtwTlUPVl NGmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=B4YUxFFcqfLKGc47lrHSN4rEV4rWS7YudCY+3T61Wdo=; b=Xo+FTq/Hvc1Br9rr8M3aG7BilIizqbBm03SgcrxRicCqzQKCiO5/RVtcbcwXNaisrq gJDk4OmaTBz240U3Y+LDPpvmK5E48LEU4Ve2S1NJSMgC0GfZUMiKtt08goi9Z3le3q23 roeVhGydq95w/t/iP2n2tMRCzawTN7TI5/48CMNa05dvlI3v8UBRk4+vy/YhRRvGafQD AABVPGPKnhL/5sfYsc8nOetnde0y43kyHmmvaNYC1bX0ql9bV1iPGSIMEFYOdZfU9kmy kfalIxgeM9/XItRu2/FBkAhdQ9a/HQNE12MszhxknwUb/jwXWtTBBNtChxpdz99M9k6L 0kPg== X-Gm-Message-State: AOAM531EO6fiFRogKHpAmT+vzVnBOH71IL2J+NnYXGB36I5PAzUf03we mT9q4A/GeoXoOKNfMYDRE3I= X-Google-Smtp-Source: ABdhPJzt3Ub4O6C1NHK9bPfWUH2XZrh4/Rf1HIK/DEOyPDqUSdDuIUBDsNoaJDyOIgQVxwVn3BdzXw== X-Received: by 2002:a5d:47c3:: with SMTP id o3mr17313895wrc.175.1610911523243; Sun, 17 Jan 2021 11:25:23 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 06/20] hw/arm/msf2-soc: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:32 +0100 Message-Id: <20210117192446.23753-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/arm/msf2-soc.h | 11 ++++++----- hw/arm/msf2-soc.c | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/hw/arm/msf2-soc.h b/include/hw/arm/msf2-soc.h index d4061846855..41a328c77f9 100644 --- a/include/hw/arm/msf2-soc.h +++ b/include/hw/arm/msf2-soc.h @@ -52,6 +52,12 @@ struct MSF2State { =20 ARMv7MState armv7m; =20 + MSF2SysregState sysreg; + MSSTimerState timer; + MSSSpiState spi[MSF2_NUM_SPIS]; + MSF2EmacState emac; + + /* Properties */ char *cpu_type; char *part_name; uint64_t envm_size; @@ -60,11 +66,6 @@ struct MSF2State { uint32_t m3clk; uint8_t apb0div; uint8_t apb1div; - - MSF2SysregState sysreg; - MSSTimerState timer; - MSSSpiState spi[MSF2_NUM_SPIS]; - MSF2EmacState emac; }; =20 #endif diff --git a/hw/arm/msf2-soc.c b/hw/arm/msf2-soc.c index d2c29e82d13..2d163710f54 100644 --- a/hw/arm/msf2-soc.c +++ b/hw/arm/msf2-soc.c @@ -224,6 +224,7 @@ static void m2sxxx_soc_class_init(ObjectClass *klass, v= oid *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D m2sxxx_soc_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, m2sxxx_soc_properties); } =20 --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911530; cv=none; d=zohomail.com; s=zohoarc; b=h03mt8cxJKPkaj/+ald3Oi1tsFGS8c5yd/pfocrn539lL8qOGvcDw6avHQJ/9odVYCaqgvp316O27NbeGljZ/oAB+ic/qpAEvghhmgidagUx9/5PHi9yTSaljvErSxw+ttr/wXq9YIO7JGNiXzmJY3WE6bFUoiiwzG1uOvyTFOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911530; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wX5YisuWL/1kxfpeKOV4oTMHdWldWIq42qYJ2gfj7dc=; b=UekUMU3KcDo9T/QyTQZ+WetK+Yui1Us7YLCJaMQAYGP64OGuIaA2KYdwf/bdK02yrMR38H5K6syIVaXc2XFGSZAkYOyXxoItFfhqmPPF/dIcrnx3dDFcGk/EALu3b8xfb256gYSuQcXceNJYz3giCWOUK4IRxDmwa2OJlhMr67k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1610911530125321.49235987334293; Sun, 17 Jan 2021 11:25:30 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id m187so5480347wme.2 for ; Sun, 17 Jan 2021 11:25:29 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id y13sm25915641wrl.63.2021.01.17.11.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wX5YisuWL/1kxfpeKOV4oTMHdWldWIq42qYJ2gfj7dc=; b=o70zgkLCjTk2UunB4bDarF1cLu3Jbi3yIP7VJDK7c11SrDRhmIV1yLNUdenmCjok8u 4ADSSGJ6qzqcc5l7sZO87WbUkT1bQekPohWaF331aijg6hXgpjmGh9WGnH6VEgLMQOkO mWyu/4neq/W1ekNPxcPHi3H1kTToXfUH9cwmTF23l0OoV5i9Kix8CDi9hXz9MaZxtpeV g2Z82AJbxVOrPQUSWdq2cRU6FTqfCJYXIv0kiazkBEZhqiNsOanbpt0RxMRUpDL7zns9 9oDaTS1eQ5PuTUwHQ4gJLaIVJFurBATIV05O0YiAc1FnEPPcNkONEk2KQC7IDaNn26Mn KYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wX5YisuWL/1kxfpeKOV4oTMHdWldWIq42qYJ2gfj7dc=; b=DeuqkjnVfaazHvn95Ro3VqkOy5raqe+bqMLJqqIVTfdh/XTGsMIJ3IzjrygwmJZC96 UuhUJj0hyuyR/Oz98iIJzrLJPshR5PXKNhaQd43w6QiI/loZZ5SURM2owUKnYvSf2+Gj Cx7+pzYSo5y6YZP8r5AtwcyIBLNo8hB6NiFQawH1Z18GZRrzTydfbVRj0Euz1eRbrbl9 PFqoO6RutBoCKFYGpTOMosT7KwW8PJjP/MUerrBZQgNxT/P6FJDM57bnprfwq0fOqMFY 3x4gBwNf91kQGMyBKroKipYXle7ZgfOQQVpQ6CVu2hi0y51Ph/VdkhiZCRiSqq/ifQk+ vIIA== X-Gm-Message-State: AOAM531eSfW/ehri4GGYFU0k+AIpwVyy7mXsf4zqpOo6kp2ZcxOKXyYJ /XI9td/7txcwYgQVkobzCbU= X-Google-Smtp-Source: ABdhPJw5tInLIHrxS25OFyOXfZ0TxV2j0sp/xO2VJT+x5kdUNjd34M8oQ5/ZX1VSSeyeFHBh8CdBVA== X-Received: by 2002:a7b:c5d6:: with SMTP id n22mr17103434wmk.70.1610911528446; Sun, 17 Jan 2021 11:25:28 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 07/20] hw/core/split-irq: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:33 +0100 Message-Id: <20210117192446.23753-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/split-irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/split-irq.c b/hw/core/split-irq.c index 3b90af2e8f9..a7072f922cd 100644 --- a/hw/core/split-irq.c +++ b/hw/core/split-irq.c @@ -71,6 +71,7 @@ static void split_irq_class_init(ObjectClass *klass, void= *data) /* No state to reset or migrate */ device_class_set_props(dc, split_irq_properties); dc->realize =3D split_irq_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; =20 /* Reason: Needs to be wired up to work */ dc->user_creatable =3D false; --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911535; cv=none; d=zohomail.com; s=zohoarc; b=TpvrNhB87ZFum44Z2fnaeRU2n3qYzxqKdL54Klfa8kKJGBCTo3F5YBms5SNbWWLFJAZfQu/ftaKAq4Ase5SZ4D5+H4P+VawzVdMINhwBnthGi8jAleN1A86KCtNc00aDqXyzf4nzFw0x6a+fmBhGPo+Cxy0YKcChH7feGW2YTSY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911535; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gddpL1/dTBK1hhWCBYVWNUJWRgr6oC/oPS+FjqFdg/8=; b=WY4SqjLElB2lluiHN9bjVpGTT6mNN6JIuiQLjcd/6rLPWfDlB9xW3p1ow6ty4wjuZREYKLHT/k/47duzT8zXm/DJGngoypx6iiaW4XPxl2FP0W6ypcRTVwiFiOfVWeRlTqxCaY8M0VyWeNeU3R+pjITFOuYorMYOtmkt/hvQdCY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 161091153569638.85236570750703; Sun, 17 Jan 2021 11:25:35 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id j18so740456wmi.3 for ; Sun, 17 Jan 2021 11:25:35 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id z63sm22476855wme.8.2021.01.17.11.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gddpL1/dTBK1hhWCBYVWNUJWRgr6oC/oPS+FjqFdg/8=; b=MEj8ltNQAsGz6HhkTJgapNBfe0IqX1RUk87fpo+4ZlDjM4zgtCwgkEp9nUF+pxxhY5 sbyps4aVG5XlxrBzXquYrG2TR2iiSM/PNhQkbTXhFF5W3NawOAc/6X5Be2TNMXrnKtNk QX5ZXm/JIPt+jd5VS/tC8RnG0RWuxJ9lh64ISrq5awvS34PUSg/uElvpNEVBJmjlhEdg sX2E+eYmia7cJDGxZSYaeKK/cFW+qVUgVfEpK9X9ZlVXG1WEwTd457arKjZpJNcyEoxf kYHOJmt554sLczGB2utJUktB12+lAFG5uYhb/oksuibma+K8nJyjTR4Jw+oWWbgiq5Ts u/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gddpL1/dTBK1hhWCBYVWNUJWRgr6oC/oPS+FjqFdg/8=; b=osB/imIfSzKA9bmztTKXmyZHY01e00N6aOKDNuDa5CTwWt8XorOJ0ECaoDsukXpnOj gB7NbEZ9zRD6ktrmPPo+Aj64tsfda7dP3VkPZ7TGKxPk5c1MeZnKwyeqCXdDDEHNBgwh ZL6ViiUdKIKCJFiMpIsw5zhofsZyCqeQ0hg9iUHaxaP3rbBR3UOg7eAPyZowZ48WV/Te x2l/x6kCK9w+PB8Z0Szwq7TE5zzqOFrMeEs9qegL2YM0Jib8GCMMND9d6u20Y2d0MiPy RIdQ0q2w+vjR5fFXteT9u60zxeIB8/Er1f2uLW87WxzHfOCw8nDKuM4m82GA7GOL6I8u LZ+w== X-Gm-Message-State: AOAM530MpF+bR/RFZb9KmgqB75wRvS495XKGRm0HHMq4L2bgG1I3n0OZ onLOSdP2xp879i+WjDTHZME= X-Google-Smtp-Source: ABdhPJxPlULh+KbAeGjEMtbR6PISEiUMYiKcem1wR8wu4GDx4AmpPY28PzPGjyFikBnjS0d0AvzZzQ== X-Received: by 2002:a05:600c:2a47:: with SMTP id x7mr15892217wme.145.1610911533975; Sun, 17 Jan 2021 11:25:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 08/20] hw/cpu/a9mpcore: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:34 +0100 Message-Id: <20210117192446.23753-9-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/cpu/a9mpcore.h | 3 ++- hw/cpu/a9mpcore.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/cpu/a9mpcore.h b/include/hw/cpu/a9mpcore.h index e0396ab6af7..234ac13be2c 100644 --- a/include/hw/cpu/a9mpcore.h +++ b/include/hw/cpu/a9mpcore.h @@ -25,10 +25,11 @@ struct A9MPPrivState { SysBusDevice parent_obj; /*< public >*/ =20 + /* Properties */ uint32_t num_cpu; - MemoryRegion container; uint32_t num_irq; =20 + MemoryRegion container; A9SCUState scu; GICState gic; A9GTimerState gtimer; diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index d03f57e579b..2e1d2d46b5b 100644 --- a/hw/cpu/a9mpcore.c +++ b/hw/cpu/a9mpcore.c @@ -175,6 +175,7 @@ static void a9mp_priv_class_init(ObjectClass *klass, vo= id *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D a9mp_priv_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, a9mp_priv_properties); } =20 --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911541; cv=none; d=zohomail.com; s=zohoarc; b=DRXj9wGE36o78wlQn1NX8+ENHLBHDcQaKYr+cSvcV7t/0cBKjrgUN4RryRzqELvcKhDJP4uGC7zXFcT1dqmqfQxLXOkFnYwtknhGsZK4u5KqHLsIc/KDpLAsku8bXEifY/HUv7gzh9KkZOZXMIX2q7HAO+gWLERWX1BGTeUzHqg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911541; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pKKkrFO8F1VopBGRhEeTOsmc/pmqYXz+y2wSUuToQKs=; b=gdXT7LI5szyCOR7zgAu94qdyemYg7u+WGRvIdc72YVYrUXHoWf237FZBZz0FMGx/B+mGS2jGAfxkPTsaadtw/Niduq3fQSPimm71RAvSJNWL8r0IWOX1AWKmhWAltwXPSwvWGNdJZo1AjY96h3vExBY32Zhzm/N8vYwQbKvtZOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1610911541178488.839619869191; Sun, 17 Jan 2021 11:25:41 -0800 (PST) Received: by mail-wr1-f41.google.com with SMTP id l12so9227127wry.2 for ; Sun, 17 Jan 2021 11:25:40 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id d7sm13672923wmb.47.2021.01.17.11.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pKKkrFO8F1VopBGRhEeTOsmc/pmqYXz+y2wSUuToQKs=; b=abdd41j0opUWZIuUA79sZKaCfzJERrHUNPpBxp+ZHP9t5WKnzb5qJ/cv5+00yp9P3/ yc4hBydIt/XHqiy2exOUhN60eGoeP36HdCZo/tb1kZCJvZfbjNBQ5WDlyVZcRvcyI8Mn WVrMYcYcgCBQCKUobw2r6oXPrKWtBDGPEfQAqzjQ+J4rXQ+ikAhLLjR+5d85ecbEmp1M d+KW1onX1CQ5tVeq++cvABJvIN6othWtak6A8KyB6IWpySztCN5T3Cl8yMagC6QUGdBa xscbS5h6OHkcwHunFjNt5cUpDuwlGjhavY5pRCoo3POvPzUEBogQ0WUqiBdeYUav7tCN Q64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pKKkrFO8F1VopBGRhEeTOsmc/pmqYXz+y2wSUuToQKs=; b=VtifhMYGcf9oDK6AleZshFMmrl/NaMsu7a/J1ci+DcwHBQV9eu2n+gHyFob1vnasl+ g/oEdzHdoDDFSfGt3DhiB5gVoJytZHWePK+oPbGf+vyCnxCyTh4rl72tNgBvVGAItTLC JDC6fX0ntNRxoNnsETwmHQtbHg/wNbsjtVRTiOCz+RlcmJmYey+oSrKNhCEI8Dad5phn cpauVoizbo2bJBF4knsIjQxFw2lfoaJRz1kgufz5/2aOtYqgEW1KLr+5DDUCH/qfjcvO yb3wqY0DilL4OAPFM61rmUjqymb9yOm/yR8jRUtH0giLCnvCqWwjBO0oL4ZNm+gc13d2 ZhOg== X-Gm-Message-State: AOAM532pRDWxVn+z3wf+dvKftr+AH1jHoBctI79hHyunuv9o+N9x55gG ehy60WKqdg8HIiXqU32uWa0= X-Google-Smtp-Source: ABdhPJxGbiZ+QMxA8NFrJPa/qsSqN3k1USt0wHaekZ09igWMoTfvqW83Tbzp8QuMl1lP5mFX7q6a0Q== X-Received: by 2002:adf:e9d2:: with SMTP id l18mr22023842wrn.179.1610911539529; Sun, 17 Jan 2021 11:25:39 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 09/20] hw/cpu/cluster: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:35 +0100 Message-Id: <20210117192446.23753-10-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/cpu/cluster.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c index e444b7c29d1..95653a643ad 100644 --- a/hw/cpu/cluster.c +++ b/hw/cpu/cluster.c @@ -80,6 +80,7 @@ static void cpu_cluster_class_init(ObjectClass *klass, vo= id *data) =20 device_class_set_props(dc, cpu_cluster_properties); dc->realize =3D cpu_cluster_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; =20 /* This is not directly for users, CPU children must be attached by co= de */ dc->user_creatable =3D false; --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1610911546; cv=none; d=zohomail.com; s=zohoarc; b=WniiOu1RcckcEMdg+jjIG+HQ4rCkSqDrkbpqFqv+oPaEK957jubr8JyTy1rFf8OCqtYFoEVHkEpgjzc0VON2g7zRMyfeEzIsRxDHTAE0+2EKQSy7ZJm02nYHVTSK2yA+Opy94cx9GEnNYGP7cix4rJJvgycNhG0176CUsSqnzxQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911546; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jZzarPuuax9WApxhmE01fr+TB+KCuz6yb6zkBqC3alw=; b=PBN+rnVPJ6izeBlDMpdo1fpEGJtOQIr+gKRut0XpAIxdksDzbnvkx+eJLK9mM42snTeS8LRO3mQC23Awq4FKKQV+KGEQ6rUwQJ5gY+aEwX4B4hshahXneq4nJ3jq9ROHxmrcjA3HMsT4qxORQDcwA9ZoGRZhitItaF4yBHN0/jc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 161091154682283.1163965405733; Sun, 17 Jan 2021 11:25:46 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id a9so11001327wrt.5 for ; Sun, 17 Jan 2021 11:25:46 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id a62sm23805600wmh.40.2021.01.17.11.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jZzarPuuax9WApxhmE01fr+TB+KCuz6yb6zkBqC3alw=; b=BjEEoijBKCngZNJ4PJZ9MgD12GyN9KvoyfaGeEFEvlCRaOIoYLXGxTatCJpEj4A7y3 QeYv14aOuInHEnyD2NXsa1mdVFUhA4VsRr4jEeV0C6EH32G6pFo0XnD9buanUxPH/Udv Pj9vdTuj8vCc5hEOHzcdAAW81FX1G1O/iPSCtd9ArbzAtBvlkn5kfY3oGmREszpgJyjq PLGcmzXandd80hwLqc8pxwMEt709t7gPmIaEl+Jhk8jwEClgjH6k0D6RnY81wPR4fZeg pooL7huiagIHMJwBXtLpoAOMO2p8C1JidxSVlDjan/PgzTuikmo3UojoSN7dzQPT86Hl t3nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=jZzarPuuax9WApxhmE01fr+TB+KCuz6yb6zkBqC3alw=; b=BV8htyiagQZXengjfRap2CVaZavE2b3y9wXpyfwLQnB2JolemkWltbbLeJB2qb8QD0 z3CtFBiw6Vw7EPB85abCLpFySX0atiXcx2rOVzPjhCH8M7bVjpjG90dfGP7TGILoLv48 1/nvhRMWfIOZFgEamP+UQR5GDsjw/d/+FBdMiybXS4ICkdQhnkJ3BV29WpcGqxzzm1i8 CMZ90gGdpjuNH905vsoL/wvNLN6iJhL9vuoc3nvl68vbTHXoY54ODR6/BbZyQmeAnLz4 Yq7REPAHodvMohS/TH8jAcRMP61pllaeA4gzA0Ma/0LFYP5MOeEJqhcKXIrptZtk6PuY 04RQ== X-Gm-Message-State: AOAM532ZE4fCa/nKcFTgL/XpDnYDIvcZcPyB2GiVHYme8+JIEcRPHm1d 9r1VjoYtJqyKTF3S8Hp85QU= X-Google-Smtp-Source: ABdhPJzhHN5NH3XdmnMDGLeheKdmt+bcamNy9x8l13em+2QyDbAM7LcWd7IqgOeUT8KztyA/3dOdlg== X-Received: by 2002:a05:6000:1547:: with SMTP id 7mr16295455wry.301.1610911545081; Sun, 17 Jan 2021 11:25:45 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 10/20] hw/usb/hcd-ohci: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:36 +0100 Message-Id: <20210117192446.23753-11-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dr. David Alan Gilbert --- hw/usb/hcd-ohci.h | 2 ++ hw/usb/hcd-ohci.c | 1 + 2 files changed, 3 insertions(+) diff --git a/hw/usb/hcd-ohci.h b/hw/usb/hcd-ohci.h index 11ac57058d1..fd4842a352f 100644 --- a/hw/usb/hcd-ohci.h +++ b/hw/usb/hcd-ohci.h @@ -101,6 +101,8 @@ struct OHCISysBusState { /*< public >*/ =20 OHCIState ohci; + + /* Properties */ char *masterbus; uint32_t num_ports; uint32_t firstport; diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index f8c64c8b95b..302aab30992 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2007,6 +2007,7 @@ static void ohci_sysbus_class_init(ObjectClass *klass= , void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D ohci_realize_pxa; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; set_bit(DEVICE_CATEGORY_USB, dc->categories); dc->desc =3D "OHCI USB Controller"; device_class_set_props(dc, ohci_sysbus_properties); --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) client-ip=209.85.221.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911552; cv=none; d=zohomail.com; s=zohoarc; b=Z7waFdkcJE88kBAAqvpek/5JaCY6vEk+TW6tI3aWflSjBi+zReUU9czdSpCWiZ6bJ/Bd0vjkKD7+Q05EHo6L+CKfKcQeVynBxwdW4uIpHNNrUP3VFY26NcfP7WXoXrH8gybB5p+E15jOm66PuAyWzBYEI99IIXFKIdy8bABwoEM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911552; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z6fdnKTIA2Uc0MDNjyGFMUBSbkvaU7MEUTklOzizagw=; b=ZZ9r8FQzBtRnnJrZwxHWYsQDTCvI1jdftEgQvDFgvKLrM4qWwKI1AzFtiLqnnWccFUa7fWVwhEmQwqvzUUsMFj94hU7dr3RYhzLuTXrRI0I2By6NzRAxKzpv3rPR4n5LkVm+VRWpXycT1z83EsKEDpZWWE2L5VDoW2iM4CnuyK4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.zohomail.com with SMTPS id 161091155230777.90439067171803; Sun, 17 Jan 2021 11:25:52 -0800 (PST) Received: by mail-wr1-f43.google.com with SMTP id a12so14427232wrv.8 for ; Sun, 17 Jan 2021 11:25:51 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id p17sm1553314wmg.46.2021.01.17.11.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z6fdnKTIA2Uc0MDNjyGFMUBSbkvaU7MEUTklOzizagw=; b=i831de7ev0B0ka/oKIaU7WcweUF8wA6VKEUx3FYesxBXhAhi8O2BP9AKIfHV6h2Zdb /KdQ2Qhs5o3gouffIc31QonCGidlp9UD+KBva0GCd9KslDqfyEwLCfCg6OHWsgCVeaip qYZncpxH3yJ3U0zQiedGxfG3Jt6bg4lry0ZcjuRWV1xUydMHr6Nlzh5mx+R4sZX6/Jn0 1mOgQNwgDuhqBH/shdu1RCmylc4/KJyLr1/uFhom5rx6HzokXlYUnodFYfe2etd6a7V/ ONu3ivBrmll+MpFjeawgRm4QOAuLvq5Ez8e3vITnBoCI3T4vLZ/BZa8PEz0fYwD/AW/c pHZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z6fdnKTIA2Uc0MDNjyGFMUBSbkvaU7MEUTklOzizagw=; b=fST/pbXZ6pK72sCzzqBbfqhUUwtFt31LPuamxZ66LmiGHe9W8WAwW7ISsHr1hESrFf f2jwyquMgbS/1EOCuiAEf09O7Ds4GSi5r383BlWj7E0D7t7hWOs+azmiTlR3Eb3lPX0E MFwL0KqbDjBaBDFpnvokF9wYMJkNcxHq1gOvWWsbNfbiUBo70EnnZZxWAVHVHfY33iYV th6B1dKEcK3NMPPMuGQDR9iiDh3gygNw4dTyaDZAsT2327VVFsBq2FuFNWn41yJ/GRmp +QjudemQEL5cCypuF4ae01BSsMo1RiivFF5kJ2wG53NinNkYFzM7ITVmOH1B8TOdF5KU 8C9A== X-Gm-Message-State: AOAM533naEURLWeSr8om/WC9Bq4n2VOhDktk12sMq0B+k3S4/zHf0H4f wAJYqoQTF9kzJLorm/4njDs= X-Google-Smtp-Source: ABdhPJxWmbI7JojtrE4OgQhnrClZGqIaWR+FS2o3uA3TmpANaN2WRmhoOGuP+gy12dgSvAnRLi6ROQ== X-Received: by 2002:adf:cc81:: with SMTP id p1mr22516009wrj.339.1610911550627; Sun, 17 Jan 2021 11:25:50 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 11/20] hw/intc/arm_gicv2m: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:37 +0100 Message-Id: <20210117192446.23753-12-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/intc/arm_gicv2m.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/intc/arm_gicv2m.c b/hw/intc/arm_gicv2m.c index d564b857eba..664cc9fb032 100644 --- a/hw/intc/arm_gicv2m.c +++ b/hw/intc/arm_gicv2m.c @@ -55,6 +55,7 @@ struct ARMGICv2mState { MemoryRegion iomem; qemu_irq spi[GICV2M_NUM_SPI_MAX]; =20 + /* Properties */ uint32_t base_spi; uint32_t num_spi; }; @@ -182,6 +183,7 @@ static void gicv2m_class_init(ObjectClass *klass, void = *data) =20 device_class_set_props(dc, gicv2m_properties); dc->realize =3D gicv2m_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; } =20 static const TypeInfo gicv2m_info =3D { --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911557; cv=none; d=zohomail.com; s=zohoarc; b=WWKMj4/EFfkZuYH17nG2cjHM1jWhjM63E1RaPrn6fA4BRHzAfCaJxeCrvCvLxJDL9raEASXzzxfMIPO/hm9qtQaqZ/0kQHWVxjOd5vcFGyR3FjJseIu4GpA7Qpe9SH1y9X5b5xy7vRcrRjWCb121R2Qz03KNs8qyzS0x7FfCpJ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911557; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ywUmqbvL1fXxkTM+pHTvth+aqc+cAGL+9PBE1kwGlvU=; b=NyfUYsZUwcgnN0Kde8WOibhfPz3TUEFucwBuKNjj00+KgdCFpr3hqSpO9+mfH84qWxEA/adk+jSN1rYPTJxKuhDa77nowKQAOxYnxim44gQMMFo2ik3tpARWpxLdPDROsEo7Ym735jAGiOdihNMqMJIR2S0aSXaidp/LtdEIxsg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 161091155775452.110954550297265; Sun, 17 Jan 2021 11:25:57 -0800 (PST) Received: by mail-wm1-f41.google.com with SMTP id j18so740945wmi.3 for ; Sun, 17 Jan 2021 11:25:57 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id c18sm42879172wmk.0.2021.01.17.11.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ywUmqbvL1fXxkTM+pHTvth+aqc+cAGL+9PBE1kwGlvU=; b=k7DODHe+DDG3vQtF/snRglJd6BfW3ctKhMz9N5ZFRJPXSf0dzDpFVpp9dGeQyIgka2 mdTqYVgIVGe5jiF7pLc665Uf/KYCTz00064LRcNBOnBSZwp4xOO/C2FsgmaTxp+Kiri3 3Mf9O0Cx7AipZaS1Zz8GU8BYzJTllHxdSsIAZYe4jQYB666OfBzttpHt1QlcVEFKMp2/ DUtIxBfJ+7eq4+Tuhq2c7ApuCa19fDN6L1A5gmBj05wZQPRf7cxIsFi8TZ+4YZM1sl73 AzwsJyf9tONeU4ZjEQivy5FmqH5hXP/mttczYyRpcyFWIc7Di+uYnV/oAf6jLi0l8iIp oobg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ywUmqbvL1fXxkTM+pHTvth+aqc+cAGL+9PBE1kwGlvU=; b=h9va0PSZc1YGtMpmJLLvmHpKtsw0/cKfdJEWXU2ftdvT6XwOZhh+eL90WD/lbeziyF 8OL7aj6lZaArdtQuUzEcCHKSTx5Ly25AmOgIBK6JrzfXgarVNYNnE3lXBwtItSGDTn+L P/g2gZq+eeMs6lWM/EEm1h8nD00AFDm3BHU3lDsqD5enI+l/H6336k1IAhDPlxvE/h2s QPhYqaML2YjjnxcFQjwWOEkaJgXkVyMQwHDeITin4IzkA3MDanpbMq/vIaACHAuko9dT +d12PZB0/ug/IVsP+WXxm0GvOI7t0hTEdXME6tCAtzrWMfkadKroyLZCSrjN4dYBCX3Q xM7Q== X-Gm-Message-State: AOAM531GMiM4dD042xxYrI8Pg9E4lw9apYJX0kk3GsRQyJs4Sqc/diL9 eVYVwtm588ZszVrGO2caIMw= X-Google-Smtp-Source: ABdhPJza6zbRor9M5WyThlg8NoJDp6Fltcq7KawV8Ng1oH1jGEM16OJHPmdV21ZTChQidt5vQpLFbQ== X-Received: by 2002:a1c:9c91:: with SMTP id f139mr18028374wme.118.1610911556017; Sun, 17 Jan 2021 11:25:56 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 12/20] hw/misc/armsse-cpuid: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:38 +0100 Message-Id: <20210117192446.23753-13-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/armsse-cpuid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/armsse-cpuid.c b/hw/misc/armsse-cpuid.c index d58138dc28c..61251d538b9 100644 --- a/hw/misc/armsse-cpuid.c +++ b/hw/misc/armsse-cpuid.c @@ -115,6 +115,7 @@ static void armsse_cpuid_class_init(ObjectClass *klass,= void *data) * This device has no guest-modifiable state and so it * does not need a reset function or VMState. */ + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; =20 device_class_set_props(dc, armsse_cpuid_props); } --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1610911562; cv=none; d=zohomail.com; s=zohoarc; b=NUVdlnfd6uLU/nNcJ2lwXItbDFlEKNjTFDt0D7T2Q9EdZzapmvib/ayJP3vdgQL/hqeJViCnwa0m3xoXawsr9Nl8NuyX9iDUnyAmy24RSP7UcdDreW8NeCcUr5sgsE7acq0SVB9eDMSDvsNv8VF+Fep8Q8Kpwc0A90grsoX9KNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911562; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DRYX7wbIVKKy2xsQ0SOHg/10f2SElgXUvILpXN/GlbY=; b=jMNR+/WqJei13ftDl3QngPhpFxq9g5+4CqxA8G7RF3YWMD3AEP49DMOdmjzr+Dw5axzkystFmvn4eL3LLuaZwyq0Y0fbdAx03RGY4nGE303rBexJMLp62DP0iRjosbJtMU9hi30k7Nz/6vX/Z06ZwIP0RuAB0rb4619HY7abhTU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 1610911562849752.5793819916453; Sun, 17 Jan 2021 11:26:02 -0800 (PST) Received: by mail-wm1-f43.google.com with SMTP id u14so7851350wmq.4 for ; Sun, 17 Jan 2021 11:26:02 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id 14sm21096877wmk.37.2021.01.17.11.25.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DRYX7wbIVKKy2xsQ0SOHg/10f2SElgXUvILpXN/GlbY=; b=lpPEyFuXuoafu/yi/Nqa55IIFSScEH1LM1s99Q2JEy5YXrYuZYLY1/LVTSuU369szr GG91IPMKGJStj2z43+4segzsyxdD31ASCqPzMDsVM1obfyhx4L/d94P+/+M89uwZbauA n3UWb4wcvZsd+7/zRF0MDjCHwjR2jzzZIeaMHe3sUqEfGIYnrlF/NBjAnh64oLilH4M5 ffEGLK2HAq/Ax9odiPh5vQtVKvwylVFWC9pH+5G6doaOAxUzKycwsNvJm+SsXr5vl5pa hga79J2/seUXvJNkyrSiJmto2tiMe7Y6HfoYywf3sp5SlAcCRei9UHD8DoswqWR0AN8z nDmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DRYX7wbIVKKy2xsQ0SOHg/10f2SElgXUvILpXN/GlbY=; b=sngKaQY9K6X3bx/3i+qkMFZtIIffksAeAnVTXaAQF6nXCroY0at13HEvitXu8MSHNm OIFxNdq96qhsTbSKUjthQw15zGFKgT7diP1zrOmRoetb9VHctBlNwHMfwdcAzvvz4C5G w6RYu3uPtqVEqQoSPYHDy5Xh02CjdBgMRIVQvYJfyz88d+LhT67PwGAXWUSlx9aSyzzw m6BOlwYyC2EHPbbh3MxV/I74MGamYz81Czl2OxetiBOm/KqGXx7aLNZPHK24PREClPTq oPCjURSYf5UldaxaW6js6F8VTCyNDHri8lVfAHevlBptN6NQhw0tlwEWWUkBJAlBPRrd yWFg== X-Gm-Message-State: AOAM530F9HNdLsa2rkhnNDyby3pOmxp6Om7AGhQ+rkDqNsLJQQbIBqTv l0Di7co/Jv8Ez7fA9RC+qiw= X-Google-Smtp-Source: ABdhPJy4cdiAJh+fC43tbu5pjvny/oXmQebYPEcKMKLunspdGaFCEQAwtWyCGO89YQa/dK69ZtsPYQ== X-Received: by 2002:a7b:cf3a:: with SMTP id m26mr14828497wmg.66.1610911561170; Sun, 17 Jan 2021 11:26:01 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 13/20] hw/misc/iotkit-sysinfo: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:39 +0100 Message-Id: <20210117192446.23753-14-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/iotkit-sysinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/iotkit-sysinfo.c b/hw/misc/iotkit-sysinfo.c index b2dcfc4376c..8bb9a2ef8b2 100644 --- a/hw/misc/iotkit-sysinfo.c +++ b/hw/misc/iotkit-sysinfo.c @@ -120,6 +120,7 @@ static void iotkit_sysinfo_class_init(ObjectClass *klas= s, void *data) * This device has no guest-modifiable state and so it * does not need a reset function or VMState. */ + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; =20 device_class_set_props(dc, iotkit_sysinfo_props); } --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911568; cv=none; d=zohomail.com; s=zohoarc; b=FFuObwfDRA85VwL/OAeQKv94WSgKzxM4XQD+16ZN0g8rCzxQc/EqI90XAJK16n+nVgm9RGTbnamSEt1HYhxeuyGUCc3UxeIszGY/bIhc4go3x5o8ttLWxkG555Uq2pcL5Zc4Ci71VQmeakHlBsz0AVWenhR2QBPcY7t1Jlip8tU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911568; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+o+ioZvx1jeZgR8bC7wg2B3Sh0sACSJW4nTdU8f7aTU=; b=mIhJ4oMZRAqHJGyT8Wuvi2Rfp65YEilDUF4X4FPwGgS/4z8+3UaRTKVMbr8ZDoi1M+DG8eybXiXeej50uHTR1jJ6Eal+kBpFQg6isvzUgPXSa5n8d40R0YgwfdKVsB7MuWN5bHfOchh1xhbhAGQs0PktInC7QxHi5EbSs6dlyIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 1610911568324730.3120826721432; Sun, 17 Jan 2021 11:26:08 -0800 (PST) Received: by mail-wm1-f47.google.com with SMTP id j18so741165wmi.3 for ; Sun, 17 Jan 2021 11:26:07 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id m18sm25364721wrw.43.2021.01.17.11.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+o+ioZvx1jeZgR8bC7wg2B3Sh0sACSJW4nTdU8f7aTU=; b=RILotdEvzW7p4sBqW4M3EnDurWmb3N1pLM5Sn80jZz3dhPqGzfe1LGXAZuKZFhPNfL 7Lx7XpFlVVSrcJsJXSE27NstSKS9FbF5TaaXEm6257Aes2wSs4ogex1kzLzabXoQYSIF hfcH2YVJ8DYFrNipRSor0w3i9gryP7mn5BQn1VHaXAUgUGYOtQapyTSkZAvZrkjM678L qguqYfFKE/GYaTw1mVfUQZOP8YDUeZCdbJ7H4CMKC/E16A66D64xL85cRrhR/kTt2TM8 V+zkE0A0GlZ5Ix/60gPfowSN+Wx9X3Drp1WCJDNWNG6RR9Y7pJY0Hka6u6o6g0cyQ7yP LLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+o+ioZvx1jeZgR8bC7wg2B3Sh0sACSJW4nTdU8f7aTU=; b=Lau1+7CNmTHlv0jwgvE5d2aEAsG8hDnKusW4vaR7npz/XukDI/JdxVUWgozoT6YmHS GtXxbsGClo1ZUdmyS/+4m8Yh8UwIZQd++8fVqr387dAxjXXhVwVNUAXH8tUYKYgjUjVs y6+lr6ygne3cWB/hjpCjYhLZScWd+3xThiuL9kjU6a0c2fFXP+DaubRZQKL/9bVtLSCx PuVu0wMB9QOzYttAFwINWl1tUDx1G4OXnmi6q4+kT5YpQ88hGUKbkRZ//lmTU+LZStJa c1IagMYqdgoOIq4WSDIrMpXmjg1weHIooIL86NnuMVwSf445eKDxExTfTl28ZBlN2eDT INKg== X-Gm-Message-State: AOAM533GUtENzf6UCKOdzEGT2XZXPOMf257UBWg2WHU8v+3diqx/1fnI Ky7r9yuEigRWNy3rOqaG0os= X-Google-Smtp-Source: ABdhPJwuJyD5eoJZdzZeLrTpidVMX4ieENOmYUA+91AatCaoyylhNKb7AwKmVzAyg91mXVCdFTHbWQ== X-Received: by 2002:a1c:6744:: with SMTP id b65mr6011059wmc.60.1610911566671; Sun, 17 Jan 2021 11:26:06 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 14/20] hw/misc/unimp: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:40 +0100 Message-Id: <20210117192446.23753-15-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/unimp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index 6cfc5727f0b..e5ede95c124 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -81,6 +81,7 @@ static void unimp_class_init(ObjectClass *klass, void *da= ta) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D unimp_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, unimp_properties); } =20 --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911573; cv=none; d=zohomail.com; s=zohoarc; b=B8rNiF+AKUD1TqhrUvox1Pe0qt1CP/NsIukHeJtnfRJNyob3xKkvzg2ekBrSx2/Piu5/SsQBHUw1PChUZgxsBAwhyEG6No8In6S/JRyzUYcf6FMxkYPPDNaZc8ZeeA2DCQo4AJucl2xqFU8ri0d7n/2aICeMOAEQolGKBd6QD7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911573; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OG4UEEhgrdnthw/7SfhW0jpVgnxGKL48F7b84mxBL0Y=; b=k/+rN+JXGSAu3Ni4YgtNMj9IaHPec9JpK21+AIDWrc9e35VedKXdH1KEm8iNa45F9Xd9p3MjoECIKFBIhQ0qNoXEOas/Qo83p1fh5yfaoiSNGjz8SThAmz+juGZlpjXL8SpJ6UicamDjkRpNXE655+yCbaM2ZTsbZXHkJUNQN2o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1610911573836390.86117773262856; Sun, 17 Jan 2021 11:26:13 -0800 (PST) Received: by mail-wm1-f54.google.com with SMTP id u14so7851585wmq.4 for ; Sun, 17 Jan 2021 11:26:13 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id v20sm27021723wra.19.2021.01.17.11.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OG4UEEhgrdnthw/7SfhW0jpVgnxGKL48F7b84mxBL0Y=; b=d1hCPPD2xD1wJ+ELj4EXKXvHf5LWkdVFuJ6DUWt6j6JneNcQ5YKxKbitQlO+YmW+vO EnGhR+vcKbFIoe5cCUn/VYx+ycAQesN4/1eQKKGJ8aRaJ3O/iFxgq7XOsEEJGgOLFfVu 1Pv9HxD9KNv3eutgax74SADs46HixAvEknnx8jGCMz/i8NO+1YLgYT1z4s4Xuh5XHYTo E+XV3hrJ7nzNIE75qSqNrcxBlqp8dxtgsodEkFx93MEaPGLCxMpRyrRxLVglDI05Xl2D iU9v6VRnloJr1dHA5Xn1doJe9TcNhoTdsJY7MJOMcT3W8wGR67ygmXeqUHe5UQx4xmNN 04ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OG4UEEhgrdnthw/7SfhW0jpVgnxGKL48F7b84mxBL0Y=; b=gDAXis2HQm0wOyphoT8IM0C0gpyxd5hWSMSP0nDtrvhJPCWYaFGFeKq1eWtyxigKgq 5ECfwLFTKI1KFjA3bMBRfzvucBGYkmO6JSwFVaB8Fe1K+DTRmhkFT6ASDAlM7JDxx3iV Dvi51kl8lTNL1eFtxaMibds+4g3qw+6absCOM8pGUqetWwh3WYgFkmj1YpdaippZqdCZ TZwVeQO3Uw274DJMszt0HylnOHEIBpelJlXR1ADACqKAp/HKeXEHdCIx+24JNjCDGh8K vOJtoG7oeWmkCqHNg7EETCUEQl7wi93OoWCVa7DPuF2YCnB7wxbPQ7alrFhbIKklmFrW F0CQ== X-Gm-Message-State: AOAM530DlaKBN0vVb7GkU5GIbMeIATNU8Ss+7C4or5pwgz11QKGEIIfA ePPx9Q/LnxhFDN1Eu0Jg/4M= X-Google-Smtp-Source: ABdhPJzutk6ePzHawSll3xN2iOVVCJtHT1zjoYf0c0Fn7F8ecRYwBXidzFLAGHXx/CMlgKv6LoEgdA== X-Received: by 2002:a7b:ce11:: with SMTP id m17mr721232wmc.158.1610911572131; Sun, 17 Jan 2021 11:26:12 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 15/20] hw/nubus/mac-nubus-bridge: Mark the device with no migratable fields Date: Sun, 17 Jan 2021 20:24:41 +0100 Message-Id: <20210117192446.23753-16-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This device doesn't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- hw/nubus/mac-nubus-bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nubus/mac-nubus-bridge.c b/hw/nubus/mac-nubus-bridge.c index 7c329300b82..ede36ccc5dd 100644 --- a/hw/nubus/mac-nubus-bridge.c +++ b/hw/nubus/mac-nubus-bridge.c @@ -27,6 +27,7 @@ static void mac_nubus_bridge_class_init(ObjectClass *klas= s, void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->desc =3D "Nubus bridge"; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; } =20 static const TypeInfo mac_nubus_bridge_info =3D { --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911579; cv=none; d=zohomail.com; s=zohoarc; b=iNbmcO1cOQ7JskfDFQPwOqbRGrvomhzU7wV8MGdP+/qyrch78G2XUuZeNbprVuuap0TjT0z3fpKPaVqKDZxY7VKv0yaG4piboziS2/2TLCeSzQusO+qCxpANp11hq3OMjSnmC63eP9gXlrDavZui7aqSVEeOqod1w6LUsB0XJjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911579; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Bx350E5m3VyPci30nthMcxfcvDfYIGiblZKZEeXM5tA=; b=UswPkS3E/YACNEAd0m7eMxOpV5SpU99V5anol1TVGZItpGRBtFur6QpKzp0JfasO40OmfwOM0IvdQ4l+uL5ZfrgiH/Kgw4nq590MzHrzX4Ctkf7Exs1dGy/xTMhhJuaMl9Gw52/6tLoOfJwoTSaEsYLxvSFhBm8RNffOBSHLPhA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 1610911579169967.857665240239; Sun, 17 Jan 2021 11:26:19 -0800 (PST) Received: by mail-wm1-f49.google.com with SMTP id s24so3914303wmj.0 for ; Sun, 17 Jan 2021 11:26:18 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id a24sm15013983wmj.17.2021.01.17.11.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bx350E5m3VyPci30nthMcxfcvDfYIGiblZKZEeXM5tA=; b=HDL1cOYRAppqKDmt0+6iCG+tyRa20Vszx0WdmS5WO4jtkTwdghRo7ux+0D8e69Uuiw 5Q/xpoa4zO6PZxWg34I8XAcOCHbo09E8+8AymMWcJ+19VUo/dFWq072XbTkgYlap/Iv4 34tjuUMRZkwuhTEq75obgsagYTcucmWPEESKu4unh5QY05yV8W4ImCOJaL2TdlgfmTn7 Paoui5pA9tXlupK38Io8YVI1ozZL8qLn/V6PAUOonYkcOiE8KWeocwhDD009rHjUedXq edFMLdbiI4AM33Wp2tryl8IrOQ8fOhStobBacJ+f63I31IVazo4JE8UW7WPcbt7zFtCZ wpxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Bx350E5m3VyPci30nthMcxfcvDfYIGiblZKZEeXM5tA=; b=EedavZkI2HoIeB+GGAZAIW42fXM1zetTWlDzZ45i2/Ug2c53FDZ3+meH0mq4TGiAmf s9wiXA0BYsxZlPugqVwN15InNuGxN7Jb3Atq35Kvb50alb38Zo5HuTT/ZoEzewZSaI+z Hx4ej/mNCeLHmTaKUupRxGKiwPjyKjL5ubm7uozM7UBT0o+U/qBDnMXp+n68JIoFWqMn /NdVkdW9Nt+BfWdqzC14HZ37UbEvngABx9AocxmSko81hg0W9dgCWu5PBlkmrHKp0WLf GykMrG4wmZh05qJqHf25r25Wp4SUl46x/mkDVTOM+W6gmnRoo93QRne/sqdzHHpxWgNe LHUA== X-Gm-Message-State: AOAM5320oo3cdhj4LHYuOqGUiXVwtu1jCSPdgm8xE/8oVlUYQS/UdKEQ 5j3rBgvfbkpSJJ1oXamIuBo= X-Google-Smtp-Source: ABdhPJwOdTStGNdd9lQ6Q15iSvEbhn8d+kx24B0aMkfbK/kzK64HdGME4mUFDC/bS4yOg2dAnQX5dA== X-Received: by 2002:a1c:984a:: with SMTP id a71mr11036888wme.175.1610911577485; Sun, 17 Jan 2021 11:26:17 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 16/20] hw/sparc64/sun4u: Mark devices with no migratable fields Date: Sun, 17 Jan 2021 20:24:42 +0100 Message-Id: <20210117192446.23753-17-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) These devices don't have fields to migrate. Be explicit by using vmstate_qdev_no_state_to_migrate. Add a more descriptive comment to keep a clear separation between static property vs runtime changeable. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Artyom Tarasenko --- hw/sparc64/sun4u.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c index 0fa13a73302..fdf0aa875be 100644 --- a/hw/sparc64/sun4u.c +++ b/hw/sparc64/sun4u.c @@ -84,12 +84,15 @@ struct hwdef { struct EbusState { /*< private >*/ PCIDevice parent_obj; + /*< public >*/ =20 ISABus *isa_bus; qemu_irq isa_bus_irqs[ISA_NUM_IRQS]; - uint64_t console_serial_base; MemoryRegion bar0; MemoryRegion bar1; + + /* Properties */ + uint64_t console_serial_base; }; =20 #define TYPE_EBUS "ebus" @@ -386,6 +389,7 @@ static void ebus_class_init(ObjectClass *klass, void *d= ata) k->device_id =3D PCI_DEVICE_ID_SUN_EBUS; k->revision =3D 0x01; k->class_id =3D PCI_CLASS_BRIDGE_OTHER; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; device_class_set_props(dc, ebus_properties); } =20 --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) client-ip=209.85.221.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911584; cv=none; d=zohomail.com; s=zohoarc; b=W0pHlD05cQ8gRATYXzIdLrfSSG5lxqfVggfv7pboF5OehDbebOp2s7/f5VzXdi7XrwN1+XQsE+6Iw78NKMMjFqP6AvE4oPhTtfEK+kNVPi9CHo2Rt/m2gGHRHEIerpjoDnRwI4m/hfYYMOlAuquuB67pFW8JebuUhdr8M2oFV7E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911584; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XogiRe5yl1pNdqgPP5V4b7SXP6ekjym12cW6DYLGVp0=; b=FYFRyCAentGgz1WOFhg6NUYowZQwClU9Lq2anjx4vGaMu59V8H+SJOWh66OFGcI4bfqVb5Ccymt6HFeA0rmSpAHCov0/VsSP5oHEh7l5RuHICy1hiLNKn0Ogpnnraxn25Au6AfGrG0ha/7JqVhxMOOGC59l/byf8hQP9Pco4oGg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.zohomail.com with SMTPS id 1610911584574188.02270074717694; Sun, 17 Jan 2021 11:26:24 -0800 (PST) Received: by mail-wr1-f48.google.com with SMTP id d26so14435491wrb.12 for ; Sun, 17 Jan 2021 11:26:24 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id v4sm25387282wrw.42.2021.01.17.11.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XogiRe5yl1pNdqgPP5V4b7SXP6ekjym12cW6DYLGVp0=; b=dHzl2LACEwVQNJhxnDfIp+k/e2+8X0LFiprYl04+U7/AQgBLE93j09+DEwxBHCx72r CpPITxjy0TJLx+gj5fT+DRnsn6nE411uOqW8Q0Qz+7e3Hzv2ATu6bA3hbpfk0+wVyWx0 urrTcZ+Q3haAu562yWx3+KF3Z1YQpnASASkSMdgJJ1h72rLOJOfRwKX3BllpWATYdY7H SV3Cv0fvvH2RbAGCDNA7wxT2nNU8eHb1aDIpyyFwoOM4+7aue5h+I1mRqG+ItGfAI2Tu LSeFn1EDviFdR6c5vpEaSX5nwDmIKmMKo8XujmtGig2c/WpZHoWmX90dUJgA4O/RwgFP Jy5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XogiRe5yl1pNdqgPP5V4b7SXP6ekjym12cW6DYLGVp0=; b=XBt5F9KpGOvWVKj1F+qrF/6KGyhYR1X+MANj09uwTcs6A2+gUQqSs9dM3KElCup3am WgFQesMBxtmn7oAFvehrPFSrVMfEI03sX9UxsPO7VfSU75EwSe+O/CxGZamU/IwFqYT4 e/79u/DTanCLJ3g9xYv5X+jAW8kLm6E7LMmtY66n71GOKMikToNwOGmEI8TE9q/DIGr1 iG+Hxl/veo+233c9nuBdlaXG6Yq8Y4IKzOcQGh41sTgADPNRYBOdzmh7zV2bArWOESlW bi2CmtdGHaL87FF0Pm+nJEaqCMvjlheQjl0GkmKBiMA6PaJGfGRfH+bgUcqPoutxlagw YN+Q== X-Gm-Message-State: AOAM5324rwDDX0ls5fQA/Ohv7woE13Aw/y85h+Efi2w7VNkcvQkZn2bx Opkx8oRbt8HLGFVRENFr2Go= X-Google-Smtp-Source: ABdhPJz3j/0k13Y+1hAKw3keqLsar5KE6t3HteVdbPBktHQmHravmlslxwvSJKSccWLBysDa73hcFw== X-Received: by 2002:adf:eecc:: with SMTP id a12mr22631110wrp.312.1610911582822; Sun, 17 Jan 2021 11:26:22 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 17/20] hw/pci-host/gpex: Mark device with no migratable fields Date: Sun, 17 Jan 2021 20:24:43 +0100 Message-Id: <20210117192446.23753-18-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) TYPE_GPEX_HOST does not have internal state to migrate. Its only interesting state is in the GPEXRootState, which is a TYPE_GPEX_ROOT_DEVICE which migrates itself. Explicit there is nothing to migrate by using the special vmstate_qdev_no_state_to_migrate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/gpex.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/gpex.c b/hw/pci-host/gpex.c index 2bdbe7b4561..2565dc27ae4 100644 --- a/hw/pci-host/gpex.c +++ b/hw/pci-host/gpex.c @@ -115,6 +115,7 @@ static void gpex_host_class_init(ObjectClass *klass, vo= id *data) =20 hc->root_bus_path =3D gpex_host_root_bus_path; dc->realize =3D gpex_host_realize; + dc->vmsd =3D vmstate_qdev_no_state_to_migrate; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; } --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1610911590; cv=none; d=zohomail.com; s=zohoarc; b=nW7ZrgKUQBok33yXxk8q+W844EGTxyPm0OmBkgWAQI0kX0ve1IoBPee1KJn37/evL2gJmI/iHvMkkUHd9uJf1lASMKLLXx1rmX9ToSPgb5ldiPIkAZoKSTZ4F/CVv30WR+7tX1jkw+k/xY50jY/HXnFR8oNlwLKXKv3i3tdb4GE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911590; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sLzS9Bs5+OgQ/PoK/Es1Ix8oJMDYYC+sg+uBbYc2jF4=; b=kUWr2e/XMoA4hQO5NlxOCBdBBJE74nmtNM/sziLt8YcMF7cenX/XAmhP7WXwlvDwJ2b6RCoWGaYiglGv2a/uHh2j3ww7f/jEuDCQVivH/v9iMBK+A4kjfKaThQDgCHRSD85FPcwH7crFO7DQlUXaxLHFgSGzuUa0MwgsirJpt1c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 161091159001661.50800547234519; Sun, 17 Jan 2021 11:26:30 -0800 (PST) Received: by mail-wr1-f52.google.com with SMTP id c5so14444987wrp.6 for ; Sun, 17 Jan 2021 11:26:29 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id z3sm25943380wrn.59.2021.01.17.11.26.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sLzS9Bs5+OgQ/PoK/Es1Ix8oJMDYYC+sg+uBbYc2jF4=; b=CkwMsV8INxC6IbZrpQSLWtqkYM7Lrst93pFDrrc3JrCNpyl8DEtgIQRIklY4zeLfhI yXFPy4lMl4WV92ZnEdFZvwSS/hHcJ8PznnYo9IrN4tZz9iVrWbilg4pN3Mo7HFefVzT4 z/aybAzi/R5NF6BQ5rPc7h1KyRFdiRHhCHZvo65slVvfl3OW+0ilZcnHTg6a2G+sHcok n17dBnJhF6oRK3A3+h28snY7ClgEiKLuoa7FsnKBDQ4tDr9njcijK8/E/wxwy84l+LZB eXRJu8NLo6kjCugqwFJICAkikVgZn2rwDx3ndHgvbski6Ayk5W4o70rkLtpwTNf3k2Pv PlkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=sLzS9Bs5+OgQ/PoK/Es1Ix8oJMDYYC+sg+uBbYc2jF4=; b=k9fhQRJ5mK/I+6VAWJlx3sueE4ODNCs3A3n8zZfcKzzNlc0wBHrNLiSx/ko876YjMK cOzpRuLx0BLUIFRcMxfc8RTw2hNTBVueBleJOOzUJPpDQ7Ck63ndSEZpqqOklUEpu6Ea u6a/BlcycNywbXOuVUujuwXUec64XDSlt3SV6QnfDCJLqk30G7H1cbi5cdLBon2+jrVc DzNOwfh7ghDkLNMxymHJdBKr0XokhHhUAkNLE74T3WKjykddKeSMiKXcMZRTmN+ZNL/S O0Ay0Rhe1J6acsEOZ+DLNc0DLClGBiVWgaePJgGaqd26zswZ4eONQ9NG2gWpL2at1jgr Q2xA== X-Gm-Message-State: AOAM5300STp/hE2vmSnU0Tr+hhqQJ7WUgz5sjHWYzN/npJL7gj90OksZ 32VVtA9v4RSmzmALeRmrtuU= X-Google-Smtp-Source: ABdhPJxWrf+AFOLydS3QL/cdCmgoG08Uh/rSVPpDcMqUO7MHLHlm/zfTafxeQ0CNyCiIKJf+lJj5Eg== X-Received: by 2002:a05:6000:1565:: with SMTP id 5mr23155649wrz.109.1610911588342; Sun, 17 Jan 2021 11:26:28 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 18/20] hw/core/qdev: Display warning for devices missing migration state Date: Sun, 17 Jan 2021 20:24:44 +0100 Message-Id: <20210117192446.23753-19-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When built with --enable-qdev-debug, QEMU displays warnings listing devices missing migration state: $ qemu-system-arm -S -M spitz qemu-system-arm: warning: missing migration state for type: 'pxa270-c0-ar= m-cpu' qemu-system-arm: warning: missing migration state for type: 'serial' qemu-system-arm: warning: missing migration state for type: 'pxa2xx-pcmci= a' qemu-system-arm: warning: missing migration state for type: 'pxa2xx-pcmci= a' qemu-system-arm: warning: missing migration state for type: 'pxa2xx-i2c-s= lave' qemu-system-arm: warning: missing migration state for type: 'pxa2xx-i2c-s= lave' qemu-system-arm: warning: missing migration state for type: 'ads7846' qemu-system-arm: warning: missing migration state for type: 'max1111' Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Unresolved issue: https://www.mail-archive.com/qemu-devel@nongnu.org/msg721700.html Peter: > I think where we'd like to get to is installing a migration > blocker if the machine has any devices which don't have a vmsd. > But for that we'd need to be pretty sure we'd got all the devices > on machines where we care about migration, and we're clearly a > fair way from that (eg we need to do something about the > devices like the CPU which don't have a vmsd but handle their > migration some other way so they don't trigger the condition > for warning/migration-blocker). --- configure | 10 ++++++++++ meson.build | 1 + hw/core/qdev.c | 5 +++++ 3 files changed, 16 insertions(+) diff --git a/configure b/configure index 155dda124c2..984befbb99d 100755 --- a/configure +++ b/configure @@ -383,6 +383,7 @@ blobs=3D"true" pkgversion=3D"" pie=3D"" qom_cast_debug=3D"yes" +qdev_debug=3D"no" trace_backends=3D"log" trace_file=3D"trace" spice=3D"$default_feature" @@ -1005,6 +1006,10 @@ for opt do ;; --enable-qom-cast-debug) qom_cast_debug=3D"yes" ;; + --disable-qdev-debug) qdev_debug=3D"no" + ;; + --enable-qdev-debug) qdev_debug=3D"yes" + ;; --disable-virtfs) virtfs=3D"disabled" ;; --enable-virtfs) virtfs=3D"enabled" @@ -1048,6 +1053,7 @@ for opt do debug=3D"yes" strip_opt=3D"no" fortify_source=3D"no" + qdev_debug=3D"yes" ;; --enable-sanitizers) sanitizers=3D"yes" ;; @@ -5912,6 +5918,10 @@ if test "$qom_cast_debug" =3D "yes" ; then echo "CONFIG_QOM_CAST_DEBUG=3Dy" >> $config_host_mak fi =20 +if test "$qdev_debug" =3D "yes" ; then + echo "CONFIG_QDEV_DEBUG=3Dy" >> $config_host_mak +fi + echo "CONFIG_COROUTINE_BACKEND=3D$coroutine" >> $config_host_mak if test "$coroutine_pool" =3D "yes" ; then echo "CONFIG_COROUTINE_POOL=3D1" >> $config_host_mak diff --git a/meson.build b/meson.build index 3d889857a09..545c8f9f88b 100644 --- a/meson.build +++ b/meson.build @@ -2472,6 +2472,7 @@ summary_info +=3D {'TPM support': config_host.has_key('CONFIG_TPM')} summary_info +=3D {'libssh support': config_host.has_key('CONFIG_LIBSSH= ')} summary_info +=3D {'QOM debugging': config_host.has_key('CONFIG_QOM_CA= ST_DEBUG')} +summary_info +=3D {'QDEV debugging': config_host.has_key('CONFIG_QDEV_D= EBUG')} summary_info +=3D {'Live block migration': config_host.has_key('CONFIG_LIV= E_BLOCK_MIGRATION')} summary_info +=3D {'lzo support': lzo.found()} summary_info +=3D {'snappy support': snappy.found()} diff --git a/hw/core/qdev.c b/hw/core/qdev.c index f0d0afd438d..9a73a242fa4 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -792,6 +792,11 @@ static void device_set_realized(Object *obj, bool valu= e, Error **errp) &local_err) < 0) { goto post_realize_fail; } + } else { +#ifdef CONFIG_QDEV_DEBUG + warn_report("missing migration state for type: '%s'", + object_get_typename(OBJECT(dev))); +#endif } =20 /* --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911595; cv=none; d=zohomail.com; s=zohoarc; b=ip4719/i2GhCXad4ZvqlxgKm+8ARfXwN/D0AhyS1N5uiHqSh/v0vQw1BThObin5RPlXgdL2Ed2RxAejV7sWX5m/9gIjezoXASLU1lEromhF6xLmLGPs8lVnOx8sbMs6rP9OUtUZt3hacbzZZAc08Uq6y/V6FxN8YbZjzwxMj5mE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911595; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cQ7WuH65hManE2WTAsW8tOQLREFQZ7ZlBTq/RCNJDW0=; b=OZwRwq3qlYclxwVGEE7Epw2P64WlTy+RE+b3gxT/ex0AQqVCi0BoUv+MuNcxVHuj5zzmIK10TVvtDFlBNBiqERSM3e9EQ0eYRkdewR94ncDrT1AYzCKFmDsSs8ex0Kd9JnwEYFcZ5NGMUL58KI6qn66GvPr2UrNPPPj5FUfKCwY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1610911595332542.0594841890681; Sun, 17 Jan 2021 11:26:35 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id m4so14440211wrx.9 for ; Sun, 17 Jan 2021 11:26:34 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id v11sm24403198wrt.25.2021.01.17.11.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cQ7WuH65hManE2WTAsW8tOQLREFQZ7ZlBTq/RCNJDW0=; b=JVwXzyhxfwZ0PfTAO21ov55DvH4NurMxFuxYYskpxXRWpJ5OgzEF+m6pBPZL+aJssr rDHVXdKh0nM+GSV1JvyKTpCWg9JUEFk8k28CQ5O4bHDM2uH0S9CHS/odVO9PKWtWTVFA /mK61ANrkf9p/Aox3nkyVxxu+2rpdpW4DNZIUDeHJgbYFKwM3Gl373e9YWZgg4TD6X8C IN1BMR8bvV3CochTmOSOSiDmQm4zjCMYWv+ArKTDNPxUBUW1g8hlcL78zKAZAWCkzQqL zWzkFgXamnC8XE1TjDmvlfyYoqLPjDq8jVwymbn7lT+XZNmGkIzBK1RJPYzwj14UqUfj ykNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cQ7WuH65hManE2WTAsW8tOQLREFQZ7ZlBTq/RCNJDW0=; b=ckgwXyznqin3nuFnqCXo8RvTXbSNn1cqOUEs0I6qv+Q6yx3+MaLvBKnGcG0K9t9Dgq FwzHZYzO84FVuoax6rVb1VNYJxNqOmJx+VSwkM19r/n+Q5ihwx7ThV2jd+cdCGZSmr+s qHrNa2PpzxB8NqFyRAsr3kIMALAtErykf7/WwRXMhaPtxWgpdlp0swnuy2cWbFk1Ah4E sWpdXj//3zq0+zNqzPxVyGLXWwMyAaNlUhEJGPZ/GQ9+/Fwl/O2zwts04DlZMHuL82rk m6Nhq9VZjpJ0CY0Lrw+o48PrlHSKFXZ+ywMbAyPwrAM96IPn8iJQ9H9uwQUmEniRjGua 464A== X-Gm-Message-State: AOAM531u7qSrW6u7oYSclSinCMq8s7qc1piaC+10K9M2JiDz1TgyO+SP fsZK5cjuKjQDpeTC/N9VXwQ= X-Google-Smtp-Source: ABdhPJw0affoOQBd3BXv6ayluNOZxyQlytCo+1A20sV29BzouOR7ewU9Q8FY0mIPS4j8uDKHxbwQCg== X-Received: by 2002:adf:d0d0:: with SMTP id z16mr22876173wrh.209.1610911593569; Sun, 17 Jan 2021 11:26:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 19/20] stubs/vmstate: Add VMSTATE_END_OF_LIST to vmstate_user_mode_cpu_dummy Date: Sun, 17 Jan 2021 20:24:45 +0100 Message-Id: <20210117192446.23753-20-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Add a name and end marker to the vmstate_user_mode_cpu_dummy variable. Reported-by: Dr. David Alan Gilbert Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Dr. David Alan Gilbert --- stubs/vmstate.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/stubs/vmstate.c b/stubs/vmstate.c index f561f9f39bd..1d0e03e233b 100644 --- a/stubs/vmstate.c +++ b/stubs/vmstate.c @@ -2,7 +2,12 @@ #include "migration/vmstate.h" =20 #if defined(CONFIG_USER_ONLY) -const VMStateDescription vmstate_user_mode_cpu_dummy =3D {}; +const VMStateDescription vmstate_user_mode_cpu_dummy =3D { + .name =3D "cpu_common_user", + .fields =3D (VMStateField[]) { + VMSTATE_END_OF_LIST() + }, +}; #endif =20 const VMStateDescription vmstate_no_state_to_migrate =3D { --=20 2.26.2 From nobody Sun Apr 28 17:42:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610911600; cv=none; d=zohomail.com; s=zohoarc; b=Slh9Q8j98Y5rdTVbZ4AikDStHlj1cbfyy8DcMrFZwUTBRFTFOcHL3KeVkcfWMQfEYHEFEAxDhpQ6vziCBo2ZQDRNezra3leTnCv31j+BcgY/oUOoVj0tjoaQSBmWAk8JBurILMYo9L4WrxO27y5br9m8INE1jIdF53HuhgvNAHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610911600; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D/vhGf9tYrzI/+Qv47CWtkJxcBt3ZEhYVSaLznm82dE=; b=lvn/LMmkziaSovffLsUOGcRwy9H2iC9TcRMD9vg36tCS5IlNy5CuSbI4TTNZOvBofEuBX46hQ0yQsPChmxWunxwxTM1dyL6xDnUZMZAWPHDlCLEwHrIwjTmOCUJfojSL+xAE214DOtogJY9r10Q083FDyyj5lQAkt32LFIM4Frk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1610911600720412.5798161927578; Sun, 17 Jan 2021 11:26:40 -0800 (PST) Received: by mail-wm1-f54.google.com with SMTP id y187so12069562wmd.3 for ; Sun, 17 Jan 2021 11:26:40 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id j7sm21720217wmb.40.2021.01.17.11.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 11:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D/vhGf9tYrzI/+Qv47CWtkJxcBt3ZEhYVSaLznm82dE=; b=dDIS/7Ww+gYmBQD8IMElHJNn7JWSXIxRghqGgbo8cMyxwhw8p/6ubLO11lw+vm1ZQ2 UqqHLYgUegb0abI5GEcwCObm3ghvemj1qkIY9BWUUpsuc3nBY1fIR/5egA46QCzJpq35 YJQclTTYuUqdvZXRJdbSN3tn56EW9NfesLJaMLMXDaPPkk39A5cak7kHtnv/DJmGiEIe BCYLb69WO7aLof7gZKSu2Dgs5ZiWtWGYEGSU7MrLm1rf16ioj+u7Ckxh8gVoPGHA3trD tVed2SiZPpXpVTRpAdMFFkMSRsdt48VTaXD9guI/2L+4SqYbTEd8DbKlwJwfL6cijqzk wmgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=D/vhGf9tYrzI/+Qv47CWtkJxcBt3ZEhYVSaLznm82dE=; b=kc6awDUyEY8M2uWmGM1SwRJc1NVd3v6KhqGa62XV/e6I9fN9hwfXuARdqXIMsiw6t1 nYazJCupOn3ZDuMKWj7qMf4bXHH/d/ZfWndHcTYHt7ftVDXuCMMBJ+6TwujkK5mU+TxE zMnjSZzmZpO91o+9HsbFrPpXR5KtwHR94YCdiyZKLtLO03/SFEcLne8T2tEdvr+amMiO dZNvwkl1yHa4YHUXDC/zB92l/XSJDgSowFzjJZuViXYEGFZngpLXuEXOGIs/If8eRl6h 3y27e/j93+ad1s529JvfFjXEP4Jgf17jIUrWkmRUVuP4/0c3+Afwz0Glq+gAQ85X/Nau WqzA== X-Gm-Message-State: AOAM5301OHT2Cv+xFjmJiGOGeXPg3JZRP/mc3LAUedL91znqU+B5QZDb YyevPdUi+80tvcEaQzSGcMg= X-Google-Smtp-Source: ABdhPJzIcaeD79hTA/Hun2LIAf5jPVodgZiUbtt9nKaY6Exb5IX56l+RDcFbxAto+c8yERamWN+R+w== X-Received: by 2002:a05:600c:255:: with SMTP id 21mr17520686wmj.69.1610911599053; Sun, 17 Jan 2021 11:26:39 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-arm@nongnu.org, Marcel Apfelbaum , Artyom Tarasenko , Paolo Bonzini , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Subbaraya Sundeep , Andrew Jeffery , Juan Quintela , Eduardo Habkost , Andrew Baumann , Gerd Hoffmann , Joel Stanley , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 20/20] migration/vmstate: Simplify vmstate for user-mode CPU Date: Sun, 17 Jan 2021 20:24:46 +0100 Message-Id: <20210117192446.23753-21-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117192446.23753-1-f4bug@amsat.org> References: <20210117192446.23753-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) User-mode wants an empty vmstate for the CPUs. We can use the generic vmstate_no_state_to_migrate object which is the same. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 2 +- include/migration/vmstate.h | 3 --- stubs/vmstate.c | 9 --------- 3 files changed, 1 insertion(+), 13 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index c79a58db9b9..01e75cc7403 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1132,7 +1132,7 @@ bool target_words_bigendian(void); #ifdef CONFIG_SOFTMMU extern const VMStateDescription vmstate_cpu_common; #else -#define vmstate_cpu_common vmstate_user_mode_cpu_dummy +#define vmstate_cpu_common vmstate_no_state_to_migrate #endif =20 #define VMSTATE_CPU() { = \ diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 50559598eac..dfe20b5caa1 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -194,9 +194,6 @@ struct VMStateDescription { const VMStateDescription **subsections; }; =20 -#if defined(CONFIG_USER_ONLY) -extern const VMStateDescription vmstate_user_mode_cpu_dummy; -#endif extern const VMStateDescription vmstate_no_state_to_migrate; =20 extern const VMStateInfo vmstate_info_bool; diff --git a/stubs/vmstate.c b/stubs/vmstate.c index 1d0e03e233b..c360a929f60 100644 --- a/stubs/vmstate.c +++ b/stubs/vmstate.c @@ -1,15 +1,6 @@ #include "qemu/osdep.h" #include "migration/vmstate.h" =20 -#if defined(CONFIG_USER_ONLY) -const VMStateDescription vmstate_user_mode_cpu_dummy =3D { - .name =3D "cpu_common_user", - .fields =3D (VMStateField[]) { - VMSTATE_END_OF_LIST() - }, -}; -#endif - const VMStateDescription vmstate_no_state_to_migrate =3D { .name =3D "empty-state", .fields =3D (VMStateField[]) { --=20 2.26.2