From nobody Tue Feb 10 17:35:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610902118; cv=none; d=zohomail.com; s=zohoarc; b=CPovVhxwL7b11E6kHQDmso5g/B0RZhtcAXOtDWda/gR8qBA92lIsPKfFJr9BWBskQoJY+ee7oSGtjPgni7KHT2CDjNtMipwYjtV9J2w2RIYZiwoBCoCMBE+oQ0VJY25OO/6tVO1K5jldiYVoE6sUidyhK8YgFXgu4ZF5QAYBm+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610902118; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IdvZXWO0/2ft9HXnEBMCvSFP098rRCS4xqKPXBAMD88=; b=kdpfWjpHDjUbYk1qMd9PHguwaX6o77/dKt6iW7aUpIkB4I3Nl14DnXkCF3kGibEh1VJFDC21xsfYLZuSOJhFsaDnzyZQv25s8kgQxtLXf1b7+RpMXFWsv71XFn3axcZxjwQefky6Z2F9LZ4W61CnPr9X/voHpo+4yOumv9xgmOw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1610902118492924.5403654268644; Sun, 17 Jan 2021 08:48:38 -0800 (PST) Received: by mail-wm1-f53.google.com with SMTP id g10so11836312wmh.2 for ; Sun, 17 Jan 2021 08:48:37 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id z8sm6535372wmi.44.2021.01.17.08.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Jan 2021 08:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IdvZXWO0/2ft9HXnEBMCvSFP098rRCS4xqKPXBAMD88=; b=q+LybSz3hTQG0sdPiNPSWhBg9FIBb5NC04B+Ee7coimMmQUjrU7/FZA9BvTIhQ4HfU kKW+SH8zd7As6FUdm4x5fthoVMyvGH+YzcWQNfD/h2+y4m8jCz3OIY4gUhAYRZV+AGXt 0QXYqU5oun5JFRRzIn0NcfkqE0PRy7iBr9krpEQt9Ne5XR7+15L/Y0LDh6Xc9Q7QPrj9 7xk/5Oi6uOwAHbhfxsVUWN+9lw92zm4EIASm+uTgnGNVPDIZ6o1NUnmmGzWwQsaQThCp edAv1lrJSzgeN/XcHBnRTTkNv1aZRWFI9eZ6Uld9SzZd3owXCRFas807ENarK7R/Yb6A 6z1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IdvZXWO0/2ft9HXnEBMCvSFP098rRCS4xqKPXBAMD88=; b=RADH1o5j+b5KGT8MEqTZH8/7sPI+OrL3au55HVwfGaB8FYxnLmiA+lxwSiWqFWI5ve R5jmfBt///5UUltiefMcfX1JZwO8CYn2x6TlzKyso/IXdbY0WET/2TY6XT8WBrS1JO3o LEQyVjuWCNEYufsSbW8cKPtN+FD2MMpiru3jkTX4g+tXd9mTYo42Ga3rLxtblGJZm/wR CWtJ1gGlb/al96xYexNqNC7WHy8pHSIVHWu/HyUkkcPQkKzQi68siPKOdvQ3+fsinRVI 7O/HfDoIWOgpYrdWGa9CkVTgHhecvgQpN9vXVw/U8f0ad1Q2qCVC87qqawtS/Mooa8N3 NSaw== X-Gm-Message-State: AOAM531UcwUX8FPcXrgzdRb9DzEbPiY7gAbIcNkz52TevmR6kNDLRB52 QtVlZaPN56LE+0LzMmSfDpQ= X-Google-Smtp-Source: ABdhPJySu7s0H+ZsCwsLugDNtCt67aIogtEi2clUdX79r66Ba+dIzNkbv397uoZyfTRIlrO7ANThQQ== X-Received: by 2002:a7b:c3d3:: with SMTP id t19mr8998552wmj.151.1610902116757; Sun, 17 Jan 2021 08:48:36 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Claudio Fontana , Huacai Chen , Richard Henderson , Eduardo Habkost , Paolo Bonzini , Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Riku Voipio , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/6] accel/tcg: Declare missing cpu_loop_exit*() stubs Date: Sun, 17 Jan 2021 17:48:11 +0100 Message-Id: <20210117164813.4101761-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210117164813.4101761-1-f4bug@amsat.org> References: <20210117164813.4101761-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) cpu_loop_exit*() functions are declared in accel/tcg/cpu-exec-common.c, and are not available when TCG accelerator is not built. Add stubs so linking without TCG succeed. Problematic files: - hw/semihosting/console.c in qemu_semihosting_console_inc() - hw/ppc/spapr_hcall.c in h_confer() - hw/s390x/ipl.c in s390_ipl_reset_request() - hw/misc/mips_itu.c Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- I suppose the s390x kvm-only build didn't catch this because of compiler optimization: in s390_ipl_reset_request(): 640 if (tcg_enabled()) { 641 cpu_loop_exit(cs); 642 } and "sysemu/tcg.h" is: 13 #ifdef CONFIG_TCG 14 extern bool tcg_allowed; 15 #define tcg_enabled() (tcg_allowed) 16 #else 17 #define tcg_enabled() 0 18 #endif --- accel/stubs/tcg-stub.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index 8c18d3eabdd..2304606f8e0 100644 --- a/accel/stubs/tcg-stub.c +++ b/accel/stubs/tcg-stub.c @@ -28,3 +28,13 @@ void *probe_access(CPUArchState *env, target_ulong addr,= int size, /* Handled by hardware accelerator. */ g_assert_not_reached(); } + +void QEMU_NORETURN cpu_loop_exit(CPUState *cpu) +{ + g_assert_not_reached(); +} + +void QEMU_NORETURN cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc) +{ + g_assert_not_reached(); +} --=20 2.26.2