From nobody Wed Feb 11 06:15:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.47 as permitted sender) client-ip=209.85.208.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610724670; cv=none; d=zohomail.com; s=zohoarc; b=SYR7jslgXW9N6W0YyoN9nePKI64/8GnjGC9kWPp+sOYfNsbRnGG6eC9SEHZmDuAyYS+7RPooOECDcUZdY0Z558eDa6tT+hHp2x9FeYgP9Km80qO86QpbePYCatCLzokEGInNIhVvRv3lpOPQiChTqRV3T1IDzdasNJtu6UCmaHk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610724670; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z4qy97PFtHKZ/41ys7UAdQh2nrLy+ZugZUPugDx4O98=; b=HHPIgiCuQdxp9ls/VW3EcTnJRGxOjBZknvXGHJGNbODA5EipH2/wkEv+bR6RpBt24a1WIkEo4EFtyrKA/vL6H6hzPW9hE8jDZuvniJcDj8ZYA2MoBEcsqiR8j90FR8wd4GMsBRmBUk7sVl6TXwhTXbJlLE/Ry2lPnYHhdNL+/Jo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by mx.zohomail.com with SMTPS id 1610724670159962.0988120318951; Fri, 15 Jan 2021 07:31:10 -0800 (PST) Received: by mail-ed1-f47.google.com with SMTP id dj23so7352449edb.13 for ; Fri, 15 Jan 2021 07:31:09 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id d4sm4147193edq.36.2021.01.15.07.31.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 07:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Z4qy97PFtHKZ/41ys7UAdQh2nrLy+ZugZUPugDx4O98=; b=AKI5uBOzblTOtH+Y7blzK5kUzm7yX4uP4lOKG2Q6F2ycmw3FsO++nnhUxzXdfA5XJG XZYZ85YCskXvpMe8rpnC4HrptdTt3GjMUclmZY/RyqkolB1AblsypnQ2pYKXeZXVmTyB e+/yXhRrPtzGfkuwxMOwv/AfHd8rHcZSpwsCpIwJMTy09UaREP7jYC915+nl5LCJjOc1 5EVlz0Fig/u5Xvg7U9QqOXRcj377Qjd1MaH5onD7vpHLYEhWdKjjgInQiY2nL58GFiPC tulis2+2sfRpwolfN/pbgkBw9WrsVO8Kx+gswt0NiwGUBL8yR2kgA4AIfX35TIGdYnKy N5dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Z4qy97PFtHKZ/41ys7UAdQh2nrLy+ZugZUPugDx4O98=; b=ceXwKRDVIG7MmBMSJW/wLCG8FdySQre/J3X+BmKI3pZyrXEyv0zTanp1oovI/mmkpP 6MJMkiBu2w5hQw/AYKr34y+9CvE6vq0k4jZRmZZDf8x7hN6GeNDYD7kRw6fFw6iiUR0+ +H5hfz7cfQIqDTu+kgIfBz+gUjXgZiTqWVyhXLOjYHT8cn7W/1YH+31vIgi7bcfr7oOG TiH+BTe+kg32cGbPd3WAEd+R0AjI8negJOq/o6qe+LzFcRTNRte92BWXRl3wqCZYDe+0 9r0zgXDWK9XpFcpx6MmX1eUchypKnRk5U9ySGmJzux/fMs68u2KzLnhlrxSo7yYX9rNM bjdA== X-Gm-Message-State: AOAM531zFcaCDkcCtXGxG8l8gwuEoKG9Vix/jV+UACaAqBcyDRlU2jpE kjYvtqNnMN7NgMjp//9EfED8SF6AnVQ= X-Google-Smtp-Source: ABdhPJxHD291RM+cDSzyoPG+y1Ffmdg+MFamJVee5CPxbE0/XGtkUPwwimZP+IE2KD8yhhdl0B0yqA== X-Received: by 2002:a05:6402:40c4:: with SMTP id z4mr9862256edb.233.1610724668346; Fri, 15 Jan 2021 07:31:08 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Jean-Christophe Dubois , qemu-arm@nongnu.org, Peter Chubb , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Juan Quintela Subject: [PATCH v7 3/9] hw/ssi: imx_spi: Rework imx_spi_reset() to keep CONREG register value Date: Fri, 15 Jan 2021 16:30:43 +0100 Message-Id: <20210115153049.3353008-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210115153049.3353008-1-f4bug@amsat.org> References: <20210115153049.3353008-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When the block is disabled, all registers are reset with the exception of the ECSPI_CONREG. It is initialized to zero when the instance is created. Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM), chapter 21.7.3: Control Register (ECSPIx_CONREG) Reviewed-by: Juan Quintela Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ssi/imx_spi.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index 40f72c36b61..78b19c2eb91 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -231,12 +231,23 @@ static void imx_spi_flush_txfifo(IMXSPIState *s) static void imx_spi_reset(DeviceState *dev) { IMXSPIState *s =3D IMX_SPI(dev); + unsigned i; =20 DPRINTF("\n"); =20 - memset(s->regs, 0, sizeof(s->regs)); - - s->regs[ECSPI_STATREG] =3D 0x00000003; + for (i =3D 0; i < ARRAY_SIZE(s->regs); i++) { + switch (i) { + case ECSPI_CONREG: + /* CONREG is not updated on reset */ + break; + case ECSPI_STATREG: + s->regs[i] =3D 0x00000003; + break; + default: + s->regs[i] =3D 0; + break; + } + } =20 imx_spi_rxfifo_reset(s); imx_spi_txfifo_reset(s); --=20 2.26.2