From nobody Tue Feb 10 20:06:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.50 as permitted sender) client-ip=209.85.218.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610724660; cv=none; d=zohomail.com; s=zohoarc; b=NYLIaXWjnH2ubXRFy7lFHXnCv0UzDJSdMUqOChay2I1qge0EQwIaac816JbjlvnPy5NPYV6BgIljHUhygbZAt1BqBaLDske8Jd+9m/+ZTo16LpIlgmXQUbT808CkUj6QPBegmXVdGRUseGdyXU5uVVKV5cUBqfY3L4h3bEjJ94Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610724660; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xdTpIDS65/IfYybVOuMbzhHG9RGib9cm8VYJpYoGsWk=; b=jo20H+96tOaYmVRY8cloDVkRSrZ8q0YpwhYATkNThU9At/ty6k0SkuatAT836JaP1FtR3k9wGUPXPjfw9/ZDJ2KsLxoZsU7TbPISS5s0+Tvd1Gjl9jhHlFkokx5Y59vK5unuwIL8Q5GQjf+QJp+mVoXKTxL2se9aged2CaILZDY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by mx.zohomail.com with SMTPS id 1610724660522639.1433147990035; Fri, 15 Jan 2021 07:31:00 -0800 (PST) Received: by mail-ej1-f50.google.com with SMTP id ke15so6188799ejc.12 for ; Fri, 15 Jan 2021 07:30:58 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id i13sm4072081edu.22.2021.01.15.07.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 07:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xdTpIDS65/IfYybVOuMbzhHG9RGib9cm8VYJpYoGsWk=; b=OW95yZ/cB5wcvzWT38Vd+zNLll5JxteBr2Myl5hn64k+oxwwMBwXONmMWjNH/tgUxR W7G++IlKXLQidpJhUWQit6bL5Hsam6lpizDuqULcqTIS3Awm5+VmbVemJIzNf2wEEmL+ oO/bju/QmaiqCcJtO0VhIv06U+MQbN/BSkOShK/jE3YO81a8LSDCXMio9uqHWV/51Zsw SMKDbd4GTAkV61z5YREDml8FrQ52Fc5614qtqUXSJGp2RAOMq84wZAqtGqvUoeJbIwSy pgpFf/hHnHpth+GArvrNRY+suSIqEzEoWfxi89CdtBlR9l7MV1QWnmqncMA2ymASxWpC gBVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xdTpIDS65/IfYybVOuMbzhHG9RGib9cm8VYJpYoGsWk=; b=nWfrA3ErHKGjxBQpLXedySQhsM1LOL9SoS22IYTLWyyZWniTqQwEsByE4hEl27Uquv QHT33IxzfyT14PTK4ctvaaBC41H/rvNNSnkfggo8tZDi/cSA5LPu2tanv//xbaHT3Kwf WPqQ7P/Ejcc5b9NR2pvxCrHMO8ed/g8ZzdfHFqmKRHiH0bf9wJYFHtFilXvvKoWQ047r xX1y240fi/nGIgx6fRkApd4JCcU9uJkDEYb3ziFNJbZSE3lCIdBgJAeYLuatdfcRW4Ns 2K6fa9SrShzGfl16QuAU/7PADWz0wY3oN96QigS/VhQqPUQYzxEdOlJj7hGuHImsx3yD hI9w== X-Gm-Message-State: AOAM532Ur/pINTQBciqKTwEzt5PhuQsgN1951Q8qS/7UXmcGUibwGTR7 Cw4wCZjc3DMpC1LjG+w64Lk= X-Google-Smtp-Source: ABdhPJxGLLkOcJHJhS6j9RasBp0evkUe38IcKFyeYc7uMMyBFInFEzZokuwydfSChIia1SyLsc7kNg== X-Received: by 2002:a17:906:971a:: with SMTP id k26mr9644949ejx.515.1610724657419; Fri, 15 Jan 2021 07:30:57 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , Jean-Christophe Dubois , qemu-arm@nongnu.org, Peter Chubb , Peter Maydell , Bin Meng , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Juan Quintela Subject: [PATCH v7 1/9] hw/ssi: imx_spi: Use a macro for number of chip selects supported Date: Fri, 15 Jan 2021 16:30:41 +0100 Message-Id: <20210115153049.3353008-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210115153049.3353008-1-f4bug@amsat.org> References: <20210115153049.3353008-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Bin Meng Avoid using a magic number (4) everywhere for the number of chip selects supported. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210112145526.31095-2-bmeng.cn@gmail.com> Reviewed-by: Juan Quintela Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/ssi/imx_spi.h | 5 ++++- hw/ssi/imx_spi.c | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/hw/ssi/imx_spi.h b/include/hw/ssi/imx_spi.h index b82b17f3643..eeaf49bbac3 100644 --- a/include/hw/ssi/imx_spi.h +++ b/include/hw/ssi/imx_spi.h @@ -77,6 +77,9 @@ =20 #define EXTRACT(value, name) extract32(value, name##_SHIFT, name##_LENGTH) =20 +/* number of chip selects supported */ +#define ECSPI_NUM_CS 4 + #define TYPE_IMX_SPI "imx.spi" OBJECT_DECLARE_SIMPLE_TYPE(IMXSPIState, IMX_SPI) =20 @@ -89,7 +92,7 @@ struct IMXSPIState { =20 qemu_irq irq; =20 - qemu_irq cs_lines[4]; + qemu_irq cs_lines[ECSPI_NUM_CS]; =20 SSIBus *bus; =20 diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index d8885ae454e..e605049a213 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -361,7 +361,7 @@ static void imx_spi_write(void *opaque, hwaddr offset, = uint64_t value, =20 /* We are in master mode */ =20 - for (i =3D 0; i < 4; i++) { + for (i =3D 0; i < ECSPI_NUM_CS; i++) { qemu_set_irq(s->cs_lines[i], i =3D=3D imx_spi_selected_channel(s) ? 0 : 1); } @@ -424,7 +424,7 @@ static void imx_spi_realize(DeviceState *dev, Error **e= rrp) sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->iomem); sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq); =20 - for (i =3D 0; i < 4; ++i) { + for (i =3D 0; i < ECSPI_NUM_CS; ++i) { sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->cs_lines[i]); } =20 --=20 2.26.2