From nobody Mon Feb 9 17:25:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610718746; cv=none; d=zohomail.com; s=zohoarc; b=T24MBoHdBYiZMxKwXV/l5KJ/UPWXWrpOBs0BcKOUYQTyXc9tS8ver3NmVKQXN5iPXuXek3MJWC/81mtAg/gpJtPr88Pm5oJoGJ5trPCVtLBxg/2C/6ZRUOGMHj+MgCzi8BJaz6k7P6x9azO1SoIwjnAbisH4wiqSW4d0iuRB7fM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610718746; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KFWPq1W6WpQvv5fZvi5fxk9b8cb3IFSPQqe4LAA/rvc=; b=eZr0nmtjOSCMu6eCn+fOO8/S1PvK4sZXPSXSneXmybW8wjBgY8lw25EttnnHxpcdWy+DBgYVt++Jl3UF/zkDjVD1UrBjCcCTZhVWeqxQl8skd5XxyJJqjN7b1sVSXIUWgjWpvWAU9om93x1C+hJ3JQhrDqWCuhcwKsRpFiG33xw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610718746142683.8762892747296; Fri, 15 Jan 2021 05:52:26 -0800 (PST) Received: from localhost ([::1]:37454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0PWa-0006u1-Vn for importer@patchew.org; Fri, 15 Jan 2021 08:52:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0P3L-00070Q-62 for qemu-devel@nongnu.org; Fri, 15 Jan 2021 08:22:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l0P3A-0003HA-78 for qemu-devel@nongnu.org; Fri, 15 Jan 2021 08:22:10 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-370-qsW7RuZjP7WcVycRBJ9u4Q-1; Fri, 15 Jan 2021 08:21:51 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6637100F340; Fri, 15 Jan 2021 13:21:50 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE97B6F7EB; Fri, 15 Jan 2021 13:21:47 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4B00C1800633; Fri, 15 Jan 2021 14:21:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610716914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KFWPq1W6WpQvv5fZvi5fxk9b8cb3IFSPQqe4LAA/rvc=; b=AWGY5KHDSvZ1Y28YPQswmpCSeywQ7pURv7vKtHzky0QwdjpmzmoLzmnqWNIus4QeC1HZIj Al+LCo29leVHfl+afJMGsQ1ZesqB1UfOrcJwEMBMFKX6wfFu0sa/bjPpNLpUJSW83yJlot tZ7myHVEv2LaQeRS0S+t8XkpxvOOebQ= X-MC-Unique: qsW7RuZjP7WcVycRBJ9u4Q-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PULL 04/30] sdlaudio: don't start playback in init routine Date: Fri, 15 Jan 2021 14:21:20 +0100 Message-Id: <20210115132146.1443592-5-kraxel@redhat.com> In-Reply-To: <20210115132146.1443592-1-kraxel@redhat.com> References: <20210115132146.1443592-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?UTF-8?q?Volker=20R=C3=BCmelin?= , Gerd Hoffmann , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Volker R=C3=BCmelin Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device. This patch keeps the SDL2 device pause state in sync with hw->enabled. Signed-off-by: Volker R=C3=BCmelin Reviewed-by: Thomas Huth Tested-by: Thomas Huth Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de Message-Id: <20210110100239.27588-4-vr_qemu@t-online.de> Signed-off-by: Gerd Hoffmann --- audio/sdlaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c index 431bfcfddd97..68126a99ab32 100644 --- a/audio/sdlaudio.c +++ b/audio/sdlaudio.c @@ -312,7 +312,6 @@ static int sdl_init_out(HWVoiceOut *hw, struct audsetti= ngs *as, =20 s->initialized =3D 1; s->exit =3D 0; - SDL_PauseAudio (0); return 0; } =20 --=20 2.29.2