From nobody Mon Feb 9 17:36:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610530553; cv=none; d=zohomail.com; s=zohoarc; b=fLyN/Fx/WRg/W1uA/O6ZNx2NXaJNL2XYept4wvu1gxTrFdkTc97YXRdu5m7df5qEXyxHKQqrK97Sy0iUgeny3T4yHcerwX62/KgnKzwXouW/vtwcTV2o/gpqdz83KDgVsRCSnOnZRN0RrHCg27PdWYZkKKc4t7HC1MU6XS50Rco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610530553; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h75iak/bbCWrSRfC26SSu6eLIUokCgUIkNAwELbATaE=; b=QXWY5BNgwUSmTzQMxtYTkvZAMIY941MkgpyN7RTQ/YGqUb42FrT1jtTBXW/dbefsCx3O3CtxaMvTAEcgSB1FunIPFrgb3vP1aj7StT1+PZ09LvLIc69FgpfCPitcRIyqN75VIl/TSRAmMQ9oyR40+TfHzeXifXA85BW4xt/q4mI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610530553504426.3300483063384; Wed, 13 Jan 2021 01:35:53 -0800 (PST) Received: from localhost ([::1]:33002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzcZE-0002gB-3t for importer@patchew.org; Wed, 13 Jan 2021 04:35:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzcUq-0005tN-8p for qemu-devel@nongnu.org; Wed, 13 Jan 2021 04:31:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzcUk-0002xe-CD for qemu-devel@nongnu.org; Wed, 13 Jan 2021 04:31:19 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-PbiSRMNoO4mWY0y3fmePdw-1; Wed, 13 Jan 2021 04:31:09 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52233DF8A5; Wed, 13 Jan 2021 09:31:08 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-172.ams2.redhat.com [10.36.112.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EE0E1002393; Wed, 13 Jan 2021 09:31:08 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9B92411385D4; Wed, 13 Jan 2021 10:31:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610530273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h75iak/bbCWrSRfC26SSu6eLIUokCgUIkNAwELbATaE=; b=bC5FJe2Oo6oZgaF1PWFIqia27n4Lrr56EydH4QUIN895jLsKMnhfNOeRQGEP6zCWVDaO4m 2ZkixZBOcHNA5weenqa7JSxqHZsD7wqo86D9ReKXS2jP9L6oojeAi+8HrCwf+SlJ3ZuSHG j3iPSjP9ICQhWbaseLJfDglPDUGS8tI= X-MC-Unique: PbiSRMNoO4mWY0y3fmePdw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test Date: Wed, 13 Jan 2021 10:31:01 +0100 Message-Id: <20210113093101.550964-8-armbru@redhat.com> In-Reply-To: <20210113093101.550964-1-armbru@redhat.com> References: <20210113093101.550964-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, lukasstraub2@web.de, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) From: Lukas Straub A connecting chardev object has an additional reference by the connecting thread, so if the chardev is still connecting by the end of the test, then the chardev object won't be freed. This in turn means that the yank instance won't be unregistered and when running the next test-case yank_register_instance will abort, because the yank instance is already/still registered. Signed-off-by: Lukas Straub Reviewed-by: Daniel P. Berrang=C3=A9 Message-Id: <1445e97a5800e3f2ba024ad52b500a0315701632.1609167865.git.lukass= traub2@web.de> Signed-off-by: Markus Armbruster --- tests/test-char.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-char.c b/tests/test-char.c index 06102977b6..469d25989c 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -937,6 +937,7 @@ static void char_socket_client_dupid_test(gconstpointer= opaque) g_assert_nonnull(opts); chr1 =3D qemu_chr_new_from_opts(opts, NULL, &error_abort); g_assert_nonnull(chr1); + qemu_chr_wait_connected(chr1, &error_abort); =20 chr2 =3D qemu_chr_new_from_opts(opts, NULL, &local_err); g_assert_null(chr2); --=20 2.26.2