From nobody Tue Feb 10 06:07:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) client-ip=209.85.218.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610476572; cv=none; d=zohomail.com; s=zohoarc; b=H5lYPBwd/aXIT+3mloDcU3Hw/NhsnGRyAlktrYHg8vZt4Zi9F4WSG0tBu1S+SP+IFqVk50vJ9l1ZFSFx9jH4fX+AXyUmbwk6h6R2/G5dg1R9jjBYIob9+zUx6g/rCBdZbAUwEPxsYEQbY41jdOd+gnFZfJX6wPWfmqppDB11pBw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610476572; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sTf/aemsAO2NtfPs8v4zrOflI4yUb4IKKFkIlDtQdrA=; b=Ct7JnuRB+/oty47lMgN8t82pFgzIqUkeW273wsG7VJTt27QWoK4z+TTsidQli6lI5ZzNbFKlw6+M2OJrOgankAEHtOrhLj58CzXsUuiA6dEF4Lip1CA3ZHdJ3s9EBqktO+gxRN/JbTt1Cg3x0GA+gZhENRzQYJT9cni7K9IOhlo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mx.zohomail.com with SMTPS id 1610476572910242.20792115808229; Tue, 12 Jan 2021 10:36:12 -0800 (PST) Received: by mail-ej1-f48.google.com with SMTP id ga15so4946583ejb.4 for ; Tue, 12 Jan 2021 10:36:12 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190]) by smtp.gmail.com with ESMTPSA id d8sm1823526edm.75.2021.01.12.10.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sTf/aemsAO2NtfPs8v4zrOflI4yUb4IKKFkIlDtQdrA=; b=nt3Sr93wmoNyIKcCz30xibARHh/Rs7H3fHH6D446KnXhwTyWIkulJq7KfkrYodKvru aXDJt50D9ItyavdSgWtYPl7yFpSNv2eF7V/MuiMFrZwZZkOPbndH9iryksotchCc+8F/ TOEbXjMKvj45tc74hvq5C1imH7Q9FJFvFzBTXtnFEgMk0TMOxXQGHQHDjOK6XvGEodVd 8BuSpizxXUtxillHfEMKT5BmMdhEmCGeoP0pVo0AMXBL+/vaqJy9gCJStJ9fgfODvBBk NgpIAB00M16eVPPiKuFDFGYCuPLCQx1t4945XaqZtfKyVMm4rBvnUmIX/+Zkfpo1Nwnc Kk3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=sTf/aemsAO2NtfPs8v4zrOflI4yUb4IKKFkIlDtQdrA=; b=soztoOInxgC31Ra++KK6teZquizbo4pkQajH+yCRMKoU4wSxlHWApgIzvYB9C3n5ij Iz/lo6SyH12mrDsq10QLceBK+5UK0hXYBRGAiNXbD/pT0cm9u6Z5aGoco2uyeMCGgkIp aY1nDHcTLdGh1GGI+W2pgHYX5sjRPBwOb0LgvWE2WSXEd3xYzUIjq2zkpQu9cU/8xGSQ 4a8rKdN3UK/SsXneS2965Z88WXumR86kHmUwUlDdpOVc3PkQAXdbXFeHp3gwGUiYlSrV jbPtLtS/tdVeCoJ00AwkjlLvzWqK45u/ma42xf0zERAb+33BxxYF01qVVtQ8GTfJurHd Q0JQ== X-Gm-Message-State: AOAM531qGsZveOjjhLNmVEsNa5fCFT7tKl68EDzHnrhHZWYbkX4BwjK8 1YG3BIrzAFVxY5Q6O9WgUro= X-Google-Smtp-Source: ABdhPJyTLFYq815QTQiMct9wfSoFn3sulj1+mU2xMypZG7hgK72rzLWTWoiZ7LNFLtGEt9U8PIJUPw== X-Received: by 2002:a17:907:206a:: with SMTP id qp10mr124370ejb.432.1610476571090; Tue, 12 Jan 2021 10:36:11 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Bin Meng , qemu-devel@nongnu.org, Bin Meng Cc: qemu-arm@nongnu.org, Jean-Christophe Dubois , Peter Maydell , Alistair Francis , Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v6 05/11] hw/ssi: imx_spi: Rework imx_spi_reset() to keep CONREG register value Date: Tue, 12 Jan 2021 19:35:23 +0100 Message-Id: <20210112183529.2011863-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210112183529.2011863-1-f4bug@amsat.org> References: <20210112183529.2011863-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When the block is disabled, all registers are reset with the exception of the ECSPI_CONREG. It is initialized to zero when the instance is created. Ref: i.MX 6DQ Applications Processor Reference Manual (IMX6DQRM), chapter 21.7.3: Control Register (ECSPIx_CONREG) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Juan Quintela --- hw/ssi/imx_spi.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index bcc535f2893..96aecc8fa28 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -232,12 +232,23 @@ static void imx_spi_flush_txfifo(IMXSPIState *s) static void imx_spi_reset(DeviceState *dev) { IMXSPIState *s =3D IMX_SPI(dev); + unsigned i; =20 trace_imx_spi_reset(); =20 - memset(s->regs, 0, sizeof(s->regs)); - - s->regs[ECSPI_STATREG] =3D 0x00000003; + for (i =3D 0; i < ARRAY_SIZE(s->regs); i++) { + switch (i) { + case ECSPI_CONREG: + /* CONREG is not updated on reset */ + break; + case ECSPI_STATREG: + s->regs[i] =3D 0x00000003; + break; + default: + s->regs[i] =3D 0; + break; + } + } =20 imx_spi_rxfifo_reset(s); imx_spi_txfifo_reset(s); --=20 2.26.2