From nobody Tue Feb 10 11:12:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) client-ip=209.85.208.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610476561; cv=none; d=zohomail.com; s=zohoarc; b=NSBa7Dbl+vEQtOr9ebcSe3Egtj7nohWMspLXEZMPaa86Nru6Mg+YVcM9FtFubPavvai7lwgGV+8hK+pQVIoaq5cT2DKl/yYjO/3Ys3W+rRbBDlDz/GjXO+f1MLMhrgJ9jsj9d7S4A8a/RTpDt00C4Vnud5+Z+RVTpVB6WmfSr/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610476561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cIbTTFaWqBlw1RG7hwtN0wXtBq0CsVDSjfCtHIelito=; b=D5HpcGQX/WvXsgasWsVlYqvTzQRMIbbzJ+GSMrpuNhgRL0CqKSlW88EXZHWOy8XRa0RCskq4eQOQE3vhMxwHVJDiPV3M54Z2AYWv55h1sbpdVWI4Ix7+Qsnemf9ywKyt4GbJiwmxGlNRlqLCdPm2c9tU/K78dLear31C1owS7EE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mx.zohomail.com with SMTPS id 1610476561612457.42752293206934; Tue, 12 Jan 2021 10:36:01 -0800 (PST) Received: by mail-ed1-f52.google.com with SMTP id u19so3483327edx.2 for ; Tue, 12 Jan 2021 10:36:00 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190]) by smtp.gmail.com with ESMTPSA id x16sm1526282ejb.38.2021.01.12.10.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cIbTTFaWqBlw1RG7hwtN0wXtBq0CsVDSjfCtHIelito=; b=oa8ugs1bbQImjYGvzrrC9iWH7/IjBH8mPKKCZ8C05gGEOlFpRWPXcWH4bujSXJxR8L vfdcmn6vRw7g3PkYOqWmlzTbHMNuY1Ph7Irgfxri+atvvyZtQN/41RqW7jM5djB97iUw ir2MPcYNIOm8vAX8c5zUSTIwz5ikhwBjsvnKdgbCuC0y4NzD7nqrrEtLK84qtCfZ9Pyy d857Hx/cImqGReyN6V3IacfHN0VmVMQ+ng/9uFA/GNnDlGZU9qHodYNM8iiS86lZhSKa qFSarRoX10B9uNaB6TRZJbBqeVfKG70WV+My3vz1aGTACF3yp615ysOW/t8kmLyR+2WT c7/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cIbTTFaWqBlw1RG7hwtN0wXtBq0CsVDSjfCtHIelito=; b=mmFjpaOHNT5lqz4qcnAgvO2ROVlv4uRi/Za+a71tM9UZZoXqdDhPOB66U2BPSLdQDM suT89hAPOuKmCOnAuakW5HTMfHuMEjIgQvz286kCWVBUKkVPCThYexwd8KgEJYn30Z8B K+c5OyvX6HdU45ZQX4szpm11ATJwA0J8yyshhHgUU6rcbFOVgxFb8szKaFpUrE7VcS3i u/4ix3tBCq3Kz509+ueqBaSyF4tpO8m5d+UJEguEtgLAkfeWJW7DN+0VIesBcLX072nB p0si5kkpxV8dF93xy7T0sALohGPHcCqV5bWx82t13eLNfmGTPII9AbtiuXRg2QCQFYkb Jx9Q== X-Gm-Message-State: AOAM532ImF2lcZpOwzTetNFxBLdfIBp81BxYe1UQrfkJmiyvTrP7Qfpd wZa7eAK5mF4MnfturvYm/eY= X-Google-Smtp-Source: ABdhPJwXzxR76AAx/y9vRklqRXPWNY6DAT3STKdSWqBWNiTOJe5HoaMnC6gcmQVmIM/ugRNI5omFog== X-Received: by 2002:a50:f745:: with SMTP id j5mr384426edn.92.1610476559715; Tue, 12 Jan 2021 10:35:59 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Bin Meng , qemu-devel@nongnu.org, Bin Meng Cc: qemu-arm@nongnu.org, Jean-Christophe Dubois , Peter Maydell , Alistair Francis , Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v6 03/11] hw/ssi: imx_spi: Convert some debug printf()s to trace events Date: Tue, 12 Jan 2021 19:35:21 +0100 Message-Id: <20210112183529.2011863-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210112183529.2011863-1-f4bug@amsat.org> References: <20210112183529.2011863-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Convert some DPRINTF() to trace events. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Juan Quintela --- hw/ssi/imx_spi.c | 8 ++++---- hw/ssi/trace-events | 7 +++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index 40f72c36b61..35ab33c0511 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -14,6 +14,7 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "trace.h" =20 #ifndef DEBUG_IMX_SPI #define DEBUG_IMX_SPI 0 @@ -232,7 +233,7 @@ static void imx_spi_reset(DeviceState *dev) { IMXSPIState *s =3D IMX_SPI(dev); =20 - DPRINTF("\n"); + trace_imx_spi_reset(); =20 memset(s->regs, 0, sizeof(s->regs)); =20 @@ -290,7 +291,7 @@ static uint64_t imx_spi_read(void *opaque, hwaddr offse= t, unsigned size) break; } =20 - DPRINTF("reg[%s] =3D> 0x%" PRIx32 "\n", imx_spi_reg_name(index), value= ); + trace_imx_spi_read(index, imx_spi_reg_name(index), value); =20 imx_spi_update_irq(s); =20 @@ -310,8 +311,7 @@ static void imx_spi_write(void *opaque, hwaddr offset, = uint64_t value, return; } =20 - DPRINTF("reg[%s] <=3D 0x%" PRIx32 "\n", imx_spi_reg_name(index), - (uint32_t)value); + trace_imx_spi_write(index, imx_spi_reg_name(index), value); =20 change_mask =3D s->regs[index] ^ value; =20 diff --git a/hw/ssi/trace-events b/hw/ssi/trace-events index 612d3d6087a..20fcaf32df6 100644 --- a/hw/ssi/trace-events +++ b/hw/ssi/trace-events @@ -1,3 +1,5 @@ +# See docs/devel/tracing.txt for syntax documentation. + # aspeed_smc.c =20 aspeed_smc_flash_set_segment(int cs, uint64_t reg, uint64_t start, uint64_= t end) "CS%d segreg=3D0x%"PRIx64" [ 0x%"PRIx64" - 0x%"PRIx64" ]" @@ -10,6 +12,11 @@ aspeed_smc_dma_rw(const char *dir, uint32_t flash_addr, = uint32_t dram_addr, uint aspeed_smc_write(uint64_t addr, uint32_t size, uint64_t data) "@0x%" PRIx= 64 " size %u: 0x%" PRIx64 aspeed_smc_flash_select(int cs, const char *prefix) "CS%d %sselect" =20 +# imx_spi.c +imx_spi_reset(void) "" +imx_spi_read(uint32_t index, const char *name, uint32_t value) "index:%u (= %s) value:0x%08x" +imx_spi_write(uint32_t index, const char *name, uint32_t value) "index:%u = (%s) value:0x%08x" + # npcm7xx_fiu.c =20 npcm7xx_fiu_enter_reset(const char *id, int reset_type) "%s reset type: %d" --=20 2.26.2