From nobody Tue Feb 10 21:59:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.54 as permitted sender) client-ip=209.85.218.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610476550; cv=none; d=zohomail.com; s=zohoarc; b=ZtAgXjkuCZn49Um//a30QLaSuSt+FvzYcv2eeEmoZV3liYviMOvu32lH958r/gq3CB34Zm6Mh3t5gxCk9kiM2SV6gg3q+in6ooGWKhkrbICW/3v++NwqP6PJoEru4gNkKdNsSJiwRrNKBk4eudRTAgjNmAJv68Pxd46eSlkddCU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610476550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZanZiJ3tTZSMBujs+F1bLNbZeY/v2F63RmtFKqnRXj4=; b=ciT+Qh5G37HftX81DPXzWdCPxPt6iYFuW4yxVsAINjv1H922EQvOEye+Xrh8mVpyWNMoygH/kPyi3yRIfIzeZbxQJz8V2Gg8f6cC49gM2JjxB0YycMpzThyg0iCr20iebmLtOgFyOvsIL6dKWv0C3waXZLhPdn5NuqNsjtA/ATs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mx.zohomail.com with SMTPS id 1610476550616238.0912532256466; Tue, 12 Jan 2021 10:35:50 -0800 (PST) Received: by mail-ej1-f54.google.com with SMTP id t16so4872009ejf.13 for ; Tue, 12 Jan 2021 10:35:50 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190]) by smtp.gmail.com with ESMTPSA id qn4sm1510593ejb.50.2021.01.12.10.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZanZiJ3tTZSMBujs+F1bLNbZeY/v2F63RmtFKqnRXj4=; b=dUoqNviw/pjbxVL7TjynR6A/+y579dM8g8u+tMtPz5fQKSBztKWEBI65tCRom+hNZg oijQ3NMQuMtbqnWixlyHuKiXVl7ctkHdWR3mkl4limigjVmNPQ1dP+o+vCm4AINfqTFM OwoYnNBXYUKlO+HrMvdwAjHpZz1Elkn8zMkJ6WAWlEGb7xdQFaNSgC7Yj8fbGVxxnnl1 TEc9ZK4FVs8xRxYBHwAfRR1q3CFBWXKrDDJzdfKJ/2lQjsewJ9pha7GJi43E94CnBcyx ZChaVjTEoUy0Ujb/AcUHZlQS/vcw78KtaeViYaaO4Nyi1xYxK+L4wjGlks+Gns47KNo+ nbNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ZanZiJ3tTZSMBujs+F1bLNbZeY/v2F63RmtFKqnRXj4=; b=aaA2gka/aL8uSPaatZbAhfSsFPhb7v2sCtKFLL3ZFSXhd+3SdDOVnfip45VZVUswcI /mtxYj2KkQDgNK8owz+teP0Ndxn79ndVfIerSbRpBhi0+ocXwQOnJDXhUse/d0tsviOT 1pYK0SOKDNVp+auCNR2JB1SjhHwZ6V2yH5UF+VhMa+L4eR3Zg9CQVVCd2pFku/eOu435 Vy5s9EIpAZVYeLSZS6JnZTZirRKDPKl+y/mlBu2SuVt3Kd0d3xEdHRs3N6Ih80KCIHdc 36FNSHQ4o0PUBwyFKOYDs6ki6VMhK7NjDt0MzwJ93Gw0qEAWameqQpMIsRFCBrplywGX 4ANw== X-Gm-Message-State: AOAM530dcP3UD6bLOC/vaNsNSW4P7SrjH1DYB+J9D9KCroTUXOPT0L7j vvtLuSvQbapN2YOwenvkbSI= X-Google-Smtp-Source: ABdhPJysWxc+TAlm+ctgH1Xuw3U+dIcY2JoBnCZcJOfWq19ss3KHzzKDrTCH6LUMvGYcbq/pkumZmw== X-Received: by 2002:a17:906:653:: with SMTP id t19mr138235ejb.44.1610476548916; Tue, 12 Jan 2021 10:35:48 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Bin Meng , qemu-devel@nongnu.org, Bin Meng Cc: qemu-arm@nongnu.org, Jean-Christophe Dubois , Peter Maydell , Alistair Francis , Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v6 02/11] hw/ssi: imx_spi: Remove pointless variable initialization Date: Tue, 12 Jan 2021 19:35:20 +0100 Message-Id: <20210112183529.2011863-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210112183529.2011863-1-f4bug@amsat.org> References: <20210112183529.2011863-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) 'burst_length' is cleared in imx_spi_reset(), which is called after imx_spi_realize(). Remove the initialization to simplify. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Juan Quintela --- hw/ssi/imx_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index e605049a213..40f72c36b61 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -428,8 +428,6 @@ static void imx_spi_realize(DeviceState *dev, Error **e= rrp) sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->cs_lines[i]); } =20 - s->burst_length =3D 0; - fifo32_create(&s->tx_fifo, ECSPI_FIFO_SIZE); fifo32_create(&s->rx_fifo, ECSPI_FIFO_SIZE); } --=20 2.26.2