[PATCH v3 0/3] vnc: support some new extensions.

Gerd Hoffmann posted 3 patches 2 weeks, 1 day ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210112134120.2031837-1-kraxel@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc.h |  2 ++
ui/vnc.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++---------
2 files changed, 74 insertions(+), 13 deletions(-)

[PATCH v3 0/3] vnc: support some new extensions.

Posted by Gerd Hoffmann 2 weeks, 1 day ago
The rfb standard keeps envolving.  While the official spec is kind of
frozen since a decade or so the community maintains an updated version
of the spec at:
	https://github.com/rfbproto/rfbproto/

This series adds support for two new extensions from that spec: alpha
cursor and extended desktop resize.

alpha cursor allows a full alpha channel for the cursor image (unlike
the rich cursor extension which has only a bitmask for transparency).

extended desktop resize makes the desktop-resize work both ways, i.e. we
can not only signal guest display resolution changes to the vnc client
but also vnc client window size changes to the guest.

Tested with tigervnc.

Support for gtk-vnc is in progress.

v3:
 - dropped cursor patches (already merged).
 - fix client initialization (reply to update request not set encoding).

v2:
 - dropped qxl bits (will be a separate patch series).
 - use error codes for desktop resize responses.
 - little tweaks here and there.
 - pick up some review tags.

Gerd Hoffmann (3):
  vnc: move check into vnc_cursor_define
  vnc: move initialization to framebuffer_update_request
  vnc: add support for extended desktop resize

 ui/vnc.h |  2 ++
 ui/vnc.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++---------
 2 files changed, 74 insertions(+), 13 deletions(-)

-- 
2.29.2



Re: [PATCH v3 0/3] vnc: support some new extensions.

Posted by Daniel P. Berrangé 1 week, 6 days ago
On Tue, Jan 12, 2021 at 02:41:17PM +0100, Gerd Hoffmann wrote:
> The rfb standard keeps envolving.  While the official spec is kind of
> frozen since a decade or so the community maintains an updated version
> of the spec at:
> 	https://github.com/rfbproto/rfbproto/
> 
> This series adds support for two new extensions from that spec: alpha
> cursor and extended desktop resize.
> 
> alpha cursor allows a full alpha channel for the cursor image (unlike
> the rich cursor extension which has only a bitmask for transparency).
> 
> extended desktop resize makes the desktop-resize work both ways, i.e. we
> can not only signal guest display resolution changes to the vnc client
> but also vnc client window size changes to the guest.
> 
> Tested with tigervnc.
> 
> Support for gtk-vnc is in progress.

FWIW, basic support (ie no multi-head) is implemented and testable
via the examples/gvncviewer program in gtk-vnc.

virt-viewer/remote-viewer are still todo.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|