From nobody Tue Nov 18 10:37:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610451002; cv=none; d=zohomail.com; s=zohoarc; b=RqcdJ9dUA8Au7ucxxPs+dhfwkO+MH7RBJhXXnkSJjYZhR2oQGXht7LvFIKEemfH/vOA3q4ME1plAbcrai2nJb1bmrO9vvD7WZt8n2ILu7zPlZXt/3mCLaW2Jdm86LgQgy1SFA5Y0tGCdoiWkAlPLvzsncG8Gk3E2AcXN/0mNpLQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610451002; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=dRiaAu9hETYu/BXG8y6YWk/SYgh2bgnB6lVdCYZbJwU=; b=nQ+RMXmPCRs1DE5KjJ0efgzt1y0nS7CWX6CpII1TYRrfoPQ41e7mElXbHbC7wJ0YPXMPszf8uP5BUHDOJrR9gZ/ehlTY2pvKWKGUNv24KnnJ1uMAZei3MjzubYs67y0f/2p3yKJRHZn0ydQUxgu55S1vA939hkq/2kUOX06tpmA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1610451002246238.9917014354304; Tue, 12 Jan 2021 03:30:02 -0800 (PST) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-3-Qe8rZVsiN12gLazc0d2pmg-1; Tue, 12 Jan 2021 06:29:59 -0500 Received: by mail-wr1-f72.google.com with SMTP id r8so988988wro.22 for ; Tue, 12 Jan 2021 03:29:59 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (190.red-83-57-173.dynamicip.rima-tde.net. [83.57.173.190]) by smtp.gmail.com with ESMTPSA id j59sm5067392wrj.13.2021.01.12.03.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 03:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610451001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dRiaAu9hETYu/BXG8y6YWk/SYgh2bgnB6lVdCYZbJwU=; b=VzsycT9ig00Vh1e+Ax2bZpZAe0PtW2P1RCDsQU6/lbtJPTSFaueKM0vaDRCWRuE5XDRT4X hQMgxvDzqei2dD16LbasqmtLVx1m6J3Nwuz+kMqxq3d/jxl8mu9sORFDH8vybtqqBPJcYd R2zv+IpQzNSBjfx2ASfmWWwM6MU38ME= X-MC-Unique: Qe8rZVsiN12gLazc0d2pmg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dRiaAu9hETYu/BXG8y6YWk/SYgh2bgnB6lVdCYZbJwU=; b=Tzgm3Plt3PqjnRmkrGrgOxUObWu4g+kQ5OaH8VVLE8aSIg5YvI+LN9l1chlFU0fAEH Y7zvd64Ytc+FIdqFAjSU09CfANPjc/rCtUodljPRaimwYC3TpJlWYcaT5C9vbkrVw4/S f6MZ0Rnr2OES+wIz7c80Ug7ixEfRJcsjWpZ7u5X5Osk6X/UllB8k+tIjGHo3jsz1IOYB w2GSlNrbdrcpg9wnHFBKr76Llbj9mYFbk7d59XYGX6Kfkrgkgk4ekS0OP4mmRwxjYFhl z8XcuQuzQAikf9M6NEuFQlCyn/TMnQcnwEDWNR4LUTyQkNAn7PE58gnsl5+Gs3BFD+QH bGjA== X-Gm-Message-State: AOAM533Q7A/8Ov/n6pXbZMdCHu3sTiltbecRlpBuqDjERxGOzTHApQ2p SZlMOEYlpUhPOALHA6Mkix2ltX9r+g0MKhvOqblsUQ7O2Wv71vqUtOYxv22dQksDPukXleFdNXx z9VZYwSboFGMbmQ== X-Received: by 2002:adf:dc84:: with SMTP id r4mr3739691wrj.232.1610450998306; Tue, 12 Jan 2021 03:29:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxOCkOEWLUrR2VTOfh7upb+ZmDxb4KFoAyvMlLsnIrxZeGnKt4CZvlhL66lzNjHfSzeOppwvQ== X-Received: by 2002:adf:dc84:: with SMTP id r4mr3739671wrj.232.1610450998092; Tue, 12 Jan 2021 03:29:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, qemu-block@nongnu.org, John Snow , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/ide/ahci: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Date: Tue, 12 Jan 2021 12:29:55 +0100 Message-Id: <20210112112955.1849212-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Replace fprintf() calls by qemu_log_mask(LOG_GUEST_ERROR). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/ide/ahci.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 4b675b9cfd8..6d50482b8d1 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -465,8 +465,9 @@ static void ahci_mem_write(void *opaque, hwaddr addr, =20 /* Only aligned reads are allowed on AHCI */ if (addr & 3) { - fprintf(stderr, "ahci: Mis-aligned write to addr 0x" - TARGET_FMT_plx "\n", addr); + qemu_log_mask(LOG_GUEST_ERROR, + "ahci: Mis-aligned write to addr 0x%03" HWADDR_PRIX = "\n", + addr); return; } =20 @@ -1111,7 +1112,8 @@ static void process_ncq_command(AHCIState *s, int por= t, uint8_t *cmd_fis, g_assert(is_ncq(ncq_fis->command)); if (ncq_tfs->used) { /* error - already in use */ - fprintf(stderr, "%s: tag %d already used\n", __func__, tag); + qemu_log_mask(LOG_GUEST_ERROR, "%s: tag %d already used\n", + __func__, tag); return; } =20 --=20 2.26.2