From nobody Tue Nov 18 11:51:02 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1610449033; cv=none; d=zohomail.com; s=zohoarc; b=au1lzeUn6l5Y/YfK31cjmbdV43FlR7abJpPsucU1duDc0J753HJ6SHABHFPt4xYCgmKgWcrKOVVVAwzUp4ak383omp+roftYOxtzQx6ukEbg2vBD7WNbWUxpoXWiEt+9geYDbvy15J+mBVd1ejCd9qgnln4Eg+RUdxNTkNaZeZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610449033; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eUwr0wF5QJ3BMVheQlwi5UeXJ+8L31ajk/7WCn5BtK8=; b=AbFfCtOpx3NaMf0Xo+7s5Hxa01/zIqlUhnBed4RndZyIrQiGEq4lueg0UeabfIIyr3e5PwXjrxGgQXUYcSU0wwrbGF/Wt9w4VMehH+RsD96UeLSpQxoL1eQtSiWZIAQ6QgFfyZnnHwLxNZVLauaDDSl/NF1UJ72W9chFNB3C5Q0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610449033736736.1285410160984; Tue, 12 Jan 2021 02:57:13 -0800 (PST) Received: from localhost ([::1]:50628 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzHMO-00087l-Ki for importer@patchew.org; Tue, 12 Jan 2021 05:57:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzGnW-00062B-H5; Tue, 12 Jan 2021 05:21:10 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzGnU-0003PW-HI; Tue, 12 Jan 2021 05:21:10 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DFRQd0HYzz15pGV; Tue, 12 Jan 2021 18:19:53 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.498.0; Tue, 12 Jan 2021 18:20:45 +0800 From: Gan Qixin To: , Subject: [PATCH v2 1/2] pl031: Use timer_free() in the finalize function to avoid memleaks Date: Tue, 12 Jan 2021 18:17:45 +0800 Message-ID: <20210112101746.379517-2-ganqixin@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210112101746.379517-1-ganqixin@huawei.com> References: <20210112101746.379517-1-ganqixin@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=ganqixin@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Gan Qixin , Euler Robot , kuhn.chenqun@huawei.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When running device-introspect-test, a memory leak occurred in the pl031_in= it function, this patch use timer_free() in the finalize function to fix it. ASAN shows memory leak stack: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf5621cfc in timer_new_full qemu/include/qemu/timer.h:523 #3 0xaaabf5621cfc in timer_new qemu/include/qemu/timer.h:544 #4 0xaaabf5621cfc in timer_new_ns qemu/include/qemu/timer.h:562 #5 0xaaabf5621cfc in pl031_init qemu/hw/rtc/pl031.c:194 #6 0xaaabf6339f6c in object_initialize_with_type qemu/qom/object.c:515 #7 0xaaabf633a1e0 in object_new_with_type qemu/qom/object.c:729 #8 0xaaabf6375e40 in qmp_device_list_properties qemu/qom/qom-qmp-cmds.c= :153 #9 0xaaabf5a95540 in qdev_device_help qemu/softmmu/qdev-monitor.c:283 #10 0xaaabf5a96940 in qmp_device_add qemu/softmmu/qdev-monitor.c:801 #11 0xaaabf5a96e70 in hmp_device_add qemu/softmmu/qdev-monitor.c:916 #12 0xaaabf5ac0a2c in handle_hmp_command qemu/monitor/hmp.c:1100 Reported-by: Euler Robot Signed-off-by: Gan Qixin --- Cc: Peter Maydell --- hw/rtc/pl031.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/rtc/pl031.c b/hw/rtc/pl031.c index ae47f09635..f0981e6c21 100644 --- a/hw/rtc/pl031.c +++ b/hw/rtc/pl031.c @@ -194,6 +194,14 @@ static void pl031_init(Object *obj) s->timer =3D timer_new_ns(rtc_clock, pl031_interrupt, s); } =20 +static void pl031_finalize(Object *obj) +{ + PL031State *s =3D PL031(obj); + + timer_del(s->timer); + timer_free(s->timer); +} + static int pl031_pre_save(void *opaque) { PL031State *s =3D opaque; @@ -329,6 +337,7 @@ static const TypeInfo pl031_info =3D { .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(PL031State), .instance_init =3D pl031_init, + .instance_finalize =3D pl031_finalize, .class_init =3D pl031_class_init, }; =20 --=20 2.27.0