From nobody Tue Nov 18 10:40:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=bytedance.com ARC-Seal: i=1; a=rsa-sha256; t=1610437918; cv=none; d=zohomail.com; s=zohoarc; b=OtWrUxSgG9a+escPRqKi01fGwvYgLUuPahUtt84IDM5Lg5bnAOT8XVgfGWPAxle41nycPbrJP8MpROrMlsv0afoRfHaWqDE4OCiHE0mwdczuXhZ6tPVxOCBbPpIwDKNuGbc3baTZoiLGBbU0LcLgoJ9GrF0rW7tL0BXoNREKuNU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610437918; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iirlCwjvMpIb0qx3Fc7xuD+1vEwlFlrqkaNXF92YMa0=; b=CkOaEDjvNSg6I55iJxDW/d+xYGxTdCEonoaQd6FczzTGjcEQyolrDYycMG12jCnH9ZJQzs/eOyI6WVR/djYIGqbekBeyygTB+Vs0YcqtMY4cuAuu3pZhMuiZiG7LJN9P8hTMAk3DeT7QuBvfF0MgAdUEtsbe+3jC5tSMWEzucFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161043791819743.23983814776318; Mon, 11 Jan 2021 23:51:58 -0800 (PST) Received: from localhost ([::1]:39372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzET4-000317-EI for importer@patchew.org; Tue, 12 Jan 2021 02:51:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzEQu-0001bV-HV for qemu-devel@nongnu.org; Tue, 12 Jan 2021 02:49:40 -0500 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:38807) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzEQs-0002iR-7N for qemu-devel@nongnu.org; Tue, 12 Jan 2021 02:49:40 -0500 Received: by mail-pl1-x630.google.com with SMTP id d4so153058plh.5 for ; Mon, 11 Jan 2021 23:49:37 -0800 (PST) Received: from always-libai.bytedance.net ([61.120.150.71]) by smtp.gmail.com with ESMTPSA id 193sm2144582pfz.36.2021.01.11.23.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 23:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iirlCwjvMpIb0qx3Fc7xuD+1vEwlFlrqkaNXF92YMa0=; b=oX2Gy+uvi+Nrj+umcySclfD4OBg9Jrd0E+yXJNzV+859hmxGwN++k5T+RioPCstfBp J830gXPkbV2wVFUul4YMBtUwQUQCBbVGW59BMqU0XJeLNAgGvF2SV8bbE/sGaKJAGFBQ 9kR8Cdr+nCjdPLy1up/JXwCpJi9du8kG9Uf1NiRtuOP9JzPez9wXqIRbreLRY7kkVHRe xV+1OZLdJTlQGtCG5Q0kADtfrVGbwK65NyeD0roLhvOD79odCS9kzVtuaKXofMFj8GeK OIcoXQiCBrE3RFzckLsGC2bpcbAsPqAMj61OZ8wxM7frueSlU+6IUChJSFfoRtmL+neH y0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iirlCwjvMpIb0qx3Fc7xuD+1vEwlFlrqkaNXF92YMa0=; b=tat54Vpcnvn2YIG3koPYD+D11Ysh3fO6BjDTzsnMPbjrfmVdfX3l/2gOI/mPdzoJzo 7d/gMUBy1ZYIdcFtofsiHfxFCYciQWWjpgYPHHTzr4qbEgjPCaplC6KJOqEYM9o0RUhR n2/f3D11p6P10YKeW1zLwp5C+uI4bdvI3RxPXLtUFsnMSiyd3tBf4NiH9i8upJX76DDl LK0gXT0vJefpwGv7SvDRb3I+TuPSzwtNIBJ2gxkcXz+FmLbn5fe/Tp3t4hAmUTn+uURt OXCWCOepKA8mqyZzNB/yORYM4KA6dowEPgnDERbLGUFx2pN6CohAKLys5qXDc6Re3Jug ve5g== X-Gm-Message-State: AOAM530Pzs8Dq8S2F4FfpXJSacHavk7OYuMAZInKKI1TdwUgDNXNeuu0 eJW6HIol6hA4NEJmTzBd1wvVQw== X-Google-Smtp-Source: ABdhPJzp3WHv16M66FQLbiYhoY6eE4bCNnw0B9+wBsDlYpEjBEW+GP5k7iuIxfyayGkYOp4KkWKfhw== X-Received: by 2002:a17:90a:66ce:: with SMTP id z14mr3204107pjl.153.1610437776950; Mon, 11 Jan 2021 23:49:36 -0800 (PST) From: zhenwei pi To: kbusch@kernel.org, its@irrelevant.dk, kwolf@redhat.com, mreitz@redhat.com Subject: [PATCH v2 1/1] hw/block/nvme: add smart_critical_warning property Date: Tue, 12 Jan 2021 15:49:24 +0800 Message-Id: <20210112074924.217862-2-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210112074924.217862-1-pizhenwei@bytedance.com> References: <20210112074924.217862-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=pizhenwei@bytedance.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhenwei pi , philmd@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" There is a very low probability that hitting physical NVMe disk hardware critical warning case, it's hard to write & test a monitor agent service. For debugging purposes, add a new 'smart_critical_warning' property to emulate this situation. The orignal version of this change is implemented by adding a fixed property which could be initialized by QEMU command line. Suggested by Philippe & Klaus, rework like current version. Test with this patch: 1, change smart_critical_warning property for a running VM: #virsh qemu-monitor-command nvme-upstream '{ "execute": "qom-set", "arguments": { "path": "/machine/peripheral-anon/device[0]", "property": "smart_critical_warning", "value":16 } }' 2, run smartctl in guest #smartctl -H -l error /dev/nvme0n1 =3D=3D=3D START OF SMART DATA SECTION =3D=3D=3D SMART overall-health self-assessment test result: FAILED! - volatile memory backup device has failed Signed-off-by: zhenwei pi --- hw/block/nvme.c | 28 ++++++++++++++++++++++++++++ hw/block/nvme.h | 1 + 2 files changed, 29 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 27d2c72716..a98757b6a1 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1214,6 +1214,7 @@ static uint16_t nvme_smart_info(NvmeCtrl *n, uint8_t = rae, uint32_t buf_len, } =20 trans_len =3D MIN(sizeof(smart) - off, buf_len); + smart.critical_warning =3D n->smart_critical_warning; =20 smart.data_units_read[0] =3D cpu_to_le64(DIV_ROUND_UP(stats.units_read, 1000)); @@ -2827,6 +2828,29 @@ static Property nvme_props[] =3D { DEFINE_PROP_END_OF_LIST(), }; =20 + +static void nvme_get_smart_warning(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) +{ + NvmeCtrl *s =3D NVME(obj); + uint8_t value =3D s->smart_critical_warning; + + visit_type_uint8(v, name, &value, errp); +} + +static void nvme_set_smart_warning(Object *obj, Visitor *v, const char *na= me, + void *opaque, Error **errp) +{ + NvmeCtrl *s =3D NVME(obj); + uint8_t value; + + if (!visit_type_uint8(v, name, &value, errp)) { + return; + } + + s->smart_critical_warning =3D value; +} + static const VMStateDescription nvme_vmstate =3D { .name =3D "nvme", .unmigratable =3D 1, @@ -2857,6 +2881,10 @@ static void nvme_instance_init(Object *obj) "bootindex", "/namespace@1,0", DEVICE(obj)); } + + object_property_add(obj, "smart_critical_warning", "uint8", + nvme_get_smart_warning, + nvme_set_smart_warning, NULL, NULL); } =20 static const TypeInfo nvme_info =3D { diff --git a/hw/block/nvme.h b/hw/block/nvme.h index e080a2318a..64e3497244 100644 --- a/hw/block/nvme.h +++ b/hw/block/nvme.h @@ -139,6 +139,7 @@ typedef struct NvmeCtrl { uint64_t timestamp_set_qemu_clock_ms; /* QEMU clock time */ uint64_t starttime_ms; uint16_t temperature; + uint8_t smart_critical_warning; =20 HostMemoryBackend *pmrdev; =20 --=20 2.25.1