From nobody Tue Nov 18 11:51:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1610406802; cv=none; d=zohomail.com; s=zohoarc; b=AguJki/R2fKOQzDWtf4r18WO02GfklWlk8znzPygBpSRTbi8y9WtcJmFm/dq11Il6uQClspNsMNwQpmLkTGrZwhx8Enu5yfpSMiwbpBxAIF5vnjYdUIBVxi7++QgqPUai259iBHnkn4xlonC34cF7oxj7THymwxoAlfJDUd7jb4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610406802; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uSqBlmmaV2nVJPAfpMvtZ9TuNPcVPPBGEyURqCr9eR8=; b=YjmWPGzc55FNNFPj1/ePXeOiMt9GC7UQpt9U2OV9oek9bVo798Zi7yY/9RHMqjZ3DgdRGPfPhXMy3SDlYobLPhBhfH0jDNAehoN6JvlImlJcy3DiCohAhgAva/4+KWkWlvAtC/Epy6JXhmw4UgaQM403sFOu270Hnnt70uED8C8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610406802637782.7058590490835; Mon, 11 Jan 2021 15:13:22 -0800 (PST) Received: from localhost ([::1]:49534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz6NF-0006a2-2s for importer@patchew.org; Mon, 11 Jan 2021 18:13:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz6LL-0004gE-5c for qemu-devel@nongnu.org; Mon, 11 Jan 2021 18:11:23 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:33312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kz6LG-0006Ck-Rc for qemu-devel@nongnu.org; Mon, 11 Jan 2021 18:11:22 -0500 Received: by mail-pj1-x102e.google.com with SMTP id w1so612265pjc.0 for ; Mon, 11 Jan 2021 15:11:18 -0800 (PST) Received: from localhost.localdomain (rrcs-173-197-107-21.west.biz.rr.com. [173.197.107.21]) by smtp.gmail.com with ESMTPSA id g202sm658105pfb.196.2021.01.11.15.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 15:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uSqBlmmaV2nVJPAfpMvtZ9TuNPcVPPBGEyURqCr9eR8=; b=LoZfIxoD7Nz1tDre55zbWQu0XPFcB8AXj6EfmE950Jsx0jdtFtFVexhVD2cFyLyRYH vFOAjSmRX1AhFRNCVURM1mU5FsQ4OMZyDRVj1sR9Rs6cY2S+WwXVZR2OIzwkncgxF14u 96y8wWqLUYYV8N/Bw182BX8p08yjRnYYi1eGN8j4oQAp603PSZVr4aiIHyA9HmduQrnk YmKnFOuOa2jCtXCxQYjBHPNmuM7bZx0Ue+uPi8I4Bay6tasdvjTPK/LELM16OaOTQbn4 MS7RxXO3uE9swpV03k5g/C6jA6bxhVfCKh3JHeW+aUFO2Pnpmi1KfnHyaNYoiJq2pWB1 02PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uSqBlmmaV2nVJPAfpMvtZ9TuNPcVPPBGEyURqCr9eR8=; b=dcrkXo0HkPzK17LUlZSzFE8LtmBxgbiU9Io1ytnS0kAJSMUqLHX9OX+6FkNwDxuzdF Ko/1fsK1UOEiZr/uDihOKe1ul8iRIBTpvMhQM/xYW1CJWNeKCPBo0/9ALnrb/apZatiP WUpwwkA7pOV4cHNxL8ZmLLiAdighNs388GU0mXe5gTJhDnT1I6bKhGUdShMtgF6Nx/et x67GrUnrP3eu6nwdA/LFJgq3RTATbtKpBc8y7Ae/8BHyQX5ixdIqYnX0fyfHSwAW8Iaf BoIV9ROF8NayMIUGx7mCxNFbjTSb8z519CwHOBaifu4ykWWLuKwegI9xxFOZN7s99jQv c1Ug== X-Gm-Message-State: AOAM530S5SnT5wJyyR9y1HQU6dDMMF02a59KG0mxIeYzB6cSHtifl1hi LNepkYnbNt+Vf/S7q0+HNmJtAPlp4pXRnA== X-Google-Smtp-Source: ABdhPJy+cJglhwlafMvPRB6kj4gljIHPPNJXWsRCX5HZZsfXp/Hk9kc7ddJNQhSL4bPHd5g7gpF66A== X-Received: by 2002:a17:90a:c082:: with SMTP id o2mr1211934pjs.197.1610406677218; Mon, 11 Jan 2021 15:11:17 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v6 3/3] target/arm: Use object_property_add_bool for "sve" property Date: Mon, 11 Jan 2021 13:11:08 -1000 Message-Id: <20210111231108.461088-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210111231108.461088-1-richard.henderson@linaro.org> References: <20210111231108.461088-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Andrew Jones , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The interface for object_property_add_bool is simpler, making the code easier to understand. Reviewed-by: Andrew Jones Signed-off-by: Richard Henderson --- target/arm/cpu64.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index d9feaa9cdb..8e1fad00bb 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -488,6 +488,12 @@ static void cpu_max_set_sve_max_vq(Object *obj, Visito= r *v, const char *name, cpu->sve_max_vq =3D max_vq; } =20 +/* + * Note that cpu_arm_get/set_sve_vq cannot use the simpler + * object_property_add_bool interface because they make use + * of the contents of "name" to determine which bit on which + * to operate. + */ static void cpu_arm_get_sve_vq(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { @@ -529,26 +535,17 @@ static void cpu_arm_set_sve_vq(Object *obj, Visitor *= v, const char *name, set_bit(vq - 1, cpu->sve_vq_init); } =20 -static void cpu_arm_get_sve(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) +static bool cpu_arm_get_sve(Object *obj, Error **errp) { ARMCPU *cpu =3D ARM_CPU(obj); - bool value =3D cpu_isar_feature(aa64_sve, cpu); - - visit_type_bool(v, name, &value, errp); + return cpu_isar_feature(aa64_sve, cpu); } =20 -static void cpu_arm_set_sve(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) +static void cpu_arm_set_sve(Object *obj, bool value, Error **errp) { ARMCPU *cpu =3D ARM_CPU(obj); - bool value; uint64_t t; =20 - if (!visit_type_bool(v, name, &value, errp)) { - return; - } - if (value && kvm_enabled() && !kvm_arm_sve_supported()) { error_setg(errp, "'sve' feature not supported by KVM on this host"= ); return; @@ -563,8 +560,7 @@ void aarch64_add_sve_properties(Object *obj) { uint32_t vq; =20 - object_property_add(obj, "sve", "bool", cpu_arm_get_sve, - cpu_arm_set_sve, NULL, NULL); + object_property_add_bool(obj, "sve", cpu_arm_get_sve, cpu_arm_set_sve); =20 for (vq =3D 1; vq <=3D ARM_MAX_VQ; ++vq) { char name[8]; --=20 2.25.1