From nobody Mon Feb 9 01:16:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1610383326; cv=none; d=zohomail.com; s=zohoarc; b=PqDTSJn6fV8KietIMpNfuc3K1bCsNU8WZI8+Cr5NSOCX7K6d5aO+uxaydtdYATHFVoLWFIRBldp+fkEfj1zXi+mn2n/3a5p0m+8xshSGT1l+p/bHWSg7n6XpHovv9lDovQnY34gUqasaX7FsgUVxCjhKiGpgvoN9690wey1u4gU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610383326; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UNX38AuloCa9Rt+ZF43j1K4sgMxXKCpz7PBSU7u0cnE=; b=a7fWqTGP7gyFJpnHnk2xM7frdVJt283pxRuuzPDVu4sK0UOPqggqGVXAQ/lyPQI63ePvJ6A63IoXONnIYLR8329I3EDf7rG18bggPI1ujh917U5TA92z/G1fbCKELRjRlF7/RzhYd1CL2peGXWi6rxzg5Ejc1i2PALnLHrFRp8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1610383326316644.8299129906936; Mon, 11 Jan 2021 08:42:06 -0800 (PST) Received: from localhost ([::1]:35056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kz0Gb-0000tX-4D for importer@patchew.org; Mon, 11 Jan 2021 11:42:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kz0Dm-0005gF-6w for qemu-devel@nongnu.org; Mon, 11 Jan 2021 11:39:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kz0Dk-0000Z4-IE for qemu-devel@nongnu.org; Mon, 11 Jan 2021 11:39:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-4mz3iwFQO4mqri8LxevXkA-1; Mon, 11 Jan 2021 11:39:06 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19C08803628; Mon, 11 Jan 2021 16:39:05 +0000 (UTC) Received: from t480s.redhat.com (ovpn-115-103.ams2.redhat.com [10.36.115.103]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64EB01971A; Mon, 11 Jan 2021 16:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610383147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNX38AuloCa9Rt+ZF43j1K4sgMxXKCpz7PBSU7u0cnE=; b=b/dB2oj7hyKIO3qm6jgKGIm62WASVFsi1F4iseiHwxAcjb0iLO5F3OZ9DZMDzENifwqGBg zaN59DiVCe8CjF6Cu9S/mQvrRKn7RyUINrkPsJz7019rEMmTAQg/weZovdk6IzXWdy8g61 rgIgKNyS8ZUfUhyWRAhaDYHY9QEeyuQ= X-MC-Unique: 4mz3iwFQO4mqri8LxevXkA-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v3 5/5] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE Date: Mon, 11 Jan 2021 17:38:45 +0100 Message-Id: <20210111163845.18148-6-david@redhat.com> In-Reply-To: <20210111163845.18148-1-david@redhat.com> References: <20210111163845.18148-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , David Hildenbrand , Richard Henderson , Cornelia Huck , Nick Desaulniers , qemu-s390x@nongnu.org, Guenter Roeck Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In our EXECUTE fast path, we have to ignore the content of r0, if specified by b1 or b2. Fixes: d376f123c7de ("target/s390x: Re-implement a few EXECUTE target insns= directly") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Tested-by: Nick Desaulniers Tested-by: Guenter Roeck Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 0108611cc9..1901e9dfc7 100644 --- a/target/s390x/mem_helper.c +++ b/target/s390x/mem_helper.c @@ -2473,8 +2473,8 @@ void HELPER(ex)(CPUS390XState *env, uint32_t ilen, ui= nt64_t r1, uint64_t addr) uint32_t d1 =3D extract64(insn, 32, 12); uint32_t b2 =3D extract64(insn, 28, 4); uint32_t d2 =3D extract64(insn, 16, 12); - uint64_t a1 =3D wrap_address(env, env->regs[b1] + d1); - uint64_t a2 =3D wrap_address(env, env->regs[b2] + d2); + uint64_t a1 =3D wrap_address(env, (b1 ? env->regs[b1] : 0) + d= 1); + uint64_t a2 =3D wrap_address(env, (b2 ? env->regs[b2] : 0) + d= 2); =20 env->cc_op =3D helper(env, l, a1, a2, 0); env->psw.addr +=3D ilen; --=20 2.29.2