From nobody Tue Feb 10 03:38:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1610058502; cv=none; d=zohomail.com; s=zohoarc; b=USQoqWKwR6hcMqknK4BZrg/R718/nt8yL0BoUTQbymW9TDnugIij8dp6eZRNCw8WfoXlguDvCG94YfnJLwEVtnC0r5o0+OCSHASbp7m6ea3GeOl2cIIiJV1MYzwfhjUrU0sqgTaSp7uVHiA+Twst1P1MNiPmCa9NNiRz+cHWMgQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610058502; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ADeLjBIuNm8Db2lkSUMCJRDAVngCOHiUxA4Y6spWn0I=; b=F7ksxz1X2Ao+4Y/htC+flE4ZXQSS6qaSP6yk7GfaniosBNTzko1OJFO8rrRMosJuikzTAUQkMq4cK465RkqCtb1jOdaIdL9X9q3HaLZVrIwyY1QXPLxmR6a2z2w1dodyqaWL6nMTOKs0RvM8KLGZssD2yjg8rnN94fI58JsAggI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 16100585024221023.3668910212217; Thu, 7 Jan 2021 14:28:22 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id c5so7112680wrp.6 for ; Thu, 07 Jan 2021 14:28:21 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (241.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.241]) by smtp.gmail.com with ESMTPSA id m17sm11788101wrn.0.2021.01.07.14.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 14:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ADeLjBIuNm8Db2lkSUMCJRDAVngCOHiUxA4Y6spWn0I=; b=DsPiUBFgZubvxf2GePgfLlQAvIsVAdsSz4Pr9D3xFLnGnAV6kscnE/yLi/H5oybGLJ lf6RlFYc8SoacNkGAukiY77zsn/ei6qXWVMzAh0raYVJ+BZGXSc3gX+fw1NAah1cI+zw 8PgNNKqAdzIlWOklbEDv9+ZAVUtEE4XqP6XZUxNg7IYik2MvFnSkGbKXZH2iCmoneHUa wUTrY0iosyh0IdFd1OolVkHkDYyuWJHnSG47p28Wsmkh7VI+05X3pkbvPLTWqeme9Ypg IddKtUBE2yWH2SK57efV4dnc4mdZxos5u/NcrMP1Z8oJkPnAuAvXAt7NCZK8CIzc4U2w CjKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ADeLjBIuNm8Db2lkSUMCJRDAVngCOHiUxA4Y6spWn0I=; b=akuOJyyeVgFbuKDH+dhSGFmQqnvYHp2UvEC6i/VF35b1ewbxohc2vDNKOpuyDSEBio hVOztnBs5djVpULYnkQ6m4naxnczlEpXsFq4PDeE0KjISNXrzbNywgUem8YQNQDFRDAh AGMvAlMm8/gJ043VQjlFrcz55HAsr6teld/Axt/w08/55oYk0LDOKmsfhrz26A3m2cMs SzQTghHaGh5/GVacgn183u2NwS1vz7K5zqTNEsu95QH4j0yTHAzMxCLBLPZ//fLpPR5C Utvk799jttFF3DYaOl2BTxTwC6zS7W6JsJkme2oX9GeJ9L6hgU8WgQGBJ/8dDPB92lT4 Cu+w== X-Gm-Message-State: AOAM532aWOFnwdb7lLx4jjRd6E/B+qZYdjbnbmojT5CsYr97dc5cEy+u 3qUfubplD5IuTncr4MZVj8w= X-Google-Smtp-Source: ABdhPJwmwG+IOuURAtgZfJZeyY0mGhHbK6Zox4gOBAU8vjb6V2st3D0j0ccmQnWMvuf9SjqNPgJ4VQ== X-Received: by 2002:a5d:684b:: with SMTP id o11mr667739wrw.157.1610058500527; Thu, 07 Jan 2021 14:28:20 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Paolo Bonzini , Laurent Vivier , kvm@vger.kernel.org, Jiaxun Yang , Aurelien Jarno , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Paul Burton , Richard Henderson Subject: [PULL 63/66] target/mips: Convert Rel6 LDL/LDR/SDL/SDR opcodes to decodetree Date: Thu, 7 Jan 2021 23:22:50 +0100 Message-Id: <20210107222253.20382-64-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210107222253.20382-1-f4bug@amsat.org> References: <20210107222253.20382-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) LDL/LDR/SDL/SDR opcodes have been removed from the Release 6. Add a single decodetree entry for the opcodes, triggering Reserved Instruction if ever used. Remove unreachable check_insn_opc_removed() calls. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201208203704.243704-12-f4bug@amsat.org> --- target/mips/mips64r6.decode | 6 ++++++ target/mips/translate.c | 5 +---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/target/mips/mips64r6.decode b/target/mips/mips64r6.decode index e812224341e..8c3fc5dae9c 100644 --- a/target/mips/mips64r6.decode +++ b/target/mips/mips64r6.decode @@ -10,8 +10,14 @@ # (Document Number: MD00087-2B-MIPS64BIS-AFP-6.06) # =20 +&REMOVED !extern &lsa rd rt rs sa !extern =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &lsa =20 DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa + +REMOVED 011010 ----- ----- ---------------- # LDL +REMOVED 011011 ----- ----- ---------------- # LDR +REMOVED 101100 ----- ----- ---------------- # SDL +REMOVED 101101 ----- ----- ---------------- # SDR diff --git a/target/mips/translate.c b/target/mips/translate.c index 73efbd24585..f46d7c5f80b 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28871,11 +28871,10 @@ static bool decode_opc_legacy(CPUMIPSState *env, = DisasContext *ctx) if (ctx->insn_flags & INSN_R5900) { check_insn_opc_user_only(ctx, INSN_R5900); } + check_insn_opc_removed(ctx, ISA_MIPS_R6); /* fall through */ case OPC_LDL: case OPC_LDR: - check_insn_opc_removed(ctx, ISA_MIPS_R6); - /* fall through */ case OPC_LWU: case OPC_LD: check_insn(ctx, ISA_MIPS3); @@ -28884,8 +28883,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, Di= sasContext *ctx) break; case OPC_SDL: case OPC_SDR: - check_insn_opc_removed(ctx, ISA_MIPS_R6); - /* fall through */ case OPC_SD: check_insn(ctx, ISA_MIPS3); check_mips_64(ctx); --=20 2.26.2