From nobody Tue Feb 10 03:38:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) client-ip=209.85.128.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610058441; cv=none; d=zohomail.com; s=zohoarc; b=B28DVI3FmxdjTPgclc6EYfxQAI81DDrUE6/asXA2Ry9Zpft0gB/s+TjIrcaselXPnkio1EjZGI6r5OQmixL1WLvQutX3dPwJgIxZpZYXHmgh7oV0ohJrjOGTVevpl71DJQu0Nir8JupFR71FWqIt3t8ywtliIejGz6nTAxXDIn4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610058441; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rBzgLDqqE9tlixFb1w2Ems4Ej+21PfOS0dtp5Xnk1qE=; b=Vco/XXdTRnX9I6rIj/qF/k4OAkk/IzevLXCktUUXI6ueWQS8EQ6M/jMsJRK3KL7/MMF2gxtLBaBEbxk5jGs4me+ZcYY7N8E+pKko3XvUKA95Ptim/fSe24SO13N7+AwlmB8HA+kv7RwU28Eq35PHpsV1++T8SSKDNXjbnUfaaKA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.zohomail.com with SMTPS id 1610058441424728.3747138139646; Thu, 7 Jan 2021 14:27:21 -0800 (PST) Received: by mail-wm1-f48.google.com with SMTP id g185so6834742wmf.3 for ; Thu, 07 Jan 2021 14:27:20 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (241.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.241]) by smtp.gmail.com with ESMTPSA id f77sm9367016wmf.42.2021.01.07.14.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 14:27:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rBzgLDqqE9tlixFb1w2Ems4Ej+21PfOS0dtp5Xnk1qE=; b=XbMQJGvj/ERQdAoqFOepJIDBJBm4DPyk7iHUwRpA3fFh+5xFh/FO+wULHMhIpPtpVU H1Ylr0RRBgLph1HF5h/zyUPw5cfKvJqceiULQvPmTTiey43fJhlF+sNyMcEUZ46prG92 QN+7j0zYlZTGJQO7doASweklnwwodL8ol0ZvtJNl6NxddseLXLPtrisuM/epcYJPLxrZ oewa1iIHa+nYlvFTn8ciNS2ZrXFMHkVnyidP2Zk+sYiFtpbJhrX5PfRQ9wHPF0xwV7Uv T2Rkjd7GhvS6ELbcbPEI/+4VwMqO5BPVJMyCbz6WWXRLJ40zDb1ERjkeg9hYrlL1hGeC TTYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rBzgLDqqE9tlixFb1w2Ems4Ej+21PfOS0dtp5Xnk1qE=; b=OfyACNbVQj+uxqVVqZ1J0OLYM1wbur/UprKvMmWZp7ccE144DfOJUFBdDcYkBB2FRx YoDcQoDCkQJ5j0GfLnPrDNA+jRB68U5pLVDrFqEIsWiUTDmxgBdHXHnh6SVZR6OyTik6 uxZTUwFaJ+p+h6Cu4ICR+U3jVZ03g0douXtu/Sd5mq8exZ8EuVlYuyUTkg7tG3Bg7Of4 s5+ool2OXxCkLUAvHDIaU/LF9EVuBHM/1tta4JBioUTZZnJuH2sEA5R56QJJqwqT5Z4K m2i/JLyWVCFvEtYdY0HKb/ZRs3wekeM+w7DS70H/gPaHi5vaHYVJ52q9iV+KAyzCHmbS 4lEA== X-Gm-Message-State: AOAM5330HRgKuFJ4/Hy9X9alpTgLXd3sz7IGrKdo4zH0ZV2txgDO2YAt KKhQX2Xngry99Z5VHHIhoP8= X-Google-Smtp-Source: ABdhPJz3cwRLw1uViG9szTaeR7d2mfQE7xcFc/rcQiEksAumr9lADebyUs4v2fikkm9QTzErOR897w== X-Received: by 2002:a1c:4645:: with SMTP id t66mr510210wma.152.1610058439578; Thu, 07 Jan 2021 14:27:19 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Paolo Bonzini , Laurent Vivier , kvm@vger.kernel.org, Jiaxun Yang , Aurelien Jarno , Huacai Chen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Paul Burton , Richard Henderson Subject: [PULL 51/66] target/mips: Pass TCGCond argument to MSA gen_check_zero_element() Date: Thu, 7 Jan 2021 23:22:38 +0100 Message-Id: <20210107222253.20382-52-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210107222253.20382-1-f4bug@amsat.org> References: <20210107222253.20382-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Simplify gen_check_zero_element() by passing the TCGCond argument along. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20201215225757.764263-25-f4bug@amsat.org> --- target/mips/msa_translate.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/target/mips/msa_translate.c b/target/mips/msa_translate.c index a4f9a6c1285..52bd428759a 100644 --- a/target/mips/msa_translate.c +++ b/target/mips/msa_translate.c @@ -304,7 +304,8 @@ static inline int check_msa_access(DisasContext *ctx) return 1; } =20 -static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt) +static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, + TCGCond cond) { /* generates tcg ops to check if any element is 0 */ /* Note this function only works with MSA_WRLEN =3D 128 */ @@ -339,7 +340,7 @@ static void gen_check_zero_element(TCGv tresult, uint8_= t df, uint8_t wt) tcg_gen_or_i64(t0, t0, t1); /* if all bits are zero then all elements are not zero */ /* if some bit is non-zero then some element is zero */ - tcg_gen_setcondi_i64(TCG_COND_NE, t0, t0, 0); + tcg_gen_setcondi_i64(cond, t0, t0, 0); tcg_gen_trunc_i64_tl(tresult, t0); tcg_temp_free_i64(t0); tcg_temp_free_i64(t1); @@ -378,10 +379,7 @@ static bool gen_msa_BxZ(DisasContext *ctx, int df, int= wt, int s16, bool if_not) return true; } =20 - gen_check_zero_element(bcond, df, wt); - if (if_not) { - tcg_gen_setcondi_tl(TCG_COND_EQ, bcond, bcond, 0); - } + gen_check_zero_element(bcond, df, wt, if_not ? TCG_COND_EQ : TCG_COND_= NE); =20 ctx->btarget =3D ctx->base.pc_next + (s16 << 2) + 4; ctx->hflags |=3D MIPS_HFLAG_BC; --=20 2.26.2