From nobody Tue Nov 18 09:18:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yadro.com ARC-Seal: i=1; a=rsa-sha256; t=1609600498; cv=none; d=zohomail.com; s=zohoarc; b=anm74GZquVsGMhC8q0sognhpikZXtHmcAjA+B6K17fghJTCTTZ1YA95geXkIpAb5H9MICa1ofPQ+MJlwMKSK5NXsiOOfhFHwp7hXLXbGVBXCAful5hiKRHiUNnEsBxlohDBefSkg9ifUtkBzJzkiu6mb76PU0vBZGklfYIS6Lxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609600498; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=US/Gg+joCs3dkZs7NKC/aId12fkcDwMqWt+mGbx9OiA=; b=UwkPO0eW8DZFDsHzyhu9uEnDtdCL5FJj6V6b0RLpHuLQ4lmGz/eUyTSSZa/G9LfJH+FeqJo6AHp/kI+p8yJJ66SeBYOGCO9DyvDoQukm8d/yd/Ybo3jCm7gRqU3zgMfIuL7zFH8TBvtOCqyB1WQibFrX2IMpae1tSNTZaissNIs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609600498565953.4132577894251; Sat, 2 Jan 2021 07:14:58 -0800 (PST) Received: from localhost ([::1]:33528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvicK-0006Sn-W4 for importer@patchew.org; Sat, 02 Jan 2021 10:14:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvibh-00062h-J4 for qemu-devel@nongnu.org; Sat, 02 Jan 2021 10:14:17 -0500 Received: from mta-02.yadro.com ([89.207.88.252]:44082 helo=mta-01.yadro.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvibf-0006MD-O2 for qemu-devel@nongnu.org; Sat, 02 Jan 2021 10:14:17 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 80DDF412FD; Sat, 2 Jan 2021 15:14:13 +0000 (UTC) Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t1upiqZZRh-G; Sat, 2 Jan 2021 18:14:12 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 0D1B241281; Sat, 2 Jan 2021 18:14:11 +0300 (MSK) Received: from localhost (172.17.204.212) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Sat, 2 Jan 2021 18:14:11 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mta-01; t=1609600452; x= 1611414853; bh=6VC+20pFRfr229zX6ogdC9BeDocARBwVHtqonjdNkh8=; b=b PXELUqbKczN6mjq6wAAmH4vVF4U8aPZAPQgTw2/UT2eqUTFk0FDJGRDw4msCtbZ9 B+16m7r+hxnwfZBAUJAuxPNHHgSCKT2vIBcqOAzDylVJCFzu+q0i+F27JonLC59y QvFZxUMf6nkQP3beQtuUrX4GRBrfuooqAeb+DmG2cs= X-Virus-Scanned: amavisd-new at yadro.com From: Roman Bolshakov To: Subject: [PATCH v2] ui/cocoa: Fix openFile: deprecation on Big Sur Date: Sat, 2 Jan 2021 18:07:21 +0300 Message-ID: <20210102150718.47618-1-r.bolshakov@yadro.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.17.204.212] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=89.207.88.252; envelope-from=r.bolshakov@yadro.com; helo=mta-01.yadro.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Roman Bolshakov , Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @yadro.com) Content-Type: text/plain; charset="utf-8" ui/cocoa.m:1188:44: warning: 'openFile:' is deprecated: first deprecated in= macOS 11.0 - Use -[NSWorkspace openURL:] instead. [-Wdeprecated-declarations] if ([[NSWorkspace sharedWorkspace] openFile: full_file_path] =3D=3D= YES) { ^ /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Framewor= ks/AppKit.framework/Headers/NSWorkspace.h:350:1: note: 'openFile:' has been explicitly marked deprecated here - (BOOL)openFile:(NSString *)fullPath API_DEPRECATED("Use -[NSWorkspace ope= nURL:] instead.", macos(10.0, 11.0)); ^ Signed-off-by: Roman Bolshakov Reviewed-by: Peter Maydell --- Changes since v1: - Changed URLWithString: to fileURLWithPath:isDirectory: (Peter) ui/cocoa.m | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index f32adc3074..ea3b845b53 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1178,6 +1178,7 @@ QemuCocoaView *cocoaView; /* Where to look for local files */ NSString *path_array[] =3D {@"../share/doc/qemu/", @"../doc/qemu/", @"= ../docs/"}; NSString *full_file_path; + NSURL *full_file_url; =20 /* iterate thru the possible paths until the file is found */ int index; @@ -1186,7 +1187,9 @@ QemuCocoaView *cocoaView; full_file_path =3D [full_file_path stringByDeletingLastPathCompone= nt]; full_file_path =3D [NSString stringWithFormat: @"%@/%@%@", full_fi= le_path, path_array[index], filename]; - if ([[NSWorkspace sharedWorkspace] openFile: full_file_path] =3D= =3D YES) { + full_file_url =3D [NSURL fileURLWithPath: full_file_path + isDirectory: false]; + if ([[NSWorkspace sharedWorkspace] openURL: full_file_url] =3D=3D = YES) { return; } } --=20 2.29.2