From nobody Tue Nov 18 10:37:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1609414744; cv=none; d=zohomail.com; s=zohoarc; b=B/WXaL7Qc2v7yhoXbOVCSHuilMsR7dJjqbkTkN1X5cKftC25770n2Pq92Ps/fj7kM+MtZ1riGOr7cwDY7Lcnlf53IyrcxV79wgaDxjPEmTZ31NlW79F4Fxlf63GL91CV3P0XtTH14kjZOBY5N4K0a+zN/FTsSEByPHBF33vHC8s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609414744; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g6JPQD6xiASzsd5Dw3ZaAXCN7n31YqD9DBZI66sNy+c=; b=FqsgDL0O5yfBSS2uLVMwQ+xXYWdO5y+3PEw9wt8BjgtjtBhKnfgQ9TeAtOQtZ4BPpZ3pExI4+j1ZZkx6C/lavctpT98ECJ1jV7TMlH9YOGTGB4XCrjBTQy/wS+yghYhdUfG+ON9M6HA1WfNGkelEwpmXpB8CTu0dbqdyXAnF4wY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609414744319383.13345634342784; Thu, 31 Dec 2020 03:39:04 -0800 (PST) Received: from localhost ([::1]:59086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuwIJ-0000JZ-2m for importer@patchew.org; Thu, 31 Dec 2020 06:39:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuwAR-0007lW-2z; Thu, 31 Dec 2020 06:30:57 -0500 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:36060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuwAM-0007Hp-Hm; Thu, 31 Dec 2020 06:30:52 -0500 Received: by mail-pg1-x52a.google.com with SMTP id c132so1640175pga.3; Thu, 31 Dec 2020 03:30:49 -0800 (PST) Received: from i9-aorus-gtx1080.localdomain (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id t23sm45957591pfc.0.2020.12.31.03.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Dec 2020 03:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g6JPQD6xiASzsd5Dw3ZaAXCN7n31YqD9DBZI66sNy+c=; b=L0Oo3SetoY5JRUMOvwrzpU3+HIThP0im9jZ8NIqF39LUcSa1+UcugENKAQdIaI2xIx yZlQM7T3wMN34kGe5KTsM3WnmtcmRW831TcAY7RUfby2UTSJsnHWo4o/TRyQmG3Ie4YS 1aDrHZ84zx4IRHImLynHmMXqEUxIS17lonXMDjYJQu+vYtsfyMJh6dU5OcI9BriTSdmR l8Aa6OdhHAHVJzsiuW2zvEdM5WXs8xYZpqREGFbkZHyvDI1w60LpyoEDzwglktjwILoS Rs7IGItIjEwF3pf8EXG8Qy/GoK1P28U3t7Qa6y2TONJBDAn//Jr18Fd3pO5mEmynW65W YdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g6JPQD6xiASzsd5Dw3ZaAXCN7n31YqD9DBZI66sNy+c=; b=m59Y2UfqCOIaP19VZRJ2fSoHXXyA2nRSy6dewr9uBhhn1GpnvcfjNocxLkf30iEGhW Jr0klLJwu8NUig1Y9pFpQ8TMWFEuYK2bwrDM3OGkTjVS+ZyYgFEnWjfwb0rVLiLv/GvA c4/t5i5f35JuyVryutip0BwbynvVkvVRcYwUG2LgW2bpb3vCbTqUleyR8QskweajM5mM 0MqMqepVDdJnz2hmJ0KLJTKrebXNvGp31GOvLXj7w0WlJok86rM5HUOkA00SEPBW/7zZ XKgyEK9NYotodwyi2jrKDzlIgFO3VcsSXWfQPcNkOmOSgY0+8FDCgCNxN96xaCkQmXEe tg1g== X-Gm-Message-State: AOAM531UZxLdsGK6wo1f8UTRLEe7SO2HJnVkRNHfxAj9bGZAVcZd0y1U qFP+vMYnKoTiQKQJjaHviCo= X-Google-Smtp-Source: ABdhPJxCIE/ZTcAOKOAP2HLV7gCUj8Z55FlTWRyjAvN0UnzaSVnu0ZhzQtfDpFwVcxpU3e7aj39b9w== X-Received: by 2002:a63:4c52:: with SMTP id m18mr48310012pgl.280.1609414248645; Thu, 31 Dec 2020 03:30:48 -0800 (PST) From: Bin Meng To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , qemu-block@nongnu.org, qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 07/22] hw/sd: ssi-sd: Suffix a data block with CRC16 Date: Thu, 31 Dec 2020 19:29:55 +0800 Message-Id: <20201231113010.27108-8-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201231113010.27108-1-bmeng.cn@gmail.com> References: <20201231113010.27108-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=bmeng.cn@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bin Meng Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Type: text/plain; charset="utf-8" From: Bin Meng Per the SD spec, a valid data block is suffixed with a 16-bit CRC generated by the standard CCITT polynomial x16+x12+x5+1. This part is currently missing in the ssi-sd state machine. Without it, all data block transfer fails in guest software because the expected CRC16 is missing on the data out line. Fixes: 775616c3ae8c ("Partial SD card SPI mode support") Signed-off-by: Bin Meng Acked-by: Alistair Francis --- hw/sd/ssi-sd.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 228ce4ddc7..10b0ac2eaf 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -17,6 +17,7 @@ #include "hw/qdev-properties.h" #include "hw/sd/sd.h" #include "qapi/error.h" +#include "qemu/crc-ccitt.h" #include "qemu/module.h" #include "qom/object.h" =20 @@ -40,6 +41,7 @@ typedef enum { SSI_SD_RESPONSE, SSI_SD_DATA_START, SSI_SD_DATA_READ, + SSI_SD_DATA_CRC16, } ssi_sd_mode; =20 struct ssi_sd_state { @@ -48,6 +50,7 @@ struct ssi_sd_state { int cmd; uint8_t cmdarg[4]; uint8_t response[5]; + uint16_t crc16; int32_t arglen; int32_t response_pos; int32_t stopping; @@ -193,12 +196,24 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, u= int32_t val) case SSI_SD_DATA_START: DPRINTF("Start read block\n"); s->mode =3D SSI_SD_DATA_READ; + s->response_pos =3D 0; return 0xfe; case SSI_SD_DATA_READ: val =3D sdbus_read_byte(&s->sdbus); + s->crc16 =3D crc_ccitt_false(s->crc16, (uint8_t *)&val, 1); if (!sdbus_data_ready(&s->sdbus)) { DPRINTF("Data read end\n"); + s->mode =3D SSI_SD_DATA_CRC16; + } + return val; + case SSI_SD_DATA_CRC16: + val =3D (s->crc16 & 0xff00) >> 8; + s->crc16 <<=3D 8; + s->response_pos++; + if (s->response_pos =3D=3D 2) { + DPRINTF("CRC16 read end\n"); s->mode =3D SSI_SD_CMD; + s->response_pos =3D 0; } return val; } @@ -236,6 +251,7 @@ static const VMStateDescription vmstate_ssi_sd =3D { VMSTATE_INT32(cmd, ssi_sd_state), VMSTATE_UINT8_ARRAY(cmdarg, ssi_sd_state, 4), VMSTATE_UINT8_ARRAY(response, ssi_sd_state, 5), + VMSTATE_UINT16(crc16, ssi_sd_state), VMSTATE_INT32(arglen, ssi_sd_state), VMSTATE_INT32(response_pos, ssi_sd_state), VMSTATE_INT32(stopping, ssi_sd_state), @@ -287,6 +303,7 @@ static void ssi_sd_reset(DeviceState *dev) s->cmd =3D 0; memset(s->cmdarg, 0, sizeof(s->cmdarg)); memset(s->response, 0, sizeof(s->response)); + s->crc16 =3D 0; s->arglen =3D 0; s->response_pos =3D 0; s->stopping =3D 0; --=20 2.25.1