From nobody Tue Nov 18 09:19:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609395180; cv=none; d=zohomail.com; s=zohoarc; b=HK45hn9UVI+0aKAV/4b0VgGOdvW+dTh1g3s0PalSCAkgQ3jWooXAS9T2ybgHd7IagKeYwPifmOLzX3fwphFWYZKAsRQunyFyKKoVvGcpurIFp1DvbUH2LsO4UH4RxlXL3tTijZeeR3EvePq+b6FxluuSft1gnIEFBdvUsmhVCgs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609395180; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0nXpwFTr4qgFJMqV0T5oDyjzLZ8e+WY6ZbnAtZbEcuc=; b=DnUKDNzN8dQBzCxhj9ychZfipx3vOA0BEllVJzg/ncpe/T0Nzh1eyTNvJ/MvAr97uNuHlNklvpuJ0qC0jL6aUrdypsn7UvZmTIMp/DF1a1C322olvoAGftSkHie8lAta8/KzRJ3v1MxqEavBmTnQVHz8oyehwuMk17pVaDq9Neg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609395180650618.5194492719648; Wed, 30 Dec 2020 22:13:00 -0800 (PST) Received: from localhost ([::1]:54072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kurCk-0004lC-QZ for importer@patchew.org; Thu, 31 Dec 2020 01:12:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kurAv-0003Vi-EE; Thu, 31 Dec 2020 01:11:05 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kurAr-0005fc-Ck; Thu, 31 Dec 2020 01:11:04 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4D5yRd6QgNzkycJ; Thu, 31 Dec 2020 14:09:49 +0800 (CST) Received: from DESKTOP-EDHIELA.china.huawei.com (10.174.187.50) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Thu, 31 Dec 2020 14:10:42 +0800 From: Jinhao Gao To: , Subject: [PATCH v3 3/3] vmstate: Fix memory leak in vmstate_handle_alloc() Date: Thu, 31 Dec 2020 14:10:20 +0800 Message-ID: <20201231061020.828-4-gaojinhao@huawei.com> X-Mailer: git-send-email 2.29.2.windows.2 In-Reply-To: <20201231061020.828-1-gaojinhao@huawei.com> References: <20201231061020.828-1-gaojinhao@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.50] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=gaojinhao@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Berger , Jason Wang , "Michael S . Tsirkin" , Greg Kurz , "Dr . David Alan Gilbert" , Juan Quintela , wanghaibin.wang@huawei.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , zhukeqian1@huawei.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Some memory allocated for fields having a flag of VMS_ALLOC in SaveState may not free before VM load vmsd in migration. So we pre-free memory before allocation in vmstate_handle_alloc() to avoid memleaks. Reported-by: Euler Robot Signed-off-by: Jinhao Gao Signed-off-by: Michael S. Tsirkin Reviewed-by: Dr. David Alan Gilbert --- migration/vmstate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/vmstate.c b/migration/vmstate.c index e9d2aef66b..873f76739f 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -70,6 +70,7 @@ static void vmstate_handle_alloc(void *ptr, const VMState= Field *field, gsize size =3D vmstate_size(opaque, field); size *=3D vmstate_n_elems(opaque, field); if (size) { + g_free(*(void **)ptr); *(void **)ptr =3D g_malloc(size); } } --=20 2.23.0