From nobody Tue Nov 18 10:39:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609342972; cv=none; d=zohomail.com; s=zohoarc; b=NHJ3FBmjWDNpHAemBO3NhR4gh8aces6ei2urbti/xmFzXH3ud65DMHd3NLjcxRo1H5l52sBb+e16HuNONT/EkDmR0HiYSxbMEMzdjANov2NExUCFP4wkdp6joG4p9O11ambyQb4PwSro6MxuMKI08c5VybhLkbKMGJO2D7hqcXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609342972; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Yz2XMVlWbECd6DfvJoyKUXRDj0gWebd7B+ht4rM5s+o=; b=ifFHMkpXZEnIKDFEzwsUF0n0fXjouMMgLoN6xyEIkXNHHzESH5BIRmzMpC4MwwxNGTKOuV1vnfRj9plTT0tm3P8C47jLtiP56AE/sRFpererO6p/QbQj6KcI8FyoKQQgjHBSeA2+YUXPCt9U0hAq+yVJ+AtEFx+Jry5iK/bAtw0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609342972113108.0381210363687; Wed, 30 Dec 2020 07:42:52 -0800 (PST) Received: from localhost ([::1]:50934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kudcg-0005NZ-IC for importer@patchew.org; Wed, 30 Dec 2020 10:42:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudYb-0000Ie-Aq for qemu-devel@nongnu.org; Wed, 30 Dec 2020 10:38:37 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:50784 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudYY-00022k-VB for qemu-devel@nongnu.org; Wed, 30 Dec 2020 10:38:36 -0500 Received: from host86-148-34-1.range86-148.btcentralplus.com ([86.148.34.1] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kudYY-00070L-Qy; Wed, 30 Dec 2020 15:38:38 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu Date: Wed, 30 Dec 2020 15:37:28 +0000 Message-Id: <20201230153745.30241-9-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201230153745.30241-1-mark.cave-ayland@ilande.co.uk> References: <20201230153745.30241-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.148.34.1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH 08/25] esp: apply transfer length adjustment when STC is zero at TC load time X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Perform the length adjustment whereby a value of 0 in the STC represents a transfer length of 0x10000 at the point where the TC is loaded at the start of a DMA command rather than just when a TI (Transfer Information) command is executed. This better matches the description as given in the datasheet. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index c716a97847..f38b4a2ecd 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -564,9 +564,6 @@ static void handle_ti(ESPState *s) } =20 dmalen =3D esp_get_tc(s); - if (dmalen =3D=3D 0) { - dmalen =3D 0x10000; - } s->dma_counter =3D dmalen; =20 if (s->do_cmd) { @@ -701,7 +698,11 @@ void esp_reg_write(ESPState *s, uint32_t saddr, uint64= _t val) if (val & CMD_DMA) { s->dma =3D 1; /* Reload DMA counter. */ - esp_set_tc(s, esp_get_stc(s)); + if (esp_get_stc(s) =3D=3D 0) { + esp_set_tc(s, 0x10000); + } else { + esp_set_tc(s, esp_get_stc(s)); + } } else { s->dma =3D 0; } --=20 2.20.1