From nobody Tue Nov 18 10:39:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609343584; cv=none; d=zohomail.com; s=zohoarc; b=hxocFphM6ZE12iGJub+C6QCA8IO7piHYmU1PIkzjytflbQDta0GkQtBZNX8xV7iH40SRuIYYmXERn4chUzRudJEQp0YikdcKeZt6BV5kvLWpJdy6rF097GdJZVlgl8gjDMuRu32Dp/zEePwxtmSC0IbxC4ow6MkznTtSMReCaiA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609343584; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0CiVB2QresLEhmM1jhULksFE0nbvWQTcXGIo8g3YM6g=; b=Vu/o3vh6nm9tYJn3KJwtgTWamrWrPq0W+/ZDGroUAkFfjEn8xNHAL/HbQQJbTb8v52P1AzJc1hNSW8XoyAE9lU+fz26zlYWaqNsXrQTV1Z/JUDSAoKSffI103rgjIFMjKRwYgf4PfFL6yk/ChMMUNxKM9nCMi8DvEhxy4PqDdzk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609343584833143.81211268113168; Wed, 30 Dec 2020 07:53:04 -0800 (PST) Received: from localhost ([::1]:47940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kudmZ-0007i2-Gi for importer@patchew.org; Wed, 30 Dec 2020 10:53:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudZr-0001qr-5Z for qemu-devel@nongnu.org; Wed, 30 Dec 2020 10:39:55 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:50958 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudZp-0002Ka-Dg for qemu-devel@nongnu.org; Wed, 30 Dec 2020 10:39:54 -0500 Received: from host86-148-34-1.range86-148.btcentralplus.com ([86.148.34.1] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kudZf-00070L-Uw; Wed, 30 Dec 2020 15:39:47 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu Date: Wed, 30 Dec 2020 15:37:45 +0000 Message-Id: <20201230153745.30241-26-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201230153745.30241-1-mark.cave-ayland@ilande.co.uk> References: <20201230153745.30241-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.148.34.1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH 25/25] esp: add 4 byte PDMA read and write transfers X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The MacOS toolbox ROM performs 4 byte reads/writes when transferring data to and from the target. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 773fe09c49..b356a65f5c 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -933,6 +933,12 @@ static void sysbus_esp_pdma_write(void *opaque, hwaddr= addr, esp_pdma_write(s, val >> 8); esp_pdma_write(s, val); break; + case 4: + esp_pdma_write(s, val >> 24); + esp_pdma_write(s, val >> 16); + esp_pdma_write(s, val >> 8); + esp_pdma_write(s, val); + break; } dmalen =3D esp_get_tc(s); if (dmalen =3D=3D 0 || (s->ti_wptr =3D=3D TI_BUFSZ)) { @@ -957,6 +963,12 @@ static uint64_t sysbus_esp_pdma_read(void *opaque, hwa= ddr addr, val =3D esp_pdma_read(s); val =3D (val << 8) | esp_pdma_read(s); break; + case 4: + val =3D esp_pdma_read(s); + val =3D (val << 8) | esp_pdma_read(s); + val =3D (val << 8) | esp_pdma_read(s); + val =3D (val << 8) | esp_pdma_read(s); + break; } if (s->ti_rptr =3D=3D s->ti_wptr) { s->ti_wptr =3D 0; @@ -971,7 +983,7 @@ static const MemoryRegionOps sysbus_esp_pdma_ops =3D { .write =3D sysbus_esp_pdma_write, .endianness =3D DEVICE_NATIVE_ENDIAN, .valid.min_access_size =3D 1, - .valid.max_access_size =3D 2, + .valid.max_access_size =3D 4, }; =20 static const struct SCSIBusInfo esp_scsi_info =3D { @@ -1014,7 +1026,7 @@ static void sysbus_esp_realize(DeviceState *dev, Erro= r **errp) sysbus, "esp-regs", ESP_REGS << sysbus->it_shift= ); sysbus_init_mmio(sbd, &sysbus->iomem); memory_region_init_io(&sysbus->pdma, OBJECT(sysbus), &sysbus_esp_pdma_= ops, - sysbus, "esp-pdma", 2); + sysbus, "esp-pdma", 4); sysbus_init_mmio(sbd, &sysbus->pdma); =20 qdev_init_gpio_in(dev, sysbus_esp_gpio_demux, 2); --=20 2.20.1