From nobody Tue Nov 18 10:39:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609343126; cv=none; d=zohomail.com; s=zohoarc; b=L9uTP5dU0a3u5oAKriUblXPmIvSE8dIOU7O1IGvvansBo0mNDd3UKtq3JAVW8fLyuo5MGBDAubODTpxBdFpoYer588AKpuH6gvEBiRhPAtj69JmRJvsRSZY9CiaNeUZVf+eKDJB/A4PFH15D8cNx/TTPKkNr0A32+2hNLgKvpyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609343126; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=F8MvXe/iOYasRfSaiaLkdm2v0C5Wre3krQrx0Yu5Uh4=; b=ak4Hiu9NsMW/C+WRZl5tLEFWNzuW6/FVGbrEAsaeEfalKYmAYeqzgdCJIN2PkxflUmy+q5t6yaQne0Q4TLsVecXvUa3dl0TFFe5w+cyQnPFbbUjslAKOkScRjLQJ9LSlXos/MHzujBQuTyK1tjXVPkjTGzN3GR/pipZ3mVUuMuA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160934312641790.44830311182261; Wed, 30 Dec 2020 07:45:26 -0800 (PST) Received: from localhost ([::1]:59438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kudfA-0000SP-78 for importer@patchew.org; Wed, 30 Dec 2020 10:45:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudZb-0001VB-Ay for qemu-devel@nongnu.org; Wed, 30 Dec 2020 10:39:39 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:50916 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kudZW-0002Gf-5b for qemu-devel@nongnu.org; Wed, 30 Dec 2020 10:39:39 -0500 Received: from host86-148-34-1.range86-148.btcentralplus.com ([86.148.34.1] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kudZL-00070L-2b; Wed, 30 Dec 2020 15:39:27 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu Date: Wed, 30 Dec 2020 15:37:41 +0000 Message-Id: <20201230153745.30241-22-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201230153745.30241-1-mark.cave-ayland@ilande.co.uk> References: <20201230153745.30241-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.148.34.1 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH 21/25] esp: rename get_cmd_cb() to esp_select() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This better describes the purpose of the function. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/esp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 33e3cf657b..50bddc7d68 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -199,7 +199,7 @@ static void esp_pdma_write(ESPState *s, uint8_t val) esp_set_tc(s, dmalen); } =20 -static int get_cmd_cb(ESPState *s) +static int esp_select(ESPState *s) { int target; =20 @@ -255,7 +255,7 @@ static uint32_t get_cmd(ESPState *s, uint8_t *buf, uint= 8_t buflen) } trace_esp_get_cmd(dmalen, target); =20 - if (get_cmd_cb(s) < 0) { + if (esp_select(s) < 0) { return 0; } return dmalen; @@ -297,7 +297,7 @@ static void do_cmd(ESPState *s, uint8_t *buf) =20 static void satn_pdma_cb(ESPState *s) { - if (get_cmd_cb(s) < 0) { + if (esp_select(s) < 0) { return; } s->do_cmd =3D 0; @@ -323,7 +323,7 @@ static void handle_satn(ESPState *s) =20 static void s_without_satn_pdma_cb(ESPState *s) { - if (get_cmd_cb(s) < 0) { + if (esp_select(s) < 0) { return; } s->do_cmd =3D 0; @@ -349,7 +349,7 @@ static void handle_s_without_atn(ESPState *s) =20 static void satn_stop_pdma_cb(ESPState *s) { - if (get_cmd_cb(s) < 0) { + if (esp_select(s) < 0) { return; } s->do_cmd =3D 0; --=20 2.20.1