From nobody Sat Apr 4 12:26:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609140596; cv=none; d=zohomail.com; s=zohoarc; b=aPHHuxXDpiBFO0Jg90v0s3UYhXZ2Ki/jdxVuJ0bH7UoAeaXL88V4wDeyePM/MXAp3PwL5N0JJ8prv6ipM/nkfqAHE7XU0tmi9wmiyhVGhoNsedSdek1DWzROwSNJTwskoJP0jWk48g1por4fM1flKXz+8gOGriUIrCeJKB4Ibxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609140596; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WhZgPCliDHMarVlUb7nzlgAopFJUGsbsB48xO+1OE2g=; b=DUaoJJQtgofwWTG1oT/arcsXorqIAIls0YRN+gKWccdqJRHf5wv/b54bBLDad+1UsCfy0qLRCylmpmlw9MNbqJM2ZtKe85j0Ow+sRm31P3H7zl1v0Zc9Twh4u1Ob4H8J/FWRqBSnYQb1aapfPpU2Xvzk+zZvZzj6Lxri8/TLC3g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160914059585055.076320737718106; Sun, 27 Dec 2020 23:29:55 -0800 (PST) Received: from localhost ([::1]:46546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktmyX-0001zu-1j for importer@patchew.org; Mon, 28 Dec 2020 02:29:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvZ-0000FC-7y; Mon, 28 Dec 2020 02:26:49 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvI-0007jr-C5; Mon, 28 Dec 2020 02:26:48 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4D48GF6Bwtz15kqJ; Mon, 28 Dec 2020 15:25:25 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 28 Dec 2020 15:26:07 +0800 From: Zhang Han To: Subject: [PATCH 1/4] qobject: open brace '{' following struct go on the same line Date: Mon, 28 Dec 2020 15:11:26 +0800 Message-ID: <20201228071129.24563-2-zhanghan64@huawei.com> X-Mailer: git-send-email 2.29.1.59.gf9b6481aed In-Reply-To: <20201228071129.24563-1-zhanghan64@huawei.com> References: <20201228071129.24563-1-zhanghan64@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhanghan64@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Put open brace '{' on the same line of struct. Signed-off-by: Zhang Han Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- qobject/json-parser.c | 3 +-- qobject/qjson.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/qobject/json-parser.c b/qobject/json-parser.c index c0f521b56b..18b87a42f3 100644 --- a/qobject/json-parser.c +++ b/qobject/json-parser.c @@ -31,8 +31,7 @@ struct JSONToken { char str[]; }; =20 -typedef struct JSONParserContext -{ +typedef struct JSONParserContext { Error *err; JSONToken *current; GQueue *buf; diff --git a/qobject/qjson.c b/qobject/qjson.c index f1f2c69704..f5623081e3 100644 --- a/qobject/qjson.c +++ b/qobject/qjson.c @@ -22,8 +22,7 @@ #include "qapi/qmp/qstring.h" #include "qemu/unicode.h" =20 -typedef struct JSONParsingState -{ +typedef struct JSONParsingState { JSONMessageParser parser; QObject *result; Error *err; --=20 2.29.1.59.gf9b6481aed From nobody Sat Apr 4 12:26:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609140591; cv=none; d=zohomail.com; s=zohoarc; b=gtKcAOgYrDbHWSjTO35IxBEcwSjiW9wAW8VDEvb9OgsnjMfoHdYlC+nUOBWQxyDw2axeUf+urI2ndjbGANhsGbvPcvOQTowYQ4aR0P+P0/P9/0c1CY3FoDec99Sz7bzjTIkYm14OkqzFQQB4QN1qb/Ajt+wls3y/rRDhRCKlGcY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609140591; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CVpeADauN4h2NX+JTHkUvZAFclWHg+r8p54Q1bWucQw=; b=CN1t1WsD+pi9ZwP1uEkjJ2/BCFXQllRsDjZAMLWY+SlijImOCMHFTJ3ICUzRqGem5x2cRYqAecJhOYShPIy144TRLRdQG9fVHorlvLuN5eanLUTUhZL3IFVFmordVQetyXeRxl4agrorA6FYGTqcm69CpOaznSwS5YukdPEXGyA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160914059186676.95718706152002; Sun, 27 Dec 2020 23:29:51 -0800 (PST) Received: from localhost ([::1]:46474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktmyU-0001yF-Go for importer@patchew.org; Mon, 28 Dec 2020 02:29:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvY-0000Ee-Nu; Mon, 28 Dec 2020 02:26:48 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvI-0007lK-Dw; Mon, 28 Dec 2020 02:26:48 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4D48GL70Bkz15kqQ; Mon, 28 Dec 2020 15:25:30 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 28 Dec 2020 15:26:07 +0800 From: Zhang Han To: Subject: [PATCH 2/4] qobject: code indent should never use tabs Date: Mon, 28 Dec 2020 15:11:27 +0800 Message-ID: <20201228071129.24563-3-zhanghan64@huawei.com> X-Mailer: git-send-email 2.29.1.59.gf9b6481aed In-Reply-To: <20201228071129.24563-1-zhanghan64@huawei.com> References: <20201228071129.24563-1-zhanghan64@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhanghan64@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Transfer tabs to spaces. Signed-off-by: Zhang Han --- qobject/qdict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 1079bd3f6f..2c07b3c87f 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -38,8 +38,8 @@ QDict *qdict_new(void) */ static unsigned int tdb_hash(const char *name) { - unsigned value; /* Used to compute the hash value. */ - unsigned i; /* Used to cycle through random values. */ + unsigned value; /* Used to compute the hash value. */ + unsigned i; /* Used to cycle through random values. */ =20 /* Set the initial value from the key size. */ for (value =3D 0x238F13AF * strlen(name), i=3D0; name[i]; i++) --=20 2.29.1.59.gf9b6481aed From nobody Sat Apr 4 12:26:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609140831; cv=none; d=zohomail.com; s=zohoarc; b=GLg54OhCxa99wv2b0inYjmygkufH8QQtffRbGGviMKCvwfLpB7FbchHSDfccWT4ToDtFSgy/JI8c3yta2Vl5O3EjLVrPie82s9wegwshAr/dDxnMuNvzfPvOh61ENivcJPmxmapgcVQf4rHN4AA/qXVyhB8ZaLRZvp4xTOxOH/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609140831; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3L6bu+01SkQE7Rz0EFRIDzXzPYGm049nMauhAKiWA4c=; b=Uv0ugTwQ+1+ssPMKVu7PH+Spkrdm3L4J1EVPYkTXWJifIKhpYwHWMv6TJ5GC7f+vJB7TE+DhanKie4navoyeKyBl5tdoSfWgpDTCn5XfLk/t8avmP+zPuzr1RL4ks41XqzMapAEAfSlsbzz5C/KYaND6RrZ4Wd2m4/685Rlj13g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609140831474272.75747180060125; Sun, 27 Dec 2020 23:33:51 -0800 (PST) Received: from localhost ([::1]:53040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktn2M-0004q3-5m for importer@patchew.org; Mon, 28 Dec 2020 02:33:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvY-0000ES-AU; Mon, 28 Dec 2020 02:26:48 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvI-0007lI-Dd; Mon, 28 Dec 2020 02:26:48 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4D48GL6qY5z15kqN; Mon, 28 Dec 2020 15:25:30 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 28 Dec 2020 15:26:08 +0800 From: Zhang Han To: Subject: [PATCH 3/4] qobject: spaces required around that operators Date: Mon, 28 Dec 2020 15:11:28 +0800 Message-ID: <20201228071129.24563-4-zhanghan64@huawei.com> X-Mailer: git-send-email 2.29.1.59.gf9b6481aed In-Reply-To: <20201228071129.24563-1-zhanghan64@huawei.com> References: <20201228071129.24563-1-zhanghan64@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhanghan64@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Add spaces around operators. Signed-off-by: Zhang Han --- qobject/qdict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 2c07b3c87f..05ec950e05 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -42,8 +42,8 @@ static unsigned int tdb_hash(const char *name) unsigned i; /* Used to cycle through random values. */ =20 /* Set the initial value from the key size. */ - for (value =3D 0x238F13AF * strlen(name), i=3D0; name[i]; i++) - value =3D (value + (((const unsigned char *)name)[i] << (i*5 % 24)= )); + for (value =3D 0x238F13AF * strlen(name), i =3D 0; name[i]; i++) + value =3D (value + (((const unsigned char *)name)[i] << (i * 5 % 2= 4))); =20 return (1103515243 * value + 12345); } --=20 2.29.1.59.gf9b6481aed From nobody Sat Apr 4 12:26:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609141018; cv=none; d=zohomail.com; s=zohoarc; b=N7EWGPkoQ+5anu8Q17CES4XDryCthoqY4dHE0i/+NT7NP1ptn8MXMrY5edLh1WCr/blYMT/XwFdb/r+PpoR79YYHmmxwKwv6AUxKR5z07BOTf7ru9TSF90gB8kmUMJRDt/W8uJ+aimeOGoGU6cLC61zlIk/YqRHcXUJ6o2Ld0Ds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609141018; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gXSbnj2Ykt2GQWZ6o2LxsUMu4g6qmhAf7Vxzy3RuY1E=; b=cbL3JNB8ayBRUYbdIemYp1H6vTsiAvgVRKbKfcdWGl6ue21jkb+ngI6lovdv33y7kcEao2I/XcKYa0YtLTy0suGRyAz85koS6FQq2WO2RG605XNTJbYVTGrqecCkeuvPrejaNtkEWnTsyUnz5ODDgTZDzRshxxce0pC5l7bapxo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609141018189270.0656366911177; Sun, 27 Dec 2020 23:36:58 -0800 (PST) Received: from localhost ([::1]:59228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktn5M-0007rP-Ea for importer@patchew.org; Mon, 28 Dec 2020 02:36:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvY-0000EZ-JI; Mon, 28 Dec 2020 02:26:48 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktmvI-0007l6-DD; Mon, 28 Dec 2020 02:26:48 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4D48GL6fm3z15kqH; Mon, 28 Dec 2020 15:25:30 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 28 Dec 2020 15:26:09 +0800 From: Zhang Han To: Subject: [PATCH 4/4] qobject: braces {} are necessary for all arms of this statement Date: Mon, 28 Dec 2020 15:11:29 +0800 Message-ID: <20201228071129.24563-5-zhanghan64@huawei.com> X-Mailer: git-send-email 2.29.1.59.gf9b6481aed In-Reply-To: <20201228071129.24563-1-zhanghan64@huawei.com> References: <20201228071129.24563-1-zhanghan64@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=zhanghan64@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.chen@huawei.com, hunongda@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Add braces {} for arms of if/for statement Signed-off-by: Zhang Han Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- qobject/qdict.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 05ec950e05..0a49b787ab 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -42,8 +42,9 @@ static unsigned int tdb_hash(const char *name) unsigned i; /* Used to cycle through random values. */ =20 /* Set the initial value from the key size. */ - for (value =3D 0x238F13AF * strlen(name), i =3D 0; name[i]; i++) + for (value =3D 0x238F13AF * strlen(name), i =3D 0; name[i]; i++) { value =3D (value + (((const unsigned char *)name)[i] << (i * 5 % 2= 4))); + } =20 return (1103515243 * value + 12345); } @@ -92,8 +93,9 @@ static QDictEntry *qdict_find(const QDict *qdict, QDictEntry *entry; =20 QLIST_FOREACH(entry, &qdict->table[bucket], next) - if (!strcmp(entry->key, key)) + if (!strcmp(entry->key, key)) { return entry; + } =20 return NULL; } --=20 2.29.1.59.gf9b6481aed