From nobody Mon Feb 9 20:31:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1608997471; cv=none; d=zohomail.com; s=zohoarc; b=T+YQ5MgxtnJgn0OczTVmuYdou5ov5dhyikrq6Lao0DVM35MxIapFtpUb+zlCkgfh7e/nVVxlHijRNX1awrml73hV/iFfSvqkr9870slwcpCwGCvnzFTgffhH0UK54cA9P9lV2UExldceljVM0LxPsazT1MD0/mgPke3zLyuxGOY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608997471; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZNFWq1NCPqO+TccVkrOsV6199tjVX6uwjmL6/Un1CU4=; b=UzRqbq40Q68vjsg8Z/BNxv8AcmvD6n6aQ/1e6OxBjgNKtq7FRN7Vwry6KQJZtV0pwoUZRRPgZPoNaRNyx9/Ylkvah8ujU6DkO1buM1QUCYqh4KnMG7d8U/mf84qTEqE/VSDXyax6DGkxSkd5S5FNS4XGNHbjPab17JlY1DSc7To= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160899747117054.47375383547228; Sat, 26 Dec 2020 07:44:31 -0800 (PST) Received: from localhost ([::1]:40834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktAJR-0008AT-Ck for importer@patchew.org; Sat, 26 Dec 2020 09:12:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt6uC-0002Iv-D1; Sat, 26 Dec 2020 05:34:37 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt6uA-0004oZ-Na; Sat, 26 Dec 2020 05:34:36 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D30X7476mzhySd; Sat, 26 Dec 2020 18:33:27 +0800 (CST) Received: from DESKTOP-EDHIELA.china.huawei.com (10.174.187.50) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Sat, 26 Dec 2020 18:34:04 +0800 From: g00517791 To: , Subject: [PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci Date: Sat, 26 Dec 2020 18:33:43 +0800 Message-ID: <20201226103347.868-5-gaojinhao@huawei.com> X-Mailer: git-send-email 2.29.2.windows.2 In-Reply-To: <20201226103347.868-1-gaojinhao@huawei.com> References: <20201226103347.868-1-gaojinhao@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.50] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.191; envelope-from=gaojinhao@huawei.com; helo=szxga05-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 26 Dec 2020 09:05:46 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , Jason Wang , Stefan Berger , Greg Kurz , "Dr . David Alan Gilbert" , Juan Quintela , wanghaibin.wang@huawei.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , zhukeqian1@huawei.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Jinhao Gao When VM migrate VMState of spapr_pci, the field(msi_devs) of spapr_pci having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free memory of msi_devs in SaveStateEntry of spapr_pci after QEMUFile save VMState of spapr_pci, it may result in memory leak of msi_devs. We add the post_save func to free memory, which prevents memory leak. Signed-off-by: Jinhao Gao Acked-by: David Gibson --- hw/ppc/spapr_pci.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 76d7c91e9c..1b2b940606 100644 --- a/hw/ppc/spapr_pci.c +++ b/hw/ppc/spapr_pci.c @@ -2173,6 +2173,16 @@ static int spapr_pci_pre_save(void *opaque) return 0; } =20 +static int spapr_pci_post_save(void *opaque) +{ + SpaprPhbState *sphb =3D opaque; + + g_free(sphb->msi_devs); + sphb->msi_devs =3D NULL; + sphb->msi_devs_num =3D 0; + return 0; +} + static int spapr_pci_post_load(void *opaque, int version_id) { SpaprPhbState *sphb =3D opaque; @@ -2205,6 +2215,7 @@ static const VMStateDescription vmstate_spapr_pci =3D= { .version_id =3D 2, .minimum_version_id =3D 2, .pre_save =3D spapr_pci_pre_save, + .post_save =3D spapr_pci_post_save, .post_load =3D spapr_pci_post_load, .fields =3D (VMStateField[]) { VMSTATE_UINT64_EQUAL(buid, SpaprPhbState, NULL), --=20 2.23.0