From nobody Tue Feb 10 13:01:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1608996927; cv=none; d=zohomail.com; s=zohoarc; b=gSuQ+rMj/+coiGL8jx8EI1o00JW/ndb5Az80ZJVpbCm9XbfD0BK85HOmUR0Cvns50H70cgaiDB2ZbJV2YtUMQtihIdUCymIQKynyu0c5LtfG6TAFgY5S/CZ8rkXGACizYlmNtoiNs7j/6YBAqwOZd9PpaSASJUsvcPzm4mEpLQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608996927; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dUzQOh2+y2tI4zzEon+4SakuZ72949EUgq9H/s4vtxs=; b=QCCR7v5Md+EgbHnsZpmBXYC36KOMNLTRUYCuDwjiDrE7cZEm84rKYLSMv8MKGM8Swknhd3vbxkh3OI1PWnK92/TRF8uuX4uZj6KqF0gcBAXtvsTI5K9b4yIFB43/YMmdkhrIQ+U3ZOSufaVMuOB/0Y7drdw/gs0ppHgQ2iYX5QQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608996927892493.7069550582671; Sat, 26 Dec 2020 07:35:27 -0800 (PST) Received: from localhost ([::1]:36034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktAGp-00064f-Nm for importer@patchew.org; Sat, 26 Dec 2020 09:10:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt6u1-0002Di-Dt; Sat, 26 Dec 2020 05:34:25 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:2628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt6ty-0004nK-Hy; Sat, 26 Dec 2020 05:34:24 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4D30X3040qz7GcD; Sat, 26 Dec 2020 18:33:23 +0800 (CST) Received: from DESKTOP-EDHIELA.china.huawei.com (10.174.187.50) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Sat, 26 Dec 2020 18:34:01 +0800 From: g00517791 To: , Subject: [PATCH 1/8] vmbus: Fix memory leak of vmstate_gpadl Date: Sat, 26 Dec 2020 18:33:40 +0800 Message-ID: <20201226103347.868-2-gaojinhao@huawei.com> X-Mailer: git-send-email 2.29.2.windows.2 In-Reply-To: <20201226103347.868-1-gaojinhao@huawei.com> References: <20201226103347.868-1-gaojinhao@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.187.50] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=gaojinhao@huawei.com; helo=szxga07-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 26 Dec 2020 09:05:44 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S . Tsirkin" , Jason Wang , Stefan Berger , Greg Kurz , "Dr . David Alan Gilbert" , Juan Quintela , wanghaibin.wang@huawei.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , zhukeqian1@huawei.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Jinhao Gao When VM migrate VMState of vmbus/gpadl, the field(gfns) of vmbus/ gpadl having a flag of VMS_ALLOC needs to allocate memory. If the dst doesn't free memory which has been allocated for SaveStateEntry of vmbus/gpadl before dst loads device state, it may result that the pointer of gfns is overlaid when vm loads. We add the pre_load func to free memory, which prevents memory leak. Signed-off-by: Jinhao Gao --- hw/hyperv/vmbus.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 896e981f85..a91623aaac 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -519,10 +519,21 @@ void vmbus_unmap_sgl(VMBusChanReq *req, DMADirection = dir, struct iovec *iov, } } =20 +static int vmbus_gpadl_pre_load(void *opaque) +{ + VMBusGpadl *gpadl =3D VMBusGpadl(opaque); + + g_free(gpadl->gfns); + gpadl->gfns =3D NULL; + gpadl->num_gfns =3D0; + return 0; +} + static const VMStateDescription vmstate_gpadl =3D { .name =3D "vmbus/gpadl", .version_id =3D 0, .minimum_version_id =3D 0, + .pre_load =3D vmbus_gpadl_pre_load, .fields =3D (VMStateField[]) { VMSTATE_UINT32(id, VMBusGpadl), VMSTATE_UINT32(child_relid, VMBusGpadl), --=20 2.23.0