From nobody Tue Nov 18 09:17:00 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608759663; cv=none; d=zohomail.com; s=zohoarc; b=K57ehoUWgHd4f6QCiyMjneSQFWuaT852OmJBSiQ2gFGMFPWra+hrl4/DxRAcVD2S4higmuOZrEi3tdm7PHwUQUzO/1JCt8hodIF6Y/P/oH/wtLGstaxBHwzZvQt5yMxARXoV459pbj4LlfPar5O9wgt8hZAa32qY7UDz+/OLd34= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608759663; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zw66UG1OaBcXeCmLsS+UADDs62L8hdtJV3l9Qj/ZNQg=; b=majzTWHNBjCC8012JmO7wkGY587peQqm7u+OnU7bvURNSqWmtFasmFPyaU9Ro53AZWIdL5AWR572opHbIoOqeYSKoolwe37eCqOWR1IL7iWdRCtIxPJy6LF8mhCI54KMQbsfDzdxAc2BlPl1rMu5UpDhToc6mk3V1PiNgd54j6Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16087596632231005.8051332337054; Wed, 23 Dec 2020 13:41:03 -0800 (PST) Received: from localhost ([::1]:36522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksBsU-0000vM-4b for importer@patchew.org; Wed, 23 Dec 2020 16:41:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksBg5-0002uF-FO for qemu-devel@nongnu.org; Wed, 23 Dec 2020 16:28:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38695) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1ksBg3-0004Zk-Tv for qemu-devel@nongnu.org; Wed, 23 Dec 2020 16:28:13 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-525-kCoFPSl-Phi485aAO8P4wA-1; Wed, 23 Dec 2020 16:28:07 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45C7C10054FF; Wed, 23 Dec 2020 21:28:06 +0000 (UTC) Received: from localhost (ovpn-113-96.rdu2.redhat.com [10.10.113.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id D75872CF2B; Wed, 23 Dec 2020 21:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608758891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zw66UG1OaBcXeCmLsS+UADDs62L8hdtJV3l9Qj/ZNQg=; b=fnlwiEOLaeqCxNs6uusbs4l4D7jQ+0vqtUT/W4cojEoxWC0gCdwT3gK1ooVoLv0UVA+vp7 NgAZ7fvHY0IWvztQQhH+kViLjHB2f6QbjTMqhfUyLRGme0UFdH2bnbHHhsSajFfD5dLe+C mhOvoHbeGt/wocwHnQ62h05Rdld9hmA= X-MC-Unique: kCoFPSl-Phi485aAO8P4wA-1 From: Eduardo Habkost To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 14/15] qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen() Date: Wed, 23 Dec 2020 16:27:34 -0500 Message-Id: <20201223212735.512062-15-ehabkost@redhat.com> In-Reply-To: <20201223212735.512062-1-ehabkost@redhat.com> References: <20201223212735.512062-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Igor Mammedov , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) We're just doing pointer math with the device pointer, we can simply use obj instead. Signed-off-by: Eduardo Habkost Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Igor Mammedov Message-Id: <20201211220529.2290218-32-ehabkost@redhat.com> Signed-off-by: Eduardo Habkost --- hw/core/qdev-properties.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index f3bbf05465..50f40949f5 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -559,10 +559,9 @@ static void set_prop_arraylen(Object *obj, Visitor *v,= const char *name, * array-length field in the device struct, we have to create the * array itself and dynamically add the corresponding properties. */ - DeviceState *dev =3D DEVICE(obj); Property *prop =3D opaque; uint32_t *alenptr =3D object_field_prop_ptr(obj, prop); - void **arrayptr =3D (void *)dev + prop->arrayoffset; + void **arrayptr =3D (void *)obj + prop->arrayoffset; void *eltptr; const char *arrayname; int i; @@ -602,7 +601,7 @@ static void set_prop_arraylen(Object *obj, Visitor *v, = const char *name, * they get the right answer despite the array element not actually * being inside the device struct. */ - arrayprop->prop.offset =3D eltptr - (void *)dev; + arrayprop->prop.offset =3D eltptr - (void *)obj; assert(object_field_prop_ptr(obj, &arrayprop->prop) =3D=3D eltptr); object_property_add(obj, propname, arrayprop->prop.info->name, --=20 2.28.0