From nobody Tue Nov 18 09:19:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1608714716; cv=none; d=zohomail.com; s=zohoarc; b=J8LzhRtpP2vdSFHeBPRf3elmUPDoWU0cmoky7sAIUfID4xFT/bn08LvJBOae+ETAxUXYDrcQzkWtIB1cTBn3RRG+LxKYmeA9D1ebNKV1o79y67T2cPuBEIKCkFHqgjKagdHNhvsS0mD0kPg9WlWwoPazbyZMPXjcW3MhFgy0qn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608714716; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DQFXyfnWk8wibpU1H9oSH/R1PwMhcIMP2NhEE8rZ2O0=; b=gcZJTa5byShrps48BgRv1ApuqImTp1dl9+Y/o7a/n+R7PS92G2IOsLDUNYziYT2aviy+JZ/xsMLEjMK/WdXgvot0rE2LJ2C7SjpZKXmTtHinyW0L7qMfr6RixEPaz9gSB8FS81Buhcq1y4YxYsV9FlvPQqQ1d9rWWq6UOGMA9VU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608714716926864.7347521875836; Wed, 23 Dec 2020 01:11:56 -0800 (PST) Received: from localhost ([::1]:39970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks0BX-00055W-Ti for importer@patchew.org; Wed, 23 Dec 2020 04:11:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks09w-0003hA-0q for qemu-devel@nongnu.org; Wed, 23 Dec 2020 04:10:16 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:2571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks09q-0002Xp-Qa for qemu-devel@nongnu.org; Wed, 23 Dec 2020 04:10:15 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4D16pX4Wp9zhvKV; Wed, 23 Dec 2020 17:09:24 +0800 (CST) Received: from localhost (10.174.184.155) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Wed, 23 Dec 2020 17:09:53 +0800 From: Jiahui Cen To: Subject: [PATCH v3 3/8] acpi/gpex: Inform os to keep firmware resource map Date: Wed, 23 Dec 2020 17:08:31 +0800 Message-ID: <20201223090836.9075-4-cenjiahui@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201223090836.9075-1-cenjiahui@huawei.com> References: <20201223090836.9075-1-cenjiahui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=cenjiahui@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xieyingtai@huawei.com, Jiahui Cen , Eduardo Habkost , "Michael S. Tsirkin" , Ard Biesheuvel , Richard Henderson , Paolo Bonzini , Igor Mammedov , Laszlo Ersek , wu.wubin@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" There may be some differences in pci resource assignment between guest os and firmware. Eg. A Bridge with Bus [d2] -+-[0000:d2]---01.0-[d3]----01.0 where [d2:01.00] is a pcie-pci-bridge with BAR0 (mem, 64-bit, non-pref)= [size=3D256] [d3:01.00] is a PCI Device with BAR0 (mem, 64-bit, pref) [size=3D= 128K] BAR4 (mem, 64-bit, pref) [size=3D= 64M] In EDK2, the Resource Map would be: PciBus: Resource Map for Bridge [D2|01|00] Type =3D PMem64; Base =3D 0x8004000000; Length =3D 0x4100000; = Alignment =3D 0x3FFFFFF Base =3D 0x8004000000; Length =3D 0x4000000; Alignment =3D 0= x3FFFFFF; Owner =3D PCI [D3|01|00:20] Base =3D 0x8008000000; Length =3D 0x20000; Alignment =3D 0= x1FFFF; Owner =3D PCI [D3|01|00:10] Type =3D Mem64; Base =3D 0x8008100000; Length =3D 0x100; Align= ment =3D 0xFFF It would use 0x4100000 to calculate the root bus's PMem64 resource wind= ow. While in Linux, kernel will use 0x1FFFFFF as the alignment to calculate the PMem64 size, which would be 0x6000000. So kernel would try to allocate 0x6000000 from the PMem64 resource window, but since the window size is 0x4100000 as assigned by EDK2, the allocation would fail. The diffences could result in resource assignment failure. Using _DSM #5 method to inform guest os not to ignore the PCI configuration that firmware has done at boot time could handle the differences. Signed-off-by: Jiahui Cen --- hw/pci-host/gpex-acpi.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/gpex-acpi.c b/hw/pci-host/gpex-acpi.c index 11b3db8f71..c189306599 100644 --- a/hw/pci-host/gpex-acpi.c +++ b/hw/pci-host/gpex-acpi.c @@ -112,10 +112,24 @@ static void acpi_dsdt_add_pci_osc(Aml *dev) UUID =3D aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D"); ifctx =3D aml_if(aml_equal(aml_arg(0), UUID)); ifctx1 =3D aml_if(aml_equal(aml_arg(2), aml_int(0))); - uint8_t byte_list[1] =3D {1}; - buf =3D aml_buffer(1, byte_list); + uint8_t byte_list[] =3D { + 0x1 << 0 /* support for functions other than function 0 */= | + 0x1 << 5 /* support for function 5 */ + }; + buf =3D aml_buffer(ARRAY_SIZE(byte_list), byte_list); aml_append(ifctx1, aml_return(buf)); aml_append(ifctx, ifctx1); + + /* PCI Firmware Specification 3.1 + * 4.6.5. _DSM for Ignoring PCI Boot Configurations + */ + /* Arg2: Function Index: 5 */ + ifctx1 =3D aml_if(aml_equal(aml_arg(2), aml_int(5))); + /* 0 - The operating system must not ignore the PCI configuration that + * firmware has done at boot time. + */ + aml_append(ifctx1, aml_return(aml_int(0))); + aml_append(ifctx, ifctx1); aml_append(method, ifctx); =20 byte_list[0] =3D 0; --=20 2.29.2