From nobody Tue Nov 18 07:46:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608680775; cv=none; d=zohomail.com; s=zohoarc; b=SL1bSMtelnNF7ngVHg/xPkQuAfoiSUSP1NK3nrGABEOKNKNEDTsI8WaqPewwQGLTpIMhuj2xw0BdN01inN5W3QEnrloLDChlcOj2A81GUdiHkU+5QlidarhmNsXer65uVzgaWGmFRbxF/R8l56H6TM5XXUkrHd+uSno1JvFiw6o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608680775; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zPDTtMuVWH7cDEENau1hatGQ/3PgZ39Wy4zAGtqhPTg=; b=QN8UteCZbXWljWj51xhWL03xqd7doazVwXt3rXFnoQz+PtzsvnX89lZXzc5SodGgQVuyq4/KV2X/k89gBrdyr1cWH1ZojVVFCySLabu8ZqxxfuCJElFPU+R+LlZa0Yju+1eQQjou0CPuChPHRpJ9aiJf0SAO3pSU6PIAAEgWetY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608680775652693.0157048513493; Tue, 22 Dec 2020 15:46:15 -0800 (PST) Received: from localhost ([::1]:50182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krrM6-0004jC-ID for importer@patchew.org; Tue, 22 Dec 2020 18:46:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krrGB-0000Np-59 for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krrG6-0005HF-UE for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:06 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-2UA1hzGpMviH7O3lNoeHWw-1; Tue, 22 Dec 2020 18:39:51 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3422D87315D; Tue, 22 Dec 2020 23:39:50 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0ED485D9CC; Tue, 22 Dec 2020 23:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608680393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zPDTtMuVWH7cDEENau1hatGQ/3PgZ39Wy4zAGtqhPTg=; b=FklzqYSp2qws8TYrNtLuRTVBTH9e//AeELOu47DjyIINe56TD2DKZh/fgvIFfGAjpkK5ik Zo0WkwZoK4f+r8+wt9Fp90uJoUDyoEk2ZZYcLa1X3r9iTOILqkItpVUelJd2wDY1HQxqlX 3f6waEDuedq8XuGE6TjBv/wHHBCVHHY= X-MC-Unique: 2UA1hzGpMviH7O3lNoeHWw-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [RFC 1/5] acpi: add aml_to_decimalstring() and aml_call6() helpers Date: Tue, 22 Dec 2020 18:39:30 -0500 Message-Id: <20201222233934.451578-2-imammedo@redhat.com> In-Reply-To: <20201222233934.451578-1-imammedo@redhat.com> References: <20201222233934.451578-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jusual@redhat.com, laine@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" it will be used by follow up patches Signed-off-by: Igor Mammedov --- include/hw/acpi/aml-build.h | 3 +++ hw/acpi/aml-build.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index e727bea1bc..695b7e6323 100644 --- a/include/hw/acpi/aml-build.h +++ b/include/hw/acpi/aml-build.h @@ -301,6 +301,7 @@ Aml *aml_arg(int pos); Aml *aml_to_integer(Aml *arg); Aml *aml_to_hexstring(Aml *src, Aml *dst); Aml *aml_to_buffer(Aml *src, Aml *dst); +Aml *aml_to_decimalstring(Aml *src, Aml *dst); Aml *aml_store(Aml *val, Aml *target); Aml *aml_and(Aml *arg1, Aml *arg2, Aml *dst); Aml *aml_or(Aml *arg1, Aml *arg2, Aml *dst); @@ -323,6 +324,8 @@ Aml *aml_call3(const char *method, Aml *arg1, Aml *arg2= , Aml *arg3); Aml *aml_call4(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *a= rg4); Aml *aml_call5(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *a= rg4, Aml *arg5); +Aml *aml_call6(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *a= rg4, + Aml *arg5, Aml *arg6); Aml *aml_gpio_int(AmlConsumerAndProducer con_and_pro, AmlLevelAndEdge edge_level, AmlActiveHighAndLow active_level, AmlShared shared, diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index f976aa667b..89702be788 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -633,6 +633,19 @@ Aml *aml_to_buffer(Aml *src, Aml *dst) return var; } =20 +/* ACPI 2.0a: 17.2.4.4 Type 2 Opcodes Encoding: DefToDecimalString */ +Aml *aml_to_decimalstring(Aml *src, Aml *dst) +{ + Aml *var =3D aml_opcode(0x97 /* ToDecimalStringOp */); + aml_append(var, src); + if (dst) { + aml_append(var, dst); + } else { + build_append_byte(var->buf, 0x00 /* NullNameOp */); + } + return var; +} + /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefStore */ Aml *aml_store(Aml *val, Aml *target) { @@ -834,6 +847,21 @@ Aml *aml_call5(const char *method, Aml *arg1, Aml *arg= 2, Aml *arg3, Aml *arg4, return var; } =20 +/* helper to call method with 5 arguments */ +Aml *aml_call6(const char *method, Aml *arg1, Aml *arg2, Aml *arg3, Aml *a= rg4, + Aml *arg5, Aml *arg6) +{ + Aml *var =3D aml_alloc(); + build_append_namestring(var->buf, "%s", method); + aml_append(var, arg1); + aml_append(var, arg2); + aml_append(var, arg3); + aml_append(var, arg4); + aml_append(var, arg5); + aml_append(var, arg6); + return var; +} + /* * ACPI 5.0: 6.4.3.8.1 GPIO Connection Descriptor * Type 1, Large Item Name 0xC --=20 2.27.0 From nobody Tue Nov 18 07:46:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608680671; cv=none; d=zohomail.com; s=zohoarc; b=IPv7DCHXxViq6JjywcyrsK5o+6HeiXEnuzHkOANUlB9OLdDMzJAP5+GrLBxU2vvpcNeWDWXvWX0sj7qI8zr5BFEQZ2KNXXQtAAvXwfDZTin0iEoI2J4uh71xayYWUFegiMJVLFDBlyOcQc0bO2ngz+vwwIfGQYPSFSKSZQ45084= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608680671; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/XNPbrJo+nneJpKzihPhHAVZV3XZKj1wCd+tWd0EZEY=; b=HZHZc5xHT/zYsLKWoDgz0R3JwYSaeAfUNC0RTJwCpXLg4PAF8Tyi9RF5of5xsxNC2EFz31GF0cjTHPgajHkmZATDAh9LFHNxNZ1wqMI7zI/9bk+CkqS3K8aFfK4I0YxXpngR7mFcLH6HgtaimJ4NaeOafaQFZiG1IeaF6C9n+wo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608680671193181.6340670177227; Tue, 22 Dec 2020 15:44:31 -0800 (PST) Received: from localhost ([::1]:48218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krrKQ-0003jU-5g for importer@patchew.org; Tue, 22 Dec 2020 18:44:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krrG9-0000MP-OH for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krrG6-0005HJ-UB for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:05 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-261-IZBGEEyeP02dBzUrqpf_JQ-1; Tue, 22 Dec 2020 18:39:52 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BFB54801817; Tue, 22 Dec 2020 23:39:51 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 93E925D9CC; Tue, 22 Dec 2020 23:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608680394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XNPbrJo+nneJpKzihPhHAVZV3XZKj1wCd+tWd0EZEY=; b=KiR6EqTI2lUy7n7uIvtkiWR3pvL72rGzjWIMnDeZf9b65Ri2GMtPvrlvOb36ewD141e7l3 9yWV+xpt8+XYxrhycmyvp8cx3N1WY1ken4rVPFxGhmke9hXz376vZ2PeFzlud7zznWgHuf WxnixsU3oPKXJJ2GvCep5txDIu/K7pk= X-MC-Unique: IZBGEEyeP02dBzUrqpf_JQ-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [RFC 2/5] tests: acpi: temporary whitelist DSDT changes Date: Tue, 22 Dec 2020 18:39:31 -0500 Message-Id: <20201222233934.451578-3-imammedo@redhat.com> In-Reply-To: <20201222233934.451578-1-imammedo@redhat.com> References: <20201222233934.451578-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jusual@redhat.com, laine@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios= -tables-test-allowed-diff.h index dfb8523c8b..5c695cdf37 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,22 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/pc/DSDT", +"tests/data/acpi/pc/DSDT.acpihmat", +"tests/data/acpi/pc/DSDT.bridge", +"tests/data/acpi/pc/DSDT.cphp", +"tests/data/acpi/pc/DSDT.dimmpxm", +"tests/data/acpi/pc/DSDT.hpbridge", +"tests/data/acpi/pc/DSDT.hpbrroot", +"tests/data/acpi/pc/DSDT.ipmikcs", +"tests/data/acpi/pc/DSDT.memhp", +"tests/data/acpi/pc/DSDT.numamem", +"tests/data/acpi/pc/DSDT.roothp", +"tests/data/acpi/q35/DSDT", +"tests/data/acpi/q35/DSDT.acpihmat", +"tests/data/acpi/q35/DSDT.bridge", +"tests/data/acpi/q35/DSDT.cphp", +"tests/data/acpi/q35/DSDT.dimmpxm", +"tests/data/acpi/q35/DSDT.ipmibt", +"tests/data/acpi/q35/DSDT.memhp", +"tests/data/acpi/q35/DSDT.mmio64", +"tests/data/acpi/q35/DSDT.numamem", +"tests/data/acpi/q35/DSDT.tis", --=20 2.27.0 From nobody Tue Nov 18 07:46:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608680419; cv=none; d=zohomail.com; s=zohoarc; b=IYpGeBryNRNVKkj5T07jRbOe+Pc6T5sRw81NOYIemvBjRgpPmPUKiMAX6+KxdOoPjVm7N/ojtkuHOvzpx3VdmrAq3iKvn+KiNk5AF3Q539M43RrncpCzVLAmHSbyiKL2ZBrhIFVsVdpxTXZzGvHt6KSxIv5oJRZ607z3MR/4M9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608680419; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jRqJIElpNRLwzQi92GzEhWLqvO2sH/KNhssq3GcOdPw=; b=EDyLsnS6aXf6gkA6ZsGCEKyYWGgLRAC6W6l+IX6W1IObeGOqVFgVrKJJJNkMif61o9HCv2TGvkBg7HD2KcN3eRCRjY7Si/6B+JN2b9mLZCUFV5vreQTHFdsb63iQY/vMD4Kpm9ObQnhQIzmqK4uBxhMH0w72z7GvR9nw5TQDXHA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1608680419885277.444400677012; Tue, 22 Dec 2020 15:40:19 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-cdp7O_Y3OMmC7ueqfitzVQ-1; Tue, 22 Dec 2020 18:40:16 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55B90107ACE4; Tue, 22 Dec 2020 23:40:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5EB8660C5B; Tue, 22 Dec 2020 23:40:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 291704A7C6; Tue, 22 Dec 2020 23:39:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0BMNdvq6016669 for ; Tue, 22 Dec 2020 18:39:57 -0500 Received: by smtp.corp.redhat.com (Postfix) id 154415D9D3; Tue, 22 Dec 2020 23:39:57 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1528B5D9CC; Tue, 22 Dec 2020 23:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608680418; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=jRqJIElpNRLwzQi92GzEhWLqvO2sH/KNhssq3GcOdPw=; b=WaZMAiXX0VUggBcEK4vXb+UPhdlqYbHOsseJVytDbSf1yk8T2B2MSauysQtjx4S8/oQWk4 PVq38cbBOr59s1pjg9KMonTEul4sYV+WeMP/k6Mk865HiIBw08YhX5so9g42j395Den/Ss W2ebUzq8a2WuPXw8SDAdg2V1hgyfjG8= X-MC-Unique: cdp7O_Y3OMmC7ueqfitzVQ-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [RFC 3/5] pci: introduce apci-index property for PCI device Date: Tue, 22 Dec 2020 18:39:32 -0500 Message-Id: <20201222233934.451578-4-imammedo@redhat.com> In-Reply-To: <20201222233934.451578-1-imammedo@redhat.com> References: <20201222233934.451578-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: libvir-list@redhat.com, jusual@redhat.com, laine@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In x86/ACPI world, since systemd v197, linux distros are using predictable network interface naming since systemd v197. Which on QEMU based VMs results into path based naming scheme, that names network interfaces based on PCI topology. With this one has to plug NIC in exacly the same bus/slot, which was used when disk image was first provisioned/configured or one risks to loose network configuration due to NIC being renamed to actually used topology. That also restricts freedom reshape PCI configuration of VM without need to reconfigure used guest image. systemd also offers "onboard" naming scheme which is preffered over PCI slot/topology one, provided that firmware implements: " PCI Firmware Specification 3.1 4.6.7. DSM for Naming a PCI or PCI Express Device Under Operating Systems " that allows to assign user defined index to PCI device, which systemd will use to name NIC. For example, using -device e1000,acpi-index=3D100 guest will rename NIC to 'eno100', where 'eno' is default prefix for "onboard" naming scheme. This doesn't reqiure any advance configuration on guest side. Hope is that 'acpi-index' will be easier to consume by mangment layer, compared to forcing specic PCI topology and/or having several disk image templates for different topologies and will help to simplify process of spawning VM from the same template without need to reconfigure guest network configuration. this patch adds, 'acpi-index'* property and wires up (abuses) unused pci hotplug registers to pass index value to AML code at runtime. Following patch will add corresponding _DSM code and wire it up to PCI devices described in ACPI. *) name comes from linux kernel terminology Signed-off-by: Igor Mammedov --- CC: libvir-list@redhat.com include/hw/acpi/pcihp.h | 7 ++++++- include/hw/pci/pci.h | 1 + hw/acpi/pci.c | 6 ++++++ hw/acpi/pcihp.c | 25 ++++++++++++++++++++++++- hw/i386/acpi-build.c | 10 ++++++++++ hw/pci/pci.c | 1 + 6 files changed, 48 insertions(+), 2 deletions(-) diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h index dfd375820f..72d1773ca1 100644 --- a/include/hw/acpi/pcihp.h +++ b/include/hw/acpi/pcihp.h @@ -46,6 +46,7 @@ typedef struct AcpiPciHpPciStatus { typedef struct AcpiPciHpState { AcpiPciHpPciStatus acpi_pcihp_pci_status[ACPI_PCIHP_MAX_HOTPLUG_BUS]; uint32_t hotplug_select; + uint32_t acpi_index; PCIBus *root; MemoryRegion io; bool legacy_piix; @@ -71,6 +72,8 @@ void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root= _off); =20 extern const VMStateDescription vmstate_acpi_pcihp_pci_status; =20 +bool vmstate_acpi_pcihp_use_acpi_index(void *opaque, int version_id); + #define VMSTATE_PCI_HOTPLUG(pcihp, state, test_pcihp) \ VMSTATE_UINT32_TEST(pcihp.hotplug_select, state, \ test_pcihp), \ @@ -78,6 +81,8 @@ extern const VMStateDescription vmstate_acpi_pcihp_pci_st= atus; ACPI_PCIHP_MAX_HOTPLUG_BUS, \ test_pcihp, 1, \ vmstate_acpi_pcihp_pci_status, \ - AcpiPciHpPciStatus) + AcpiPciHpPciStatus), \ + VMSTATE_UINT32_TEST(pcihp.acpi_index, state, \ + vmstate_acpi_pcihp_use_acpi_index) =20 #endif diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 259f9c992d..e592532558 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -357,6 +357,7 @@ struct PCIDevice { =20 /* ID of standby device in net_failover pair */ char *failover_pair_id; + uint32_t acpi_index; }; =20 void pci_register_bar(PCIDevice *pci_dev, int region_num, diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c index 9510597a19..07d5101d83 100644 --- a/hw/acpi/pci.c +++ b/hw/acpi/pci.c @@ -27,6 +27,7 @@ #include "hw/acpi/aml-build.h" #include "hw/acpi/pci.h" #include "hw/pci/pcie_host.h" +#include "hw/acpi/pcihp.h" =20 void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info) { @@ -59,3 +60,8 @@ void build_mcfg(GArray *table_data, BIOSLinker *linker, A= cpiMcfgInfo *info) "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); } =20 +bool vmstate_acpi_pcihp_use_acpi_index(void *opaque, int version_id) +{ + AcpiPciHpState *s =3D opaque; + return s->acpi_index; +} diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 9dc4d3e2db..9634567e3a 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -347,7 +347,8 @@ static uint64_t pci_read(void *opaque, hwaddr addr, uns= igned int size) trace_acpi_pci_down_read(val); break; case PCI_EJ_BASE: - /* No feature defined yet */ + val =3D s->acpi_index; + s->acpi_index =3D 0; trace_acpi_pci_features_read(val); break; case PCI_RMV_BASE: @@ -367,8 +368,30 @@ static uint64_t pci_read(void *opaque, hwaddr addr, un= signed int size) static void pci_write(void *opaque, hwaddr addr, uint64_t data, unsigned int size) { + int slot; + PCIBus *bus; + BusChild *kid, *next; AcpiPciHpState *s =3D opaque; + + s->acpi_index =3D 0; switch (addr) { + case PCI_UP_BASE: + slot =3D ctz32(data); + + if (s->hotplug_select >=3D ACPI_PCIHP_MAX_HOTPLUG_BUS) { + break; + } + + bus =3D acpi_pcihp_find_hotplug_bus(s, s->hotplug_select); + QTAILQ_FOREACH_SAFE(kid, &bus->qbus.children, sibling, next) { + Object *o =3D OBJECT(kid->child); + PCIDevice *dev =3D PCI_DEVICE(o); + if (PCI_SLOT(dev->devfn) =3D=3D slot) { + s->acpi_index =3D object_property_get_uint(o, "acpi-index"= , NULL); + break; + } + } + break; case PCI_EJ_BASE: if (s->hotplug_select >=3D ACPI_PCIHP_MAX_HOTPLUG_BUS) { break; diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index f18b71dea9..27d2958e25 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1132,6 +1132,16 @@ static void build_piix4_pci_hotplug(Aml *table) aml_append(method, aml_return(aml_int(0))); aml_append(scope, method); =20 + method =3D aml_method("AIDX", 2, AML_NOTSERIALIZED); + aml_append(method, aml_acquire(aml_name("BLCK"), 0xFFFF)); + aml_append(method, aml_store(aml_arg(0), aml_name("BNUM"))); + aml_append(method, + aml_store(aml_shiftleft(aml_int(1), aml_arg(1)), aml_name("PCIU"))= ); + aml_append(method, aml_store(aml_name("B0EJ"), aml_local(0))); + aml_append(method, aml_release(aml_name("BLCK"))); + aml_append(method, aml_return(aml_local(0))); + aml_append(scope, method); + aml_append(table, scope); } =20 diff --git a/hw/pci/pci.c b/hw/pci/pci.c index d4349ea577..617f48ff3b 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -76,6 +76,7 @@ static Property pci_props[] =3D { QEMU_PCIE_EXTCAP_INIT_BITNR, true), DEFINE_PROP_STRING("failover_pair_id", PCIDevice, failover_pair_id), + DEFINE_PROP_UINT32("acpi-index", PCIDevice, acpi_index, -1), DEFINE_PROP_END_OF_LIST() }; =20 --=20 2.27.0 From nobody Tue Nov 18 07:46:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608681027; cv=none; d=zohomail.com; s=zohoarc; b=BS4tIMfVx6FsJhZ8oW6nMvnQbGGwOKxkq5wV/J5QSyxMDOE4Askgv55edDSxGpYBe/JXLAuKBMhHORXmJ/UWdu2I8fuBAfJIMZI9P0GPvDg4P+URHZ4+eFhonpKgVg/KRzi1WLqX5xfDc3jjwSNC92Uk/1HVDO4mwmG24CEft3Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608681027; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vG6Nf4uLUP1oDiFldWPLguPrfZcpaMKpYzFOBkRd4yI=; b=GL1BXDGiKO50CRLJIAwD7+ccwBmBirdamgVweH6CJy7KteJPI72bsLhU4EfxZQbVSMU152pMYp1xZ9LjBu+YnGKq5zSsxOjbHgOIMAlG+LleEOrBJISuyN7jlGBF6Ge/8QBH9RE8xpW2uYyZ7HcuewUpRHO3tVjSA6y+3UQ+6MQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160868102734423.51975531421226; Tue, 22 Dec 2020 15:50:27 -0800 (PST) Received: from localhost ([::1]:55782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krrQ9-0007io-U9 for importer@patchew.org; Tue, 22 Dec 2020 18:50:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krrGR-0000Zp-TC for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krrGO-0005QW-Vk for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:22 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-OW4vXeubNaCa0o8QtpKIaw-1; Tue, 22 Dec 2020 18:40:18 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4FC22EC1A2; Tue, 22 Dec 2020 23:40:17 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6093F5D9CC; Tue, 22 Dec 2020 23:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608680420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vG6Nf4uLUP1oDiFldWPLguPrfZcpaMKpYzFOBkRd4yI=; b=ZHN0JXOdd3dISl8tSWx7yYPDzlh2yAPQOgWBQNvCJWnwvI8DeDITUuvgV0OsPYOPpm7BHU kIYkzRj41uV4nyF2SRwLBYtWqBTTp960UWBOGUrrG7bcRRVlQKmnwiZnXgfKn14gBybWLh v87LII1ZdrJ/Znki/J3BoKul9zldyoA= X-MC-Unique: OW4vXeubNaCa0o8QtpKIaw-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [RFC 4/5] pci: acpi: add _DSM method to PCI devices Date: Tue, 22 Dec 2020 18:39:33 -0500 Message-Id: <20201222233934.451578-5-imammedo@redhat.com> In-Reply-To: <20201222233934.451578-1-imammedo@redhat.com> References: <20201222233934.451578-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jusual@redhat.com, laine@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Implement _DSM according to: PCI Firmware Specification 3.1 4.6.7. DSM for Naming a PCI or PCI Express Device Under Operating Systems and wire it up to cold and hot-plugged PCI devices. Feature depends on ACPI hotplug being enabled (as that provides PCI devices descriptions in ACPI and MMIO registers that are reused to fetch acpi-index). acpi-index should work for - cold plugged NICs: $QEMU -evice e1000,acpi-index=3D100 =3D> 'eno100' - hot-plugged (monitor) device_add e1000,acpi-index=3D200,id=3Dremove_me =3D> 'eno200' - replugged (monitor) device_del remove_me (monitor) device_add e1000,acpi-index=3D1 =3D> 'eno1' Windows also sees index under "PCI Label Id" field in properties dialog but otherwise it doesn't seem to have any effect. Signed-off-by: Igor Mammedov --- include/hw/acpi/pci.h | 1 + hw/acpi/pci.c | 78 +++++++++++++++++++++++++++++++++++++++++++ hw/i386/acpi-build.c | 21 ++++++++++-- 3 files changed, 97 insertions(+), 3 deletions(-) diff --git a/include/hw/acpi/pci.h b/include/hw/acpi/pci.h index bf2a3ed0ba..5e1eb2a96a 100644 --- a/include/hw/acpi/pci.h +++ b/include/hw/acpi/pci.h @@ -34,4 +34,5 @@ typedef struct AcpiMcfgInfo { } AcpiMcfgInfo; =20 void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info= ); +Aml *aml_pci_device_dsm(void); #endif diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c index 07d5101d83..6d49d515d3 100644 --- a/hw/acpi/pci.c +++ b/hw/acpi/pci.c @@ -65,3 +65,81 @@ bool vmstate_acpi_pcihp_use_acpi_index(void *opaque, int= version_id) AcpiPciHpState *s =3D opaque; return s->acpi_index; } + +Aml *aml_pci_device_dsm(void) +{ + Aml *method, *UUID, *ifctx, *ifctx1, *ifctx2, *ifctx3, *elsectx; + Aml *acpi_index =3D aml_local(0); + Aml *zero =3D aml_int(0); + Aml *bnum =3D aml_arg(4); + Aml *sun =3D aml_arg(5); + + method =3D aml_method("PDSM", 6, AML_SERIALIZED); + + /* + * PCI Firmware Specification 3.1 + * 4.6. _DSM Definitions for PCI + */ + UUID =3D aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D"); + ifctx =3D aml_if(aml_equal(aml_arg(0), UUID)); + { + aml_append(ifctx, aml_store(aml_call2("AIDX", bnum, sun), acpi_ind= ex)); + ifctx1 =3D aml_if(aml_equal(aml_arg(2), zero)); + { + uint8_t byte_list[1]; + + ifctx2 =3D aml_if(aml_equal(aml_arg(1), aml_int(2))); + { + /* + * advertise function 7 if device has acpi-index + */ + ifctx3 =3D aml_if(aml_lnot(aml_equal(acpi_index, zero))); + { + byte_list[0] =3D + 1 /* have supported functions */ | + 1 << 7 /* support for function 7 */ + ; + aml_append(ifctx3, aml_return(aml_buffer(1, byte_list)= )); + } + aml_append(ifctx2, ifctx3); + } + aml_append(ifctx1, ifctx2); + + byte_list[0] =3D 0; /* nothing supported */ + aml_append(ifctx1, aml_return(aml_buffer(1, byte_list))); + } + aml_append(ifctx, ifctx1); + elsectx =3D aml_else(); + /* + * PCI Firmware Specification 3.1 + * 4.6.7. _DSM for Naming a PCI or PCI Express Device Under + * Operating Systems + */ + ifctx1 =3D aml_if(aml_equal(aml_arg(2), aml_int(7))); + { + Aml *pkg =3D aml_package(2); + Aml *label =3D aml_local(2); + Aml *ret =3D aml_local(1); + + aml_append(ifctx1, aml_concatenate(aml_string("PCI Device "), + aml_to_decimalstring(acpi_index, NULL), label)); + + aml_append(pkg, zero); + aml_append(pkg, aml_string("placeholder")); + aml_append(ifctx1, aml_store(pkg, ret)); + /* + * update apci-index to actual value + */ + aml_append(ifctx1, aml_store(acpi_index, aml_index(ret, zero)= )); + /* + * update device label to actual value + */ + aml_append(ifctx1, aml_store(label, aml_index(ret, aml_int(1)= ))); + aml_append(ifctx1, aml_return(ret)); + } + aml_append(elsectx, ifctx1); + aml_append(ifctx, elsectx); + } + aml_append(method, ifctx); + return method; +} diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 27d2958e25..447ad39c35 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -385,6 +385,13 @@ static void build_append_pci_bus_devices(Aml *parent_s= cope, PCIBus *bus, aml_call2("PCEJ", aml_name("BSEL"), aml_name("_SUN")) ); aml_append(dev, method); + method =3D aml_method("_DSM", 4, AML_SERIALIZED); + aml_append(method, + aml_return(aml_call6("PDSM", aml_arg(0), aml_arg(1), + aml_arg(2), aml_arg(3), + aml_name("BSEL"), aml_name("_SUN"= ))) + ); + aml_append(dev, method); aml_append(parent_scope, dev); =20 build_append_pcihp_notify_entry(notify_method, slot); @@ -412,6 +419,14 @@ static void build_append_pci_bus_devices(Aml *parent_s= cope, PCIBus *bus, dev =3D aml_device("S%.02X", PCI_DEVFN(slot, 0)); aml_append(dev, aml_name_decl("_ADR", aml_int(slot << 16))); =20 + aml_append(dev, aml_name_decl("_SUN", aml_int(slot))); + method =3D aml_method("_DSM", 4, AML_SERIALIZED); + aml_append(method, + aml_return(aml_call6("PDSM", aml_arg(0), aml_arg(1), aml_arg(2), + aml_arg(3), aml_name("BSEL"), aml_name("_S= UN"))) + ); + aml_append(dev, method); + if (pc->class_id =3D=3D PCI_CLASS_DISPLAY_VGA) { /* add VGA specific AML methods */ int s3d; @@ -434,9 +449,7 @@ static void build_append_pci_bus_devices(Aml *parent_sc= ope, PCIBus *bus, aml_append(method, aml_return(aml_int(s3d))); aml_append(dev, method); } else if (hotplug_enabled_dev) { - /* add _SUN/_EJ0 to make slot hotpluggable */ - aml_append(dev, aml_name_decl("_SUN", aml_int(slot))); - + /* add _EJ0 to make slot hotpluggable */ method =3D aml_method("_EJ0", 1, AML_NOTSERIALIZED); aml_append(method, aml_call2("PCEJ", aml_name("BSEL"), aml_name("_SUN")) @@ -1142,6 +1155,8 @@ static void build_piix4_pci_hotplug(Aml *table) aml_append(method, aml_return(aml_local(0))); aml_append(scope, method); =20 + aml_append(scope, aml_pci_device_dsm()); + aml_append(table, scope); } =20 --=20 2.27.0 From nobody Tue Nov 18 07:46:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608680603; cv=none; d=zohomail.com; s=zohoarc; b=FXnau+FUREN9XW7CkThAXBLY06cVPOnBVY41HpVKee7duGhVmVDXwpXg8nJfNTTjR3kb97U/mSRJvIv81A1DJV+2kdZ/XvUxATcm7wdZLW0IZoBQXxBZx6ZbrM07iDDqLYZfDd8B21ZBz8WHhZZ8Zh6j5ylwfB2czteSPD7BixY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608680603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xFH0cwCqPCVgEcaMaptGyUomCN52+5h9kuiiYvyjfug=; b=Zvz4zD9/P71gNx7Fhj0oB7YA8Im0FzQ5YYhYDHLwNqEwGaFKSvr4MbS1X1jx2nUblbxCqQD7khZUzGNbvOMfzrbQGfn6SNfN/QtInj3BRLLXfU9DngdKYjE3SPjsmUipIg23CpNx7iVOGZMAivDKytAixvwx/r6W1+QJptC2zA8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608680603765225.8071463916599; Tue, 22 Dec 2020 15:43:23 -0800 (PST) Received: from localhost ([::1]:45098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krrJK-0002G7-DV for importer@patchew.org; Tue, 22 Dec 2020 18:43:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krrGt-0000iK-Ff for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krrGc-0005V2-Q3 for qemu-devel@nongnu.org; Tue, 22 Dec 2020 18:40:51 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-yh2pAKnPO8eSy7FqNODT5w-1; Tue, 22 Dec 2020 18:40:26 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73A1C59; Tue, 22 Dec 2020 23:40:25 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 99CDF5D9CC; Tue, 22 Dec 2020 23:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608680428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xFH0cwCqPCVgEcaMaptGyUomCN52+5h9kuiiYvyjfug=; b=NZNmdRzfGSUxrPU1YEI1w+0FKb4WYPe/jYgXW3cmrIcPWLkoRR2TBNeuqsSRg5riQ2YpmU DMOLuIFeKZiav0mOlxMSUQvmC3Ct2XjUuKJHcq9zd8B83ceB1tW7cjWm78dm1NqbO+OzGl IZE44To3OConqBDChFUzP+fnEYA9QgY= X-MC-Unique: yh2pAKnPO8eSy7FqNODT5w-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [RFC 5/5] tests: acpi: update expected data files Date: Tue, 22 Dec 2020 18:39:34 -0500 Message-Id: <20201222233934.451578-6-imammedo@redhat.com> In-Reply-To: <20201222233934.451578-1-imammedo@redhat.com> References: <20201222233934.451578-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jusual@redhat.com, laine@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Expected change is addition of AIDX and PDSM methods at PCI0 scope and _DSM methods (+ _SUN field where it was missing) to each PCI device slot @@ -277,6 +277,54 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", = 0x00000001) Release (BLCK) Return (Zero) } + + Method (AIDX, 2, NotSerialized) + { + Acquire (BLCK, 0xFFFF) + BNUM =3D Arg0 + PCIU =3D (One << Arg1) + Local0 =3D B0EJ /* \_SB_.PCI0.B0EJ */ + Release (BLCK) + Return (Local0) + } + + Method (PDSM, 6, Serialized) + { + If ((Arg0 =3D=3D ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d= ") /* Device Labeling Interface */)) + { + Local0 =3D AIDX (Arg4, Arg5) + If ((Arg2 =3D=3D Zero)) + { + If ((Arg1 =3D=3D 0x02)) + { + If ((Local0 !=3D Zero)) + { + Return (Buffer (One) + { + 0x81 = // . + }) + } + } + + Return (Buffer (One) + { + 0x00 = // . + }) + } + ElseIf ((Arg2 =3D=3D 0x07)) + { + Concatenate ("PCI Device ", ToDecimalString (Local0), = Local2) + Local1 =3D Package (0x02) + { + Zero, + "placeholder" + } + Local1 [Zero] =3D Local0 + Local1 [One] =3D Local2 + Return (Local1) + } + } + } } Scope (_SB) @@ -883,11 +931,22 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT",= 0x00000001) Device (S00) { Name (_ADR, Zero) // _ADR: Address + Name (_SUN, Zero) // _SUN: Slot User Number + Method (_DSM, 4, Serialized) // _DSM: Device-Specific Met= hod + { + Return (PDSM (Arg0, Arg1, Arg2, Arg3, BSEL, _SUN)) + } } [...] @@ -912,6 +971,11 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", = 0x00000001) { PCEJ (BSEL, _SUN) } + + Method (_DSM, 4, Serialized) // _DSM: Device-Specific Met= hod + { + Return (PDSM (Arg0, Arg1, Arg2, Arg3, BSEL, _SUN)) + } } [...] Signed-off-by: Igor Mammedov --- tests/data/acpi/pc/DSDT | Bin 5065 -> 6023 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 6390 -> 7348 bytes tests/data/acpi/pc/DSDT.bridge | Bin 6924 -> 8689 bytes tests/data/acpi/pc/DSDT.cphp | Bin 5529 -> 6487 bytes tests/data/acpi/pc/DSDT.dimmpxm | Bin 6719 -> 7677 bytes tests/data/acpi/pc/DSDT.hpbridge | Bin 5026 -> 5990 bytes tests/data/acpi/pc/DSDT.hpbrroot | Bin 3084 -> 3177 bytes tests/data/acpi/pc/DSDT.ipmikcs | Bin 5137 -> 6095 bytes tests/data/acpi/pc/DSDT.memhp | Bin 6424 -> 7382 bytes tests/data/acpi/pc/DSDT.numamem | Bin 5071 -> 6029 bytes tests/data/acpi/pc/DSDT.roothp | Bin 5261 -> 6324 bytes tests/data/acpi/q35/DSDT | Bin 7801 -> 7863 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin 9126 -> 9188 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7819 -> 7911 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8265 -> 8327 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9455 -> 9517 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7876 -> 7938 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9160 -> 9222 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8932 -> 9024 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7807 -> 7869 bytes tests/data/acpi/q35/DSDT.tis | Bin 8407 -> 8468 bytes 21 files changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT index f6173df1d598767a79aa34ad7585ad7d45c5d4f3..b9afc0a458d77b7346fca9cd2d8= 797a4d4ed8302 100644 GIT binary patch delta 1298 zcmX@9-mcH(66_MvF3!NfxMw5R9wsJd;mIeM+UiBL9X(wln4*=3DPe4M@i|1ZdJ@(cAX zsASA!2ypfcEpRe$^-73V2T3kT5bFC3p8KBMJKf^ zGdWd(VR`~XQh|^F69aESPGWLuMt)98Y7s+XK|)6&14BVlMu~8JStxAax*# z=3Dq4|gU_+=3D{9tH*`h z;5{J)QUU~g;YvtB0U-sm2`M;6NWn)!3SHx&QzG delta 321 zcmZqIKdH{;66_LkQka2(aluBeJxoj<9FtElwQc^%T*hhSS`ZT->=3DZBHn;+opX~5wW z?CQf1-NYSiU=3DYs{@8}W)03}*P5>gG1f`cj=3D~qx%PY@zs1f{n@>0eOVP6#631f`EbX)a-ixF3|B h1f{P*X(oWs1f`!rX)RHRe4eQ0=3DJldC7y$$2T}A)^ diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acp= ihmat index 67f3f7249eaaa9404ebf0f2d0a324b8c8e3bd445..806bcbee30dc38117fbb37f433b= fbcec171ce34b 100644 GIT binary patch delta 1298 zcmexnxW$soCDdXi_!4w77wAmYa!;1cZ1x4?~ka)zKVm%s({lTU+9t9&Plzw(tl z?Ce_rGAk!HVS&`-EQSRFlQX%P7I00PoWQU|keRU&L@+G0T3|6bi;KOO7ihkMi%x1; zW^$?m!}J7(qyixUCI;SuoW$hRjQpIG)FOt&f`pDl28M#9jzmU=3DC5fB;m>2Wadn}BJ z4|a+da99X5!GOal*wu$2x=3DAzGz#yI@-q9t9fg?UR)Q>?#JRay)o+Tg`XJlq&gVcc} zqMN)}f(@Z+c^DX&AnLi8aA^<$nrG<3u!I4`Fme%qvW!7O(M?V)lO2ULWN>K)E65?F zU^*cMhX^TnOGtr)Fabw86H<^zNWn}(3XTv`@SczYDG>s`a3!RmfRKXOgcKYjq~IeV z1u~)peBn+=3DK@lMZa|tOpK}f-8LJH)>2>8O2kb)9I3g#11aEg$EuVR|~Xa&J$QSpb2 E0B6*PDgXcg delta 321 zcmdmD`OT2aCDC)^9ai_YEIS`)?kiq(wv+Rr8h(A?@-!W z1R`G#r4K`Cc2S79HHq)$ diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge index 643390f4c4138b37fc481656d3f555d0eeedcb02..fd0c98e8adacada8252ed74f887= 773feb275bfc8 100644 GIT binary patch delta 2372 zcmeA%`{>N&66_N4QIUaxF>fQ+9wsJd;mIeM+UiBL9X(wln4*=3DPe4M@i|1ZdJ@(cAX zsASA!2ypfcEpRe$^-73V2T3kT5bFC3p8KBMJKf^ zGdWd(VR`~XQh|^F69aESPGWLuMt)98Y7s+XK|)6&14BVlMMk$u^4C=3DGt@9< zT!w+2%NX5cGg*gMSq7J?=3Dq5*&$w9p8coaCXOs?V8z^`CAAqA}>1WedKNWpDF3fM#m zSYb#=3DK@1@U?SvHk=3DOf^TyM#>O5F=3Dnh13v);afD3hB&2{*fPfYE37NnpPQV0HLJATH zDd;AoU>hL?4+$yYks#m;b3zK%3lcD)myiiN2q`cSB47odq$WRF3AMReh?9v4n6XE* bC9sqRhQnyKgoMLrwuFSk0A))($$N|d2}8v< delta 595 zcmez9++)V&66_MfBhA3T_+lg19wsIaj>#vO+BW}WF5@)vcoGvI>=3DZBH@Fc+5(}2S% z*wu$2x`{j3z#yI@-q9rp$k7TmgmQQo7?>C)Kjf8_^e+oGw1B7p3NkZ*H8MswsZ2KG zQ)Z5C(wJPzrw*hwC-30X0MmbFC3p8KBMJKf^ zGdWd(VR`~XQh|^F69aESPGWLuMt)98Y7s+XK|)6&14BVlMKE9t&gQ zgPr0992NpiFyL?scJ*P1Zqf`kFo@@fcXSD2;D`?n^u~8JStxAax*# z=3Dq4|gU_+=3D{9tH*`h8N=3Dkb-nV3MLU!u$Pd67lafD3li{!9U%pogcM96 zq+mZG1+NGx5EUZe3kO09vI!}eMo7UyLJHmxQXno&z!y%06yy?8Fhf|AAFUwRyhHdQ FBLHotgn$45 delta 321 zcmca^G*g?)CD=3DZBHn;+opX~5wW z?CQf1-NYSiU=3DYs{@8}W)0MCzACz_yhRC-;=3D~GaePXr03}*P81@a g1f`cj=3D~qx%PYfbo1f{n@>0eOVPF!dXi_!4w77wAmYa!;1cZ1x4?~ka)zKVm%s({lTU+9t9&Plzw(tl z?Ce_rGAk!HVS&`-EQSRFlQX%P7I00PoWQU|keRU&L@+G0T3|6bi;KOO7ihkMi%x1; zW^$?m!}J7(qyixUCI;SuoW$hRjQpIG)FOt&f`pDl28M#9jzmU=3DC5fB;nBVZ%dn}BJ z4|a+da99X5!GOal*wu$2x=3DAzGz#yI@-q9t9fg?UR)Q>?#JRay)o+Tg`XJlq&gVcc} zqMN)}f(@Z+c^DX&AnLi8aA^<$nrG<3u!I4`Fmjn(EzHN{#4@=3D{SVIPvmgpv+f~|xU zJRqciTZDiWW`qn7ZNWpeO3LX(sz$;3?7Z!vRBok85M@Yd=3DLJFP`Qot`pz!z48 z6r>VTFoBSQ-Gmf8Bcwo3oPaNE2q{P>q+k*u1$zl8ctJ>kumk~L*hy&eqhDDIO2m1T^N>t8AdRMF^Cb}q&c}nM1vVb z?|{;OptOT1M7#w`pMcUlVi55FC_M#A-+FC3p8KBMJKf^ zGdWd(VR`~XQh|^F69aESPGWLuMt)98Y7s+XK|)6&14BVlMu~8JStxAax*# z=3Dq4|gU_+=3D{9tH*`hZLk6#c0743?2`N}cNWn!y3jPpMpw36Y7eRy+)Dlv#f{=3DpCgcSTEq(GCO zfGC)-{+MT;tw{ofG7ZpF#{E8PS)eoU$3f{uQ2H5^))Ioq=3DRxUBQ2HB` mwi1TO*Fot+P?}8yBJKsH`=3DInCC@m%mk&hD9+&o+KG$R1zbY0H? diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpb= rroot index a3046226ec1dcb234b726029b3790dfedb3b9221..4f930ed9644a4018da96ef3e5db= edcb89ef19ee0 100644 GIT binary patch delta 177 zcmeB?cqzf<66_L^$-}_FsJfAB6?c{^cT9Y+Q@nsLSAespL3ER5uz^85N4%p;5Ccbi zaHt=3DHhnU(Dn?CJxOh;H&?2{weP1)9eMQP0JMOT**`+_HLl!G;zP OiJ@_=3Dr2$Hb;6bB#*myC}hGf|7B z4jQrHnVhgf%KiLeX5s70H28c`G{-8Mgrf}m zoPPX}QhQ=3DM{wel6WJJ@;s&A-vuT=3Dw^wWo`W9%W+R^~bQcEMi(XP*_ovy}QXH}7Sg`MuW2^`H! z*+r0>LlVa+v@#m1!{I4PA<|PGi z!265|mKY3?yw6$<4)*=3DmA~#)dh=3DD5%ykLM1Av26)U=3D0ID7`VZ}D+ZWuWQ!CAR16$r z;1&aK7znV)7HJHWFmQr_I}E&IAQVQnn8ZK@1E(0c$G`^$*vL@#pYy-wB5%Yu=3DFxzD delta 321 zcmX@FKT(6rCDl3p0}k$7BKKw#|+#Wt>K?1u^l#PVoZ1`2o(J1{_Yo zu09OWP29l-2Jsy6jxIq!j#jWCl*7Zoz{D_FolllgbFv$s26J?i=3DHxCYeGWCD878iRlFVK7i7oF6y z%;Z!BhUp0mNd-azObomQIf=3D=3Ds8TmOWsYMKl1qmIA3=3D9QH9f^z#OA&dAKl2B`x{ zL^pY{1RFxt@-Q$kLDX|G;nE-iG|$k5VF?3>VdNqJWf_BnqMMvpCMOGN$l%fpR?tUC z!A?R7o)A*NFHFDhaMkb>QW6g(rOKv0B$FKh@YNGGIV5+Mb92`P9%NP(~@ z0bke=3DQjkeV!4yIY_7hU@ijV?PF#^7DAfzChkb-H16dWX^;0+-K;^Lb8Xa&J$bMc3a E0H>0MX#fBK delta 321 zcmca+Im3v{CDC)>j}#;YEJeQ)?kiq(wsaIN?(Q2k|GfC zSSY;^N&NdN!< diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numa= mem index 40cfd933259af05ac2aee07fca32f22122255211..dbb6b182fbd3b45a6ca38d84928= 92867f9000a4e 100644 GIT binary patch delta 1288 zcmX@F-mA~$66_MvE6%{cn6{B?4-=3DEK@Z=3DLrZS^ABj-DoFOR8C2+y~^Vf|~qj*?;pp!H0|h Dh4h1Q delta 344 zcmeCxKd;W^66_LkUYLP_(Q6~u9wsIaj>#vO+BW}WuHg)DEr^K^c8VA9%@1()G~jRw zcJ*P1ZsHC$Fo@@fcXSB?a~H*Xca!3Y41)nL;A diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp index 078fc8031b479cc77b6527a2b7b4bd576b6e6028..fccb574c38ef112aa5e415ddf9a= 049d12b1c142c 100644 GIT binary patch delta 1420 zcmeCx++xV(66_MPMS_8Wap6X;Jxol_!jn%hwbhGgJ9@fAFhwgn`8a$3|6h>dXi_!4w77wAmYa!;1cZ1x4?~ka)zKVm%s({lTU+9t9&Plzw(tl z?Ce_rGAk!HVS&`-EQSRFlQX%P7I00PoWQU|keRU&L@+G0T3|6bi;KOO7ihkMi%x1; zW^$?m!}J7(qyixUCI;SuoW$hRjQpIG)FOt&f`pDl28M#9jzmU=3DC5fB;n9De`T(`u; z2Rp?J_-+Q8U=3DZD;8Ejw>&k^tF62!m}9~|n(AR-5cOP4xHL@uz$0tnyDHew0%AT;4>ME`GcG+GAln$Cn`|bl@hZ#UQWf3g z$THc7R~?T6Czi=3D&yc+lwEF`4h3?T*I2`NzGBj5&KLJBGfDOgNM!8t+-eiBlk!cV{# z{)7}%5mK;}kb(<@6#OQnKuv&vF9HcEs3D|aIUxm?2r2kWNP&hR0bc|YQcy=3Do!Ae33 ct`Ji2pO6AAAp*V#71HEKD~L9i3P~^l09X{PMgRZ+ delta 362 zcmdmD*sICq66_MvE5g9Qcx)rr9wsIaj>#vO+BW}WF5}ektci&ac8V8ptO;=3DTG>C5E z4mL1|=3DZJT731WzD(h4?&a(EaRm>4GCE1-tqH)v8R^<5Omi zZqk^X%cl;cH79T2(*V<7ptJ=3D)gkJ-t4?t-a0f@KOAyN}qw!0-_N45GXwZO5cIf3StoX6fw=3Ds IOU3w^0M)Q&D*ylh diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT index d25cd7072932886d6967f4023faac1e1fa6e836c..9506b60117147fd8ebe30fc3bf9= f124773e6a3c5 100644 GIT binary patch delta 129 zcmexqv)z`;cZ62GLEL!3GBL9Py4WK@1%6 y!J&Q(BI5Bb!M;380)S*jW>&USu&WP9BD%?wCD_0MqLv3}9z;DOF7=3Db+3 y;7~sX5%GAJU|*gk0YEY%Gb`IE*wqIl5#8j;5^P`rQOg4~52BtCm-@-w%F+NNZzI0| delta 67 zcmaFjzRaD=3DCDnU(Dn?CJxOh;H&^2{y2RsO15g2T{+6Oa0_{IaxiuU_+?s OKpjjF9b8Pfv;Y7-elC;% delta 84 zcmaEE+ilC`66_MvEyuvX*uRlWQ%=3DW&H6}jTDPF*VHNe@^Ai9Y=3D*uWs3Bi_*^h#|U3 cE7-sS!r=3DjGV3<5dPL`iP*bu4!D8|G90GZPhbpQYW diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp index 2b933ac482e6883efccbd7d6c96089602f2c0b4d..3d17ac851fe4a988006f49deccd= ffd426581b6a7 100644 GIT binary patch delta 129 zcmX@<(C*0P66_MvuE4;+sJxNur+lUhM@)RMQ@nr=3Ddw{d2L3ER5uz^85N4%p;5Ccbi yaHt=3DHhnU(Dn?CJxOh;H&^2{y2RsO15g2T{+6OZ{X$1!(~A>mvRD delta 67 zcmZp7Jn6vY66_Mr@XcsOH6#QQ@ns(fU~DTbQ5>5fk8Y+yrWAHLv)i? Ruz>}H!vj>$FgZs-8USwS5dHuF diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.di= mmpxm index bd8f8305b028ef20f9b6d1a0c69ac428d027e3d1..acde6cb0a22f031c0f8743e5cce= b3b707e3aab61 100644 GIT binary patch delta 153 zcmaFwxz>xzCD;cZ62GLEL!3GBL9Py4WK@1%6 z!J&Q(BI5Bb!M;380)S*jW>&USu&WP9BD%?wCD_0MqLv3}9z;DOF7+Zn;|yIGmN0-A LMlc4eF^B~K#WN^W delta 90 zcmZ4M_1=3D@qCDnU(Dn?CJxOh;H&^2{y2RsO15g2T{+6OT7rtI71hPB@7^j L5sWc;zZ@$71t2Hg delta 90 zcmZp&J7UY_66_LkM2>-hQEMYtiJY4oOH6#QQ@ns(fU~DTbQ5>5fk8Y+yrWAHLv)i? cuz>}H!vj>$Ai@zJZ0N$U1k5mkF^oYB02f&mN&o-=3D diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp index 9a802e4c67022386442976d5cb997ea3fc57b58f..5e3c1a4b1a34a63edcf9394455d= bbaa86a24b044 100644 GIT binary patch delta 129 zcmX@%-sZvO66_MfrozC$xM3q#g>t3~M@)RMQ@nr=3Ddw{d2L3ER5uz^85N4%p;5Ccbi yaHt=3DHhnU(Dn?CJxOh;H&^2{y2RsO15g2T{+6Oa0`v%F+PFXCof~ delta 67 zcmZqkIN{Fa66_LkLYaYq@x?~23T16KmYDcpr+5Lo0B28w=3DqB!91A};uct@8YhUg}( RU;_&XhX<&hVe)HbX#kbp5+48n diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmi= o64 index 948c2dc7264c31932b490ca00691a7c4d9aefdb0..09faed2cd326d591b6c33203dd9= c0504808a0952 100644 GIT binary patch delta 198 zcmaFjdccj#CDKClTy74cT9Y+Q@nr=3DSAespL3ER5uz^85N4%p;5Ccbi zaHt=3DHhnU(Dn?CJxOh;H&^2{y2RsO15g2T{+6OT7rtI71hPB@7^j b5sWeUoD#d9Ua%q5PM|qV5OcVga2W&uZFw`V delta 108 zcmX@$_QaLTCD$N&HU diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.nu= mamem index 44ec1b0af400da6d298284aa959aa38add7e6dd5..642a7b39cc8bb174daa098c4a37= 7df8cd5938289 100644 GIT binary patch delta 153 zcmexwv)7i(CD3 z;7~sX5%GAJU|*gk0YEY%Gb`IE*wqIl5#8j;5^P`rQOg4~52BtCmwFMPafU7oOBg^5 LBN&6#7{meqj}s^8 delta 90 zcmdmM``?DkCD3 z;7~sX5%GAJU|*gk0YEY%Gb`IE*wqIl5#8j;5^P`rQOg4~52BtCm-@}wayd)@>z*T0 delta 69 zcmbQ@bls85CDKNK --=20 2.27.0