From nobody Tue Nov 18 09:20:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608634339; cv=none; d=zohomail.com; s=zohoarc; b=Y/Z/ZJIXtS+jPtGNuA0QHVC7fpkHWEFQFI88rYrTFKb4gg9kwygBYtUcW3HbQt79+cieYlYSUgb49sCE1QpgXU8isCJoBhypATOer3qRxj654K3lms15ZCI+aL5zVTsBElYNxMbtzmCHvCqiOtt0DrmVT7IqvOdpPchkvJ/Bn1U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608634339; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E0sYaGox2GJKp9dsgvd33obQIiHUsROrvWWkkxmFIuw=; b=KMoB3DbFxjTxPJUQ+sSlrg887U0K0m3d9+KtKElCMPA5TOwlLOk7EHqduINIzqGnommZBPrfvQdKAn1Y/VtSFK+Gz19mgpLvNryuxlFgJcqHGGBHFiD4pYvgbLowSK6v1N7rc9b4+ORLHCXea+S18xz5aiV4J1pXeu1e++Iyb7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608634339171339.50571034974394; Tue, 22 Dec 2020 02:52:19 -0800 (PST) Received: from localhost ([::1]:42982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krfH7-0005tC-TU for importer@patchew.org; Tue, 22 Dec 2020 05:52:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krfAa-00059J-SL for qemu-devel@nongnu.org; Tue, 22 Dec 2020 05:45:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53770) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1krfAX-00079P-LW for qemu-devel@nongnu.org; Tue, 22 Dec 2020 05:45:32 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-ECAVa1m8PFirFUX5Xf5PTw-1; Tue, 22 Dec 2020 05:45:26 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E311DBBEE7; Tue, 22 Dec 2020 10:45:24 +0000 (UTC) Received: from gondolin.redhat.com (ovpn-113-192.ams2.redhat.com [10.36.113.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5ADA87A319; Tue, 22 Dec 2020 10:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608633929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E0sYaGox2GJKp9dsgvd33obQIiHUsROrvWWkkxmFIuw=; b=L2HBDu2e2PyUrTcRdV5qzp8Wu4+sQijAYEMQpdGv8op2ynsdgib6zTHQLSMbXdT9cCSKJm yFp/83uzemMqK5wYe3drQEqij2EAcLOw68Ubu4WO/tqw0zW/6LHjWDIYVt+KjlZqy3SusR ccCXHdcn7eqegLvObn5lu2soSR08yCE= X-MC-Unique: ECAVa1m8PFirFUX5Xf5PTw-1 From: Cornelia Huck To: Peter Maydell Subject: [PULL 10/14] tests/acceptance: Test virtio-rng on s390 via /dev/hwrng Date: Tue, 22 Dec 2020 11:44:59 +0100 Message-Id: <20201222104503.224510-11-cohuck@redhat.com> In-Reply-To: <20201222104503.224510-1-cohuck@redhat.com> References: <20201222104503.224510-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Willian Rampazzo , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Thomas Huth /dev/hwrng is only functional if virtio-rng is working right, so let's add a sanity check for this device node. Reviewed-by: Willian Rampazzo Tested-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Signed-off-by: Thomas Huth Message-Id: <20201215183623.110128-3-thuth@redhat.com> Signed-off-by: Cornelia Huck --- tests/acceptance/machine_s390_ccw_virtio.py | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance= /machine_s390_ccw_virtio.py index 3d146b9ce640..e1ad0e29b0cd 100644 --- a/tests/acceptance/machine_s390_ccw_virtio.py +++ b/tests/acceptance/machine_s390_ccw_virtio.py @@ -64,9 +64,9 @@ class S390CCWVirtioMachine(Test): '-append', kernel_command_line, '-device', 'virtio-net-ccw,devno=3Dfe.1.1111', '-device', - 'virtio-rng-ccw,devno=3Dfe.2.0000,max_revision=3D= 0', + 'virtio-rng-ccw,devno=3Dfe.2.0000,max_revision=3D= 0,id=3Drn1', '-device', - 'virtio-rng-ccw,devno=3Dfe.3.1234,max_revision=3D= 2', + 'virtio-rng-ccw,devno=3Dfe.3.1234,max_revision=3D= 2,id=3Drn2', '-device', 'zpci,uid=3D5,target=3Dzzz', '-device', 'virtio-net-pci,id=3Dzzz', '-device', 'zpci,uid=3D0xa,fid=3D12,target=3Dseri= al', @@ -96,6 +96,19 @@ class S390CCWVirtioMachine(Test): exec_command_and_wait_for_pattern(self, 'cat /sys/bus/ccw/devices/0.3.1234/virtio?/feature= s', virtio_rng_features) + # check that /dev/hwrng works - and that it's gone after ejecting + exec_command_and_wait_for_pattern(self, + 'dd if=3D/dev/hwrng of=3D/dev/null bs=3D1k count= =3D10', + '10+0 records out') + self.clear_guest_dmesg() + self.vm.command('device_del', id=3D'rn1') + self.wait_for_crw_reports() + self.clear_guest_dmesg() + self.vm.command('device_del', id=3D'rn2') + self.wait_for_crw_reports() + exec_command_and_wait_for_pattern(self, + 'dd if=3D/dev/hwrng of=3D/dev/null bs=3D1k count= =3D10', + 'dd: /dev/hwrng: No such device') # verify that we indeed have virtio-net devices (without having the # virtio-net driver handy) exec_command_and_wait_for_pattern(self, --=20 2.26.2