From nobody Tue May 14 12:42:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608240604; cv=none; d=zohomail.com; s=zohoarc; b=DTrlaFkO9YJmRUDZYBKqiNtKUNEbEZE/1uxd4mIuoNgRzlkltns8KklZQIFZpc8566sXtKuSRmX4rZ6jP+FXJ5AfYg33V2Bwc2IDbjJUoR5D5BRuWsENoGldVgf1ZAZfSBRSS2Gh3dQM/v8Wrsy2jS4viXQPG183izEubPMYhbQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608240604; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9IkhuNugCpPw+Z6+e+QlkZMvo72EP6bO1+z1cs3T5kQ=; b=KOLmpCe+5O1/YOPDpx3teWz52RGQJodOq0UOv5fvJvBUJenoLB2R9ZTZCsfYJ+PkQN53W9iWd+oCnr7Xiopo3AIu/GTt1wejreMRkqvHFeSICDZ6p61sdpWeH5Rfx24LEuc420Kds1SbgpOwpfDUFMoWyo4sOd5OVY+8bKJEBrE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608240603847819.8723208714476; Thu, 17 Dec 2020 13:30:03 -0800 (PST) Received: from localhost ([::1]:47458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpx4c-00044u-0c for importer@patchew.org; Thu, 17 Dec 2020 12:28:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpwmI-0004zw-FT for qemu-devel@nongnu.org; Thu, 17 Dec 2020 12:09:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpwmB-0005Wd-Ug for qemu-devel@nongnu.org; Thu, 17 Dec 2020 12:09:21 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-8gp5k52SNZCaT7ZmmRjaCw-1; Thu, 17 Dec 2020 12:09:11 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 59F5D800D53; Thu, 17 Dec 2020 17:09:10 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 585E660BE5; Thu, 17 Dec 2020 17:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608224955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9IkhuNugCpPw+Z6+e+QlkZMvo72EP6bO1+z1cs3T5kQ=; b=bse1H9ZzoX8+I4C8dXfUelUQjdz6XmqV/I2vVDq+lepvJDgB6f3eMJSlfCgnI0s0J+Msci NhwKzyfE+dMdM6bDVckD+0vn8GgKUBcq+vEz7t1dQjukQ1DTYJHjiNdAOTwc7v0fw+c8hq 433aeN+WGBjAb/1pJFkvKwhURyjNFjQ= X-MC-Unique: 8gp5k52SNZCaT7ZmmRjaCw-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH v6 1/3] crypto: luks: Fix tiny memory leak Date: Thu, 17 Dec 2020 19:09:02 +0200 Message-Id: <20201217170904.946013-2-mlevitsk@redhat.com> In-Reply-To: <20201217170904.946013-1-mlevitsk@redhat.com> References: <20201217170904.946013-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Alberto Garcia , qemu-block@nongnu.org, Maxim Levitsky , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When the underlying block device doesn't support the bdrv_co_delete_file interface, an 'Error' object was leaked. Signed-off-by: Maxim Levitsky Reviewed-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/crypto.c b/block/crypto.c index aef5a5721a..b3a5275132 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -735,6 +735,8 @@ fail: */ if ((r_del < 0) && (r_del !=3D -ENOTSUP)) { error_report_err(local_delete_err); + } else { + error_free(local_delete_err); } } =20 --=20 2.26.2 From nobody Tue May 14 12:42:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608247881; cv=none; d=zohomail.com; s=zohoarc; b=heapUKXvwZK4J6wgxCfHD1dDO6UChBJLV/DJkLQy6ASXLKtc0cWfOd6dgCVNUoFSvryJJB3hYdi808SnYWbjVExV9Ej+5BnaoFnVndK+5VgNS1YRvYFDAdfgO9LBS0jcJJg4PifW0adTmL86X3Af2rqo6TUAQzv/tlN1omMHJy8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608247881; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D0HlEvjqxh7cvROOp870mU65UUlLcmZ84xVHTs4xjGo=; b=YUcdKMYVcTi1Xy4iEHAFzY/c1N98K9spvT8ruYL0xn2qhXA/1u840HmalZYqVfY3YJrzsBGtd7AFfoK0g8knid+wEwOzfu90In+L8FF9lGoZtV7Kub9YYGs2+rNh2THoq6ABThA3Z6UMcEr4gtXuKNgb07bm/5OfR559434IOXc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608247881242669.6338046647377; Thu, 17 Dec 2020 15:31:21 -0800 (PST) Received: from localhost ([::1]:44554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpwpw-0007SW-Ua for importer@patchew.org; Thu, 17 Dec 2020 12:13:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpwmM-00056c-26 for qemu-devel@nongnu.org; Thu, 17 Dec 2020 12:09:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51932) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpwmI-0005X3-8D for qemu-devel@nongnu.org; Thu, 17 Dec 2020 12:09:25 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-M24k-M3fP5uOAgxAW2dwMg-1; Thu, 17 Dec 2020 12:09:16 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1456801AC2; Thu, 17 Dec 2020 17:09:15 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id C173F60BE5; Thu, 17 Dec 2020 17:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608224960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0HlEvjqxh7cvROOp870mU65UUlLcmZ84xVHTs4xjGo=; b=X1DKb5Vpb5N1CgYhiC4qi7wb0xeuBrEWBAXpdPyOzenKqpO7mzvzQvw4uaziThFG7NN51c 40MqNYYMEnThpew3kk9eTSHHxVYI2c5TeyG2z7uUpbRSZrm3TztrCYntXpv7NkQ6FqOq9t wdjtHWMCdPo/JQpXgcQyBWhXt1O6WYE= X-MC-Unique: M24k-M3fP5uOAgxAW2dwMg-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH v6 2/3] block: add bdrv_co_delete_file_noerr Date: Thu, 17 Dec 2020 19:09:03 +0200 Message-Id: <20201217170904.946013-3-mlevitsk@redhat.com> In-Reply-To: <20201217170904.946013-1-mlevitsk@redhat.com> References: <20201217170904.946013-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Maxim Levitsky , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This function wraps bdrv_co_delete_file for the common case of removing a f= ile, which was just created by format driver, on an error condition. It hides the -ENOTSUPP error, and reports all other errors otherwise. Use it in luks driver Signed-off-by: Maxim Levitsky Reviewed-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy --- block.c | 22 ++++++++++++++++++++++ block/crypto.c | 15 ++------------- include/block/block.h | 1 + 3 files changed, 25 insertions(+), 13 deletions(-) diff --git a/block.c b/block.c index f1cedac362..b9edea3b97 100644 --- a/block.c +++ b/block.c @@ -704,6 +704,28 @@ int coroutine_fn bdrv_co_delete_file(BlockDriverState = *bs, Error **errp) return ret; } =20 +void coroutine_fn bdrv_co_delete_file_noerr(BlockDriverState *bs) +{ + Error *local_err =3D NULL; + int ret; + + if (!bs) { + return; + } + + ret =3D bdrv_co_delete_file(bs, &local_err); + /* + * ENOTSUP will happen if the block driver doesn't support + * the 'bdrv_co_delete_file' interface. This is a predictable + * scenario and shouldn't be reported back to the user. + */ + if (ret =3D=3D -ENOTSUP) { + error_free(local_err); + } else if (ret < 0) { + error_report_err(local_err); + } +} + /** * Try to get @bs's logical and physical block size. * On success, store them in @bsz struct and return 0. diff --git a/block/crypto.c b/block/crypto.c index b3a5275132..1d30fde38e 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -725,19 +725,8 @@ fail: * If an error occurred, delete 'filename'. Even if the file existed * beforehand, it has been truncated and corrupted in the process. */ - if (ret && bs) { - Error *local_delete_err =3D NULL; - int r_del =3D bdrv_co_delete_file(bs, &local_delete_err); - /* - * ENOTSUP will happen if the block driver doesn't support - * the 'bdrv_co_delete_file' interface. This is a predictable - * scenario and shouldn't be reported back to the user. - */ - if ((r_del < 0) && (r_del !=3D -ENOTSUP)) { - error_report_err(local_delete_err); - } else { - error_free(local_delete_err); - } + if (ret) { + bdrv_co_delete_file_noerr(bs); } =20 bdrv_unref(bs); diff --git a/include/block/block.h b/include/block/block.h index c9d7c58765..af03022723 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -428,6 +428,7 @@ int bdrv_freeze_backing_chain(BlockDriverState *bs, Blo= ckDriverState *base, Error **errp); void bdrv_unfreeze_backing_chain(BlockDriverState *bs, BlockDriverState *b= ase); int coroutine_fn bdrv_co_delete_file(BlockDriverState *bs, Error **errp); +void coroutine_fn bdrv_co_delete_file_noerr(BlockDriverState *bs); =20 =20 typedef struct BdrvCheckResult { --=20 2.26.2 From nobody Tue May 14 12:42:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608248043; cv=none; d=zohomail.com; s=zohoarc; b=VoKwm4GmkkrVnZ1rrXj2SdQdfFIPwHphV01VNAqRwgjpLrC5OI5uXgT9CfAxacjIDXXVZtCn19VjZvkTlHiOgAGHwIA/pXTpYScdS0cgHDB7pH4edC2CPMqswCKsLXCag5+pJR5L70VoDvS0pJGTiEs5MnEBcSbs+IZyb2WBHYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608248043; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NXHRHevDuDHBmrbi+Qd1cRZtQl8RBWFSvvZJHFj2YC4=; b=KhCQgtY64GAlgnS8SWxwf7MTjkutu0RVGufyO61Amh+jlKktfP/ta9NSFfi/75bHRA1dMk6kPR9Owh5n6vjW10xmItl0kPGOJXSw+2jx2hrRyjVGMjFBnhNRJH5Zz+YX9ZzG7Co/VYZUCMAAc/yXZfdXQ9byX+k41QVbq/Ws978= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608248043923963.2062356374944; Thu, 17 Dec 2020 15:34:03 -0800 (PST) Received: from localhost ([::1]:54582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpwv7-0003Vb-8p for importer@patchew.org; Thu, 17 Dec 2020 12:18:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpwmN-00059m-8W for qemu-devel@nongnu.org; Thu, 17 Dec 2020 12:09:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpwmL-0005XP-6Y for qemu-devel@nongnu.org; Thu, 17 Dec 2020 12:09:26 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-Q8D8qebyOryfRP1bAv6wPA-1; Thu, 17 Dec 2020 12:09:21 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4DF2800D55; Thu, 17 Dec 2020 17:09:20 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3706F60BE5; Thu, 17 Dec 2020 17:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608224963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NXHRHevDuDHBmrbi+Qd1cRZtQl8RBWFSvvZJHFj2YC4=; b=h/+CPWf6h3y1fvutaatbAw1QGzG49MOkfSJ8qAjnb++tu/kkZ68VK1y8VY8Kce4GVyPN++ 61UD+Xg5c4lY5K4LH87L6abrdjjbH4NJlD2OmQq6nTksbi6xf/oVcPpnq2kSpU7mbl8s7c at11vfYb8KIByMzs5f2C0CizWs+l7Sk= X-MC-Unique: Q8D8qebyOryfRP1bAv6wPA-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH v6 3/3] block: qcow2: remove the created file on initialization error Date: Thu, 17 Dec 2020 19:09:04 +0200 Message-Id: <20201217170904.946013-4-mlevitsk@redhat.com> In-Reply-To: <20201217170904.946013-1-mlevitsk@redhat.com> References: <20201217170904.946013-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Maxim Levitsky , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" If the qcow initialization fails, we should remove the file if it was already created, to avoid leaving stale files around. We already do this for luks raw images. Signed-off-by: Maxim Levitsky Reviewed-by: Alberto Garcia Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 3a90ef2786..a8638d250a 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3847,12 +3847,14 @@ static int coroutine_fn qcow2_co_create_opts(BlockD= river *drv, =20 /* Create the qcow2 image (format layer) */ ret =3D qcow2_co_create(create_options, errp); +finish: if (ret < 0) { - goto finish; + bdrv_co_delete_file_noerr(bs); + bdrv_co_delete_file_noerr(data_bs); + } else { + ret =3D 0; } =20 - ret =3D 0; -finish: qobject_unref(qdict); bdrv_unref(bs); bdrv_unref(data_bs); --=20 2.26.2