From nobody Sat May 18 20:15:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608246008; cv=none; d=zohomail.com; s=zohoarc; b=CEfAOzSutNqQPZ32TU5N5jIwu/ZB8aluAu+5lCrZ7/bIj9XJsPY9JCM2/axb2ORxW8ETwzsPDpVHxCDp52QSUSG5YWQALMAEJ0bhIXVKtMkhmoVzknWDtlsZNu4VRScPM+aYR274bKL6LSHafxFyZDO1dGhzkUc/e23AyHH1/ME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608246008; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uB8t/ed0eWCpzbMtlZyPmvfm1sd0uT7mTQgP7lht7Fc=; b=eScXkpqc240yH7yv0gEqTlYVXZiBTq3sIDqcyaU6vMSV3+DbzpQ7fwS7k+G6PZrUfmWwKq4ltJVmnzQkuQjP+yl3aciBsUKJwfp2VQwb3bHG4HqXAXtqZadN6YmpEMm8dGltLS1G+uV8VqPWq2vKUqODDUjNwS+ezdEVB7UWD3o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608246008409105.81005257603908; Thu, 17 Dec 2020 15:00:08 -0800 (PST) Received: from localhost ([::1]:36404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpvNx-0005Tc-Ao for importer@patchew.org; Thu, 17 Dec 2020 10:40:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpvME-0003lx-KC for qemu-devel@nongnu.org; Thu, 17 Dec 2020 10:38:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:36180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpvMC-0007A9-Sg for qemu-devel@nongnu.org; Thu, 17 Dec 2020 10:38:22 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-nwqR0fZ2MdW0ic8JF5oTRQ-1; Thu, 17 Dec 2020 10:38:18 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74C1D107ACE4; Thu, 17 Dec 2020 15:38:17 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 176AD10013C0; Thu, 17 Dec 2020 15:38:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608219500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uB8t/ed0eWCpzbMtlZyPmvfm1sd0uT7mTQgP7lht7Fc=; b=BxzeK9PP4MaXnDPPCJsdcwHTX8akjJbXUX7fX5eDYiEwHV5a9vQQuYlsFCgRvSU7xqS795 Lm9nh68+SZ92IC0E/wr8NnlmgZ1Kwxio+BcJfEHNXOKAzU81XWABTom+d+PMt5pojAxuQO c0oYZknS3YgpJlqbchGJQFNuha8mZnQ= X-MC-Unique: nwqR0fZ2MdW0ic8JF5oTRQ-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH 1/2] scripts/gdb: fix 'qemu coroutine' when users selects a non topmost stack frame Date: Thu, 17 Dec 2020 17:38:10 +0200 Message-Id: <20201217153811.919932-2-mlevitsk@redhat.com> In-Reply-To: <20201217153811.919932-1-mlevitsk@redhat.com> References: <20201217153811.919932-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , Maxim Levitsky , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The code that dumps the stack frame works like that: * save current registers * overwrite current registers (including rip/rsp) with coroutine snapshot in the jmpbuf * print backtrace * restore the saved registers. If the user has currently selected a non topmost stack frame in gdb, the above code will still restore the selected frame registers, but the gdb will then lose the selected frame index, which makes it impossi= ble to switch back to frame 0, to continue debugging the executable. Therefore switch temporarily to the topmost frame of the stack for the above code. Signed-off-by: Maxim Levitsky --- scripts/qemugdb/coroutine.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index db61389022..e1399211e6 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -70,6 +70,11 @@ def bt_jmpbuf(jmpbuf): regs =3D get_jmpbuf_regs(jmpbuf) old =3D dict() =20 + # remember current stack frame and select the topmost + # so that register modifications don't wreck it + selected_frame =3D gdb.selected_frame() + gdb.newest_frame().select() + for i in regs: old[i] =3D gdb.parse_and_eval('(uint64_t)$%s' % i) =20 @@ -81,6 +86,8 @@ def bt_jmpbuf(jmpbuf): for i in regs: gdb.execute('set $%s =3D %s' % (i, old[i])) =20 + selected_frame.select() + def coroutine_to_jmpbuf(co): coroutine_pointer =3D co.cast(gdb.lookup_type('CoroutineUContext').poi= nter()) return coroutine_pointer['env']['__jmpbuf'] --=20 2.26.2 From nobody Sat May 18 20:15:17 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608246023; cv=none; d=zohomail.com; s=zohoarc; b=lbBUtbuFnt+65zH0saGNw9WmuWWaJ7s+c5FwwbHfk7UfOMVZhEflom3JjOo08NTnMa0Jafg6sFpKvA8wcZ77/14Hj8NQ3U6ERAKxjcPN7egZ/uh8CgpjAv2bzB2J8vItj0DgZzthNcaS5RmoLBN3cfpYnVnvF6nx21sPyutzwTU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608246023; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dr3gqa6nrhH/uqBQf7dXwynNIGujuvPl3eJ29yLHITY=; b=jntZ3UnI66KS2T6SteqZxN1Ju4/i8Raz6t9F9lAAVhpcT49CUh/FQ0tvF0TFmVmOfUuGOyFrAP8eLfLvOXsYAokbevhjOLWkDwyyQNhWSMUhFsMuKfnuynnoh+mbEhq6wqY2dspNvee0F+G75j708otEz6yczxVg5/BUSlvkjNA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 160824602107257.72497133696572; Thu, 17 Dec 2020 15:00:21 -0800 (PST) Received: from localhost ([::1]:47174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpvQx-0001UT-0N for importer@patchew.org; Thu, 17 Dec 2020 10:43:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpvMH-0003sT-Ek for qemu-devel@nongnu.org; Thu, 17 Dec 2020 10:38:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpvMF-0007Al-Ok for qemu-devel@nongnu.org; Thu, 17 Dec 2020 10:38:25 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-BppVfmxHOX2Et47fkOAYSQ-1; Thu, 17 Dec 2020 10:38:21 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 864A9100A642; Thu, 17 Dec 2020 15:38:20 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0FCB710013C0; Thu, 17 Dec 2020 15:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608219503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dr3gqa6nrhH/uqBQf7dXwynNIGujuvPl3eJ29yLHITY=; b=gKJbhdcg2b6Hms3CqJQpJuJpAP6fj1FYum57xEiESjCyMwhkrAeu+9SGQbGRLWI9g8/v0D 1tHbxv89bq8CQuv7qd9YDrrxICj5vA+rKopR32dVLUeHROngJIQwpdWBdpdk9b7hwbcFGs rTqfwae1qfS9Qwxho4Om8PrOc72496Q= X-MC-Unique: BppVfmxHOX2Et47fkOAYSQ-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH 2/2] scripts/gdb: implement 'qemu bt' Date: Thu, 17 Dec 2020 17:38:11 +0200 Message-Id: <20201217153811.919932-3-mlevitsk@redhat.com> In-Reply-To: <20201217153811.919932-1-mlevitsk@redhat.com> References: <20201217153811.919932-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , Maxim Levitsky , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This script first runs the regular gdb's 'bt' command, and then if we are i= n a coroutine it prints the coroutines backtraces in the order in which they were called. Signed-off-by: Maxim Levitsky --- scripts/qemu-gdb.py | 1 + scripts/qemugdb/coroutine.py | 32 +++++++++++++++++++++++++++++++- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-gdb.py b/scripts/qemu-gdb.py index e0bfa7b5a4..4d2a9f6c43 100644 --- a/scripts/qemu-gdb.py +++ b/scripts/qemu-gdb.py @@ -40,6 +40,7 @@ timers.TimersCommand() =20 coroutine.CoroutineSPFunction() coroutine.CoroutinePCFunction() +coroutine.CoroutineBt() =20 # Default to silently passing through SIGUSR1, because QEMU sends it # to itself a lot. diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index e1399211e6..39d53a102e 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -88,8 +88,11 @@ def bt_jmpbuf(jmpbuf): =20 selected_frame.select() =20 +def co_cast(co): + return co.cast(gdb.lookup_type('CoroutineUContext').pointer()) + def coroutine_to_jmpbuf(co): - coroutine_pointer =3D co.cast(gdb.lookup_type('CoroutineUContext').poi= nter()) + coroutine_pointer =3D co_cast(co) return coroutine_pointer['env']['__jmpbuf'] =20 =20 @@ -107,6 +110,33 @@ class CoroutineCommand(gdb.Command): =20 bt_jmpbuf(coroutine_to_jmpbuf(gdb.parse_and_eval(argv[0]))) =20 +class CoroutineBt(gdb.Command): + '''Display backtrace including coroutine switches''' + def __init__(self): + gdb.Command.__init__(self, 'qemu bt', gdb.COMMAND_STACK, + gdb.COMPLETE_NONE) + + def invoke(self, arg, from_tty): + + gdb.execute("bt") + + thread =3D gdb.selected_thread() + if thread =3D=3D None or not thread.is_stopped(): + raise gdb.GdbError("No currrent thread") + + if gdb.parse_and_eval("qemu_in_coroutine()") =3D=3D False: + return + + co_ptr =3D gdb.parse_and_eval("qemu_coroutine_self()") + gdb.write("Coroutine at " + str(co_ptr) + ":\n") + + while True: + co =3D co_cast(co_ptr) + co_ptr =3D co["base"]["caller"] + if co_ptr =3D=3D 0: + break + bt_jmpbuf(coroutine_to_jmpbuf(co_ptr)) + class CoroutineSPFunction(gdb.Function): def __init__(self): gdb.Function.__init__(self, 'qemu_coroutine_sp') --=20 2.26.2