From nobody Mon Feb 9 23:00:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608247794; cv=none; d=zohomail.com; s=zohoarc; b=N1bItUqusH4k9rZWaJlZL8tXW6FrD3IZo+01+jkcoUoXWeBh5F1djoRB5ovS6+cxtOGD5tbpkF9+lMb1I9Lnix12TOmtLqejZ6fxpofpiixHXSsOrFr0XYHa9PLwcspqI3caK5pMmD0YIt65UsvyUJyYDC5QvWBwsv3et/ALOi8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608247794; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gxMQKtmTiYrrnOK3gDk/IeCeokmQ4smxQbGkg4S2Lbg=; b=MJZML8D17aEzw3pGIB13iRfViaIksM5YA41+DExelb+zRaO3njs4zkMVd5HuwCfZeaVFT3pxm1NWzsb1snFXRvA4qgJJ5hB0UzeCBRfWT9K6b/ym/YVpDcSSycjSUOsHpGMumEScjzmCKTRR60cOj+F/7T3VHflACpXslHs9AvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608247794833944.1625380085336; Thu, 17 Dec 2020 15:29:54 -0800 (PST) Received: from localhost ([::1]:46550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpvQr-0001Eh-2j for importer@patchew.org; Thu, 17 Dec 2020 10:43:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpumA-0004LW-6Q for qemu-devel@nongnu.org; Thu, 17 Dec 2020 10:01:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpulz-0007ra-8i for qemu-devel@nongnu.org; Thu, 17 Dec 2020 10:01:04 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-489-hR3LRnEkMm6XIfax-5vrMA-1; Thu, 17 Dec 2020 10:00:49 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9028A107ACF7; Thu, 17 Dec 2020 15:00:48 +0000 (UTC) Received: from localhost.localdomain (unknown [10.35.206.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0535A5D9CD; Thu, 17 Dec 2020 15:00:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608217251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gxMQKtmTiYrrnOK3gDk/IeCeokmQ4smxQbGkg4S2Lbg=; b=P8SLBn1o0Pt+pnLj7ZzAoCWEBqvW09//xAKM9Je0hTWREz4Ie1ZlBvohqapdkk3KQUpS8O tmb6kIJdIsb+52VUKGUvfDbDbkxMGf+C7FL8cmNMFCoYkbdUVfl8ooGuBwzRIKpdLH59x8 wT5cy6y+ZOPW9sFViWSjRGyX0myZbWY= X-MC-Unique: hR3LRnEkMm6XIfax-5vrMA-1 From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH 1/3] scsi: virtio-scsi: don't process IO on fenced dataplane Date: Thu, 17 Dec 2020 17:00:38 +0200 Message-Id: <20201217150040.906961-2-mlevitsk@redhat.com> In-Reply-To: <20201217150040.906961-1-mlevitsk@redhat.com> References: <20201217150040.906961-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , Maxim Levitsky , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" If virtio_scsi_dataplane_start fails, there is a small window when it drops= the aio lock (in aio_wait_bh_oneshot) and the dataplane's AIO handler can still run during that window. This is done after the dataplane was marked as fenced, thus we use this flag to avoid it doing any IO. Signed-off-by: Maxim Levitsky --- hw/scsi/virtio-scsi-dataplane.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplan= e.c index b995bab3a2..2824a25b65 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -56,8 +56,10 @@ static bool virtio_scsi_data_plane_handle_cmd(VirtIODevi= ce *vdev, VirtIOSCSI *s =3D VIRTIO_SCSI(vdev); =20 virtio_scsi_acquire(s); - assert(s->ctx && s->dataplane_started); - progress =3D virtio_scsi_handle_cmd_vq(s, vq); + if (!s->dataplane_fenced) { + assert(s->ctx && s->dataplane_started); + progress =3D virtio_scsi_handle_cmd_vq(s, vq); + } virtio_scsi_release(s); return progress; } @@ -69,8 +71,10 @@ static bool virtio_scsi_data_plane_handle_ctrl(VirtIODev= ice *vdev, VirtIOSCSI *s =3D VIRTIO_SCSI(vdev); =20 virtio_scsi_acquire(s); - assert(s->ctx && s->dataplane_started); - progress =3D virtio_scsi_handle_ctrl_vq(s, vq); + if (!s->dataplane_fenced) { + assert(s->ctx && s->dataplane_started); + progress =3D virtio_scsi_handle_ctrl_vq(s, vq); + } virtio_scsi_release(s); return progress; } @@ -82,8 +86,10 @@ static bool virtio_scsi_data_plane_handle_event(VirtIODe= vice *vdev, VirtIOSCSI *s =3D VIRTIO_SCSI(vdev); =20 virtio_scsi_acquire(s); - assert(s->ctx && s->dataplane_started); - progress =3D virtio_scsi_handle_event_vq(s, vq); + if (!s->dataplane_fenced) { + assert(s->ctx && s->dataplane_started); + progress =3D virtio_scsi_handle_event_vq(s, vq); + } virtio_scsi_release(s); return progress; } --=20 2.26.2