From nobody Tue Nov 18 07:41:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1608166159; cv=none; d=zohomail.com; s=zohoarc; b=h2nq7czRSlrcClRs9rR7vSRclzSLSGutFgdtTPHN32bpOJts7La3Xu6rXO6Z5tb7uM9Tp0mNq9x62AY3hu5sBI/2LiyoSrKHXCFyLkbJcgkK3gANCg022PtaSf2PIa4VauOnZAds6EjT4b0jQEAkf6jiBmazSHbGG5vdBYWXM/Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608166159; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=bfvJpd9+m7ujAeaE5a8zb+sHbXmybrvFRRI+Ug0qSfk=; b=oFEFADjNrib5WH2lw6MGtn/d5Ik2hMvl8HjNWQd+Pyvkaj+1IeBK4wcvayx6bDlNQEOMYxVSb1kG8oI+xRsNZBdlMx/U4hA5mFMb/JiOqosK7uzEFCp3M1vjyIsjsrdYTMlEW1nOYdvUrfzIay9snudVm3oIuHmNLt5gOUVcMv0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608166159017295.39021425791634; Wed, 16 Dec 2020 16:49:19 -0800 (PST) Received: from localhost ([::1]:40438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kphTp-0008Nb-VB for importer@patchew.org; Wed, 16 Dec 2020 19:49:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3LqraXwgKCvEpnaThmlaZhhZeX.VhfjXfn-WXoXeghgZgn.hkZ@flex--wuhaotsh.bounces.google.com>) id 1kphQP-0006Ix-Eq for qemu-devel@nongnu.org; Wed, 16 Dec 2020 19:45:45 -0500 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]:37668) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3LqraXwgKCvEpnaThmlaZhhZeX.VhfjXfn-WXoXeghgZgn.hkZ@flex--wuhaotsh.bounces.google.com>) id 1kphQI-0006qv-OW for qemu-devel@nongnu.org; Wed, 16 Dec 2020 19:45:45 -0500 Received: by mail-pg1-x54a.google.com with SMTP id f19so18392547pgm.4 for ; Wed, 16 Dec 2020 16:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=bfvJpd9+m7ujAeaE5a8zb+sHbXmybrvFRRI+Ug0qSfk=; b=u2bu7lkOAhPSab5fkkA7fhl33Gk3CPM7a6w+QT6X++zV/q7sHtc6m9NBo749jHQNyX wHemAm03YvtmFeFsmfLAk6X8T9r3Xj60r4szbW5D2R1ToVsSVDvPWGSFuSnX7dJZbiT8 7/jfnY2e3Ug754NFMIDPDeW4atHsXHH+0MmSuRcJug+G/HCoIKG2ks4Sn4R5fUqfB7ug 8sQeBxzVhMbWbxVpELH74E6tggAdjZn/ZYlDORIP3fIqBlVIjIMloVBrkX9baBl3UxKB DHiXFTWHx7xjP6rQjggbDNwI68fcgYyNZ7O+/qvG2yR2c8l82XEqGOLVMWRhXQARnf/5 3Gfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=bfvJpd9+m7ujAeaE5a8zb+sHbXmybrvFRRI+Ug0qSfk=; b=TzOBTVRT0eZ3svguSy0vwsgdd/qNa6Q+OHo5MtG7sUDF2dzD4fm8SzQXg1aD31D5ju VScr9aC+/n2nMUgafR3klS/iFJAvZbwLA+2yPqwfMVIMW1BB5uliE2QGaQw8G4G+jfiT bjUJdltu6sIrqdS0SOJdBVD7xVl5XXURe7vPXhtVV8eRVQAzRvnb0bcW7gNXdK0qiSPD XA1WVZsuTHMQDocXblFEUTKWVJ0f1RbpUnRR0E8VKI3PIkMuY+qe6GASv/akWIABCUeQ JiiMGfRxgykeUW6m8ZwlGJH9nePbo8My41YfiyCfbtxmSHyGuy0VGkkBWtP9QMQGZ80z RlKg== X-Gm-Message-State: AOAM533sUlM2+UHdnhTB5qCufVk1eiXPFC/uon26M4qp2M5lJR/IbFnC jidiXANgaRyNG7M1y5IkWL1IrkzwqFa4jA== X-Google-Smtp-Source: ABdhPJyqGrWVlcP1yP4o0FgfCT2o4dOLBfti7jl3fmktBH+6ZkwE+ArBnWpr0tqGPkcMlt4ya/SDTQR5XDsRug== X-Received: from mimik.c.googlers.com ([fda3:e722:ac3:10:7f:e700:c0a8:4e]) (user=wuhaotsh job=sendgmr) by 2002:a62:1615:0:b029:19d:c9f1:f450 with SMTP id 21-20020a6216150000b029019dc9f1f450mr34292206pfw.11.1608165934634; Wed, 16 Dec 2020 16:45:34 -0800 (PST) Date: Wed, 16 Dec 2020 16:43:49 -0800 In-Reply-To: <20201217004349.3740927-1-wuhaotsh@google.com> Message-Id: <20201217004349.3740927-7-wuhaotsh@google.com> Mime-Version: 1.0 References: <20201217004349.3740927-1-wuhaotsh@google.com> X-Mailer: git-send-email 2.29.2.684.gfbc64c5ab5-goog Subject: [PATCH v4 6/6] hw/*: Use type casting for SysBusDevice in NPCM7XX To: peter.maydell@linaro.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::54a; envelope-from=3LqraXwgKCvEpnaThmlaZhhZeX.VhfjXfn-WXoXeghgZgn.hkZ@flex--wuhaotsh.bounces.google.com; helo=mail-pg1-x54a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: minyard@acm.org, venture@google.com, qemu-devel@nongnu.org, hskinnemoen@google.com, wuhaotsh@google.com, kfting@nuvoton.com, qemu-arm@nongnu.org, Avi.Fishman@nuvoton.com, f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Reply-to: Hao Wu From: Hao Wu via X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A device shouldn't access its parent object which is QOM internal. Instead it should use type cast for this purporse. This patch fixes this issue for all NPCM7XX Devices. Signed-off-by: Hao Wu Reviewed-by: Peter Maydell --- hw/arm/npcm7xx_boards.c | 2 +- hw/mem/npcm7xx_mc.c | 2 +- hw/misc/npcm7xx_clk.c | 2 +- hw/misc/npcm7xx_gcr.c | 2 +- hw/misc/npcm7xx_rng.c | 2 +- hw/nvram/npcm7xx_otp.c | 2 +- hw/ssi/npcm7xx_fiu.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c index 306260fa67..3fdd5cab01 100644 --- a/hw/arm/npcm7xx_boards.c +++ b/hw/arm/npcm7xx_boards.c @@ -82,7 +82,7 @@ static NPCM7xxState *npcm7xx_create_soc(MachineState *mac= hine, uint32_t hw_straps) { NPCM7xxMachineClass *nmc =3D NPCM7XX_MACHINE_GET_CLASS(machine); - MachineClass *mc =3D &nmc->parent; + MachineClass *mc =3D MACHINE_CLASS(nmc); Object *obj; =20 if (strcmp(machine->cpu_type, mc->default_cpu_type) !=3D 0) { diff --git a/hw/mem/npcm7xx_mc.c b/hw/mem/npcm7xx_mc.c index 0435d06ab4..abc5af5620 100644 --- a/hw/mem/npcm7xx_mc.c +++ b/hw/mem/npcm7xx_mc.c @@ -62,7 +62,7 @@ static void npcm7xx_mc_realize(DeviceState *dev, Error **= errp) =20 memory_region_init_io(&s->mmio, OBJECT(s), &npcm7xx_mc_ops, s, "regs", NPCM7XX_MC_REGS_SIZE); - sysbus_init_mmio(&s->parent, &s->mmio); + sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->mmio); } =20 static void npcm7xx_mc_class_init(ObjectClass *klass, void *data) diff --git a/hw/misc/npcm7xx_clk.c b/hw/misc/npcm7xx_clk.c index 48bc9bdda5..0bcae9ce95 100644 --- a/hw/misc/npcm7xx_clk.c +++ b/hw/misc/npcm7xx_clk.c @@ -913,7 +913,7 @@ static void npcm7xx_clk_init(Object *obj) =20 memory_region_init_io(&s->iomem, obj, &npcm7xx_clk_ops, s, TYPE_NPCM7XX_CLK, 4 * KiB); - sysbus_init_mmio(&s->parent, &s->iomem); + sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem); } =20 static int npcm7xx_clk_post_load(void *opaque, int version_id) diff --git a/hw/misc/npcm7xx_gcr.c b/hw/misc/npcm7xx_gcr.c index 745f690809..eace9e1967 100644 --- a/hw/misc/npcm7xx_gcr.c +++ b/hw/misc/npcm7xx_gcr.c @@ -220,7 +220,7 @@ static void npcm7xx_gcr_init(Object *obj) =20 memory_region_init_io(&s->iomem, obj, &npcm7xx_gcr_ops, s, TYPE_NPCM7XX_GCR, 4 * KiB); - sysbus_init_mmio(&s->parent, &s->iomem); + sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem); } =20 static const VMStateDescription vmstate_npcm7xx_gcr =3D { diff --git a/hw/misc/npcm7xx_rng.c b/hw/misc/npcm7xx_rng.c index f650f3401f..b01df7cdb2 100644 --- a/hw/misc/npcm7xx_rng.c +++ b/hw/misc/npcm7xx_rng.c @@ -143,7 +143,7 @@ static void npcm7xx_rng_init(Object *obj) =20 memory_region_init_io(&s->iomem, obj, &npcm7xx_rng_ops, s, "regs", NPCM7XX_RNG_REGS_SIZE); - sysbus_init_mmio(&s->parent, &s->iomem); + sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem); } =20 static const VMStateDescription vmstate_npcm7xx_rng =3D { diff --git a/hw/nvram/npcm7xx_otp.c b/hw/nvram/npcm7xx_otp.c index b16ca530ba..c61f2fc1aa 100644 --- a/hw/nvram/npcm7xx_otp.c +++ b/hw/nvram/npcm7xx_otp.c @@ -371,7 +371,7 @@ static void npcm7xx_otp_realize(DeviceState *dev, Error= **errp) { NPCM7xxOTPClass *oc =3D NPCM7XX_OTP_GET_CLASS(dev); NPCM7xxOTPState *s =3D NPCM7XX_OTP(dev); - SysBusDevice *sbd =3D &s->parent; + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); =20 memset(s->array, 0, sizeof(s->array)); =20 diff --git a/hw/ssi/npcm7xx_fiu.c b/hw/ssi/npcm7xx_fiu.c index 5040132b07..4eedb2927e 100644 --- a/hw/ssi/npcm7xx_fiu.c +++ b/hw/ssi/npcm7xx_fiu.c @@ -498,7 +498,7 @@ static void npcm7xx_fiu_hold_reset(Object *obj) static void npcm7xx_fiu_realize(DeviceState *dev, Error **errp) { NPCM7xxFIUState *s =3D NPCM7XX_FIU(dev); - SysBusDevice *sbd =3D &s->parent; + SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); int i; =20 if (s->cs_count <=3D 0) { --=20 2.29.2.684.gfbc64c5ab5-goog