From nobody Mon Feb 9 08:56:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1608158131; cv=none; d=zohomail.com; s=zohoarc; b=iM+Agnm/dRGV/xj9pXL7c5cGYfOyzenxZtON9BvSDWxFZxZ0FMZt7FHDSMWTkL41puXVscAmtTEVe05vk4gX/MzCmu0DytaTekZL5tmaIG60dZtufwXFMirD7/n+gFV5+Mum0v5NET7fv0kxIV2OpXdk+2W8vtUv1qIodDjKt8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608158131; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2T6UN1mfg0U6GlpV4+jh0vnfDSHv41qUWviU2IK9Lf8=; b=RdA5PxhmKnh8NjbuDRHhNBU+DptYdFzTZRPXyAJg2ZAg5R26QCm1IYaeaRoZbI6negxbxqcGIr/l7G/BTpNav6Xs4XSZkgxrbCx6p6L8+9uR57mc2iuk7Z76NAe5KjymROiDX1HSL9gLFnyWSJwXePhV252JHGo4pGhReLi0khI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1608158131750348.49536211600196; Wed, 16 Dec 2020 14:35:31 -0800 (PST) Received: from localhost ([::1]:51790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpamp-0001oZ-PA for importer@patchew.org; Wed, 16 Dec 2020 12:40:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpacp-0008RR-Pa for qemu-devel@nongnu.org; Wed, 16 Dec 2020 12:30:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpacn-00014P-W8 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 12:30:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-IZj0P2BmPfe8wKTwhsmIrw-1; Wed, 16 Dec 2020 12:30:01 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 741AB180A093; Wed, 16 Dec 2020 17:29:59 +0000 (UTC) Received: from thuth.com (ovpn-113-7.ams2.redhat.com [10.36.113.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7C17510023B3; Wed, 16 Dec 2020 17:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608139805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2T6UN1mfg0U6GlpV4+jh0vnfDSHv41qUWviU2IK9Lf8=; b=a5G2zJEH1snvIbLybTNsnxEmymQ+AiEyA3c/YApNx6Y4LOPpRfkNme4MOp/0f5Igz1z8qp VxgTHi0TVPB8ENuzFXBCQlwqNUUJfZi6hicD9OrujqpMdtM6fHvMm9bjKIbsC+oMxrDe55 fBAgzT3nS7wx8QhVKc/rR550DxQnJ5s= X-MC-Unique: IZj0P2BmPfe8wKTwhsmIrw-1 From: Thomas Huth To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 02/12] target/unicore32/translate: Add missing fallthrough annotations Date: Wed, 16 Dec 2020 18:29:39 +0100 Message-Id: <20201216172949.57380-3-thuth@redhat.com> In-Reply-To: <20201216172949.57380-1-thuth@redhat.com> References: <20201216172949.57380-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chen Qun , =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Looking at the way the code is formatted here (there is an empty line after break statements, but none where the break is missing), and the instruction set overview at https://en.wikipedia.org/wiki/Unicore the fallthrough is very likely intended here. So add a fallthrough comment to make the it compilable with -Werror=3Dimplicit-fallthrough. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20201211152426.350966-3-thuth@redhat.com> Signed-off-by: Thomas Huth --- target/unicore32/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c index d4b06df672..962f9877a0 100644 --- a/target/unicore32/translate.c +++ b/target/unicore32/translate.c @@ -1801,6 +1801,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, D= isasContext *s) do_misc(env, s, insn); break; } + /* fallthrough */ case 0x1: if (((UCOP_OPCODES >> 2) =3D=3D 2) && !UCOP_SET_S) { do_misc(env, s, insn); @@ -1817,6 +1818,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, D= isasContext *s) if (UCOP_SET(8) || UCOP_SET(5)) { ILLEGAL; } + /* fallthrough */ case 0x3: do_ldst_ir(env, s, insn); break; --=20 2.27.0