From nobody Tue Feb 10 04:13:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.68 as permitted sender) client-ip=209.85.218.68; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f68.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1608073121; cv=none; d=zohomail.com; s=zohoarc; b=UH9gLbo4UJw+Ti4m00JqS/bvNAlsubC5pJLWCM4VI6uiOwm6bk0W5QeDtrb+VR4+ZK0iDTPsgPkLfRLPsot1oEmBi/Rd+gABGCMOUtvlcaKvWJL5TYUNNrrbWGvEOEuSGnS3TofRC2AbaJMcitH4isf696iu0buc/0awGGBkX5c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1608073121; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BnBuWwu/IR7HzibU0fSLa1btap3ty/kGytf5ZOVzJHw=; b=RI/ug6J7msaVS/3d4lNnGx7n0frNACHny/+MQTK7z84jGJPAXwE7/jkLLM3ZZBYaLWUUbiGoHlbWpCxC4wcRFnbr9popFgwMoZ/op8R4DnnNIzsg7vOQZt72BrsP1rxbvbz8uDMTZlQ7y5sZEqhxxJtB9ZT2w3N/TzxpTweqMmQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.68 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by mx.zohomail.com with SMTPS id 1608073121976183.02973973995313; Tue, 15 Dec 2020 14:58:41 -0800 (PST) Received: by mail-ej1-f68.google.com with SMTP id b9so5109644ejy.0 for ; Tue, 15 Dec 2020 14:58:41 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id 35sm19174328ede.0.2020.12.15.14.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Dec 2020 14:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BnBuWwu/IR7HzibU0fSLa1btap3ty/kGytf5ZOVzJHw=; b=US6pT9hkIUe/3Y7u3abkxfxmo+g63uoofHU7oXDwqFCQZm1V3FKeZ5fDXzLgWMR+tz ZUIr8FArsHvKzwdU5ieVduhNmBORH2czavfCNyp2G3DaW1Wx7Y+dAOSt4ViEAcfknR4j NEDgCAFVKk+EIAx5IlI16zjC648EjQDBh+vWLjHPVKgPCIwWemlKmBw9hB648PyqxsGN VdYu36vVvnu1D9nYrydInoLe21pVmk0ZgN067MnXf6abBT+2DG+WabDXSuxUz78F/nNw ztxNkZsRG3MrTs1HcvdY+Er07tfLpecaOC2VF4tD5oP0KgRVvnanghVChVImnzbLu5mN nnig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BnBuWwu/IR7HzibU0fSLa1btap3ty/kGytf5ZOVzJHw=; b=Q5dZAfBRwHWLGJoy9ZrVIn7bSp6woPxwU0q97IwcCk5wQLlH8XTc0n5JmPAQpOImiG yP3eX9VyzizwEtb3dbKT5NeJE7hIJoRN8LK0Hg1XLCDDS4wHmtm03UIWejb/8ln5+n0C TnThYLuC89DACYzNmmYF9A2Yi4vJskixWz/yqi8M12vhU7HmNrDf5HPNDEQaa7OtahxS Lmy0xyjZu/fGIRvGkxYpDkbFTWzpCE+jNBLtknd+dtWSZAVdH+UpWW3cSGWZSk29VTiH AYGS1/8ENpfSEWHfQ9efXHYMMPIWtYUkpQ+1xR6apIifpZTh0QLjW65aLuE+1cBO06jt aGPA== X-Gm-Message-State: AOAM530eMMqH0guLAb3lyHIoYYe3XGm8BbAR2ii2XQGdoEJgZFytWkMS 4wWKGh7n4+meAShujydxCLU= X-Google-Smtp-Source: ABdhPJwWEmYN+znrgrxMg2p+03mYpoUKLrA8wM858BfPuk+pAWE4X4Nrr/vTEL+NY0y64W3QwD6D1g== X-Received: by 2002:a17:906:705:: with SMTP id y5mr14673838ejb.428.1608073120174; Tue, 15 Dec 2020 14:58:40 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Richard Henderson , qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Aleksandar Rikalo , Paolo Bonzini , Aurelien Jarno , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen Subject: [PATCH v2 07/24] target/mips: Simplify MSA TCG logic Date: Tue, 15 Dec 2020 23:57:40 +0100 Message-Id: <20201215225757.764263-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201215225757.764263-1-f4bug@amsat.org> References: <20201215225757.764263-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Only decode MSA opcodes if MSA is present (implemented). Now than check_msa_access() will only be called if MSA is present, the only way to have MIPS_HFLAG_MSA unset is if MSA is disabled (bit CP0C5_MSAEn cleared, see previous commit). Therefore we can remove the 'reserved instruction' exception. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index fc658b3be33..02ea184f9a3 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -28568,13 +28568,8 @@ static inline int check_msa_access(DisasContext *c= tx) } =20 if (unlikely(!(ctx->hflags & MIPS_HFLAG_MSA))) { - if (ctx->insn_flags & ASE_MSA) { - generate_exception_end(ctx, EXCP_MSADIS); - return 0; - } else { - gen_reserved_instruction(ctx); - return 0; - } + generate_exception_end(ctx, EXCP_MSADIS); + return 0; } return 1; } @@ -30418,7 +30413,7 @@ static void gen_msa_vec(CPUMIPSState *env, DisasCon= text *ctx) static void gen_msa(CPUMIPSState *env, DisasContext *ctx) { uint32_t opcode =3D ctx->opcode; - check_insn(ctx, ASE_MSA); + check_msa_access(ctx); =20 switch (MASK_MSA_MINOR(opcode)) { @@ -31048,9 +31043,10 @@ static bool decode_opc_legacy(CPUMIPSState *env, D= isasContext *ctx) case OPC_BNZ_H: case OPC_BNZ_W: case OPC_BNZ_D: - check_insn(ctx, ASE_MSA); - gen_msa_branch(env, ctx, op1); - break; + if (ase_msa_available(env)) { + gen_msa_branch(env, ctx, op1); + break; + } default: MIPS_INVAL("cp1"); gen_reserved_instruction(ctx); @@ -31239,7 +31235,9 @@ static bool decode_opc_legacy(CPUMIPSState *env, Di= sasContext *ctx) #endif } else { /* MDMX: Not implemented. */ - gen_msa(env, ctx); + if (ase_msa_available(env)) { + gen_msa(env, ctx); + } } break; case OPC_PCREL: --=20 2.26.2