From nobody Mon Feb 9 23:58:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607971081; cv=none; d=zohomail.com; s=zohoarc; b=R19QddnhkCUEJ5fXxVP1cJWW4rhMgj8qB6yF1C95MjG27U9Kphb1IjAymfSFXufYp8DpgMzHiAUr53I6yonlZ4y7F83OdLuUVq2WV+jVItkDwIG118G421W9oDCh6QGz1ajP4F8bqqiseLFZ/wOJHGSRkeqLlAi/+MPQlBn5mFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607971081; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=tkYIisFgK6Je25iDH+AcvdFQgbr8b03Vk9AV0zMlHWI=; b=il5GKdvPtMSfOlLSCx/nLxXHHXbp1r3FF0/9zeK557PtdaDhrOpEbb8B/lLW4NqVxqnchRVVLieF8fUqVlooUZL4Zxkvfn+FhptCZ/kU4l3aSTFcGpkK+y8zG9LNffnoPnYmnFrnMnDUKrm6yGr/Hlf6E0Qf7KukMf09l1v2whs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1607971081212102.03534550329152; Mon, 14 Dec 2020 10:38:01 -0800 (PST) Received: by mail-wm1-f54.google.com with SMTP id k10so14688624wmi.3 for ; Mon, 14 Dec 2020 10:38:00 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id p15sm24306743wrt.15.2020.12.14.10.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 10:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tkYIisFgK6Je25iDH+AcvdFQgbr8b03Vk9AV0zMlHWI=; b=hgL3Ac52u3mHBafiHWMQFZ22Iz9iA+Su5rN5IOY9SxxsUtNm3tSIXIZgoUPSbW35cm c2SVS3s/gtJEm0xzO+5g7DRoQmlZ4fwJEgCwd1trER19AAl5aD1P30esrymA8yESj3ND l8tbsA6hnXMPal+/PgwbdFUAVa6uUKbTCIxkzxYUzyNPD5jBKTOuCBvizf382DksF7JP YbNBCSN5D3xjr5rq8dIL/lR8YDyXg/iYvUYglHdyRPTNoQq9DjEU01Gqd8tIt2V91JKz STe93f1h68AdAskIYZb/HAua3Tc4iNJAxv8u2rKyNuJnQEq4VHADmGiJNBmBGVhNZcK1 X6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=tkYIisFgK6Je25iDH+AcvdFQgbr8b03Vk9AV0zMlHWI=; b=R6USWAMMLGyoYvoiVGA+i4HyrharCqcKXWrrKNJ0INz9RWcFK8Wgha8t4p0lC5MF6D iZGGO+mtUqIa8GCjr4yG6Txty8yuDwzcFczEx8q0RuoCocgKwxIP5FvYeK7CnTNalLzg xaUj2DyAbsRcJaI1xNuXCSWXiolVwqTHxEUII7KEhRajNr/eTZ6FHPgfaX7v5jxpfH1e UzgSxTV2ixbfxiAQ0y7Roq7rCvK/HYZa9U3+Dbnmpc7i3TgNmc/ZgbPump0vVyNZu0y4 99RKDLf0eG9cmvps4LsHbQIV/0GQ0DfUojImva+dAXHLYOpRLme3l5ia5pNQmFakt3V/ cYRA== X-Gm-Message-State: AOAM532HT4EmaF2qgMUSH7Xuj63q4+N8bINqJTzusSGUUL70265pVR8w MsJ80GyCwvjvqDkOeDJncRk= X-Google-Smtp-Source: ABdhPJwzkNHg3Tv/g0fScefe8FqRMtvselhx3j0oy/GqpnxEqHkfTN6UAORwsjlkl1T0lM6wjnSslA== X-Received: by 2002:a1c:6a10:: with SMTP id f16mr29145023wmc.106.1607971077643; Mon, 14 Dec 2020 10:37:57 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Aurelien Jarno , Huacai Chen , Aleksandar Rikalo , Jiaxun Yang , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 03/16] target/mips: Add !CONFIG_USER_ONLY comment after #endif Date: Mon, 14 Dec 2020 19:37:26 +0100 Message-Id: <20201214183739.500368-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201214183739.500368-1-f4bug@amsat.org> References: <20201214183739.500368-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) To help understand ifdef'ry, add comment after #endif. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/helper.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/mips/helper.c b/target/mips/helper.c index 87296fbad69..cdd7704789d 100644 --- a/target/mips/helper.c +++ b/target/mips/helper.c @@ -455,7 +455,8 @@ void cpu_mips_store_cause(CPUMIPSState *env, target_ulo= ng val) } } } -#endif + +#endif /* !CONFIG_USER_ONLY */ =20 static void raise_mmu_exception(CPUMIPSState *env, target_ulong address, int rw, int tlb_error) @@ -537,6 +538,7 @@ static void raise_mmu_exception(CPUMIPSState *env, targ= et_ulong address, } =20 #if !defined(CONFIG_USER_ONLY) + hwaddr mips_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) { MIPSCPU *cpu =3D MIPS_CPU(cs); @@ -550,7 +552,7 @@ hwaddr mips_cpu_get_phys_page_debug(CPUState *cs, vaddr= addr) } return phys_addr; } -#endif +#endif /* !CONFIG_USER_ONLY */ =20 #if !defined(CONFIG_USER_ONLY) #if !defined(TARGET_MIPS64) @@ -886,7 +888,7 @@ refill: return true; } #endif -#endif +#endif /* !CONFIG_USER_ONLY */ =20 bool mips_cpu_tlb_fill(CPUState *cs, vaddr address, int size, MMUAccessType access_type, int mmu_idx, @@ -1088,7 +1090,8 @@ static inline void set_badinstr_registers(CPUMIPSStat= e *env) env->CP0_BadInstrP =3D cpu_ldl_code(env, env->active_tc.PC - 4); } } -#endif + +#endif /* !CONFIG_USER_ONLY */ =20 void mips_cpu_do_interrupt(CPUState *cs) { @@ -1482,7 +1485,7 @@ void r4k_invalidate_tlb(CPUMIPSState *env, int idx, i= nt use_extra) } } } -#endif +#endif /* !CONFIG_USER_ONLY */ =20 void QEMU_NORETURN do_raise_exception_err(CPUMIPSState *env, uint32_t exception, --=20 2.26.2