From nobody Tue Nov 18 06:00:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607922571; cv=none; d=zohomail.com; s=zohoarc; b=i/iL0Nogcq2Mx4XX82BJ7OfTW4DI6dq9TNTOFJDsIuCEkyGAO/dpHrwcTorc61Ljnop+4znfEWJCo5xcX0a1J9T5+cHPhNT5RUXGVzi2EcN3mncRpqeYPAJAtQc5TI+lBenO6iDnBzQ2nQ2UArVWbgqDLexiQEovsgNZY6/pkcY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607922571; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=19grpbMWjtBJ3/obdLSVczsWFnHtKFwAoFyJ1GTtOds=; b=ABXHk7nNEJTP2558cnESoTz5oP0b/ep9bSHNbhOjxpi1hYEtD1p+WHmcMFDMMP8CzfFBYoeA4u6huBNIbWTnHnPpZmp3dqCt5cvgD0G3sWkT0MW88H8GSKkQ8k8RC7lJNFVAPldKshAXlC4et7skpZ0qBNmWnM64HJ9eYZAiiO8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607922571210833.899623245265; Sun, 13 Dec 2020 21:09:31 -0800 (PST) Received: from localhost ([::1]:43738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kog6z-0002uR-VD for importer@patchew.org; Mon, 14 Dec 2020 00:09:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kofwU-0005GS-HL; Sun, 13 Dec 2020 23:58:38 -0500 Received: from ozlabs.org ([203.11.71.1]:37987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kofwS-0004rd-Sq; Sun, 13 Dec 2020 23:58:38 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CvTfr5CYxz9sVw; Mon, 14 Dec 2020 15:58:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1607921892; bh=/xktcrTWGYjvCl+ilHWh8ZNOKs3LzRkFmgo9zOBipEA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hr5mmydotXoGkLEhEmri6WMLK0jAxutsabCZ/O1bOH+QqwAULUfv7JNAuI6y/wRiU cCYpFv9cQcqn5IJizoLZndu/9hQqEQu3rmStazPPaYqYFVQCX6BhxDeHZ0i3mCkzHh YxoyaLwZjLIze+yGHt1uTestoRO9UrlOVKg7DfoA= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 13/30] ppc/translate: Raise exceptions after setting the cc Date: Mon, 14 Dec 2020 15:57:50 +1100 Message-Id: <20201214045807.41003-14-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201214045807.41003-1-david@gibson.dropbear.id.au> References: <20201214045807.41003-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Giuseppe Musacchio , Richard Henderson , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Giuseppe Musacchio The PowerISA reference states that the comparison operators update the FPCC, CR and FPSCR and, if VE=3D1, jump to the exception handler. Moving the exception-triggering code after the CC update sequence solves the problem. Signed-off-by: Giuseppe Musacchio Reviewed-by: Richard Henderson Message-Id: <20201112230130.65262-5-thatlemon@gmail.com> Signed-off-by: David Gibson --- target/ppc/fpu_helper.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index f5a4be595a..44315fca0b 100644 --- a/target/ppc/fpu_helper.c +++ b/target/ppc/fpu_helper.c @@ -2501,13 +2501,6 @@ static inline void do_scalar_cmp(CPUPPCState *env, p= pc_vsr_t *xa, ppc_vsr_t *xb, } } =20 - if (vxsnan_flag) { - float_invalid_op_vxsnan(env, GETPC()); - } - if (vxvc_flag) { - float_invalid_op_vxvc(env, 0, GETPC()); - } - break; default: g_assert_not_reached(); @@ -2517,6 +2510,13 @@ static inline void do_scalar_cmp(CPUPPCState *env, p= pc_vsr_t *xa, ppc_vsr_t *xb, env->fpscr |=3D cc << FPSCR_FPCC; env->crf[crf_idx] =3D cc; =20 + if (vxsnan_flag) { + float_invalid_op_vxsnan(env, GETPC()); + } + if (vxvc_flag) { + float_invalid_op_vxvc(env, 0, GETPC()); + } + do_float_check_status(env, GETPC()); } =20 @@ -2566,13 +2566,6 @@ static inline void do_scalar_cmpq(CPUPPCState *env, = ppc_vsr_t *xa, } } =20 - if (vxsnan_flag) { - float_invalid_op_vxsnan(env, GETPC()); - } - if (vxvc_flag) { - float_invalid_op_vxvc(env, 0, GETPC()); - } - break; default: g_assert_not_reached(); @@ -2582,6 +2575,13 @@ static inline void do_scalar_cmpq(CPUPPCState *env, = ppc_vsr_t *xa, env->fpscr |=3D cc << FPSCR_FPCC; env->crf[crf_idx] =3D cc; =20 + if (vxsnan_flag) { + float_invalid_op_vxsnan(env, GETPC()); + } + if (vxvc_flag) { + float_invalid_op_vxvc(env, 0, GETPC()); + } + do_float_check_status(env, GETPC()); } =20 --=20 2.29.2