From nobody Tue Nov 18 06:04:48 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607922215; cv=none; d=zohomail.com; s=zohoarc; b=XWMC7zxxhSP6I3GjyTcxQogz1KnAwT8+Wbc5Cal9x9QhokfOUG56Z667qdVVwl8CspOZpa5XLKyFWi1FAmK9FOh1bprguczEHCYtOIxp72T708B58UVvDkarlfGuw0gUZhGhW9Gzr+mOhy5ZPy/uTiuNHJBzJNdooqRxNuFgdKM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607922215; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/mJ6njrCjgY0Vwd1jJd4BZTdM2gy1ZSg4hWOAzHEzQs=; b=ZQdeF9s9Tmcugonk13Q/nEjzicYTFSUMNIdJlgwu1/U5aIibrZ3dt8Kng0XZX3so4XfIbOIvN8BiQ1FdJK3SaamZhGgjhYXO8beX5AXLVv6Jp06pw6bTiHAnbMAx9VZScPXJRc8eagWSNJXi/kIba+u06nzeeUlb2W2iMl1bVRQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607922215198727.6334916284573; Sun, 13 Dec 2020 21:03:35 -0800 (PST) Received: from localhost ([::1]:51228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kog1G-0002od-2f for importer@patchew.org; Mon, 14 Dec 2020 00:03:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kofwR-0005Cc-E1; Sun, 13 Dec 2020 23:58:35 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:53463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kofwP-0004qq-Cr; Sun, 13 Dec 2020 23:58:35 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4CvTfr1qq2z9sVt; Mon, 14 Dec 2020 15:58:12 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1607921892; bh=ZKoVALWI63OBSDQ9zFowxkeqhZA/IacSRGnHPYTa1UE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hYhnmVy8B7iNoiqkRbmXtH6ywAv+Fn8s/pgnP8kj4p7jcSmNllSvUYb2/BfFHRqPQ pCxDiOqDNElZtcqf7TzZKiaphrbz+kYVG2rcIKP+wWoYDu2tnUb/g7vNkA+f06EdL3 kp6neTXDTyO7exmda/E+oCVIzUQD9W9goNWux3oY= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 09/30] ppc: Add a missing break for PPC6xx_INPUT_TBEN Date: Mon, 14 Dec 2020 15:57:46 +1100 Message-Id: <20201214045807.41003-10-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201214045807.41003-1-david@gibson.dropbear.id.au> References: <20201214045807.41003-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, Euler Robot , Chen Qun , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Chen Qun When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warnin= g: hw/ppc/ppc.c: In function =E2=80=98ppc6xx_set_irq=E2=80=99: hw/ppc/ppc.c:118:16: warning: this statement may fall through [-Wimplicit-f= allthrough=3D] 118 | if (level) { | ^ hw/ppc/ppc.c:123:9: note: here 123 | case PPC6xx_INPUT_INT: | ^~~~ According to the discussion, a break statement needs to be added here. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Thomas Huth Acked-by: David Gibson Message-Id: <20201116024810.2415819-7-kuhn.chenqun@huawei.com> Signed-off-by: David Gibson --- hw/ppc/ppc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index 4a11fb1640..1b98272076 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int l= evel) } else { cpu_ppc_tb_stop(env); } + break; case PPC6xx_INPUT_INT: /* Level sensitive - active high */ LOG_IRQ("%s: set the external IRQ state to %d\n", --=20 2.29.2