From nobody Tue Nov 18 04:24:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) client-ip=209.85.128.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607890800; cv=none; d=zohomail.com; s=zohoarc; b=hSbBBiDxDummmy4+NC2skW6v3+OzlNYzd+nkM69B+RkVSxhzknVT9o8ib9e1vTlVitKPQYjRPRLtZjJs1pUo5NR78ntC7bEgOCnYuOZ0MElbt3rACAAH7QFi51Z1dN8fdwn/taZ4wnZgCnD36hNPhRGTkAGdJDBH273eTs7foCE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607890800; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=39WDzgrzKw1HI9cbUqd/4nglotTqMx2ozVZiEV9EMeo=; b=T+wexw3yNr3HXTlAHlQ1aUsFicXxyTeJTJXZAfFWaTiJWSv6pCSZW3gugQkNpSTbd7VHwfkpmhgYotl/zZjRleFXdGFY4bkcLjsyKxjdZbqbTSnOvh1WuNN9L/yaxoBAuaMuED8F2RgSvzmcA5dbVwEVP7NJEuOA4pv69Eo1LRw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.zohomail.com with SMTPS id 1607890800726306.450242888817; Sun, 13 Dec 2020 12:20:00 -0800 (PST) Received: by mail-wm1-f48.google.com with SMTP id k10so11955840wmi.3 for ; Sun, 13 Dec 2020 12:20:00 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id h13sm28766022wrm.28.2020.12.13.12.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Dec 2020 12:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=39WDzgrzKw1HI9cbUqd/4nglotTqMx2ozVZiEV9EMeo=; b=HNeZlXVtc7YfjiBul+Rccx5JKDxdpjacjieOOVNOFISfGRL06tM3qvroTYE1jrNqfZ QcQZ6KXhyY8ucZpcziHxytnf1cM0TZk40qOl4gCcD0ZGmVx58ssLywumZ+c9fOCHu7m/ PtVXnTWWnDmZapEKqWpEOAguvf/tkTkTOMpwnZ1vEYZpOk7KOwKwkrlIjfkj9yeg02XR 49rsclJmeSCajmC5NXGljEy7aevH63eryJL068edfTaKTGUOTDnQvoa1lBKogaNAcPjv ZoOTWDi0x/6iJHEro0xLrcAF7PruNCGo9iVGZ9vqukZaNKkNUCuThrGHNzuoYEjeGC7d vq9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=39WDzgrzKw1HI9cbUqd/4nglotTqMx2ozVZiEV9EMeo=; b=HFXtzucyZRnnD5jh0BD92uchRlBWDFV4yRWslHSpRjaj5xkXYxrcptxS9d57vGTmpa 4jl+eBYjSjNGkv6no+kPHqpe6/FdihJOw4bhZS+fajvSw1h795p8vc/8Q5L5Ztehb/YM 7fTdb4wugXAQJK+Lc7qyFPgiIsEbfr/n/gL1nFHaBb2VZlp4kA+itnt/GnNQc2kadCTd gZs/4JFfdxSB4mMdq+o7f8xhySzWizIVfBjhJU/fm9EOx2q3LJAo1mpMxTp4dEcnW17/ Ultqh2Cu1xNeNbI6ReXsuQcMB9058mC0aqJJB9fMc6nnYME6V36v4hyX/A4QlCj5Ccmw LT1A== X-Gm-Message-State: AOAM5335P3ISnHPk2CUaLSiRJLlgNaL3LR7Q2LnLhbvYOzpsh//OD7Fq 75rVBuxWtWaM263FQ9dTLT8= X-Google-Smtp-Source: ABdhPJwOC+VH1ItUocY5MR5+0dEvvtca8Eo/rZUkwGTsvktz0B4ZV7qWU/u1sqZ4Y1ulDcTps9maWw== X-Received: by 2002:a05:600c:224b:: with SMTP id a11mr24308206wmm.97.1607890798961; Sun, 13 Dec 2020 12:19:58 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Aurelien Jarno , Aleksandar Rikalo , kvm@vger.kernel.org, Jiaxun Yang , Huacai Chen , Paul Burton , Huacai Chen Subject: [PULL 02/26] target/mips/kvm: Assert unreachable code is not used Date: Sun, 13 Dec 2020 21:19:22 +0100 Message-Id: <20201213201946.236123-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201213201946.236123-1-f4bug@amsat.org> References: <20201213201946.236123-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) This code must not be used outside of KVM. Abort if it is. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Huacai Chen Acked-by: Paolo Bonzini Message-Id: <20200429082916.10669-3-f4bug@amsat.org> --- target/mips/kvm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/target/mips/kvm.c b/target/mips/kvm.c index 72637a1e021..cbd0cb8faa4 100644 --- a/target/mips/kvm.c +++ b/target/mips/kvm.c @@ -198,9 +198,7 @@ int kvm_mips_set_interrupt(MIPSCPU *cpu, int irq, int l= evel) CPUState *cs =3D CPU(cpu); struct kvm_mips_interrupt intr; =20 - if (!kvm_enabled()) { - return 0; - } + assert(kvm_enabled()); =20 intr.cpu =3D -1; =20 @@ -221,9 +219,7 @@ int kvm_mips_set_ipi_interrupt(MIPSCPU *cpu, int irq, i= nt level) CPUState *dest_cs =3D CPU(cpu); struct kvm_mips_interrupt intr; =20 - if (!kvm_enabled()) { - return 0; - } + assert(kvm_enabled()); =20 intr.cpu =3D dest_cs->cpu_index; =20 --=20 2.26.2