From nobody Tue Nov 18 04:24:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) client-ip=209.85.128.65; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f65.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1607890835; cv=none; d=zohomail.com; s=zohoarc; b=Vy5f7MwJ8vA+leOUAqCu3EfD+H5iI7rKkxg9sUqsx42yyHjA7AX2m3IroDl7vs7D26CHYaK+ghAUtHMQhuza+D9l3jGDgVU8qbldTfGp1wENL3hD+Kq2lYYtCS6vvem//CJ62SfBxwIdPzLaODl3wOPuYjxeaomfmwt5N2iKnmQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607890835; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SiRxwMOsvHMX7da84kOf25+ipqu85MeG7Znceh6cVl0=; b=aPn7th9cQ3zX/X1uJg7Y7SPnhsZkvhOJ3+xtjEwZc+eF1kzTL7a/b3qvYDmt/H8HOPEDkydlPEk6k/LDNqMGLeXI/oY0usTy0QLUryElqsM1TH3j2Fna/DxbR2Y4EBKxeAybex5RhIevx8VLEUgp6TfQ5Hmzi3NYZ7Wn/rhqwMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.65 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.zohomail.com with SMTPS id 1607890835598399.57898659199464; Sun, 13 Dec 2020 12:20:35 -0800 (PST) Received: by mail-wm1-f65.google.com with SMTP id q75so13416358wme.2 for ; Sun, 13 Dec 2020 12:20:35 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id w3sm27387242wma.3.2020.12.13.12.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Dec 2020 12:20:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SiRxwMOsvHMX7da84kOf25+ipqu85MeG7Znceh6cVl0=; b=KsQv3qbOe+LI/cP5EbRVc/SVzgzrUF2ZAG/DrKk9RxDzkO0u6E03MnxQWFY+mGEd9D /hvwr8carDz8ZIbGZ+BIEDf5/jGNRzqNUIkp0H8jOyVxRKJh068pHSaZlm6rLALMF4fo pq6k7mFzjPpMPDe5j73MXeYWB8PQ/ceA/TP8EctzpGirpk+N0nD9ZDZ08IsLJ/gendvX 7VczUnp/wZk8oQU9W5qWER5e//1av8L5t+znrnIBpuCNRkR+PFBpPERulsbIWmY6ZvTj Ld0VBislp5Cwde6JQiZ0cub52eYHa7l27ShjMOwudC2wbeHIraeP6bg2JoTS568jpp2x TvsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SiRxwMOsvHMX7da84kOf25+ipqu85MeG7Znceh6cVl0=; b=Rk2PDXjsBkylWoVN06nko84+W8EzlRLxtXYZA/0DtUzxbLNU1Z7/+d9TRRWk+W3QvP NRrqnwFJUkTVeXmcDlNSo86axm2ZsUIPrvjgUUXKplf2nz4zXff7M5D2Ry7YQQEtDsXr 7piDTupuUjokeZ9TWGunPjYBjRvzD7y0KVx0E90dXJgncjPd3MtyOAOz54kGTaJWOKJb 2CKgJIFhpIFCcC4MxIH3jKqj3Wxp5RDJxNEDIhNSc/QTW0rI70XMrVL5V6McdaoM/skd HA7lU5dQG/wx7+I40iyEz7YKJX50qJv0AL4coy8wb5VOHoh3B/hhZzYotEE3cs7IoTKS p72A== X-Gm-Message-State: AOAM531ZATLcnwIi16ByuEgfzAHAvKjIRDtTbt2GkuV2PRyNdz9Tg9Yb dsdOghP8MOpXkO7oBkSWjBA= X-Google-Smtp-Source: ABdhPJxDuA+DFk/Zc3/I9RhXui88zg7XTIi8CvF9r8p0+haLdCa3xW3ioiFyX+skKOBc1htwpOepaw== X-Received: by 2002:a1c:b657:: with SMTP id g84mr24544929wmf.181.1607890833832; Sun, 13 Dec 2020 12:20:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Aurelien Jarno , Aleksandar Rikalo , kvm@vger.kernel.org, Jiaxun Yang , Huacai Chen , Paul Burton , Richard Henderson , Huacai Chen Subject: [PULL 09/26] target/mips: Allow executing MSA instructions on Loongson-3A4000 Date: Sun, 13 Dec 2020 21:19:29 +0100 Message-Id: <20201213201946.236123-10-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201213201946.236123-1-f4bug@amsat.org> References: <20201213201946.236123-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The Loongson-3A4000 is a GS464V-based processor with MIPS MSA ASE: https://www.mail-archive.com/qemu-devel@nongnu.org/msg763059.html Commit af868995e1b correctly set the 'MSA present' bit of Config3 register, but forgot to allow the MSA instructions decoding in insn_flags, so executing them triggers a 'Reserved Instruction'. Fix by adding the ASE_MSA mask to insn_flags. Fixes: af868995e1b ("target/mips: Add Loongson-3 CPU definition") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Huacai Chen Message-Id: <20201130102228.2395100-1-f4bug@amsat.org> --- target/mips/translate_init.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/translate_init.c.inc b/target/mips/translate_init.= c.inc index ea85d5c6a79..79f75ed863c 100644 --- a/target/mips/translate_init.c.inc +++ b/target/mips/translate_init.c.inc @@ -832,7 +832,7 @@ const mips_def_t mips_defs[] =3D .mmu_type =3D MMU_TYPE_R4000, }, { - .name =3D "Loongson-3A4000", + .name =3D "Loongson-3A4000", /* GS464V-based */ .CP0_PRid =3D 0x14C000, /* 64KB I-cache and d-cache. 4 way with 32 bit cache line size. */ .CP0_Config0 =3D MIPS_CONFIG0 | (0x1 << CP0C0_AR) | (0x2 << CP0C0_= AT) | @@ -885,7 +885,7 @@ const mips_def_t mips_defs[] =3D .CP1_fcr31_rw_bitmask =3D 0xFF83FFFF, .SEGBITS =3D 48, .PABITS =3D 48, - .insn_flags =3D CPU_LOONGSON3A, + .insn_flags =3D CPU_LOONGSON3A | ASE_MSA, .mmu_type =3D MMU_TYPE_R4000, }, { --=20 2.26.2