From nobody Tue Nov 18 04:26:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1607864976; cv=none; d=zohomail.com; s=zohoarc; b=WBGYBw/mDlqNW3qgu7e02mmT6aFoFgLUbYmaz6HSI2xwVvNvd6D0uQkFdxGuF24idyaU/4oHpXg4JzcL0zqJm4pjilqDe0kNuPtwCUmBRS+0YeWXdOJLc81oLi4W3qIu2ZMTI/pq7cxhga4VPtoHLN8mgqi8pdNoZUmbyaNNyNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607864976; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2tDWoECOFIVZMvjM5R5XLkVgnJ7S/Zytu5H8UJeC4QE=; b=R31hsR2+2MYvxRlA4NODxXtTqtJ1SgNNDczJVb3+Iw2W3QzzIp2BIfmGVaKi2x9T+GjZLmiBj52oNDKxkUTW7VJ5YEeJcEbrqZLsoAsvcD88RpyISNxlPERjS28qdzqjrHtOcX9x0AeNVwQc4ABU1FZNMGWyjXs9LE3JXtJVsdM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607864976863368.31915652709176; Sun, 13 Dec 2020 05:09:36 -0800 (PST) Received: from localhost ([::1]:53922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koR83-0008PH-QV for importer@patchew.org; Sun, 13 Dec 2020 08:09:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koR4J-0006cS-Nq for qemu-devel@nongnu.org; Sun, 13 Dec 2020 08:05:43 -0500 Received: from mailout02.t-online.de ([194.25.134.17]:60508) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koR4C-0000jo-Fi for qemu-devel@nongnu.org; Sun, 13 Dec 2020 08:05:43 -0500 Received: from fwd34.aul.t-online.de (fwd34.aul.t-online.de [172.20.26.145]) by mailout02.t-online.de (Postfix) with SMTP id A558B41ACBB7; Sun, 13 Dec 2020 14:05:32 +0100 (CET) Received: from linpower.localnet (TF5WLkZawhW1i+siDZ1kBkNHL2e4i2pPW5Vbs-7Meqmc+TvNrgFjfraAWbX4sD5w2o@[79.208.17.59]) by fwd34.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1koR47-1463rk0; Sun, 13 Dec 2020 14:05:31 +0100 Received: by linpower.localnet (Postfix, from userid 1000) id 1F05D200617; Sun, 13 Dec 2020 14:05:28 +0100 (CET) From: =?UTF-8?q?Volker=20R=C3=BCmelin?= To: Gerd Hoffmann Subject: [PATCH 2/4] coreaudio: don't start playback in init routine Date: Sun, 13 Dec 2020 14:05:26 +0100 Message-Id: <20201213130528.5863-2-vr_qemu@t-online.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <1a970310-4cff-f2f7-985e-05b2f4cd446b@t-online.de> References: <1a970310-4cff-f2f7-985e-05b2f4cd446b@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ID: TF5WLkZawhW1i+siDZ1kBkNHL2e4i2pPW5Vbs-7Meqmc+TvNrgFjfraAWbX4sD5w2o X-TOI-EXPURGATEID: 150726::1607864731-000171DC-E4377A34/0/0 CLEAN NORMAL X-TOI-MSGID: bc1e07b5-2eff-4f12-9148-cff2c6586f19 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=194.25.134.17; envelope-from=volker.ruemelin@t-online.de; helo=mailout02.t-online.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Every emulated audio device has a way to enable audio playback. Don't start playback until the guest enables the audio device to keep the Core Audio device run state in sync with hw->enabled. Tested-by: Howard Spoelstra Signed-off-by: Volker R=C3=BCmelin --- audio/coreaudio.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index 0ee85052c4..a5df950514 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -584,17 +584,6 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct a= udsettings *as, return -1; } =20 - /* start Playback */ - if (!isPlaying(core->outputDeviceID)) { - status =3D AudioDeviceStart(core->outputDeviceID, core->ioprocid); - if (status !=3D kAudioHardwareNoError) { - coreaudio_logerr2 (status, typ, "Could not start playback\n"); - AudioDeviceDestroyIOProcID(core->outputDeviceID, core->ioproci= d); - core->outputDeviceID =3D kAudioDeviceUnknown; - return -1; - } - } - return 0; } =20 --=20 2.26.2