From nobody Fri May 17 10:44:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607707038; cv=none; d=zohomail.com; s=zohoarc; b=dbvtEkTn3EAfNp0EJPpGXuMeSbf7lEhl5yJEAexqGsRtOR5Z4bU7Sb7AlTQ4o4/idv9ONt/2AsQqYTm+Z5n6hD/U0tjWF0FG5/rI/eoZusBvIsz4cmacaXg/l5B4usTR0NuJzh/oV5LIn6JxKcz6NTL267GtjHShtnT46RcDSyE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607707038; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Y9js6tWuavZqGk0V0v9buhtJVS4jKDh4XdWkJL3pBnw=; b=DlZc/Np2njiYLYiYT6MxsxA8jZjJ8sY4nTgXqs/rEf439wuBJHUhUTGZaRsKfZ4vRdoE8jtX8K/441ywsRPCwbrdktZEZXMPqW6vj9xxFdNCfKnwaJSk2oor3n5s1t7uOk6ffD7Ygd/Wvtf7hrgcIknJ3rqps2bnakCZ1Zi56dc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1607707038251607.3137749543578; Fri, 11 Dec 2020 09:17:18 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-m8kpGH6QPoytmzQc2MeiXw-1; Fri, 11 Dec 2020 12:17:13 -0500 Received: by mail-ed1-f69.google.com with SMTP id u18so4220691edy.5 for ; Fri, 11 Dec 2020 09:17:12 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id 2sm7263733ejw.65.2020.12.11.09.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 09:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607707034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y9js6tWuavZqGk0V0v9buhtJVS4jKDh4XdWkJL3pBnw=; b=JoGkUFg5qceoaeLUam9FPwTqCLnbaR1V7cOvOQ3xrJqDm9q5hNLDgcTVEQS7xnNeKfeAYt kDXzLLfl3t6I3EvBpqpUf98zzFyJiF+99j9XfnG0I3MzIA8sFrF2S/HqjD01hBaxUjbR4d 9NBmBBBcWdj+TvZnQKQIoN5lGHpFOkI= X-MC-Unique: m8kpGH6QPoytmzQc2MeiXw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y9js6tWuavZqGk0V0v9buhtJVS4jKDh4XdWkJL3pBnw=; b=VX+G/ErdiQXHaZ2vnns343QmPZVInnIqywc3xKtMTTdY3h+TKxfHIV62U2nAGB09pR wEqhD3fMPbw0XToxGBE8V4js73JAMSvuBml9q4Ga2KgY4ZZ+zl7IiM0MduqaN4s29H1o SqQYA+ph4appdhtan6TTgNrhbho5SmLFdDZQvn88K52nctJnOT0hA3NYtrVpXBzUom91 3UL7/aBBmOgeWYFkhpKPn4C5+ppXC8ehRNg87RLHvl3CqzA9FIkosso2ltnY8zyec+I7 mVnJmGQDVnyfsxZvO3pngiROOIqp7lr7YQg8UFAaJjFvc5NJkJmwT9c1Yhr/O8lt4KEV XnwA== X-Gm-Message-State: AOAM530iN6KkqAwvoqGh6NImVdUwkkgayQ50vSItr00hM+5CUEfQTfr+ 4dDP1Oou5iBZIX3afzzxqQQwmecSsX8g7MDzklW7kOiHQT/JC/PGrUXt9YbCWaXTg9o05SDJEHy PJJe8FXSJBjM12g== X-Received: by 2002:a17:906:8594:: with SMTP id v20mr11645637ejx.470.1607707031156; Fri, 11 Dec 2020 09:17:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzcvMxoOsCzK+JxjtE6LFfkvxzmjLqz2/y1qpUGQOgqR9wCIaVW2SZ7aE1Id9dPGTk5ilWqfQ== X-Received: by 2002:a17:906:8594:: with SMTP id v20mr11645622ejx.470.1607707030982; Fri, 11 Dec 2020 09:17:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Cleber Rosa , Willian Rampazzo Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Wainer dos Santos Moschetta , virt-ci-maint-team@redhat.com, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [RFC PATCH 1/2] gitlab-ci: Step in to maintain the fedora-i386-cross runner Date: Fri, 11 Dec 2020 18:17:02 +0100 Message-Id: <20201211171703.537546-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201211171703.537546-1-philmd@redhat.com> References: <20201211171703.537546-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) As I am interested in using the runner based on the fedora-i386-cross docker image, add a smoke test job to be sure this image is usable, and set the JOB_MAINTAINER_NAME/JOB_MAINTAINER_EMAIL variables so other developers can contact me in case there is a problem with the public runner based on this image. We will eventually send a patch to make script/checkpatch.pl parse the Gitlab YAML jobs to understand the JOB_MAINTAINER_NAME and JOB_MAINTAINER_EMAIL variables. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .gitlab-ci.d/crossbuilds.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index bd6473a75a7..864cad7cec5 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -39,6 +39,13 @@ ../configure --enable-werror $QEMU_CONFIGURE_OPTS --disable-system - make -j$(expr $(nproc) + 1) all check-build =20 +.cross_sanity_check_job: + stage: build + image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest + timeout: 3m + script: + - /bin/true + cross-armel-system: extends: .cross_system_build_job variables: @@ -69,6 +76,14 @@ cross-arm64-user: variables: IMAGE: debian-arm64-cross =20 +cross-i386-sanity-check: + extends: .cross_sanity_check_job + variables: + JOB_MAINTAINER_NAME: "Philippe Mathieu-Daud=C3=A9" + JOB_MAINTAINER_EMAIL: philmd@redhat.com + GIT_SUBMODULE_STRATEGY: none + IMAGE: fedora-i386-cross + cross-mips-system: extends: .cross_system_build_job variables: --=20 2.26.2 From nobody Fri May 17 10:44:21 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607707044; cv=none; d=zohomail.com; s=zohoarc; b=SLsLkLtGWdUyZRkNWTjkeReVAilYlhx7aASud4Q7zCGpldH2gJTi/U+6cPQ2NRBEJRQBLzuLhU4Tn8kWOKihDjGz/jNBtdn3Y+MGg4ZwHdS8RHfCVmn5yjqzPK59pn55v3EbxS/mInYoiiu+KGvNDDquO3SnK4mJI7mhQN3xHTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607707044; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/86y14GUAh849U3xoqBoq9267qvFGJ2R67n6SR6eH8o=; b=OZg7s/4YytZyZNryYuhVxeZakYb+9R/vtRCRUd0xUtVq0BkelCzJ8tJ0apkvy4YdZG14yTQdFT+V7OV7MuL1OwWBJtdDTJb2HV3WyItVR5+tCB9K9tL7AMN8kKQzMbpJg6Oks2LpJPovHuaRcrMUu+nc8z1S7Yk+Pr+S4GuJU0M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1607707044144429.69020721687764; Fri, 11 Dec 2020 09:17:24 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-89f83z1nNtaMXODRVy1yAQ-1; Fri, 11 Dec 2020 12:17:17 -0500 Received: by mail-ed1-f70.google.com with SMTP id bf13so4199527edb.10 for ; Fri, 11 Dec 2020 09:17:17 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (101.red-88-21-206.staticip.rima-tde.net. [88.21.206.101]) by smtp.gmail.com with ESMTPSA id n7sm8120868edb.34.2020.12.11.09.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 09:17:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607707042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/86y14GUAh849U3xoqBoq9267qvFGJ2R67n6SR6eH8o=; b=JvF3PCdBUhDZlnPB88beuAgCMqcs75LY0y7390f3xvk2xownXTKl+zp9/B7dRGHUePj08I Yi1PObmsxfvavLQ5C8Qjy1QT8bQhgvr7hBznD5YzkiP1w4eHDwQmKDNvn5RhxzUZp8z4Rg IkW7lHieXWcy7CNuUyinZpSOMFVEjGg= X-MC-Unique: 89f83z1nNtaMXODRVy1yAQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/86y14GUAh849U3xoqBoq9267qvFGJ2R67n6SR6eH8o=; b=nfap5rwvAIpUzrXhYYVXYDFIEO7ryMzVpNjsrMRx6xVpr5eYRdgbIE7mzRLbcfdNAq CIbT32a+peNLs9v/Dde3E3Kef6SjKxEq59wOdU1O89VAc7jOdr5SEM/mcowLj2QAGVcA HLiCxNVQ5SDPsQF4BjQkbWKtUWKTFDIHnGZeiFfUANYsloQ1aAciJsKP63qkQticFdG2 bFYtgx7MdjsCV7nUenrvg9ENNRK/CHaZx1OpgkdLKRm6B6N5ZJnQCiAVNks8FDzBF9nr nXJj/BJar3ajrnvqIsYzW1eFUHczvJsLF1U0z5oy1+5JXVDhi1b9ojp/4i0gg5GmSQwd kETA== X-Gm-Message-State: AOAM532xZYihFMbCQr+HbQk/3uG+Noq0HJRergGqHRFxq/EjvVF2QRK8 FUi2VVbuYTIHxxtuc3AaWUHI7kQFWKlu+RA+9ghxlz+ReIVA1osRnDKAgSjGN/3Nm7q4mTerM/T 6jV8RXaR9D6Xkxw== X-Received: by 2002:a17:906:15cc:: with SMTP id l12mr11486693ejd.363.1607707036409; Fri, 11 Dec 2020 09:17:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyiiJVu/TPUlRpNFMAHsW1dgeloiSGgkoHzNUPqI4C/GyH4eJ+8LSv/U4nyt76RAY26lSBKNw== X-Received: by 2002:a17:906:15cc:: with SMTP id l12mr11486670ejd.363.1607707036180; Fri, 11 Dec 2020 09:17:16 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Cleber Rosa , Willian Rampazzo Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Wainer dos Santos Moschetta , virt-ci-maint-team@redhat.com, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [RFC PATCH 2/2] gitlab-ci: Introduce allow_skipping_job_template Date: Fri, 11 Dec 2020 18:17:03 +0100 Message-Id: <20201211171703.537546-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201211171703.537546-1-philmd@redhat.com> References: <20201211171703.537546-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) It might be overkill (and frustrating) to rerun all the jobs when iterating over a single code unit. As some users are interested in only rerunning a specific set of jobs, allow them to use a "manual" profile, when jobs are created in the pipeline but not started. It is up to the user to manually start the jobs of interest. To switch a repository to manual, set QEMU_DEFAULT_WORKFLOW_MANUAL in the project UI, following [1]. Once a repository is using the manual workflow, the user can still automatically start the jobs by explicitly set the QEMU_IGNORE_DEFAULT_WORKFLOW which disable the manual mode. Example while pushing a branch/tag from command line (see [2]): $ git push -o ci.variable=3D"QEMU_IGNORE_DEFAULT_WORKFLOW=3D1" \ myrepo mybranch [1] https://docs.gitlab.com/ee/ci/variables/#create-a-custom-variable-in-th= e-ui [2] https://docs.gitlab.com/ee/user/project/push_options.html#push-options-= for-gitlab-cicd Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- .gitlab-ci.d/crossbuilds.yml | 4 ++++ .gitlab-ci.yml | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 864cad7cec5..56b053cbb52 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -1,4 +1,5 @@ .cross_system_build_job: + extends: .allow_skipping_job stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest timeout: 80m @@ -18,6 +19,7 @@ # KVM), and set extra options (such disabling other accelerators) via the # $ACCEL_CONFIGURE_OPTS variable. .cross_accel_build_job: + extends: .allow_skipping_job stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest timeout: 30m @@ -30,6 +32,7 @@ - make -j$(expr $(nproc) + 1) all check-build =20 .cross_user_build_job: + extends: .allow_skipping_job stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest script: @@ -40,6 +43,7 @@ - make -j$(expr $(nproc) + 1) all check-build =20 .cross_sanity_check_job: + extends: .allow_skipping_job stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest timeout: 3m diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 98bff03b47b..26b85f08f35 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -13,7 +13,21 @@ include: - local: '/.gitlab-ci.d/containers.yml' - local: '/.gitlab-ci.d/crossbuilds.yml' =20 +.allow_skipping_job_template: &allow_skipping_job_definition + rules: + # Skip if the user set the QEMU_DEFAULT_WORKFLOW_MANUAL variable for i= ts + # project. Can be overridden by setting the QEMU_IGNORE_DEFAULT_WORKFL= OW + # variable. + - if: $CI_PIPELINE_SOURCE =3D=3D "push" && $QEMU_DEFAULT_WORKFLOW_MANU= AL && $QEMU_IGNORE_DEFAULT_WORKFLOW =3D=3D null + when: manual + allow_failure: true + - when: always + +.allow_skipping_job: + <<: *allow_skipping_job_definition + .native_build_job_template: &native_build_job_definition + <<: *allow_skipping_job_definition stage: build image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest before_script: @@ -35,6 +49,7 @@ include: fi =20 .native_test_job_template: &native_test_job_definition + <<: *allow_skipping_job_definition stage: test image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest script: @@ -43,6 +58,7 @@ include: - make $MAKE_CHECK_ARGS =20 .acceptance_template: &acceptance_definition + <<: *allow_skipping_job_definition cache: key: "${CI_JOB_NAME}-cache" paths: @@ -536,6 +552,7 @@ check-dco: GIT_DEPTH: 1000 =20 build-libvhost-user: + <<: *allow_skipping_job_definition stage: build image: $CI_REGISTRY_IMAGE/qemu/fedora:latest before_script: @@ -547,6 +564,7 @@ build-libvhost-user: - ninja =20 pages: + <<: *allow_skipping_job_definition image: $CI_REGISTRY_IMAGE/qemu/ubuntu2004:latest stage: test needs: --=20 2.26.2