From nobody Mon Feb 9 10:48:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1607712466; cv=none; d=zohomail.com; s=zohoarc; b=JlyK9/SOwtfG5iEYl+MaskkMtOaTzWW3tiWNdDog7IHlO3NSc9t1FghbCQ7zxNS5GDTGeEQm37XCxiTetrRQc8Bje9w4KAn/eO1EC9a0DAx1LYCvbBVMjAmhJzeXZ/PE7PzpCXIqFwzVuAyCJuuetEfDfv7ajnY1mvfE/kXeb3k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607712466; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=orX9E/BqF8hypEKpiucSGtJYx7UZaFRHsfAJQWe4uVc=; b=IdUYQlXvymUcsT1CWMe3OVnZVEcAr9k3x+BRxmaJx+yU3q3w2fE1nsreanri+mAnlnGIIf427AuEzB1wxNM6mN6ycf1yH6k2+yWkkRqOIG5f6fKAwxKMN+cRNQx2pSS2hszN7u3RSiXc/hipbOd8sP7QF5DNpagk2pNbDe+hckk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1607712466717116.34388573533829; Fri, 11 Dec 2020 10:47:46 -0800 (PST) Received: from localhost ([::1]:39372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knmnL-0004Nk-7G for importer@patchew.org; Fri, 11 Dec 2020 13:05:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knlxt-0007XK-0N for qemu-devel@nongnu.org; Fri, 11 Dec 2020 12:12:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:42612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1knlxa-0003R8-FZ for qemu-devel@nongnu.org; Fri, 11 Dec 2020 12:12:19 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-m3d8j6MSPia4IzKg44RAbw-1; Fri, 11 Dec 2020 12:11:55 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58949800D55; Fri, 11 Dec 2020 17:11:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29C3C6F45E; Fri, 11 Dec 2020 17:11:54 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A065811328A9; Fri, 11 Dec 2020 18:11:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607706720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=orX9E/BqF8hypEKpiucSGtJYx7UZaFRHsfAJQWe4uVc=; b=OXsQC9+6IPm0SZQnId4voq6lus1mGD8GnmXQmNA+kEVJeNjg07ztxVPAb0qFlUfIrXBysE XtTamam2tWW9r/0xmgPqAUdLSYD9w2vE1oZ/SrnZeMsaTrvPoVrSi7Pa71zunlnxHDTQEN 2l0fn4WowAg83SxamUXMF4PTMfHxl6k= X-MC-Unique: m3d8j6MSPia4IzKg44RAbw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 01/20] hmp: Simplify how qmp_human_monitor_command() gets output Date: Fri, 11 Dec 2020 18:11:33 +0100 Message-Id: <20201211171152.146877-2-armbru@redhat.com> In-Reply-To: <20201211171152.146877-1-armbru@redhat.com> References: <20201211171152.146877-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Commit 48c043d0d1 "hmp: human-monitor-command: stop using the Memory chardev driver" left us "if string is non-empty, duplicate it, else duplicate the empty string". Meh. Duplicate it unconditionally. Cc: Dr. David Alan Gilbert Signed-off-by: Markus Armbruster Reviewed-by: Dr. David Alan Gilbert --- monitor/misc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/monitor/misc.c b/monitor/misc.c index 398211a034..6c3e8506a9 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -136,11 +136,7 @@ char *qmp_human_monitor_command(const char *command_li= ne, bool has_cpu_index, handle_hmp_command(&hmp, command_line); =20 WITH_QEMU_LOCK_GUARD(&hmp.common.mon_lock) { - if (qstring_get_length(hmp.common.outbuf) > 0) { - output =3D g_strdup(qstring_get_str(hmp.common.outbuf)); - } else { - output =3D g_strdup(""); - } + output =3D g_strdup(qstring_get_str(hmp.common.outbuf)); } =20 out: --=20 2.26.2